From nobody Sun Apr 28 04:45:07 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1679918203494430.29323240793906; Mon, 27 Mar 2023 04:56:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pglSJ-0006ud-BG; Mon, 27 Mar 2023 07:56:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pglSF-0006u7-Ac; Mon, 27 Mar 2023 07:56:04 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pglSA-0001gN-39; Mon, 27 Mar 2023 07:56:00 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 503ED320089C; Mon, 27 Mar 2023 07:55:56 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 27 Mar 2023 07:55:56 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 27 Mar 2023 07:55:53 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1679918155; x= 1680004555; bh=ylcd8ApIadkg24cFh65EK3b8KXwNopU172jf4fw5acI=; b=Y UlrLQkaa8rqRXNq1cy8Yu6JrZFx5h4bNhSQCK6bRTMvJT4XeWD7DoE452mxyDCg5 O0DSHiSPRfTzMpiiQcAvs30U6N+kCHUregm33c/jLqwB1A670u47ip0CnIhAT22J WXIbcfJ8mJnRkO9BZQbyeX6MF3Qk+a/EGabi8o1G7MIWBTTfSwCqPOth9sHA9LbE IpQ9fu5Wyrw03zHeMRn76ToxsWCYGpsRZXX009Yj6R1G2OrJEc/zmGW4FaN4s+tE C4aHLPoIdh4ck136VFc1Ly5J+FRp8KuxWQXyWnBaQ232LXmkE/4xo1QSEoID1p0w HwOyE1egJlN0GxfF/UozA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1679918155; x= 1680004555; bh=ylcd8ApIadkg24cFh65EK3b8KXwNopU172jf4fw5acI=; b=A jGHAP+3mMVzckxc+D97xMKUfEPGPHdBL4NxXs+67Vv2wFBqnbBFGe+WM6hQ5aLAX opBrdFg1zeiszr3DeyLDGOSUlxtdg95PcW19EwahvFELM5WVa8OFJWH5ESEODYkA E2ip89NWKNMUxbvgfSMioTi1Tn6X/e+WNuMYbO0Re0z4VPFAkF5gZQPwxxhe0IWk qUAEUOsMq9fei9Xwb61HUhXxoCDWanWhPlSkRLhnpjJf79xnasO5LgaWmRASUf5x CqsevwilWxrhXD/wuwWFtjdWwxaAhnXRVJhh0pKMWCEBXvA2UeaPM7GO2yvgpQZj nab90ygMC1fXGKknAsprQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdehvddggeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpeetnhgurhgvficulfgvfhhfvghrhicuoegrnhgurhgvfies rghjrdhiugdrrghuqeenucggtffrrghtthgvrhhnpefhgfelffeujefghefghedugfegfe efffdvjeekiedutdekiefgleegkeduleegveenucffohhmrghinhepkhgvrhhnvghlrdho rhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hnughrvgifsegrjhdrihgurdgruh X-ME-Proxy: Feedback-ID: idfb84289:Fastmail From: Andrew Jeffery To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, laurent@vivier.eu Subject: [PATCH 1/2] linux-user: elfload: s/min_mmap_addr/mmap_min_addr/ Date: Mon, 27 Mar 2023 22:25:23 +1030 Message-Id: <20230327115524.1981482-2-andrew@aj.id.au> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230327115524.1981482-1-andrew@aj.id.au> References: <20230327115524.1981482-1-andrew@aj.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=64.147.123.25; envelope-from=andrew@aj.id.au; helo=wout2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1679918205433100003 Content-Type: text/plain; charset="utf-8" As-is the error message can cause some confusion as the mentioned sysctl attribute name is wrong: https://www.kernel.org/doc/html/latest/admin-guide/sysctl/vm.html#mmap-min-= addr Signed-off-by: Andrew Jeffery --- linux-user/elfload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 1dbc1f0f9baa..601b156b476b 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -2771,7 +2771,7 @@ static void pgb_reserved_va(const char *image_name, a= bi_ulong guest_loaddr, if (addr =3D=3D MAP_FAILED || addr !=3D test) { error_report("Unable to reserve 0x%lx bytes of virtual address " "space at %p (%s) for use as guest address space (che= ck your " - "virtual memory ulimit setting, min_mmap_addr or rese= rve less " + "virtual memory ulimit setting, mmap_min_addr or rese= rve less " "using -R option)", reserved_va, test, strerror(errno= )); exit(EXIT_FAILURE); } --=20 2.39.2 From nobody Sun Apr 28 04:45:07 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1679918218218676.3437806295522; Mon, 27 Mar 2023 04:56:58 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pglSL-0006vb-MF; Mon, 27 Mar 2023 07:56:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pglSJ-0006ub-2c; Mon, 27 Mar 2023 07:56:07 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pglSE-0001hy-KW; Mon, 27 Mar 2023 07:56:04 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 558DA32007E8; Mon, 27 Mar 2023 07:55:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 27 Mar 2023 07:55:59 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 27 Mar 2023 07:55:57 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1679918158; x= 1680004558; bh=G3VEwzrPpgQY1Y6MYXIsAiRyuQmLO4WhRk5XPnxIRc4=; b=D 9iJlV3DnuoZQcj1QrPAIlQZJDx/C7x1fo9lKb1HFBIM3P047hAG5dHr/5t3UDV8Z /c59BA6O9VQ+rWo0XuCmTND6Wa6IoBslbH6tVgcF/lmq3Ber2EAkdgAZBnLaMijX HgTgJdkVEPO414Yb/5ksoXWH/P6VlrukKnMeXIzCR+Uq5beDsqY9OpxyV2InwKtd A0icdn7cl/LqJlgA25JlSbiPPUaPYIj0xNNZYF/MCzATT4LIUoQWPyH+AlMtymcq x+chDJuqeya7jiktLAhVKx3VthEW9nEnqt2V/gTJJfhLyBn/G2QSriI/wFDW5drj AihUwvGigTHHOWNZ+epog== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1679918158; x= 1680004558; bh=G3VEwzrPpgQY1Y6MYXIsAiRyuQmLO4WhRk5XPnxIRc4=; b=J s+2+BGd8Yg4Tgw+TV5VaJDUjvzI9pbAClZKXewUj0QXwofUckys56xTlaUpd7biQ amW1S7ETLhCVv5zHpcPMpMPAnPCtji/o8VMkxficILyDJTLa8Ec1jkh6LVvwvNuo s/zIIxPXZdF+AkteLhVHZyVl34Mt0SYuvsZW6WeJzoku7ZBEvjAXrUs99lCOESCx YfzkOYFh0frzxeXlwE5FnDTSbkrmBk28oS5L89clnTSrs4oxIioOYG1U7Ybrc8u/ XdgU7Pod49kqiPcADr98SmMh3dmjs4EaHFwauwnXGU/m2hyBFY4XvBvQT3y2Gl6R QpoctWK9LSmrKvUR7QHyg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdehvddggeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpeetnhgurhgvficulfgvfhhfvghrhicuoegrnhgurhgvfies rghjrdhiugdrrghuqeenucggtffrrghtthgvrhhnpeefveekleefgfejteeuheejvddttd euvdduhfelveduleeugefgfeehveefudfgueenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpegrnhgurhgvfiesrghjrdhiugdrrghu X-ME-Proxy: Feedback-ID: idfb84289:Fastmail From: Andrew Jeffery To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, laurent@vivier.eu Subject: [PATCH 2/2] linux-user: elfload: Specify -R is an option for qemu-user binaries Date: Mon, 27 Mar 2023 22:25:24 +1030 Message-Id: <20230327115524.1981482-3-andrew@aj.id.au> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230327115524.1981482-1-andrew@aj.id.au> References: <20230327115524.1981482-1-andrew@aj.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=64.147.123.25; envelope-from=andrew@aj.id.au; helo=wout2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1679918219472100003 Content-Type: text/plain; charset="utf-8" Given several different concepts are suggested for investigation, let's not confuse e.g. ulimit's -R with what was actually intended. Signed-off-by: Andrew Jeffery --- linux-user/elfload.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 601b156b476b..694794f97202 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -2772,7 +2772,8 @@ static void pgb_reserved_va(const char *image_name, a= bi_ulong guest_loaddr, error_report("Unable to reserve 0x%lx bytes of virtual address " "space at %p (%s) for use as guest address space (che= ck your " "virtual memory ulimit setting, mmap_min_addr or rese= rve less " - "using -R option)", reserved_va, test, strerror(errno= )); + "using qemu-user's -R option)", + reserved_va, test, strerror(errno)); exit(EXIT_FAILURE); } =20 --=20 2.39.2