From nobody Sun May 5 09:05:38 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1679319457; cv=none; d=zohomail.com; s=zohoarc; b=IfaySagOoedg9HC/BXNq4I+v6d8ALEHqo3kCHeX6BSkE3okHlxNrhJD3EpEcyCIA6lhjsI9ROJgu5tAGeqGOKCNF8NY9l4fN51wP8rsKy9JZbpiIDNgNnaCjVexn2EAQZW3BarMnHjgCOAI18snwL/kTFA3c1uZtkGDIAg+KMLk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679319457; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MxFVrjr23RmzfOH4M1hN0g7VfzXGELnKdK7ZPeHxp1s=; b=Rwql8CnqK5YDkEW+xGm6mbplko/vGwt9utd4rKMfeZjI+IfhAJ6amPEbsdrYN1fvOExqY0Zp9wVgIPBHlyCRiBtZvrgVGj/s4iUB4WIp3S4zMntA0vj8cJ2vgYqrBRYFsTwnXZLPykESAEOE/kkoqZtp1WEju+xVZpeak5WakOw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1679319457077188.84400056269305; Mon, 20 Mar 2023 06:37:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1peFh5-0002y8-Ec; Mon, 20 Mar 2023 09:36:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peFh3-0002xx-TA for qemu-devel@nongnu.org; Mon, 20 Mar 2023 09:36:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peFh2-0000CA-8d for qemu-devel@nongnu.org; Mon, 20 Mar 2023 09:36:57 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-367-frx-olMWMZ6eSxMcpBWhPg-1; Mon, 20 Mar 2023 09:36:52 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F1E8D1C05EB6; Mon, 20 Mar 2023 13:36:51 +0000 (UTC) Received: from localhost (unknown [10.39.208.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id DF05640C83B6; Mon, 20 Mar 2023 13:36:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679319415; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MxFVrjr23RmzfOH4M1hN0g7VfzXGELnKdK7ZPeHxp1s=; b=ghapp8R6t4IAPZdZsWE1n/DV95hK7IJO4H7eA9MMpb3ofn/FGgiNINVkqa1k4Jvs2z5Uc9 h4GAvA0I99pgR124EXf8pRe54pIO5h0IGIp3+kTEkaVk5eP1E/HllXwhjgdpGaRspv0qW8 eD66dnlGmwyiAsrF1NXbg+gUNTIrP1o= X-MC-Unique: frx-olMWMZ6eSxMcpBWhPg-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Stefan Weil , berrange@redhat.com, Gerd Hoffmann Subject: [PATCH v2 1/3] win32: add qemu_close_socket_osfhandle() Date: Mon, 20 Mar 2023 17:36:41 +0400 Message-Id: <20230320133643.1618437-2-marcandre.lureau@redhat.com> In-Reply-To: <20230320133643.1618437-1-marcandre.lureau@redhat.com> References: <20230320133643.1618437-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1679319458226100011 From: Marc-Andr=C3=A9 Lureau Close the given file descriptor, but returns the underlying SOCKET. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Daniel P. Berrang=C3=A9 --- include/sysemu/os-win32.h | 15 ++++++-- util/oslib-win32.c | 75 +++++++++++++++++++++------------------ 2 files changed, 53 insertions(+), 37 deletions(-) diff --git a/include/sysemu/os-win32.h b/include/sysemu/os-win32.h index e2849f88ab..15c296e0eb 100644 --- a/include/sysemu/os-win32.h +++ b/include/sysemu/os-win32.h @@ -171,10 +171,21 @@ bool qemu_socket_select(int sockfd, WSAEVENT hEventOb= ject, =20 bool qemu_socket_unselect(int sockfd, Error **errp); =20 -/* We wrap all the sockets functions so that we can - * set errno based on WSAGetLastError() +/* We wrap all the sockets functions so that we can set errno based on + * WSAGetLastError(), and use file-descriptors instead of SOCKET. */ =20 +/* + * qemu_close_socket_osfhandle: + * @fd: a file descriptor associated with a SOCKET + * + * Close only the C run-time file descriptor, leave the SOCKET opened. + * + * Returns zero on success. On error, -1 is returned, and errno is set to + * indicate the error. + */ +int qemu_close_socket_osfhandle(int fd); + #undef close #define close qemu_close_wrap int qemu_close_wrap(int fd); diff --git a/util/oslib-win32.c b/util/oslib-win32.c index 16f8a67f7e..a98638729a 100644 --- a/util/oslib-win32.c +++ b/util/oslib-win32.c @@ -479,40 +479,27 @@ int qemu_bind_wrap(int sockfd, const struct sockaddr = *addr, return ret; } =20 - #undef close -int qemu_close_wrap(int fd) +int qemu_close_socket_osfhandle(int fd) { - int ret; + SOCKET s =3D _get_osfhandle(fd); DWORD flags =3D 0; - SOCKET s =3D INVALID_SOCKET; - - if (fd_is_socket(fd)) { - s =3D _get_osfhandle(fd); - - /* - * If we were to just call _close on the descriptor, it would clos= e the - * HANDLE, but it wouldn't free any of the resources associated to= the - * SOCKET, and we can't call _close after calling closesocket, bec= ause - * closesocket has already closed the HANDLE, and _close would att= empt to - * close the HANDLE again, resulting in a double free. We can howe= ver - * protect the HANDLE from actually being closed long enough to cl= ose the - * file descriptor, then close the socket itself. - */ - if (!GetHandleInformation((HANDLE)s, &flags)) { - errno =3D EACCES; - return -1; - } =20 - if (!SetHandleInformation((HANDLE)s, HANDLE_FLAG_PROTECT_FROM_CLOS= E, HANDLE_FLAG_PROTECT_FROM_CLOSE)) { - errno =3D EACCES; - return -1; - } + /* + * If we were to just call _close on the descriptor, it would close the + * HANDLE, but it wouldn't free any of the resources associated to the + * SOCKET, and we can't call _close after calling closesocket, because + * closesocket has already closed the HANDLE, and _close would attempt= to + * close the HANDLE again, resulting in a double free. We can however + * protect the HANDLE from actually being closed long enough to close = the + * file descriptor, then close the socket itself. + */ + if (!GetHandleInformation((HANDLE)s, &flags)) { + errno =3D EACCES; + return -1; } =20 - ret =3D close(fd); - - if (s !=3D INVALID_SOCKET && !SetHandleInformation((HANDLE)s, flags, f= lags)) { + if (!SetHandleInformation((HANDLE)s, HANDLE_FLAG_PROTECT_FROM_CLOSE, H= ANDLE_FLAG_PROTECT_FROM_CLOSE)) { errno =3D EACCES; return -1; } @@ -521,15 +508,33 @@ int qemu_close_wrap(int fd) * close() returns EBADF since we PROTECT_FROM_CLOSE the underlying ha= ndle, * but the FD is actually freed */ - if (ret < 0 && (s =3D=3D INVALID_SOCKET || errno !=3D EBADF)) { - return ret; + if (close(fd) < 0 && errno !=3D EBADF) { + return -1; } =20 - if (s !=3D INVALID_SOCKET) { - ret =3D closesocket(s); - if (ret < 0) { - errno =3D socket_error(); - } + if (!SetHandleInformation((HANDLE)s, flags, flags)) { + errno =3D EACCES; + return -1; + } + + return 0; +} + +int qemu_close_wrap(int fd) +{ + SOCKET s =3D INVALID_SOCKET; + int ret =3D -1; + + if (!fd_is_socket(fd)) { + return close(fd); + } + + s =3D _get_osfhandle(fd); + qemu_close_socket_osfhandle(fd); + + ret =3D closesocket(s); + if (ret < 0) { + errno =3D socket_error(); } =20 return ret; --=20 2.39.2 From nobody Sun May 5 09:05:38 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1679319455; cv=none; d=zohomail.com; s=zohoarc; b=QMlDKEff9fp131L6HCxbhZ6ml8T0327jf97/0/4F2tWrQv6Tpynm8cpoik16bVmtY/uP/JSBNk/NTJb7VVpR3SQDTj4haZQOT0FK4eY08pYPn3KCtreO2O/uIQ5zg8h7yrPa2TGNA80xL9QjKhMjWJ1S0mCulHtY7Rn7WdQIy1Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679319455; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=J6MAm4KpI9ZtW2RYicApZgCO2UNL2tmhgVcp2j2ojYY=; b=g4xu0a4QTvKCieLJ8yRlHHnL6v72AxDc0Nf29iskpCwzJoE6cUZ28YetM596057lH2Wh8m0wDNOisxpqKmRVH+NV0IoVeSvRAZT3wcPHWAEFD82mw/8ImIBfoq3pjY1pI/lrVQPFB7vCNNG1iVkMpLQ5Up+ciJ3whY0tj2GLmd8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1679319455186589.6928113041466; Mon, 20 Mar 2023 06:37:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1peFh8-0002yk-36; Mon, 20 Mar 2023 09:37:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peFh6-0002yL-BC for qemu-devel@nongnu.org; Mon, 20 Mar 2023 09:37:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peFh4-0000Cq-Fc for qemu-devel@nongnu.org; Mon, 20 Mar 2023 09:37:00 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-470--A7_hVY7Ot-uSaHiKjIqSQ-1; Mon, 20 Mar 2023 09:36:56 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4F54D38221C2; Mon, 20 Mar 2023 13:36:56 +0000 (UTC) Received: from localhost (unknown [10.39.208.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8831440C6E69; Mon, 20 Mar 2023 13:36:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679319417; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J6MAm4KpI9ZtW2RYicApZgCO2UNL2tmhgVcp2j2ojYY=; b=Mn9d3aSf6R9gUg4fUubimyGBeN3qfZAt4VsPIYtLvDOwyKB1FuoKSt0QLtsTjq+ZVwZCXX vGSb4xGkpeRmmoqeV7gdLmKkxsYNalHEHs9e2Rsltb7p63tpYC6Z31DMZbcvhPqG3OR9Jc W1uOKW9S1LwUpe6+p2trABscMRuDpPU= X-MC-Unique: -A7_hVY7Ot-uSaHiKjIqSQ-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Stefan Weil , berrange@redhat.com, Gerd Hoffmann Subject: [PATCH v2 2/3] ui/spice: fix SOCKET handling regression Date: Mon, 20 Mar 2023 17:36:42 +0400 Message-Id: <20230320133643.1618437-3-marcandre.lureau@redhat.com> In-Reply-To: <20230320133643.1618437-1-marcandre.lureau@redhat.com> References: <20230320133643.1618437-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1679319456451100006 From: Marc-Andr=C3=A9 Lureau Spice uses SOCKET on win32, but QEMU now uses file-descriptors. Fixes "8.0.0rc0 Regression: spicy windows doesn't open": https://gitlab.com/qemu-project/qemu/-/issues/1549 Fixes: commit abe34282b ("win32: avoid mixing SOCKET and file descriptor sp= ace") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Daniel P. Berrang=C3=A9 --- ui/spice-core.c | 29 +++++++++++++++++++++++++++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index b05c830086..67cfd3ca9c 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -90,13 +90,23 @@ struct SpiceWatch { static void watch_read(void *opaque) { SpiceWatch *watch =3D opaque; - watch->func(watch->fd, SPICE_WATCH_EVENT_READ, watch->opaque); + int fd =3D watch->fd; + +#ifdef WIN32 + fd =3D _get_osfhandle(fd); +#endif + watch->func(fd, SPICE_WATCH_EVENT_READ, watch->opaque); } =20 static void watch_write(void *opaque) { SpiceWatch *watch =3D opaque; - watch->func(watch->fd, SPICE_WATCH_EVENT_WRITE, watch->opaque); + int fd =3D watch->fd; + +#ifdef WIN32 + fd =3D _get_osfhandle(fd); +#endif + watch->func(fd, SPICE_WATCH_EVENT_WRITE, watch->opaque); } =20 static void watch_update_mask(SpiceWatch *watch, int event_mask) @@ -117,6 +127,14 @@ static SpiceWatch *watch_add(int fd, int event_mask, S= piceWatchFunc func, void * { SpiceWatch *watch; =20 +#ifdef WIN32 + fd =3D _open_osfhandle(fd, _O_BINARY); + if (fd < 0) { + error_setg_win32(&error_warn, WSAGetLastError(), "Couldn't associa= te a FD with the SOCKET"); + return NULL; + } +#endif + watch =3D g_malloc0(sizeof(*watch)); watch->fd =3D fd; watch->func =3D func; @@ -129,6 +147,10 @@ static SpiceWatch *watch_add(int fd, int event_mask, S= piceWatchFunc func, void * static void watch_remove(SpiceWatch *watch) { qemu_set_fd_handler(watch->fd, NULL, NULL, NULL); +#ifdef WIN32 + /* SOCKET is owned by spice */ + qemu_close_to_socket(watch->fd); +#endif g_free(watch); } =20 @@ -908,6 +930,9 @@ static int qemu_spice_set_pw_expire(time_t expires) =20 static int qemu_spice_display_add_client(int csock, int skipauth, int tls) { +#ifdef WIN32 + csock =3D qemu_close_socket_osfhandle(csock); +#endif if (tls) { return spice_server_add_ssl_client(spice_server, csock, skipauth); } else { --=20 2.39.2 From nobody Sun May 5 09:05:38 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1679319477; cv=none; d=zohomail.com; s=zohoarc; b=WNbnY/BmZy0RClwEl42T+pi2cvcDqIYGH0XgOpSS0Fn5BzUY2vJp08TM3taJ3ssz8orLs9r/lm644bWJtR5wtnncdbqMA6lybLaFg1dGBwZ74LZGQttqiJhToe4Dig5+yRa63D7NJqr7dUP3sBRQfIIm0eyBXeasIHR6LBbHFvQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679319477; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=BUyMeTTjy6ngKW7/BI4gPLuQkk4HNuIn8h0LVT6p+jM=; b=GtZPVPl7aHMm80nxCwpLaslHRQg15k8vhnTrk1Y7kPz5yVvrCA0BhlYLElipo8bUL4w1ygeXQj8QoIyBdHKlVN+DfzHhAwbXDuTGPTB+NZgNeSK5MsqomEAkZs9cbgcw0OEseFJF73o5XggT1jVJ7AxigBR4ModWz7zg7xIEHXY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1679319477636121.00598879973506; Mon, 20 Mar 2023 06:37:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1peFhG-0002zO-FV; Mon, 20 Mar 2023 09:37:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peFhE-0002z0-An for qemu-devel@nongnu.org; Mon, 20 Mar 2023 09:37:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peFhC-0000EA-Ry for qemu-devel@nongnu.org; Mon, 20 Mar 2023 09:37:08 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-318-NxIempl3OCuLApAdS6XZgQ-1; Mon, 20 Mar 2023 09:37:02 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EC6E4101A553; Mon, 20 Mar 2023 13:37:00 +0000 (UTC) Received: from localhost (unknown [10.39.208.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id CB22A40C6E67; Mon, 20 Mar 2023 13:36:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679319425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BUyMeTTjy6ngKW7/BI4gPLuQkk4HNuIn8h0LVT6p+jM=; b=dLokOvIJ/dnlo9UBoWMuMpBAjhXUl7+KV658mYB+JRMazWDSGgodsi7YUZIQbIXnGc8uPL acmAJ1CMQX5wN+0CK6MT24dXXRZptqIx3Vna+tWlapmMqIYam7oMisfMq21CEYAsvnjEn3 QHPIqU0K12fG+jigPH8UyMZfzxH9o1o= X-MC-Unique: NxIempl3OCuLApAdS6XZgQ-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Stefan Weil , berrange@redhat.com, Gerd Hoffmann Subject: [PATCH v2 3/3] ui/dbus: fix passing SOCKET to GSocket API & leak Date: Mon, 20 Mar 2023 17:36:43 +0400 Message-Id: <20230320133643.1618437-4-marcandre.lureau@redhat.com> In-Reply-To: <20230320133643.1618437-1-marcandre.lureau@redhat.com> References: <20230320133643.1618437-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1679319478355100003 From: Marc-Andr=C3=A9 Lureau -display dbus is not currently available to win32 users, so it's not considered a regression. Note also the close() leak fix in case of error. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Daniel P. Berrang=C3=A9 --- ui/dbus.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/ui/dbus.c b/ui/dbus.c index 0513de9918..b9e9698503 100644 --- a/ui/dbus.c +++ b/ui/dbus.c @@ -304,11 +304,20 @@ dbus_display_add_client(int csock, Error **errp) g_cancellable_cancel(dbus_display->add_client_cancellable); } =20 +#ifdef WIN32 + socket =3D g_socket_new_from_fd(_get_osfhandle(csock), &err); +#else socket =3D g_socket_new_from_fd(csock, &err); +#endif if (!socket) { error_setg(errp, "Failed to setup D-Bus socket: %s", err->message); + close(csock); return false; } +#ifdef WIN32 + /* socket owns the SOCKET handle now, so release our osf handle */ + qemu_close_socket_osfhandle(csock); +#endif =20 conn =3D g_socket_connection_factory_create_connection(socket); =20 --=20 2.39.2