From nobody Wed Apr 24 19:35:03 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1679160767; cv=none; d=zohomail.com; s=zohoarc; b=hWU7n8nJcOXdSGH0RHa1/RClv2G0xyvWnxNz54NefcyyMteWNbbCkAGaG43/PVz6pBX/wTEFehXKYLfpxOrhhYSH9oF6xDIMCIjiCx2OGqF3nMf/npWYxHrAyAbLANcLD4LJ2mZvLWy2P8SIUijetWZFlNgg02hVMNt9DMnZ+ZM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679160767; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=PhOdPCjy9eqCMegLr52s7S4YJTBJc9cWnJnmvsj7hsI=; b=b21j4JuW3RIU8UEZEsuF/B1fYWc5C8L9gIXd80DTjg5bCWwFUkHJRFYh8Qi4UcppR5E1Bi4IDTUxSpiZxC09Byrbf0o2sI9+9YJo4Zq8v+HiEXCbQsQi6rm6iMCiT4WvZeQpw1qsBshBVQ5V+NgGJNzAnNcpIU4i6lqktZckoT8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1679160767704553.6667262982946; Sat, 18 Mar 2023 10:32:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pdaPC-0002GL-1B; Sat, 18 Mar 2023 13:31:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdaPA-0002Fr-2w for qemu-devel@nongnu.org; Sat, 18 Mar 2023 13:31:44 -0400 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pdaP8-0005Ky-Lu for qemu-devel@nongnu.org; Sat, 18 Mar 2023 13:31:43 -0400 Received: by mail-ed1-x52f.google.com with SMTP id eh3so31876379edb.11 for ; Sat, 18 Mar 2023 10:31:41 -0700 (PDT) Received: from Provence.localdomain (dynamic-077-011-121-187.77.11.pool.telefonica.de. [77.11.121.187]) by smtp.gmail.com with ESMTPSA id d13-20020a170906344d00b009318ad4a583sm2372448ejb.210.2023.03.18.10.31.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Mar 2023 10:31:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679160700; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PhOdPCjy9eqCMegLr52s7S4YJTBJc9cWnJnmvsj7hsI=; b=n9HhIldi31jNGNhouh6upDz5q2R91w+YfeQimlHiTlW2OwSVxQ+TjZAlqqWrWPbLhg QLVYAIQetYDvSuqIpFfynSKKuUkUxmMI7se3gmmyJYj4ifgB1VNL14ZMj2wqx6Ln+BEI lgLDrYz5tN4VFcoWSZ5dbS4NoTs+5UDrx5i3+1Rt9UI8oNo995vH7OCb2BC9llpBaWKw 5bKuy2iQtNJKcBtOz1PcGnQHdYriIFy8rwb6zh5Ofqrlumb5MmksxgoqmONuVt7XGSmW nnRXdJ0gI8APsBeeZVqUe89GoAgCzev2hllZEGz5x8vwnn/Ugvjwv8EH1JuKmwvX1rYR oiyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679160700; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PhOdPCjy9eqCMegLr52s7S4YJTBJc9cWnJnmvsj7hsI=; b=klo1L5E5im8nt1JFH9LhFKOF5gDP3YNVAroInj3dGrhmwg4P9MKDnyRzxKBmHg3gDv Trs0CO00RN+0ofuoGuGlThJHHtr8tNVy9+WkVYH301aPYWvUh1TW5uTT6YOLL2IObxYT DCRYcKzbpIAalWR5yeKzK0hCBP+yjiK5W6lRPDm/kbrwMRf7LTkz6XJPAdxy4onWTBKZ 4IEya8iOWIstQ/HFW3tbOWOV3ZWSIvUuzGymcGg46irasJ91DndSo8VgHmOMSBRuvh4j NvDr6mwZNQkFxG7QhIqJYhPbsuBJVY3wAgLe0Q/WIGdb3TYtNmMjV9PjL+jloT4oa/Us f0Rg== X-Gm-Message-State: AO0yUKUQfmCR63fE9MvQk8odX9EQMomz3/83kvEkG+fBg3Ln6MMcP5aH Hteh/Au5YJQno0NHJc7bH/wqf8j+aQM= X-Google-Smtp-Source: AK7set+564nby9bEN8LtCBIbr+laL0jkzL56ksnac/Vsft3T6QcWnhmQSltVovusOgNvpudp1Rvvnw== X-Received: by 2002:a17:906:370b:b0:933:3cc7:4420 with SMTP id d11-20020a170906370b00b009333cc74420mr2059066ejc.45.1679160700345; Sat, 18 Mar 2023 10:31:40 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Bernhard Beschow Subject: [PATCH for-8.0] Revert "ui: set cursor position upon listener registration" Date: Sat, 18 Mar 2023 18:31:32 +0100 Message-Id: <20230318173132.98068-1-shentey@gmail.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52f; envelope-from=shentey@gmail.com; helo=mail-ed1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1679160768152100001 Content-Type: text/plain; charset="utf-8" Commit 6effaa16ac98 ("ui: set cursor position upon listener registration") causes the mouse cursor to be placed into the lower left corner when QEMU starts. This could be reproduced with just by running `qemu-system-x86_64`. This reverts commit 6effaa16ac9846e7d6197ee54a0551fba61aecd7. Signed-off-by: Bernhard Beschow --- ui/console.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/ui/console.c b/ui/console.c index f3783021e5..35f8274aab 100644 --- a/ui/console.c +++ b/ui/console.c @@ -95,7 +95,6 @@ struct QemuConsole { QemuUIInfo ui_info; QEMUTimer *ui_timer; QEMUCursor *cursor; - int cursor_x, cursor_y, cursor_on; const GraphicHwOps *hw_ops; void *hw; =20 @@ -1666,9 +1665,6 @@ void register_displaychangelistener(DisplayChangeList= ener *dcl) if (con && con->cursor && dcl->ops->dpy_cursor_define) { dcl->ops->dpy_cursor_define(dcl, con->cursor); } - if (con && dcl->ops->dpy_mouse_set) { - dcl->ops->dpy_mouse_set(dcl, con->cursor_x, con->cursor_y, con->cu= rsor_on); - } text_console_update_cursor(NULL); } =20 @@ -1913,9 +1909,6 @@ void dpy_mouse_set(QemuConsole *con, int x, int y, in= t on) DisplayState *s =3D con->ds; DisplayChangeListener *dcl; =20 - con->cursor_x =3D x; - con->cursor_y =3D y; - con->cursor_on =3D on; if (!qemu_console_is_visible(con)) { return; } --=20 2.40.0