From nobody Mon Sep 16 19:11:54 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1679068622; cv=none; d=zohomail.com; s=zohoarc; b=Y6Shhgs7onSY/BdHTrXvNX7NAzO1YzP2k2tvgHE7xFkkSCQ3wt7sU5Vg3ETIH67aEE38frSSUIFmxWxI6wsGXEUqZBMTz2UADVa38lZ6rS1VySPO1GdwrE7RCtS6aTUlnLjFGwqnRrqXFRaVuwAE+7GOn991vGnWaFTetfPhyHw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679068622; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=askS0DPb36wWSlWBcou6AQU6SXy8h0tFjS5nQCc6vaA=; b=nS83KCyFgibwyMuK0yE5n3Y8GACkEg+FDnQbrjfTbl18zDjzBtcbrmTqOWBE6LNb6SMidBtrTYfFRf97XjMW7nbfjltoUgqQg3GYIp8/U3fQoSJKnf6adoc/wDsiF1eqCpkIRrX4xbcjVga/HJkIbYc0oyv6W5d95Lmj5qaG1eg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 167906862273228.94125510964568; Fri, 17 Mar 2023 08:57:02 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pdCQ6-0002l0-8K; Fri, 17 Mar 2023 11:55:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdCQ4-0002kY-IM for qemu-devel@nongnu.org; Fri, 17 Mar 2023 11:55:04 -0400 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pdCQ2-0007n4-Jc for qemu-devel@nongnu.org; Fri, 17 Mar 2023 11:55:04 -0400 Received: by mail-pl1-x633.google.com with SMTP id a2so5743343plm.4 for ; Fri, 17 Mar 2023 08:55:01 -0700 (PDT) Received: from stoup.. (96-82-119-43-static.hfc.comcastbusiness.net. [96.82.119.43]) by smtp.gmail.com with ESMTPSA id s5-20020a656445000000b004fb3e5681cesm1668986pgv.20.2023.03.17.08.54.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 08:54:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679068499; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=askS0DPb36wWSlWBcou6AQU6SXy8h0tFjS5nQCc6vaA=; b=Vfp4xpx/71EHcr8FctyahoeNr5bWU0tU84bZownV+f77nW87XfsVYEm1nmdoWGcDiS zKqNMtfGxW2DVeU4srp/v+XKtzHYzUm2ULHcKNWChbU6EP/+kU8LrNk903jJoevoR80T Yq5TyLX2wJR4k/2u+566lWIJv0SG/xF7WxprXxTDefl9TaysN0D6kLUCudUX4O542b1A gpuGmZXrMOYHfzlD4fx4Yyn7m60OaTMixarj5fXFgz35Hk+AzWiUDRZSdNlj/oJBby+a PA5rObGnN0t1UqFYkqlL/VtNOM3ibiM6C04zvcy/ZMYrb/o79eQvu+PkSX5ehBrxg9Jj KZVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679068499; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=askS0DPb36wWSlWBcou6AQU6SXy8h0tFjS5nQCc6vaA=; b=7OYLMYmk6b5w3UdUFGDsxpvS8eP1hzrI4dGlMxJ94BxYJXlesSvlVqs3ri2NH2Ngs+ SWjxfiDRyfGvQAwRoSvRorvNsUr/APsYuaXLzcWFGnz8oRYbyTKZnOFVUgBAga7Sl9J2 Zwc7cUAc7/n9S1bcQFlqwbN5gI184xnZXwF6AXyOXvurNMWyrBI9dLxzpu2GQ82DG2cM qx7qYlzPO0JBcH71ZabuJV+JSEi+IFNQjXprEnKKd42DhqRGWMb5cNdj6TzFgfSQaAoC WSQHr9+3wBiUaptxRVpDjXfKMCc9h613Eh/xoZLJX89v0fDauyR/0hwjWhQLAwZk159/ T3YA== X-Gm-Message-State: AO0yUKUsVEQe5uuiAp8Hyj06/glh1UL9sD0+JC9lVjQVLT79/N/33JMR okLxeV7c2RF+OXbOjpVoEWISBX09KIIuezkO38A= X-Google-Smtp-Source: AK7set9x0loyCHxOP/rEjNGvf13VMhOJGXnJ1yYK24MvlRtncYNlFSJeoQn7/pPQFOxfQt23LSTxgQ== X-Received: by 2002:a05:6a20:158e:b0:d4:c806:bdc0 with SMTP id h14-20020a056a20158e00b000d4c806bdc0mr9513037pzj.17.1679068499470; Fri, 17 Mar 2023 08:54:59 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org Subject: [PATCH v2 1/9] linux-user: Diagnose misaligned -R size Date: Fri, 17 Mar 2023 08:54:47 -0700 Message-Id: <20230317155455.341843-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230317155455.341843-1-richard.henderson@linaro.org> References: <20230317155455.341843-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::633; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1679068624471100003 Content-Type: text/plain; charset="utf-8" We have been enforcing host page alignment for the non-R fallback of MAX_RESERVED_VA, but failing to enforce for -R. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- linux-user/main.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/linux-user/main.c b/linux-user/main.c index 4b18461969..39d9bd4d7a 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -793,6 +793,12 @@ int main(int argc, char **argv, char **envp) */ max_reserved_va =3D MAX_RESERVED_VA(cpu); if (reserved_va !=3D 0) { + if (reserved_va % qemu_host_page_size) { + char *s =3D size_to_str(qemu_host_page_size); + fprintf(stderr, "Reserved virtual address not aligned mod %s\n= ", s); + g_free(s); + exit(EXIT_FAILURE); + } if (max_reserved_va && reserved_va > max_reserved_va) { fprintf(stderr, "Reserved virtual address too big\n"); exit(EXIT_FAILURE); --=20 2.34.1