From nobody Thu Mar 28 11:07:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1679039974; cv=none; d=zohomail.com; s=zohoarc; b=XoVGFvXS3l22KSfebmPYXK1uL42v+vpO1XyWyMry9JWe1zcOPLAqFV/9Atuxt/lBpOB3SB8NVOWqrvHCwz5xUP5eZbVv7gRLCEHqXnp9+Sty2DBNKO9jEVJpeTiL6Sa1IMqaZl1zHhm2sw9//JVHXMAPt2X4i/sOZXSGTCrdosI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679039974; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=J6Wuq+7GYJTxOVxGkMQVIC+icVoILnwp5Xyh8kcEQUI=; b=M/m8owXgYq5FAHZtBpTFWwx1i/8oFUnPW39VqVwnqQUyIJroAyAT0Mp62FRk/JeiE0xszUtnQVKW/dLCzO0R7x5nVJwUtnoBL1xUWT9e8RT35MwibpWAbTbOAc87jrqy5Z/ux1hIRD4C/mZRcWQ5iG4r9Zu1CE8V9X8xfXcp+6c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16790399744181.0710024010967345; Fri, 17 Mar 2023 00:59:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pd4z4-0006LO-7n; Fri, 17 Mar 2023 03:58:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pd4yy-0006LB-JN for qemu-devel@nongnu.org; Fri, 17 Mar 2023 03:58:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pd4yv-0000v1-6g for qemu-devel@nongnu.org; Fri, 17 Mar 2023 03:58:35 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-650-MxP8EklwN6CMv82VUD2Z_Q-1; Fri, 17 Mar 2023 03:58:27 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A88611C08975 for ; Fri, 17 Mar 2023 07:58:27 +0000 (UTC) Received: from localhost (unknown [10.39.208.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id 53B571410F1C; Fri, 17 Mar 2023 07:58:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679039910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=J6Wuq+7GYJTxOVxGkMQVIC+icVoILnwp5Xyh8kcEQUI=; b=dYkSqjNF6voneFaGhl2tjn5HC3e+GVk48tv9+h31Qd5lR2V1qXuy13pZxJwwMwagAY45L2 PfS/W04/UPVFjZFRW9ROuPd8SvS8F+pU4Bd/7iuEn28f6WQt0V2JC6f0gR/pERxHLnuSXC xmjA3ponkZyseQhALOvVZlSyuLBZp2w= X-MC-Unique: MxP8EklwN6CMv82VUD2Z_Q-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: berrange@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann Subject: [PATCH] ui/gtk: fix error message regression Date: Fri, 17 Mar 2023 11:58:23 +0400 Message-Id: <20230317075823.953430-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1679039976567100002 From: Marc-Andr=C3=A9 Lureau Since commit 6effaa16 ("ui: set cursor position upon listener registration") a new error message shows up when starting qemu with gtk backend: qemu: Gdk: gdk_window_get_root_coords: assertion 'GDK_IS_WINDOW (window)' f= ailed Like many display listener callbacks, skip code if the widget is not yet realized. Fixes: 6effaa16 ("ui: set cursor position upon listener registration") Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/gtk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ui/gtk.c b/ui/gtk.c index 57ae32474c..f3105796f8 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -450,7 +450,8 @@ static void gd_mouse_set(DisplayChangeListener *dcl, GdkDisplay *dpy; gint x_root, y_root; =20 - if (qemu_input_is_absolute()) { + if (qemu_input_is_absolute() || + !gtk_widget_get_realized(vc->gfx.drawing_area)) { return; } =20 --=20 2.39.2