From nobody Tue Feb 10 06:58:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1678708492; cv=none; d=zohomail.com; s=zohoarc; b=GidKqfLMMyNZtSdb2DLADsKGS8ymEhsYOAljCisyHiYiwX8DXZZvKdVYVJU1XdeIqiUKZQJmKZpLNvvYWqTMtY7yLAsRVgz+7hVeHpcN1vqdL98U0SnrUKfSnCTRc5NHEH8ymgHnvtcwIonsr5FJT0ikpgX7lrOBzLQmQrFRtUk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1678708492; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=BqxGsWxXmu7LEVQhkjkpbn+02NihnK+bVamWmx0KeA4=; b=KNCPJe01LfBO9pm9TwtEjE5XiQXASX1jVaJSg1IEuTHl5xe8Z9NazFhM5gOPRSSXsg/am2bIu5FC8ZqYhLpbuET50S0S8FdQ1nG0TGYznAXK12GXyEVxi5J3iJAEfqnsomfKFdzfbXXMk95a4RhU8Q+C/P56FySVm0XD8m0CB1A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1678708492906416.29296268132646; Mon, 13 Mar 2023 04:54:52 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pbgbi-0003pW-F5; Mon, 13 Mar 2023 07:44:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pbgbN-0003Ez-UC for qemu-devel@nongnu.org; Mon, 13 Mar 2023 07:44:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pbgbM-0003XF-4e for qemu-devel@nongnu.org; Mon, 13 Mar 2023 07:44:29 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-654-ByUOM3VlMoOP0vCmhBa-1w-1; Mon, 13 Mar 2023 07:44:22 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A434C3C0F676; Mon, 13 Mar 2023 11:44:21 +0000 (UTC) Received: from localhost (unknown [10.39.208.8]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4F4461121315; Mon, 13 Mar 2023 11:44:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678707867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BqxGsWxXmu7LEVQhkjkpbn+02NihnK+bVamWmx0KeA4=; b=N1aYjqRkQri9ZpVheLLFV5WwwK4RArSKJJiyDONXtvllCFaWIhneilNohjn3rqXfg60jlc OzNicdsJI7LQFFzy948qBoFwXyuc+40ga9PMix+bwx95ACtG4mlBZ1PDR85O0TiKBU7VBW +G0FY83IeiPbZ8lcOYy/i0ea3Rr9bCs= X-MC-Unique: ByUOM3VlMoOP0vCmhBa-1w-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Stefan Hajnoczi , Samuel Thibault , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Stefan Weil , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Wainer dos Santos Moschetta , Laurent Vivier , Joel Stanley , Kevin Wolf , Paolo Bonzini , qemu-arm@nongnu.org, Eric Blake , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Michael Roth , "Dr. David Alan Gilbert" , Thomas Huth , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Beraldo Leal , Stefan Berger , Fam Zheng , Hanna Reitz , Peter Maydell , Markus Armbruster , Jason Wang Subject: [PULL 09/25] aio/win32: aio_set_fd_handler() only supports SOCKET Date: Mon, 13 Mar 2023 15:43:19 +0400 Message-Id: <20230313114335.424093-10-marcandre.lureau@redhat.com> In-Reply-To: <20230313114335.424093-1-marcandre.lureau@redhat.com> References: <20230313114335.424093-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1678708493498100003 From: Marc-Andr=C3=A9 Lureau Let's check if the argument is actually a SOCKET, else report an error and return. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Stefan Berger Message-Id: <20230221124802.4103554-10-marcandre.lureau@redhat.com> --- util/aio-win32.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/util/aio-win32.c b/util/aio-win32.c index 74d63fa21e..08e8f5615d 100644 --- a/util/aio-win32.c +++ b/util/aio-win32.c @@ -22,6 +22,7 @@ #include "qemu/sockets.h" #include "qapi/error.h" #include "qemu/rcu_queue.h" +#include "qemu/error-report.h" =20 struct AioHandler { EventNotifier *e; @@ -70,10 +71,14 @@ void aio_set_fd_handler(AioContext *ctx, IOHandler *io_poll_ready, void *opaque) { - /* fd is a SOCKET in our case */ AioHandler *old_node; AioHandler *node =3D NULL; =20 + if (!fd_is_socket(fd)) { + error_report("fd=3D%d is not a socket, AIO implementation is missi= ng", fd); + return; + } + qemu_lockcnt_lock(&ctx->list_lock); QLIST_FOREACH(old_node, &ctx->aio_handlers, node) { if (old_node->pfd.fd =3D=3D fd && !old_node->deleted) { --=20 2.39.2