From nobody Mon Feb 9 16:12:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1678393312; cv=none; d=zohomail.com; s=zohoarc; b=e8GEMEHtBtBOKuoB8PmZA+M1vdncNxj7o1QvjeSZZ4eviUFFKJ/Y6KdimgQDw9B4NW7k1I0oUHFAEycGh0MOppkzdBPnaWiT3TYC4LeKZ/zJ/ZjMBSHdl3AurfkD0MvS5s5XBDWysfxUk7a4ImrxIqTMIhlDy1M/YOsAWAObKCI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1678393312; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=b3ClZ5bqNSiKy/nbq5LS98oyuV7R9Cbo4BQLBqocESs=; b=j0OfAb5ZwLbcpxaNNW69bq4DM5MZZA+SiDvHi48QRwrVPxORVCOdHqHa2ZXEkxGpPxCF+Iw8+JjCekcaaw4z+Mi3WzMmlQCoFASBLBOX7AOmhtIOz9QG26qYi707yRAi8fk2YiJu0EPE56v9rxUEGp6zF2nBxCYoPrljv0i2oIc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1678393312721299.1677944514681; Thu, 9 Mar 2023 12:21:52 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1paMfj-0004le-3T; Thu, 09 Mar 2023 15:15:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paMfb-0004Zf-MC; Thu, 09 Mar 2023 15:15:23 -0500 Received: from smtp-out2.suse.de ([2001:67c:2178:6::1d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1paMfZ-0002jc-Qy; Thu, 09 Mar 2023 15:15:23 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 292A9202A7; Thu, 9 Mar 2023 20:15:20 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3B5B31391B; Thu, 9 Mar 2023 20:15:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id SLpWAVU+CmTUZwAAMHmgww (envelope-from ); Thu, 09 Mar 2023 20:15:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1678392920; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b3ClZ5bqNSiKy/nbq5LS98oyuV7R9Cbo4BQLBqocESs=; b=MsBnb0PBWSsVV9UC2zwBmQrbZNWi/u3xYz0OrzUfXxU3xI8Hz2TTlMNN/LmomiyJTaaPR5 MLw1EfmrYNuDZzoT0u7sBlnss73lFNeHPyGn162mTPnFe8YXuJjDKmC0UNSSRAUrE+Q3m4 p+drIAyA0PAhb2k30voSG4kc0ABY1BM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1678392920; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b3ClZ5bqNSiKy/nbq5LS98oyuV7R9Cbo4BQLBqocESs=; b=dZQC/ekyYIPxU0rB1i8fqryosmRjHgwgmYdLwDQa/hWUG8dFtzUcOv2cMZrcFss/SFxP8q SqJLtHTRz5bJgsAg== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Claudio Fontana , Eduardo Habkost , Alexander Graf , Cornelia Huck Subject: [PATCH v8 11/11] target/arm: gdbstub: Guard pauth code with CONFIG_TCG Date: Thu, 9 Mar 2023 17:14:34 -0300 Message-Id: <20230309201434.10831-12-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230309201434.10831-1-farosas@suse.de> References: <20230309201434.10831-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:67c:2178:6::1d; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1678393314096100007 Content-Type: text/plain; charset="utf-8" We currently don't have the reading of pauth regs implemented for KVM so wrap the pauth registration with CONFIG_TCG. This avoids the build error when using --disable-tcg: libqemu-aarch64-softmmu.fa.p/target_arm_gdbstub64.c.o: in function `aarch64_gdb_get_pauth_reg': ../target/arm/gdbstub64.c:233: undefined reference to `pauth_ptr_mask' Signed-off-by: Fabiano Rosas --- Does this make sense? I seem to remember we had a rule that for KVM register values should come from the ONE_REG interface. --- target/arm/gdbstub.c | 2 ++ target/arm/gdbstub64.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/target/arm/gdbstub.c b/target/arm/gdbstub.c index 2ecc362ac2..fc937580dd 100644 --- a/target/arm/gdbstub.c +++ b/target/arm/gdbstub.c @@ -521,11 +521,13 @@ void arm_cpu_register_gdb_regs_for_features(ARMCPU *c= pu) aarch64_gdb_set_fpu_reg, 34, "aarch64-fpu.xml", 0); } +#ifdef CONFIG_TCG if (isar_feature_aa64_pauth(&cpu->isar)) { gdb_register_coprocessor(cs, aarch64_gdb_get_pauth_reg, aarch64_gdb_set_pauth_reg, 4, "aarch64-pauth.xml", 0); } +#endif /* CONFIG_TCG */ #endif } else { if (arm_feature(env, ARM_FEATURE_NEON)) { diff --git a/target/arm/gdbstub64.c b/target/arm/gdbstub64.c index 3bee892fb7..67c7cbb63c 100644 --- a/target/arm/gdbstub64.c +++ b/target/arm/gdbstub64.c @@ -210,6 +210,7 @@ int aarch64_gdb_set_sve_reg(CPUARMState *env, uint8_t *= buf, int reg) return 0; } =20 +#ifdef CONFIG_TCG int aarch64_gdb_get_pauth_reg(CPUARMState *env, GByteArray *buf, int reg) { switch (reg) { @@ -243,6 +244,7 @@ int aarch64_gdb_set_pauth_reg(CPUARMState *env, uint8_t= *buf, int reg) /* All pseudo registers are read-only. */ return 0; } +#endif =20 static void output_vector_union_type(GString *s, int reg_width, const char *name) --=20 2.35.3