From nobody Sun May 19 01:15:23 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1678379535; cv=none; d=zohomail.com; s=zohoarc; b=HK3Ret0VQf3mL8XkSwNRtCh9IDeU6Lesh67y591nGFC2gVn7wIcucfIkmIeRZaROJxtAOgrYJ5by2QRcu++hjEjKjE4WAe8EIUkXFkaF8yUa+quVSdHgS9X6BhTP3tW3RNDbg+XnPqz5CQOLUt7yqImk0GNKQPMhDzZXDaAgvLI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1678379535; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=Xxchwmn++SQPnWfBYkNl5wXzAasnqzWL/4LPzS3yxkM=; b=RJVtiE6TQGQExxrO/UfUiSjVacAFAvTlf4iax6oAuqx7/HekR0osLQPBsZqYgNtMQorsOXVux58MsTz2VmsYSz4kCbUttXSnP49pueKgg4vliaJooCU1hsiS9M2PoNlCbv3On9G8eUjdKGXAFz7DjKMcyDAnqGegPTe98MfQPMQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1678379535505958.949844228132; Thu, 9 Mar 2023 08:32:15 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1paJBN-0006qj-S5; Thu, 09 Mar 2023 11:31:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paJB9-0006jU-9G for qemu-devel@nongnu.org; Thu, 09 Mar 2023 11:31:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paJB8-00033m-1P for qemu-devel@nongnu.org; Thu, 09 Mar 2023 11:31:43 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-586-aF4Ke-rIPKeIkze6MhYGaw-1; Thu, 09 Mar 2023 11:31:37 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B119218F0241; Thu, 9 Mar 2023 16:31:36 +0000 (UTC) Received: from localhost (unknown [10.39.193.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id 196761121314; Thu, 9 Mar 2023 16:31:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678379501; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Xxchwmn++SQPnWfBYkNl5wXzAasnqzWL/4LPzS3yxkM=; b=fn/LtluXtH/gJi2Eyz3Jmvjyit6RQPN9mekt/ZdDvZJ+emyljzbkzbQXxNak/335wh6HvI YNGfvtfH67qcG8y5tbLuQWRTkpb+nNAyXY6lWLqYGFGZayz+YoR25Fj1RAdMOvcs56emeE Zrq7Da0kQfF8ox9R0EriE0TTUnkyY0k= X-MC-Unique: aF4Ke-rIPKeIkze6MhYGaw-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Kevin Wolf , Stefan Hajnoczi , Hanna Reitz , pbonzini@redhat.com Subject: [PATCH] qed: remove spurious BDRV_POLL_WHILE() Date: Thu, 9 Mar 2023 11:31:34 -0500 Message-Id: <20230309163134.398707-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1678379536412100001 Content-Type: text/plain; charset="utf-8" This looks like a copy-paste or merge error. BDRV_POLL_WHILE() is already called above. It's not needed in the qemu_in_coroutine() case. Fixes: 9fb4dfc570ce ("qed: make bdrv_qed_do_open a coroutine_fn") Signed-off-by: Stefan Hajnoczi --- block/qed.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/qed.c b/block/qed.c index ed94bb61ca..0705a7b4e2 100644 --- a/block/qed.c +++ b/block/qed.c @@ -594,7 +594,6 @@ static int bdrv_qed_open(BlockDriverState *bs, QDict *o= ptions, int flags, qemu_coroutine_enter(qemu_coroutine_create(bdrv_qed_open_entry, &q= oc)); BDRV_POLL_WHILE(bs, qoc.ret =3D=3D -EINPROGRESS); } - BDRV_POLL_WHILE(bs, qoc.ret =3D=3D -EINPROGRESS); return qoc.ret; } =20 --=20 2.39.2