From nobody Fri May 9 01:33:57 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass(p=none dis=none) header.from=linaro.org
ARC-Seal: i=1; a=rsa-sha256; t=1678063830; cv=none;
d=zohomail.com; s=zohoarc;
b=ENdmd3S9MrKWvQ+0u2sWJ0Ng5ewEQ3Xo8BbiBXIYZbC6C7CGA7N52NVx9g5jaX/v2pukmVTlFCprg8F4atq4YyuRUauXIr7BduasUAo90HTNnUsij9Cj2RsyjgYWLtLl7GP5BLer5WZJjbm05kuZ0BExieMcEaY595uOFVJwI10=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1678063830;
h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
bh=1rz9k7o4d//+CtCPfl15T22J2m9D1OS7OQgm/BQ1mJE=;
b=buoRrDibNKpis8sfZaqzv352ZEpzQ6xQVK6l/gLLycnrVP6Uol3vIpqFmlmSKuZf8vu2BMvvf7zxwIuopaxOnovbMG/bbcrV/EIVbLCi+Zvy1A5kRVkboOB6Dd11MTwWqrPrhJBwuC84wKxXTRJdPsGz4mi+WLuoUhMv6NTWFRo=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass header.from=<richard.henderson@linaro.org> (p=none dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 1678063830933904.4076788520912;
Sun, 5 Mar 2023 16:50:30 -0800 (PST)
Received: from localhost ([::1] helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces@nongnu.org>)
id 1pYyue-0005d0-9A; Sun, 05 Mar 2023 19:41:12 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)
id 1pYyu3-0004XP-Tb
for qemu-devel@nongnu.org; Sun, 05 Mar 2023 19:40:35 -0500
Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)
id 1pYyu0-0006sn-5u
for qemu-devel@nongnu.org; Sun, 05 Mar 2023 19:40:35 -0500
Received: by mail-pj1-x1041.google.com with SMTP id
x20-20020a17090a8a9400b00233ba727724so9706356pjn.1
for <qemu-devel@nongnu.org>; Sun, 05 Mar 2023 16:40:31 -0800 (PST)
Received: from stoup.. ([2602:ae:154a:9f01:87cc:49bb:2900:c08b])
by smtp.gmail.com with ESMTPSA id
r13-20020a17090b050d00b002372106a5c2sm6567901pjz.37.2023.03.05.16.40.30
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 05 Mar 2023 16:40:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google; t=1678063231;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=1rz9k7o4d//+CtCPfl15T22J2m9D1OS7OQgm/BQ1mJE=;
b=hFZkzlgB37Iwt8O+Lm7gTE073z0e7A082+fa4plp2WSq0A1DnKE7XLkQXPtxfFXy2D
5sy7DZle1kKPWdvUNwmjAREVDzAqkqARL4a0dMs6saZ0dJHl6J1PDJc4TtYt96Vi0UFe
yfiZu9BHnI6aWVGY4V0UN3uaf8uGBaI0/LOw5No2T0okJmBFtk/ECjyJ+QLWjaHzhzce
TqVjLYpToHP/IwDKFkY/Euew8Lno5w6YtpqQ6nV0vBRP4eLzfAVbcW5gar1VZEWy+oa3
C3H65dLwnZ0FTlhhVF8S46wtjgIWH+BtPevNG0D6icAgb70UtW7db9Yauor7kA6O9T4k
NNpg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112; t=1678063231;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=1rz9k7o4d//+CtCPfl15T22J2m9D1OS7OQgm/BQ1mJE=;
b=nrumDRuN4TxDD/EK2BZ9a4GXLZV8OezsrJvA4sKEkdHVJAYrnf1wiOl0jtYzS+a7ev
d+LIl5/3jpu9Ky2Fgr7kqCENRkMV+OzbrVxMfsbB+pDE4zxk1YCrdcWNLfi1Ob6xdjsU
lxdoZiSfqkdZ1539bbDdFk4BgBN1nHJ/QeQLe68Vp6QYic4FL7hlssv31P0ofk5rfxAQ
LrO++MgkcJCBcmEGYgNaYT2+lLCtPkc2EX0/xVUzHP/IcZD4NHXgougltZm5QJ8kvW90
MmpkjFmDh+fHCkYVaX0Ax0DCA9YR/95zzGsGAUWKkqmjBvaCanedhKGBybnNyB7Y87RL
od7Q==
X-Gm-Message-State: AO0yUKUVhcYq5+fNa+P78wF9Zmb0JtP51OzmeiIfoL/kKcHgrnHZGgxC
ZKHy7BtxyRgdT4U2T+hZpuIRWLGrMAqbbLSUgPw34cNm
X-Google-Smtp-Source:
AK7set8ycea5QPmk3eKK7IZ6NJe5VVsMHwgYMGJLc0h3z8JTSP3sPKKP/hb33DvDt6iaU0RoHjr7eg==
X-Received: by 2002:a17:90a:7:b0:23a:6be8:9446 with SMTP id
7-20020a17090a000700b0023a6be89446mr9777893pja.48.1678063230693;
Sun, 05 Mar 2023 16:40:30 -0800 (PST)
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org,
Taylor Simpson <tsimpson@quicinc.com>
Subject: [PULL 39/84] target/hexagon/idef-parser: Drop HexValue.is_manual
Date: Sun, 5 Mar 2023 16:39:09 -0800
Message-Id: <20230306003954.1866998-40-richard.henderson@linaro.org>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20230306003954.1866998-1-richard.henderson@linaro.org>
References: <20230306003954.1866998-1-richard.henderson@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=2607:f8b0:4864:20::1041;
envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1041.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org
X-ZohoMail-DKIM: pass (identity @linaro.org)
X-ZM-MESSAGEID: 1678063832965100011
Content-Type: text/plain; charset="utf-8"
This field is no longer used.
Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/hexagon/idef-parser/idef-parser.h | 1 -
target/hexagon/idef-parser/parser-helpers.c | 15 ---------------
target/hexagon/idef-parser/idef-parser.y | 2 --
3 files changed, 18 deletions(-)
diff --git a/target/hexagon/idef-parser/idef-parser.h b/target/hexagon/idef=
-parser/idef-parser.h
index 5c49d4da3e..17d2ebfaf6 100644
--- a/target/hexagon/idef-parser/idef-parser.h
+++ b/target/hexagon/idef-parser/idef-parser.h
@@ -185,7 +185,6 @@ typedef struct HexValue {
unsigned bit_width; /**< Bit width of the rvalue =
*/
HexSignedness signedness; /**< Unsigned flag for the rvalue =
*/
bool is_dotnew; /**< rvalue of predicate type is dotnew? =
*/
- bool is_manual; /**< Opt out of automatic freeing of param=
s */
} HexValue;
=20
/**
diff --git a/target/hexagon/idef-parser/parser-helpers.c b/target/hexagon/i=
def-parser/parser-helpers.c
index bdbb8b6a5f..0b401f7dbe 100644
--- a/target/hexagon/idef-parser/parser-helpers.c
+++ b/target/hexagon/idef-parser/parser-helpers.c
@@ -278,7 +278,6 @@ static HexValue gen_constant(Context *c,
rvalue.bit_width =3D bit_width;
rvalue.signedness =3D signedness;
rvalue.is_dotnew =3D false;
- rvalue.is_manual =3D true;
rvalue.tmp.index =3D c->inst.tmp_count;
OUT(c, locp, "TCGv_i", &bit_width, " tmp_", &c->inst.tmp_count,
" =3D tcg_constant_i", &bit_width, "(", value, ");\n");
@@ -299,7 +298,6 @@ HexValue gen_tmp(Context *c,
rvalue.bit_width =3D bit_width;
rvalue.signedness =3D signedness;
rvalue.is_dotnew =3D false;
- rvalue.is_manual =3D false;
rvalue.tmp.index =3D c->inst.tmp_count;
OUT(c, locp, "TCGv_i", &bit_width, " tmp_", &c->inst.tmp_count,
" =3D tcg_temp_new_i", &bit_width, "();\n");
@@ -320,7 +318,6 @@ HexValue gen_tmp_value(Context *c,
rvalue.bit_width =3D bit_width;
rvalue.signedness =3D signedness;
rvalue.is_dotnew =3D false;
- rvalue.is_manual =3D false;
rvalue.tmp.index =3D c->inst.tmp_count;
OUT(c, locp, "TCGv_i", &bit_width, " tmp_", &c->inst.tmp_count,
" =3D tcg_const_i", &bit_width, "(", value, ");\n");
@@ -339,7 +336,6 @@ static HexValue gen_tmp_value_from_imm(Context *c,
rvalue.bit_width =3D value->bit_width;
rvalue.signedness =3D value->signedness;
rvalue.is_dotnew =3D false;
- rvalue.is_manual =3D false;
rvalue.tmp.index =3D c->inst.tmp_count;
/*
* Here we output the call to `tcg_const_i<width>` in
@@ -375,7 +371,6 @@ HexValue gen_imm_value(Context *c __attribute__((unused=
)),
rvalue.bit_width =3D bit_width;
rvalue.signedness =3D signedness;
rvalue.is_dotnew =3D false;
- rvalue.is_manual =3D false;
rvalue.imm.type =3D VALUE;
rvalue.imm.value =3D value;
return rvalue;
@@ -390,7 +385,6 @@ HexValue gen_imm_qemu_tmp(Context *c, YYLTYPE *locp, un=
signed bit_width,
memset(&rvalue, 0, sizeof(HexValue));
rvalue.type =3D IMMEDIATE;
rvalue.is_dotnew =3D false;
- rvalue.is_manual =3D false;
rvalue.bit_width =3D bit_width;
rvalue.signedness =3D signedness;
rvalue.imm.type =3D QEMU_TMP;
@@ -1242,15 +1236,12 @@ void gen_rdeposit_op(Context *c,
*/
k64 =3D gen_bin_op(c, locp, SUB_OP, &k64, &width_m);
mask =3D gen_bin_op(c, locp, LSR_OP, &mask, &k64);
- begin_m.is_manual =3D true;
mask =3D gen_bin_op(c, locp, ASL_OP, &mask, &begin_m);
- mask.is_manual =3D true;
value_m =3D gen_bin_op(c, locp, ASL_OP, &value_m, &begin_m);
value_m =3D gen_bin_op(c, locp, ANDB_OP, &value_m, &mask);
=20
OUT(c, locp, "tcg_gen_not_i", &dst->bit_width, "(", &mask, ", ",
&mask, ");\n");
- mask.is_manual =3D false;
res =3D gen_bin_op(c, locp, ANDB_OP, dst, &mask);
res =3D gen_bin_op(c, locp, ORB_OP, &res, &value_m);
=20
@@ -1410,8 +1401,6 @@ HexValue gen_convround(Context *c,
HexValue and;
HexValue src_p1;
=20
- src_m.is_manual =3D true;
-
and =3D gen_bin_op(c, locp, ANDB_OP, &src_m, &mask);
src_p1 =3D gen_bin_op(c, locp, ADD_OP, &src_m, &one);
=20
@@ -1569,10 +1558,6 @@ HexValue gen_round(Context *c,
b =3D gen_extend_op(c, locp, &src_width, 64, pos, UNSIGNED);
b =3D rvalue_materialize(c, locp, &b);
=20
- /* Disable auto-free of values used more than once */
- a.is_manual =3D true;
- b.is_manual =3D true;
-
n_m1 =3D gen_bin_op(c, locp, SUB_OP, &b, &one);
shifted =3D gen_bin_op(c, locp, ASL_OP, &one, &n_m1);
sum =3D gen_bin_op(c, locp, ADD_OP, &shifted, &a);
diff --git a/target/hexagon/idef-parser/idef-parser.y b/target/hexagon/idef=
-parser/idef-parser.y
index 59c93f85b4..fae291e5f8 100644
--- a/target/hexagon/idef-parser/idef-parser.y
+++ b/target/hexagon/idef-parser/idef-parser.y
@@ -534,7 +534,6 @@ rvalue : FAIL
rvalue.imm.type =3D IMM_CONSTEXT;
rvalue.signedness =3D UNSIGNED;
rvalue.is_dotnew =3D false;
- rvalue.is_manual =3D false;
$$ =3D rvalue;
}
| var
@@ -693,7 +692,6 @@ rvalue : FAIL
}
| rvalue '?'
{
- $1.is_manual =3D true;
Ternary t =3D { 0 };
t.state =3D IN_LEFT;
t.cond =3D $1;
--=20
2.34.1