From nobody Tue Feb 10 21:59:51 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1677775197; cv=none; d=zohomail.com; s=zohoarc; b=ajKbRzcW3kiiQMqKY8MhhOJD+pyc18SmmN/sthDdgoj7jszjfZCgVR/g8MSyVEzjM2tZEiIxnn6lw3Z0zWK9uZaJlOoV4wY81Jn1+vWdOt/4NtMAQWCmrw5v0l0v2cdaJlPKxte1hq4gD/FFVSmb1VyAqcoymTeeXb01ebO/0FU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1677775197; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pIqp5G7ertyq/PCIurRIiNVROHJnsldBL1HAvk8RPsM=; b=fT2zUoTxLmV1M7td47aSXFopalSDROt01RZ/5Ogm1cbQfWrIDdMkMxqAXEz0AlZGEgW8TEW1sEqT0pZbhCz3r3wqZa9BW/d6mGIci8YupYBtZoQKx0rePLu/sGlrTG8cyX0pwYPPknArsKbRBvtKVWKH621OklIzWpvo06sIVNE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1677775197895853.1963384579298; Thu, 2 Mar 2023 08:39:57 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXlvD-0002xV-VW; Thu, 02 Mar 2023 11:36:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXlud-0001X0-3x for qemu-devel@nongnu.org; Thu, 02 Mar 2023 11:36:14 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXlua-0008WP-G5 for qemu-devel@nongnu.org; Thu, 02 Mar 2023 11:36:10 -0500 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-206-0uOKDKgFM0691cVp56HjQw-1; Thu, 02 Mar 2023 11:36:06 -0500 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 143A31C3D38C; Thu, 2 Mar 2023 16:36:06 +0000 (UTC) Received: from secure.mitica (unknown [10.39.194.31]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0D6AC492C3E; Thu, 2 Mar 2023 16:36:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677774967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pIqp5G7ertyq/PCIurRIiNVROHJnsldBL1HAvk8RPsM=; b=U6vcE/WiH5gTkGOordq+Ydb48SOas1feg4Cd6Mt5/Wgn97QfKknkwZv1Sb2ShXypGR3C5Q fZEpQOmB+edEQc88CKYcqrzKI7ajChEaJw57AcPl1WHJ8o/eF48LjzgSAby2L2McvLe2xC ylI/R/xVgQcPivHZx5m1aWTiWILBfgk= X-MC-Unique: 0uOKDKgFM0691cVp56HjQw-1 From: Juan Quintela To: qemu-devel@nongnu.org Cc: David Hildenbrand , Vladimir Sementsov-Ogievskiy , John Snow , Stefan Hajnoczi , Juan Quintela , qemu-block@nongnu.org, Hailiang Zhang , Fam Zheng , "Michael S. Tsirkin" , "Dr. David Alan Gilbert" , Eric Blake Subject: [PATCH 33/43] migration: Create migrate_params_init() function Date: Thu, 2 Mar 2023 17:34:00 +0100 Message-Id: <20230302163410.11399-34-quintela@redhat.com> In-Reply-To: <20230302163410.11399-1-quintela@redhat.com> References: <20230302163410.11399-1-quintela@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1677775199011100003 Content-Type: text/plain; charset="utf-8" Signed-off-by: Juan Quintela --- migration/options.h | 1 + migration/migration.c | 29 +---------------------------- migration/options.c | 31 +++++++++++++++++++++++++++++++ 3 files changed, 33 insertions(+), 28 deletions(-) diff --git a/migration/options.h b/migration/options.h index 95338d1efd..c7c9a4002b 100644 --- a/migration/options.h +++ b/migration/options.h @@ -86,5 +86,6 @@ uint64_t migrate_xbzrle_cache_size(void); /* parameters helpers */ =20 bool migrate_params_check(MigrationParameters *params, Error **errp); +void migrate_params_init(MigrationParameters *params); =20 #endif diff --git a/migration/migration.c b/migration/migration.c index 5d43e815ed..62a6f29647 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -3455,7 +3455,6 @@ static void migration_instance_finalize(Object *obj) static void migration_instance_init(Object *obj) { MigrationState *ms =3D MIGRATION_OBJ(obj); - MigrationParameters *params =3D &ms->parameters; =20 ms->state =3D MIGRATION_STATUS_NONE; ms->mbps =3D -1; @@ -3463,33 +3462,7 @@ static void migration_instance_init(Object *obj) qemu_sem_init(&ms->pause_sem, 0); qemu_mutex_init(&ms->error_mutex); =20 - params->tls_hostname =3D g_strdup(""); - params->tls_creds =3D g_strdup(""); - - /* Set has_* up only for parameter checks */ - params->has_compress_level =3D true; - params->has_compress_threads =3D true; - params->has_compress_wait_thread =3D true; - params->has_decompress_threads =3D true; - params->has_throttle_trigger_threshold =3D true; - params->has_cpu_throttle_initial =3D true; - params->has_cpu_throttle_increment =3D true; - params->has_cpu_throttle_tailslow =3D true; - params->has_max_bandwidth =3D true; - params->has_downtime_limit =3D true; - params->has_x_checkpoint_delay =3D true; - params->has_block_incremental =3D true; - params->has_multifd_channels =3D true; - params->has_multifd_compression =3D true; - params->has_multifd_zlib_level =3D true; - params->has_multifd_zstd_level =3D true; - params->has_xbzrle_cache_size =3D true; - params->has_max_postcopy_bandwidth =3D true; - params->has_max_cpu_throttle =3D true; - params->has_announce_initial =3D true; - params->has_announce_max =3D true; - params->has_announce_rounds =3D true; - params->has_announce_step =3D true; + migrate_params_init(&ms->parameters); =20 qemu_sem_init(&ms->postcopy_pause_sem, 0); qemu_sem_init(&ms->postcopy_pause_rp_sem, 0); diff --git a/migration/options.c b/migration/options.c index efa9c6788d..15ee1aa922 100644 --- a/migration/options.c +++ b/migration/options.c @@ -742,6 +742,37 @@ MigrationParameters *qmp_query_migrate_parameters(Erro= r **errp) return params; } =20 +void migrate_params_init(MigrationParameters *params) +{ + params->tls_hostname =3D g_strdup(""); + params->tls_creds =3D g_strdup(""); + + /* Set has_* up only for parameter checks */ + params->has_compress_level =3D true; + params->has_compress_threads =3D true; + params->has_compress_wait_thread =3D true; + params->has_decompress_threads =3D true; + params->has_throttle_trigger_threshold =3D true; + params->has_cpu_throttle_initial =3D true; + params->has_cpu_throttle_increment =3D true; + params->has_cpu_throttle_tailslow =3D true; + params->has_max_bandwidth =3D true; + params->has_downtime_limit =3D true; + params->has_x_checkpoint_delay =3D true; + params->has_block_incremental =3D true; + params->has_multifd_channels =3D true; + params->has_multifd_compression =3D true; + params->has_multifd_zlib_level =3D true; + params->has_multifd_zstd_level =3D true; + params->has_xbzrle_cache_size =3D true; + params->has_max_postcopy_bandwidth =3D true; + params->has_max_cpu_throttle =3D true; + params->has_announce_initial =3D true; + params->has_announce_max =3D true; + params->has_announce_rounds =3D true; + params->has_announce_step =3D true; +} + /* * Check whether the parameters are valid. Error will be put into errp * (if provided). Return true if valid, otherwise false. --=20 2.39.2