From nobody Mon Feb 9 20:12:51 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1677760647; cv=none; d=zohomail.com; s=zohoarc; b=f0NgjYZKmYJ/n5TAvEdy3kGwM1eJaXXaGBdW4HQOMG90KfN2lZuYqiagLcvxVyyVoH3K8SMXCdUuey9DK8qKArWszewk+J2qg6cCpVRGDj3Z7s2SuX5XvMf2TV9jtg4/Rivx1g4wFo8zm7qEnH5/ZqDFvqk3VtaxyBc15tTsnsA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1677760647; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NDjVGp0dIGJEJab/RXk335NOwHswWdDScGy8GXlP8Sk=; b=PDxWgu5UAAhCmXiX+DKnESTYQ7uPEXVMRfN4MJ59owePRPw+wNCUyFidnk3gOmLsiYsk5MbxJlS0O08jcGD+hRGR+GjhsMlkiSxRD578ApC0Msqf/IA1vdSLvaHNivmsjHoFScjKITTf1OgZydip7lYJk8G5KRQVYHuXk0yf9UU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1677760647482461.3224803142099; Thu, 2 Mar 2023 04:37:27 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXi7k-0002yq-39; Thu, 02 Mar 2023 07:33:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXi6d-0002UT-2E for qemu-devel@nongnu.org; Thu, 02 Mar 2023 07:32:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXi6b-0003HL-BX for qemu-devel@nongnu.org; Thu, 02 Mar 2023 07:32:18 -0500 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-580-ZxYhGsxUNcyAP3xbur1ygw-1; Thu, 02 Mar 2023 07:32:15 -0500 Received: by mail-wm1-f72.google.com with SMTP id r7-20020a05600c35c700b003eb3f2c4fb4so1014357wmq.6 for ; Thu, 02 Mar 2023 04:32:15 -0800 (PST) Received: from avogadro.local ([2001:b07:6468:f312:1c09:f536:3de6:228c]) by smtp.gmail.com with ESMTPSA id ja20-20020a05600c557400b003eb596cbc54sm2954411wmb.0.2023.03.02.04.32.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Mar 2023 04:32:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677760336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NDjVGp0dIGJEJab/RXk335NOwHswWdDScGy8GXlP8Sk=; b=bhFkpVXzYHyoaWjSO51zerKyuc24Fn3OndGt65uA8LJ3i/6ojFHZtxg7uA+2qBrEhj0bjN ZfLDn1KSWnrp6FpgzAba5ZO8pqkqG3aVTP47wEL3axvdppY4AfOTAvGrcw3fg8cRRD56fy A9UQ/4T9bOwfoJAO59peiiWg2Dw8Rg4= X-MC-Unique: ZxYhGsxUNcyAP3xbur1ygw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NDjVGp0dIGJEJab/RXk335NOwHswWdDScGy8GXlP8Sk=; b=Bps7n9jY/8UujX/WpldgB3/WSWVErersNhyVZn8vQCoiveNuRvKvh4aEibX2O0X7FK Kms6KY958IgxG+MjS9PN6LNVSjFvOOmza6moxfEGyn+U0mEFK0gvypeIkQlTGNdqwUi+ s57KV2JdKPPHFghy9K3I9MbZvig3Z+JK/2KQ/bLPTRepEF50MBM0GE/hnKiIxQaIGvN5 u1vhTraNVngFm0Q2P2ipZVyf0U6/xE4rxqJuw6yLDJZJQ6i6Fr5MNGIK56nJWovetoZN VM79R4EEVo/PB6uNbFQh2PXopmPExdyToHHzwHNrKciYNMCdrG11eakCKrafsd2fw7tg WP2Q== X-Gm-Message-State: AO0yUKXUb4USgsnKj+2ne0YKy29hdXqfvKh/DFm49SSQeipnTTTaMYiP wj2khKvpTpa6yPrup41tsvaO4WXiYKk0C3VNK8RPf9felbBdP7rvzzjpJpQ+Fn9k4RHxGhDmg5z T1VlFT6FDscTR7KziObASLzB+ZBllpaA59D4/XHmDRKm0ZN+/cc+1LOObA//rgRf+bSb33B/rcu 4= X-Received: by 2002:a5d:6545:0:b0:2c7:cc8:782c with SMTP id z5-20020a5d6545000000b002c70cc8782cmr1429931wrv.1.1677760333891; Thu, 02 Mar 2023 04:32:13 -0800 (PST) X-Google-Smtp-Source: AK7set8qXkTO8FTYfmiDo8WWd+lhsFDCOl+jq8OWxWQ3/LhBvV7/f49W1bsDuEO4qggO32MeIAQJEw== X-Received: by 2002:a5d:6545:0:b0:2c7:cc8:782c with SMTP id z5-20020a5d6545000000b002c70cc8782cmr1429917wrv.1.1677760333551; Thu, 02 Mar 2023 04:32:13 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: David Woodhouse , Paul Durrant Subject: [PULL 34/62] hw/xen: Implement EVTCHNOP_send Date: Thu, 2 Mar 2023 13:30:01 +0100 Message-Id: <20230302123029.153265-35-pbonzini@redhat.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302123029.153265-1-pbonzini@redhat.com> References: <20230302123029.153265-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1677760649516100004 Content-Type: text/plain; charset="utf-8" From: David Woodhouse Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant --- hw/i386/kvm/xen_evtchn.c | 180 ++++++++++++++++++++++++++++++++++++++ hw/i386/kvm/xen_evtchn.h | 2 + target/i386/kvm/xen-emu.c | 12 +++ 3 files changed, 194 insertions(+) diff --git a/hw/i386/kvm/xen_evtchn.c b/hw/i386/kvm/xen_evtchn.c index eea80dc0f53c..ce7a96923409 100644 --- a/hw/i386/kvm/xen_evtchn.c +++ b/hw/i386/kvm/xen_evtchn.c @@ -490,6 +490,133 @@ static int unmask_port(XenEvtchnState *s, evtchn_port= _t port, bool do_unmask) } } =20 +static int do_set_port_lm(XenEvtchnState *s, evtchn_port_t port, + struct shared_info *shinfo, + struct vcpu_info *vcpu_info) +{ + const int bits_per_word =3D BITS_PER_BYTE * sizeof(shinfo->evtchn_pend= ing[0]); + typeof(shinfo->evtchn_pending[0]) mask; + int idx =3D port / bits_per_word; + int offset =3D port % bits_per_word; + + mask =3D 1UL << offset; + + if (idx >=3D bits_per_word) { + return -EINVAL; + } + + /* Update the pending bit itself. If it was already set, we're done. */ + if (qatomic_fetch_or(&shinfo->evtchn_pending[idx], mask) & mask) { + return 0; + } + + /* Check if it's masked. */ + if (qatomic_fetch_or(&shinfo->evtchn_mask[idx], 0) & mask) { + return 0; + } + + /* Now on to the vcpu_info evtchn_pending_sel index... */ + mask =3D 1UL << idx; + + /* If a port in this word was already pending for this vCPU, all done.= */ + if (qatomic_fetch_or(&vcpu_info->evtchn_pending_sel, mask) & mask) { + return 0; + } + + /* Set evtchn_upcall_pending for this vCPU */ + if (qatomic_fetch_or(&vcpu_info->evtchn_upcall_pending, 1)) { + return 0; + } + + inject_callback(s, s->port_table[port].vcpu); + + return 0; +} + +static int do_set_port_compat(XenEvtchnState *s, evtchn_port_t port, + struct compat_shared_info *shinfo, + struct compat_vcpu_info *vcpu_info) +{ + const int bits_per_word =3D BITS_PER_BYTE * sizeof(shinfo->evtchn_pend= ing[0]); + typeof(shinfo->evtchn_pending[0]) mask; + int idx =3D port / bits_per_word; + int offset =3D port % bits_per_word; + + mask =3D 1UL << offset; + + if (idx >=3D bits_per_word) { + return -EINVAL; + } + + /* Update the pending bit itself. If it was already set, we're done. */ + if (qatomic_fetch_or(&shinfo->evtchn_pending[idx], mask) & mask) { + return 0; + } + + /* Check if it's masked. */ + if (qatomic_fetch_or(&shinfo->evtchn_mask[idx], 0) & mask) { + return 0; + } + + /* Now on to the vcpu_info evtchn_pending_sel index... */ + mask =3D 1UL << idx; + + /* If a port in this word was already pending for this vCPU, all done.= */ + if (qatomic_fetch_or(&vcpu_info->evtchn_pending_sel, mask) & mask) { + return 0; + } + + /* Set evtchn_upcall_pending for this vCPU */ + if (qatomic_fetch_or(&vcpu_info->evtchn_upcall_pending, 1)) { + return 0; + } + + inject_callback(s, s->port_table[port].vcpu); + + return 0; +} + +static int set_port_pending(XenEvtchnState *s, evtchn_port_t port) +{ + void *vcpu_info, *shinfo; + + if (s->port_table[port].type =3D=3D EVTCHNSTAT_closed) { + return -EINVAL; + } + + if (s->evtchn_in_kernel) { + XenEvtchnPort *p =3D &s->port_table[port]; + CPUState *cpu =3D qemu_get_cpu(p->vcpu); + struct kvm_irq_routing_xen_evtchn evt; + + if (!cpu) { + return 0; + } + + evt.port =3D port; + evt.vcpu =3D kvm_arch_vcpu_id(cpu); + evt.priority =3D KVM_IRQ_ROUTING_XEN_EVTCHN_PRIO_2LEVEL; + + return kvm_vm_ioctl(kvm_state, KVM_XEN_HVM_EVTCHN_SEND, &evt); + } + + shinfo =3D xen_overlay_get_shinfo_ptr(); + if (!shinfo) { + return -ENOTSUP; + } + + vcpu_info =3D kvm_xen_get_vcpu_info_hva(s->port_table[port].vcpu); + if (!vcpu_info) { + return -EINVAL; + } + + if (xen_is_long_mode()) { + return do_set_port_lm(s, port, shinfo, vcpu_info); + } else { + return do_set_port_compat(s, port, shinfo, vcpu_info); + } +} + static int clear_port_pending(XenEvtchnState *s, evtchn_port_t port) { void *p =3D xen_overlay_get_shinfo_ptr(); @@ -709,3 +836,56 @@ int xen_evtchn_bind_ipi_op(struct evtchn_bind_ipi *ipi) =20 return ret; } + +int xen_evtchn_send_op(struct evtchn_send *send) +{ + XenEvtchnState *s =3D xen_evtchn_singleton; + XenEvtchnPort *p; + int ret =3D 0; + + if (!s) { + return -ENOTSUP; + } + + if (!valid_port(send->port)) { + return -EINVAL; + } + + qemu_mutex_lock(&s->port_lock); + + p =3D &s->port_table[send->port]; + + switch (p->type) { + case EVTCHNSTAT_interdomain: + if (p->type_val & PORT_INFO_TYPEVAL_REMOTE_QEMU) { + /* + * This is an event from the guest to qemu itself, which is + * serving as the driver domain. Not yet implemented; it will + * be hooked up to the qemu implementation of xenstore, + * console, PV net/block drivers etc. + */ + ret =3D -ENOSYS; + } else { + /* Loopback interdomain ports; just a complex IPI */ + set_port_pending(s, p->type_val); + } + break; + + case EVTCHNSTAT_ipi: + set_port_pending(s, send->port); + break; + + case EVTCHNSTAT_unbound: + /* Xen will silently drop these */ + break; + + default: + ret =3D -EINVAL; + break; + } + + qemu_mutex_unlock(&s->port_lock); + + return ret; +} + diff --git a/hw/i386/kvm/xen_evtchn.h b/hw/i386/kvm/xen_evtchn.h index 107f4208485e..500fdbe8b804 100644 --- a/hw/i386/kvm/xen_evtchn.h +++ b/hw/i386/kvm/xen_evtchn.h @@ -20,10 +20,12 @@ struct evtchn_close; struct evtchn_unmask; struct evtchn_bind_virq; struct evtchn_bind_ipi; +struct evtchn_send; int xen_evtchn_status_op(struct evtchn_status *status); int xen_evtchn_close_op(struct evtchn_close *close); int xen_evtchn_unmask_op(struct evtchn_unmask *unmask); int xen_evtchn_bind_virq_op(struct evtchn_bind_virq *virq); int xen_evtchn_bind_ipi_op(struct evtchn_bind_ipi *ipi); +int xen_evtchn_send_op(struct evtchn_send *send); =20 #endif /* QEMU_XEN_EVTCHN_H */ diff --git a/target/i386/kvm/xen-emu.c b/target/i386/kvm/xen-emu.c index b8b439dd311a..19a7f16ebe6b 100644 --- a/target/i386/kvm/xen-emu.c +++ b/target/i386/kvm/xen-emu.c @@ -909,6 +909,18 @@ static bool kvm_xen_hcall_evtchn_op(struct kvm_xen_exi= t *exit, X86CPU *cpu, } break; } + case EVTCHNOP_send: { + struct evtchn_send send; + + qemu_build_assert(sizeof(send) =3D=3D 4); + if (kvm_copy_from_gva(cs, arg, &send, sizeof(send))) { + err =3D -EFAULT; + break; + } + + err =3D xen_evtchn_send_op(&send); + break; + } default: return false; } --=20 2.39.1