From nobody Tue Feb 10 07:22:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1676467697; cv=none; d=zohomail.com; s=zohoarc; b=FEyw7rYlYpbk3jZFgMVsXFoZOznEdNFrvI5kcPKbZuid6G7YxtMEZNhSspV/Zh5olb2dHG8hqgGSyK413EEXfHW65ysuShyp0mhg4og+KmyFPVJkDn6hU43dlhU7Wo4mnaOwI9SOHH0LWv3P51bitk6+j30P9I6pY2szw2xJyUE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676467697; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4q7yHq5S4Z63P/ahm7pjK2Tqngrc7sOnIY6XgPxHZ88=; b=bCxDjv26SWv2WQ3Z0S3JvcbWSVwtoN12G4Nj58xk8uHzlOr8pLbYzCuv0XkBZWTIPACyYCEYAc/u9TwrvWCnX5SgJYvDEN/LRoCYsY3tEhdrcVxQnxdCIK+pUTiIsgtVD/H93e5qvT/HG2zeMd4JJGtGeqQXFm0Y86yOD61b+QQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1676467697452914.3217029627041; Wed, 15 Feb 2023 05:28:17 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSHnd-0002aM-8o; Wed, 15 Feb 2023 08:26:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSHnZ-0002VB-IL; Wed, 15 Feb 2023 08:26:14 -0500 Received: from forwardcorp1a.mail.yandex.net ([178.154.239.72]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSHnV-0006Do-HC; Wed, 15 Feb 2023 08:26:13 -0500 Received: from vla5-b2806cb321eb.qloud-c.yandex.net (vla5-b2806cb321eb.qloud-c.yandex.net [IPv6:2a02:6b8:c18:3e0d:0:640:b280:6cb3]) by forwardcorp1a.mail.yandex.net (Yandex) with ESMTP id 5ACD65FEA9; Wed, 15 Feb 2023 16:26:02 +0300 (MSK) Received: from vsementsov-win.yandex-team.ru (unknown [2a02:6b8:b081:b4bf::1:2e]) by vla5-b2806cb321eb.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id nPk8g80UxeA1-DwywQfGB; Wed, 15 Feb 2023 16:26:01 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1676467561; bh=4q7yHq5S4Z63P/ahm7pjK2Tqngrc7sOnIY6XgPxHZ88=; h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From; b=kVmDSLTa8/DHOiaGeRv+sdKPRttOx4HGJNvHkDpxglMBIio70X65LrGa5oXVoJGHQ yVUK83tCwy1kj7yTMgWGLuELH/H8F1y0EFVNTEXeOauiy6SRMUziN6V9EN6muPMXqC G5p15InYRFeOcGirhq+lPfqL0lWCvvH0fEfpSwyk= Authentication-Results: vla5-b2806cb321eb.qloud-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, vsementsov@yandex-team.ru, jsnow@redhat.com, crosa@redhat.com, kwolf@redhat.com, hreitz@redhat.com Subject: [PATCH v5 06/16] python: rename QEMUMonitorProtocol.cmd() to cmd_raw() Date: Wed, 15 Feb 2023 16:25:37 +0300 Message-Id: <20230215132547.1620575-7-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230215132547.1620575-1-vsementsov@yandex-team.ru> References: <20230215132547.1620575-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=178.154.239.72; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1a.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1676467698338100010 Content-Type: text/plain; charset="utf-8" Having cmd() and command() methods in one class doesn't look good. Rename cmd() to cmd_raw(), to show its meaning better. We also want to rename command() to cmd() in future, so this commit is a necessary step. Signed-off-by: Vladimir Sementsov-Ogievskiy --- python/qemu/machine/machine.py | 2 +- python/qemu/qmp/legacy.py | 4 ++-- tests/qemu-iotests/iotests.py | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py index e57c254484..0428eec50c 100644 --- a/python/qemu/machine/machine.py +++ b/python/qemu/machine/machine.py @@ -683,7 +683,7 @@ def qmp(self, cmd: str, conv_keys =3D True =20 qmp_args =3D self._qmp_args(conv_keys, args) - ret =3D self._qmp.cmd(cmd, args=3Dqmp_args) + ret =3D self._qmp.cmd_raw(cmd, args=3Dqmp_args) if cmd =3D=3D 'quit' and 'error' not in ret and 'return' in ret: self._quit_issued =3D True return ret diff --git a/python/qemu/qmp/legacy.py b/python/qemu/qmp/legacy.py index c7b252842a..5552f4ebb4 100644 --- a/python/qemu/qmp/legacy.py +++ b/python/qemu/qmp/legacy.py @@ -198,8 +198,8 @@ def cmd_obj(self, qmp_cmd: QMPMessage) -> QMPMessage: ) ) =20 - def cmd(self, name: str, - args: Optional[Dict[str, object]] =3D None) -> QMPMessage: + def cmd_raw(self, name: str, + args: Optional[Dict[str, object]] =3D None) -> QMPMessage: """ Build a QMP command and send it to the QMP Monitor. =20 diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 3e82c634cf..675fbaa1c3 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu-iotests/iotests.py @@ -460,7 +460,7 @@ def __init__(self, *args: str, instance_id: str =3D 'a'= , qmp: bool =3D False): def qmp(self, cmd: str, args: Optional[Dict[str, object]] =3D None) \ -> QMPMessage: assert self._qmp is not None - return self._qmp.cmd(cmd, args) + return self._qmp.cmd_raw(cmd, args) =20 def stop(self, kill_signal=3D15): self._p.send_signal(kill_signal) --=20 2.34.1