From nobody Mon Feb 9 07:55:08 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1676373821; cv=none; d=zohomail.com; s=zohoarc; b=As5TzGDVg3uC+2V55r0nu6iLZnCYZt8PNLiM/5eTzSSGKlhFqBfu7+65rGg/3Oqwz04OqE7PPuyjxBtbvqmXG1nNjx1XBvMAjt6qXtzaeG2ep5iF+qLxS/yQ3HQCn1aI3hlDBttyfNJttsEncEsFIzOnJLAMooLb/7muC9dsVq0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676373821; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Qe7a2aGWYQpAKccN1WxYVT/DsbvqX8in3IWprtkArgQ=; b=Vs6BKe6x0HGMXsnTZGEJu0MNscZdRYZ97HzCN+yZRVi7DXkcIofRULyXIILW48CwnH9BFnhmcNoENQ/wtABnnBcS91fFWvkoi0Ot1ijH2eA46uzHBgobQwTDr7usSVG+VsHIxaYqZO5NnONM4wWu5S/tWWKc7X5mNk1vP2kS16g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1676373821769876.5669135556022; Tue, 14 Feb 2023 03:23:41 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRtOW-00081v-Up; Tue, 14 Feb 2023 06:22:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRtOR-0007sO-Om for qemu-devel@nongnu.org; Tue, 14 Feb 2023 06:22:40 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRtOC-0002Ny-Hz for qemu-devel@nongnu.org; Tue, 14 Feb 2023 06:22:39 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-240-XKEr7VF2Maq3Xs4IiZKm-A-1; Tue, 14 Feb 2023 06:22:13 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 95B16181E3EE; Tue, 14 Feb 2023 11:22:08 +0000 (UTC) Received: from thuth.com (unknown [10.39.192.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id BEA3A40B40C9; Tue, 14 Feb 2023 11:22:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676373743; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qe7a2aGWYQpAKccN1WxYVT/DsbvqX8in3IWprtkArgQ=; b=fKxt4vGL+1eJY4POFeDdhykpRqilDqsEzfs0dSE+xz/SWaE8NIHemSimTrE8t7Flb91P3g Sk2VOft0Q2/ir+rBI6xO+gLo0nT55rFTW95ymlOmRTbWARUDK2hraKWjkCfgJ2YzgEqdgI 8aa2J3IzUCh5/K837BN9U5ftkK5tH5I= X-MC-Unique: XKEr7VF2Maq3Xs4IiZKm-A-1 From: Thomas Huth To: Peter Maydell , qemu-devel@nongnu.org Cc: Fabiano Rosas Subject: [PULL 13/22] test/qtest: Fix coding style in device-plug-test.c Date: Tue, 14 Feb 2023 12:21:39 +0100 Message-Id: <20230214112148.646077-14-thuth@redhat.com> In-Reply-To: <20230214112148.646077-1-thuth@redhat.com> References: <20230214112148.646077-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1676373823813100005 Content-Type: text/plain; charset="utf-8" From: Fabiano Rosas We should not mix declarations and statements in QEMU code. Signed-off-by: Fabiano Rosas Message-Id: <20230208194700.11035-7-farosas@suse.de> Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- tests/qtest/device-plug-test.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/qtest/device-plug-test.c b/tests/qtest/device-plug-test.c index 5a6afa2b57..4f92617335 100644 --- a/tests/qtest/device-plug-test.c +++ b/tests/qtest/device-plug-test.c @@ -64,6 +64,7 @@ static void process_device_remove(QTestState *qtest, cons= t char *id) =20 static void test_pci_unplug_request(void) { + QTestState *qtest; const char *arch =3D qtest_get_arch(); const char *machine_addition =3D ""; =20 @@ -71,8 +72,8 @@ static void test_pci_unplug_request(void) machine_addition =3D "-machine pc"; } =20 - QTestState *qtest =3D qtest_initf("%s -device virtio-mouse-pci,id=3Dde= v0", - machine_addition); + qtest =3D qtest_initf("%s -device virtio-mouse-pci,id=3Ddev0", + machine_addition); =20 process_device_remove(qtest, "dev0"); =20 @@ -94,6 +95,7 @@ static void test_q35_pci_unplug_request(void) =20 static void test_pci_unplug_json_request(void) { + QTestState *qtest; const char *arch =3D qtest_get_arch(); const char *machine_addition =3D ""; =20 @@ -101,7 +103,7 @@ static void test_pci_unplug_json_request(void) machine_addition =3D "-machine pc"; } =20 - QTestState *qtest =3D qtest_initf( + qtest =3D qtest_initf( "%s -device \"{'driver': 'virtio-mouse-pci', 'id': 'dev0'}\"", machine_addition); =20 --=20 2.31.1