From nobody Mon Feb 9 16:19:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1675989199; cv=none; d=zohomail.com; s=zohoarc; b=f7KFXF0JI+U/o6kWX+25p/nT0nZugxk4UM0MesugnzGWkmwi9TO2emdnFvEV2F7+trLChSC1gBC1wpzldyNAaHQFl+7lPaCz5T0MuK7LMmtPJDJ1wlz8rrZIbRcyA5oOm1014H9lnSiK+fhhZL+qN4InYDi3XWZqDvVeCGXFzmg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1675989199; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5HuGil72VbTu8JXPIwRlzXgWe/SWcTU8vf4autsPwzg=; b=IIJVl0AR4ZAAdwOTuO5LhM4Ffvhi3CO4LCb+HvRq1e3f57EDBKSfjsEGVTnNcs5AmGBG2vmG+JzNRsjrSdq5ksqonAt0M3cmPyRH4/IY9WuVLxKEYapx4WmZc+ggPljRsbUpAm/6bI3ZoiL9ugetgSX3FO15thBWOym8QvgKeog= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1675989199887192.93256749417742; Thu, 9 Feb 2023 16:33:19 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pQHKa-0001RT-H8; Thu, 09 Feb 2023 19:32:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQHKY-0001Ou-6w for qemu-devel@nongnu.org; Thu, 09 Feb 2023 19:31:58 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQHKU-0001eY-K5 for qemu-devel@nongnu.org; Thu, 09 Feb 2023 19:31:57 -0500 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-189-txRPHgsoMb6z_DyJFV9Qcw-1; Thu, 09 Feb 2023 19:31:51 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 83B243C0D18C; Fri, 10 Feb 2023 00:31:50 +0000 (UTC) Received: from scv.redhat.com (unknown [10.22.16.119]) by smtp.corp.redhat.com (Postfix) with ESMTP id EF99718EC1; Fri, 10 Feb 2023 00:31:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675989114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5HuGil72VbTu8JXPIwRlzXgWe/SWcTU8vf4autsPwzg=; b=YvicwA8sMPQ5oxEhSmvv57lSzpAZcUSGisYjS2N1kvxXKOFBx8obaH/QNNoxECIbO8w6G6 iPP+eFfO5pDCC2wBpkQUGAo9RlXZIcuz7CHSB9mvM38S2iXWdauNHb38Fb9p1wy2q8QJ7E XkZE+QdnsLxzUuR+DpvypuBDNeIzmqM= X-MC-Unique: txRPHgsoMb6z_DyJFV9Qcw-1 From: John Snow To: qemu-devel@nongnu.org Cc: Peter Maydell , Cleber Rosa , John Snow , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth , Daniel Berrange , Beraldo Leal , Michael Roth , Wainer dos Santos Moschetta , Markus Armbruster , Paolo Bonzini , qemu-block@nongnu.org, Hanna Reitz , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Kevin Wolf Subject: [PATCH v2 3/7] configure: Look for auxiliary Python installations Date: Thu, 9 Feb 2023 19:31:43 -0500 Message-Id: <20230210003147.1309376-4-jsnow@redhat.com> In-Reply-To: <20230210003147.1309376-1-jsnow@redhat.com> References: <20230210003147.1309376-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1675989202110100006 Content-Type: text/plain; charset="utf-8" At the moment, we look for just "python3" and "python", which is good enough almost all of the time. But ... if you are on a platform that uses an older Python by default and only offers a newer Python as an option, you'll have to specify --python=3D/usr/bin/foo every time. We can be kind and instead make a cursory attempt to locate a suitable Python binary ourselves, looking for the remaining well-known binaries. This configure loop will prefer, in order: 1. Whatever is specified in $PYTHON 2. python3 3. python 4. python3.11 down through python3.6 Notes: - Python virtual environment provides binaries for "python3", "python", and whichever version you used to create the venv, e.g. "python3.8". If configure is invoked from inside of a venv, this configure loop will not "break out" of that venv unless that venv is created using an explicitly non-suitable version of Python that we cannot use. - In the event that no suitable python is found, the first python found is the version used to generate the human-readable error message. - The error message isn't printed right away to allow later configuration code to pick up an explicitly configured python. Signed-off-by: John Snow Reviewed-by: Thomas Huth --- configure | 33 +++++++++++++++++++++++++-------- 1 file changed, 25 insertions(+), 8 deletions(-) diff --git a/configure b/configure index 64960c6000f..ea8c973d13b 100755 --- a/configure +++ b/configure @@ -592,20 +592,39 @@ esac =20 : ${make=3D${MAKE-make}} =20 -# We prefer python 3.x. A bare 'python' is traditionally -# python 2.x, but some distros have it as python 3.x, so -# we check that too + +check_py_version() { + # We require python >=3D 3.6. + # NB: a True python conditional creates a non-zero return code (Failur= e) + "$1" -c 'import sys; sys.exit(sys.version_info < (3,6))' +} + python=3D +first_python=3D explicit_python=3Dno -for binary in "${PYTHON-python3}" python +# A bare 'python' is traditionally python 2.x, but some distros +# have it as python 3.x, so check in both places. +for binary in "${PYTHON-python3}" python python3.{11..6} do if has "$binary" then python=3D$(command -v "$binary") - break + if test -z "$first_python"; then + first_python=3D$python + fi + if check_py_version "$python"; then + # This one is good. + first_python=3D + break + fi fi done =20 +# If first_python is set, we didn't find a suitable binary. +# Use this one for possible future error messages. +if test -n "$first_python"; then + python=3D"$first_python" +fi =20 # Check for ancillary tools used in testing genisoimage=3D @@ -1037,9 +1056,7 @@ then error_exit "GNU make ($make) not found" fi =20 -# Note that if the Python conditional here evaluates True we will exit -# with status 1 which is a shell 'false' value. -if ! $python -c 'import sys; sys.exit(sys.version_info < (3,6))'; then +if ! check_py_version "$python"; then error_exit "Cannot use '$python', Python >=3D 3.6 is required." \ "Use --python=3D/path/to/python to specify a supported Python." fi --=20 2.39.0