From nobody Tue Feb 10 15:45:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1675932638; cv=none; d=zohomail.com; s=zohoarc; b=hz+6cNlCPUhRtTDG6bE5nQgwonNha9wCmfJcKyU3pxMubXmzns7IqODunf4Ge7s5SmVVWf2aqvaQQUVu06eXYDls7Vk8szqYPZF4zcbRclIvcAwAP98I7it+to28hoWTJ3Mv/3Lfe2viBztu6cU5pmHcOSTqB8jZA82vuwrQrI4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1675932638; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3lqo0u/rwVHdjlNoO5aDn6nQFE9yTckKjy6CeUI2KWQ=; b=AiN43t61x0+a5BRo28Qb4LosplgDP40Ys0ZjQZePm12g27mtilUAyKggD4FjV0Un/iKjzQ/E6UIrFlVYbSMJevGJF6YqC0gO0MDizoa35G4wkev4e8SkiLc3pNJ1RaPKVzMOhnIBSDJMcggh48KlylYMw9DTxvJnKNMq2mmWRO4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1675932638558123.79062108430435; Thu, 9 Feb 2023 00:50:38 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pQ2dS-0006zr-8h; Thu, 09 Feb 2023 03:50:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQ2dE-0006y0-SW for qemu-devel@nongnu.org; Thu, 09 Feb 2023 03:50:18 -0500 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pQ2dC-0007i7-Ox for qemu-devel@nongnu.org; Thu, 09 Feb 2023 03:50:16 -0500 Received: by mail-wm1-x332.google.com with SMTP id u10so906809wmj.3 for ; Thu, 09 Feb 2023 00:50:13 -0800 (PST) Received: from bark.. (bzq-84-110-34-91.static-ip.bezeqint.net. [84.110.34.91]) by smtp.gmail.com with ESMTPSA id ay42-20020a05600c1e2a00b003dffe312925sm4169535wmb.15.2023.02.09.00.50.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 00:50:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3lqo0u/rwVHdjlNoO5aDn6nQFE9yTckKjy6CeUI2KWQ=; b=qPKSbr+Yo+Sdp4nX/xoRgFH8esMxpyu9fgnDbqv0LBYOr63E99HdzBWaSlWOBDsjST p/JnDOOenTFkRJq3+sBY6JMfVKoK6XEAZOJj0e/H2qKVd0lmcYVqlXPwoqEjyRnqL4si SoLzL9B0UmNbj2+vNLkLs/mTXur/uSjx8238OTe3uNANAtOWLNtOaX+xdOXCebv2/A/D vpbTNf+15bOwHVfFswhMcHKqOIQo3lRC93hHV5I5qCUBE+zt5HFP65E1TFm9i06kOae7 1NjTTJWA0W6weeYgCqFyuHsXd4eRVL9mF7o62UCBoeSppQ95NB4E02kRJAyxge6dhK1X TMIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3lqo0u/rwVHdjlNoO5aDn6nQFE9yTckKjy6CeUI2KWQ=; b=c8WVzgnF+LzcQALe+J3rRjC1cj5eIYmqYHtO5fufpi6uhAF5kxY36ifsBbXjaZceur p9RqYIgsMdj1qsqNnTNqobQCJMI7HdISfhYWTy1nTVgkmYbUdGjy8kU9FPomsXrGLRmF AtzJwmwYJzsJJTkVPkxoYnT/R0zn5H7tyk1j4ZrdcGT23bZ7fIDjMgGAm/FfDHvc+nPh EedmHzs+nR9Dq1TSsTHsWEO9nWILlNQEgxsz8FzJE+vs1JmothfKoyJHBC/Ns8htz+lY t17OLRr0n/bt0mY/kMqKfOmNQ/CzhPYnyTr94UAjJ+9/iZnZYR0b47yOtEq+yZVZZApE 9qYw== X-Gm-Message-State: AO0yUKWFzit9mQA5g0B3X229IHR+D/vXVKVNKEF/FUg69mMHmW24mO9+ RPc9nSk42gj83CQIV9ckEP0ffoFmESOQFJ89 X-Google-Smtp-Source: AK7set8wElEyiZaLSRg/z28L3AO/ffjBH4GQxnEdSd626kvgO211YvquPe58EFDVZdLl1DuHjzE1Zg== X-Received: by 2002:a05:600c:1714:b0:3dc:5a7c:f8ad with SMTP id c20-20020a05600c171400b003dc5a7cf8admr12230633wmn.21.1675932612628; Thu, 09 Feb 2023 00:50:12 -0800 (PST) From: Kfir Manor To: qemu-devel@nongnu.org, Konstantin Kostiuk , Michael Roth Cc: Yan Vugenfirer Subject: [PATCH 1/3] qga/win/installer: add VssOption to installer Date: Thu, 9 Feb 2023 10:50:02 +0200 Message-Id: <20230209085004.2745131-2-kfir@daynix.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230209085004.2745131-1-kfir@daynix.com> References: <20230209085004.2745131-1-kfir@daynix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=2a00:1450:4864:20::332; envelope-from=kfir@daynix.com; helo=mail-wm1-x332.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @daynix-com.20210112.gappssmtp.com) X-ZM-MESSAGEID: 1675932640937100003 Content-Type: text/plain; charset="utf-8" Adds registry value VssOption with value 1 to QEMU Guest Agent VSS Provider= service registry key Signed-off-by: Kfir Manor Reviewed-by: Konstantin Kostiuk --- qga/installer/qemu-ga.wxs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs index 51340f7ecc..f7f145aa05 100644 --- a/qga/installer/qemu-ga.wxs +++ b/qga/installer/qemu-ga.wxs @@ -121,6 +121,10 @@ + + + --=20 2.38.1 From nobody Tue Feb 10 15:45:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1675932676; cv=none; d=zohomail.com; s=zohoarc; b=FriOW5/v9YhoWeZTYF4JW4GQVNpPnTHiUmMz44GQ+Vdwj/FzJd5cR9ka/7BaU/mpH+0TlZ1//dbTPCKohf9RGKeLrta6O9bdBO2S1Biv4K4n2QVke3kqXoUnuyl+1TEEDXKMPK8ICG5lfIIBbbnSMEO0LS4MpTbSEara44wd1dw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1675932676; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VrYWLwdpop3m2KNW8eg+gDmihIX9bgIE0wBNkGgT27I=; b=Y6Qas0DTfYN99eFXg0Cuj0enh7RVMxS5CKOvBU1h4ztCdi8O3dDExKtx93TFY9ptYKQTVjGRy3GBMf4gZVQFwzVEFgQ6dNWaLIcGgg30JpaP5mQE/RCN+ytQbEGIYyerBj8FcqkskO5O20zeuToF6aPfugZBL8nbDnr6ZW3tp1E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1675932676292739.5565943347267; Thu, 9 Feb 2023 00:51:16 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pQ2dP-0006z2-6C; Thu, 09 Feb 2023 03:50:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQ2dF-0006y6-QH for qemu-devel@nongnu.org; Thu, 09 Feb 2023 03:50:22 -0500 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pQ2dD-0007iC-4p for qemu-devel@nongnu.org; Thu, 09 Feb 2023 03:50:17 -0500 Received: by mail-wm1-x32d.google.com with SMTP id m16-20020a05600c3b1000b003dc4050c94aso924923wms.4 for ; Thu, 09 Feb 2023 00:50:14 -0800 (PST) Received: from bark.. (bzq-84-110-34-91.static-ip.bezeqint.net. [84.110.34.91]) by smtp.gmail.com with ESMTPSA id ay42-20020a05600c1e2a00b003dffe312925sm4169535wmb.15.2023.02.09.00.50.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 00:50:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VrYWLwdpop3m2KNW8eg+gDmihIX9bgIE0wBNkGgT27I=; b=y+mzMTm6sfjkNPI1aAccx6Sq1RH8gJ+cFvJZGqjy2lHV8toYhXGDz6x4FQ7YFhtekh uE9oYrhBv/wvBI1TBEFAZJ8gARZ/gUx2BZ4tEfLXZedaoXlCdF0W00TdOlCvLHsIUNai 5bRZUX0guZaI98FMLfNmNPGvBMl4ZuAldwDNIjHW8Y5qpCJnsj4ZV00fwf4fHG7HsBjN o+ZpGqPHg2cGy/RRuW/4N0tWLcizVeFNuSD5mpEbDKWaJYNPGWaWn3A8muSfFsFOVMn5 ZBp5oFqiDqsOFeBdUw5MFsotTkZmm7uBypdh9Y0NPTj76KBnGjM/dvV/xNPyHPP+AgVF 6lJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VrYWLwdpop3m2KNW8eg+gDmihIX9bgIE0wBNkGgT27I=; b=JfKpmE6R6MJADN+lLxcAx0AQMNSGXbUOfPbGOlcsJoDApDXWHR5KfOtDJFuZLzb9Vw LL3aNcTKZSOP8cTTvSdOgQXQNa33zD8D9gg9uYW8gbnQ3qWx5My/MsQICN6uCSsJQOtH RMmPQ3T1yi3skCt5qWIYTATqSq0BivvW8qsIztKSVtM8aQMAxTY9V5616s8xyLsfy/fi 4ke3cQDaPn1FlhFgIiYG/YvcMQxvnxp1jN4nmx8cKSwq4DVhfskZ04MtN6ophS56Ewd0 a8ZEwE2YSZ7QZw6fsktV1AOTnb77I9vPhuCdyhDoEVZJj5BYSj/2JevXN+TzqWfvn/ao +6PQ== X-Gm-Message-State: AO0yUKWQNslI7rzyBwzVgcLjsQIQ0iEj0ldGFKlW4Z8+MIJyJKwhhiNw zIlszPQwdeAF/EFgD0eTcTNHWNKd9cd3BJtp X-Google-Smtp-Source: AK7set/8iRQFMNo7p1/rEv/Nh/xFGs8ZnpIpqD5Qh6j0t3OBXHb4WKNGkW/k1cybk+BjWq4DcKcnkA== X-Received: by 2002:a05:600c:45cf:b0:3df:9858:c03c with SMTP id s15-20020a05600c45cf00b003df9858c03cmr5235629wmo.17.1675932613572; Thu, 09 Feb 2023 00:50:13 -0800 (PST) From: Kfir Manor To: qemu-devel@nongnu.org, Konstantin Kostiuk , Michael Roth Cc: Yan Vugenfirer Subject: [PATCH 2/3] qga/win/vss: query VSS backup type Date: Thu, 9 Feb 2023 10:50:03 +0200 Message-Id: <20230209085004.2745131-3-kfir@daynix.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230209085004.2745131-1-kfir@daynix.com> References: <20230209085004.2745131-1-kfir@daynix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=2a00:1450:4864:20::32d; envelope-from=kfir@daynix.com; helo=mail-wm1-x32d.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @daynix-com.20210112.gappssmtp.com) X-ZM-MESSAGEID: 1675932678420100003 Content-Type: text/plain; charset="utf-8" Query VSS backup type number (DWORD) from QEMU Guest Agent VSS Provider reg= istry key registry value VssOption Translate the VSS backup type number (DWORD) into its VSS backup type (VSS_= BACKUP_TYPE) Returns the queried VSS backup type if the program encounters unexpected be= haviors or values return default VSS backup type VSS_BT_FULL instead Signed-off-by: Kfir Manor Reviewed-by: Konstantin Kostiuk --- qga/vss-win32/requester.cpp | 38 +++++++++++++++++++++++++++++++++++++ qga/vss-win32/vss-handles.h | 3 +++ 2 files changed, 41 insertions(+) diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp index b371affeab..27fdb9236b 100644 --- a/qga/vss-win32/requester.cpp +++ b/qga/vss-win32/requester.cpp @@ -23,6 +23,8 @@ /* Call QueryStatus every 10 ms while waiting for frozen event */ #define VSS_TIMEOUT_EVENT_MSEC 10 =20 +#define DEFAULT_VSS_BACKUP_TYPE VSS_BT_FULL + #define err_set(e, err, fmt, ...) = \ ((e)->error_setg_win32_wrapper((e)->errp, __FILE__, __LINE__, __func__= , \ err, fmt, ## __VA_ARGS__)) @@ -234,6 +236,42 @@ out: } } =20 +DWORD get_reg_dword_value(HKEY baseKey, LPCSTR subKey, LPCSTR valueName, + DWORD defaultData) +{ + DWORD regGetValueError; + DWORD dwordData; + DWORD dataSize =3D sizeof(DWORD); + + regGetValueError =3D RegGetValue(baseKey, subKey, valueName, RRF_RT_DW= ORD, + NULL, &dwordData, &dataSize); + if (regGetValueError !=3D ERROR_SUCCESS) { + return defaultData; + } + return dwordData; +} + +bool is_valid_vss_backup_type(VSS_BACKUP_TYPE vssBT) +{ + return (vssBT > VSS_BT_UNDEFINED && vssBT < VSS_BT_OTHER); +} + +VSS_BACKUP_TYPE get_vss_backup_type( + VSS_BACKUP_TYPE defaultVssBT =3D DEFAULT_VSS_BACKUP_TYPE) +{ + VSS_BACKUP_TYPE vssBackupType; + + vssBackupType =3D static_cast( + get_reg_dword_value(HKEY_LOCAL_MACHINE, + QGA_PROVIDER_REGISTRY_ADDR= ESS, + "VssOption", + defaultVssBT)); + if (!is_valid_vss_backup_type(vssBackupType)) { + return defaultVssBT; + } + return vssBackupType; +} + void requester_freeze(int *num_vols, void *mountpoints, ErrorSet *errset) { COMPointer pAsync; diff --git a/qga/vss-win32/vss-handles.h b/qga/vss-win32/vss-handles.h index 0f8a741ad2..1a7d842129 100644 --- a/qga/vss-win32/vss-handles.h +++ b/qga/vss-win32/vss-handles.h @@ -6,6 +6,9 @@ #define QGA_PROVIDER_NAME "QEMU Guest Agent VSS Provider" #define QGA_PROVIDER_LNAME L(QGA_PROVIDER_NAME) #define QGA_PROVIDER_VERSION L(QEMU_VERSION) +#define QGA_PROVIDER_REGISTRY_ADDRESS "SYSTEM\\CurrentControlSet"\ + "\\Services"\ + "\\" QGA_PROVIDER_NAME =20 #define EVENT_NAME_FROZEN "Global\\QGAVSSEvent-frozen" #define EVENT_NAME_THAW "Global\\QGAVSSEvent-thaw" --=20 2.38.1 From nobody Tue Feb 10 15:45:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1675932688; cv=none; d=zohomail.com; s=zohoarc; b=SUh0ialLtFG6xzQ+eQul+qvCEc8HYoVuynLJoorBt5MyhIqBLSKU42a64cUkVno0qCL5aQYKBvDdtW8Yao2pjIREys7uPiigH/NSOWaP8DFIATdyUwlvCTq8SuU16SwW3EDDLsiQ8pG69RQHU1SGCEtn5E2k71kutTnGu7nLhmI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1675932688; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=cOyK1xwkRtmIF35qit/32W4WDgM+0CBPhABx7HpojiY=; b=DHjTvjt08LgVierdQcX1tcLaN5tS8qChB9Fl8kUZP0uyZlOFrsnBr82cCMSfEfFhWqc+POUQhFhGWyQHUedYz7+GGFXRqLz7X/zT4HsP+kc9pk1Ch2d3gxb+08tym0TwV0rRjUw0Ii4Cero05scBHVKT3Rw1MAzo+ZD3eNS++Hc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1675932688310333.64843065850675; Thu, 9 Feb 2023 00:51:28 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pQ2dP-0006yu-4n; Thu, 09 Feb 2023 03:50:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQ2dH-0006yA-3w for qemu-devel@nongnu.org; Thu, 09 Feb 2023 03:50:24 -0500 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pQ2dE-0007iH-Mo for qemu-devel@nongnu.org; Thu, 09 Feb 2023 03:50:17 -0500 Received: by mail-wm1-x32e.google.com with SMTP id o36so923548wms.1 for ; Thu, 09 Feb 2023 00:50:15 -0800 (PST) Received: from bark.. (bzq-84-110-34-91.static-ip.bezeqint.net. [84.110.34.91]) by smtp.gmail.com with ESMTPSA id ay42-20020a05600c1e2a00b003dffe312925sm4169535wmb.15.2023.02.09.00.50.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 00:50:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cOyK1xwkRtmIF35qit/32W4WDgM+0CBPhABx7HpojiY=; b=P0ea7NRJC/KcW2mhn5pcuJL4IWuWkve7FVLSeOV5twBqEzADfN8XgO/dUH+N7E8bRQ Ha/XwsFsGRgHFmiQL504WaU1bqTdmuX5uAAc9VAOwGOLOnu9OK7itv+bVcdsAhuMRKFt d+bnUirz3GWQx0B12j2GHVDHTTaaWNrLjhnlnRLMbrZbQOY0WLgTRAMEIc95VNldih6U iBYDtVJyfHaZAeCnqYSifybEd3Z621DwQfTWe+AyIsJFyZ4DDI84CDA6uW6yzbrBUvt4 hPgxn9QS+D/y1w/4WGwc/lrvpd0Zdc5MXjKMUGlOF49vF6FUyFVJsNgv/SxpRQDoMWhd 5wEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cOyK1xwkRtmIF35qit/32W4WDgM+0CBPhABx7HpojiY=; b=dauRlxDGLtyMIG+6DBlAEvfb9nqV0Bo0xooWQ6HF1srKpTzNoWOdqd3pWiM9V4nOXI 41ro+aVQrZNOp0slHjN139VwqTsHiA2nk2fQaGaPNmC/c95GD978PxqnuzC4qiKNxttN 2STXqoD14OWpEw8aOogw0/leopaWuRZ+E311qJtoodwlY4Q8irS2W0fqWQqKP02mFADz K4E/oDKDlY/1JsVk/pSjaRFvAzVeja3vlEY36j0krQES27mPD5yv+LDeYFxgaCLH58+3 4x/ziCWvZrA8BxoAEeVTaDumv+b5XqHAby8uZG1XoTNA+X0vkFNDFwhmvyEbrpgBg/Hz NbgQ== X-Gm-Message-State: AO0yUKXXbWJ2HMmuN1nfSRs/MJd5hqhzxKBEkrVC562xfg29Dhi1DuqS sOKuBd6K7bW56M2m4upRwzYAUGq9kZc4sD+Q X-Google-Smtp-Source: AK7set/VE8XyOH28Eu3PMgFpWhQCOE/Fky7BVpV7mtIAiNYJyjKxX1dsN0OCgGPhqLbj/cfC50NBhw== X-Received: by 2002:a05:600c:1894:b0:3de:1d31:1048 with SMTP id x20-20020a05600c189400b003de1d311048mr9279827wmp.29.1675932614526; Thu, 09 Feb 2023 00:50:14 -0800 (PST) From: Kfir Manor To: qemu-devel@nongnu.org, Konstantin Kostiuk , Michael Roth Cc: Yan Vugenfirer Subject: [PATCH 3/3] qga/win/vss: requester_freeze changes Date: Thu, 9 Feb 2023 10:50:04 +0200 Message-Id: <20230209085004.2745131-4-kfir@daynix.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230209085004.2745131-1-kfir@daynix.com> References: <20230209085004.2745131-1-kfir@daynix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=2a00:1450:4864:20::32e; envelope-from=kfir@daynix.com; helo=mail-wm1-x32e.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @daynix-com.20210112.gappssmtp.com) X-ZM-MESSAGEID: 1675932688593100001 Content-Type: text/plain; charset="utf-8" Change requester_freeze so that the VSS backup type queried from the regist= ry Signed-off-by: Kfir Manor Reviewed-by: Konstantin Kostiuk --- qga/vss-win32/requester.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp index 27fdb9236b..163b3870b9 100644 --- a/qga/vss-win32/requester.cpp +++ b/qga/vss-win32/requester.cpp @@ -285,6 +285,7 @@ void requester_freeze(int *num_vols, void *mountpoints,= ErrorSet *errset) DWORD wait_status; int num_fixed_drives =3D 0, i; int num_mount_points =3D 0; + VSS_BACKUP_TYPE vss_bt =3D get_vss_backup_type(); =20 if (vss_ctx.pVssbc) { /* already frozen */ *num_vols =3D 0; @@ -332,7 +333,7 @@ void requester_freeze(int *num_vols, void *mountpoints,= ErrorSet *errset) goto out; } =20 - hr =3D vss_ctx.pVssbc->SetBackupState(true, true, VSS_BT_FULL, false); + hr =3D vss_ctx.pVssbc->SetBackupState(true, true, vss_bt, false); if (FAILED(hr)) { err_set(errset, hr, "failed to set backup state"); goto out; --=20 2.38.1