From nobody Tue Feb 10 17:31:28 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1675885787; cv=none; d=zohomail.com; s=zohoarc; b=Ap86+krFnKaARMsfz2u9ys0wk2c1f8KsG2qQZFr4b3Zj6SoJhFw4xjs8SMyGTyl3osPc6SlbhJrnlPvTGOQLJpUa0SB1zbN/D4Z0FQNG0T9u++nRx3wxCxEAXZu3NEKNnIM6ggVd0cvAL/+yId20rmAnBuFUSeA18aH1TFCHQx0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1675885787; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7KofdD8kQOCDl5fEESn1wqAGvGzSotgFEHsnJ+jaPQ8=; b=c5/W2l5aRFwg/GaUfJoDpeEWQYu2yhrwEnIgvhIDEYSIQHeaK1rZkJWI2uBBLiOMyrt88wu+VMFQ/nnhOYVCDzfJNeaPbZaq2PghRtCA/5yJMlh3ogNphsqwUkaH5c7UXkvAGanMcE/6EMft+mTjm5uOTHQs+Kr7TPz0OkaJPwc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1675885786993181.2580932401762; Wed, 8 Feb 2023 11:49:46 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPqRe-0000cc-TL; Wed, 08 Feb 2023 14:49:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPqRW-0000Ww-GC for qemu-devel@nongnu.org; Wed, 08 Feb 2023 14:49:22 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPqRU-0002AS-Le for qemu-devel@nongnu.org; Wed, 08 Feb 2023 14:49:22 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E529620494; Wed, 8 Feb 2023 19:49:18 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2DB9F13425; Wed, 8 Feb 2023 19:49:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id IGrDObz842OZIwAAMHmgww (envelope-from ); Wed, 08 Feb 2023 19:49:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1675885758; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7KofdD8kQOCDl5fEESn1wqAGvGzSotgFEHsnJ+jaPQ8=; b=1ttzVWJdXzurt3nNpFfIKAZLrOmtI7gtj6+MJ+jztN6l3oBUo8QRuGzye88MXgSgTrG+kd pO4lri2/5HhKKp3y4J0KiEw/uViCFps0GbJcIsPL47yHuVQVtxDXuEJ7i8mrjbUEwy4O1f JSC9yEanrwLh39KROTY0sa3z8uOa1OQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1675885758; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7KofdD8kQOCDl5fEESn1wqAGvGzSotgFEHsnJ+jaPQ8=; b=ILGOVEv/iPKYUVCGacw9OYZYYcnScjitzVgHCQg0fcex4iuX6CMePQTkHKFF5psmQjq0+4 V6RoRDxQWUqoxMAg== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Thomas Huth , Laurent Vivier , Paolo Bonzini Subject: [PATCH v2 07/12] tests/qtest: Skip unplug tests that use missing devices Date: Wed, 8 Feb 2023 16:46:55 -0300 Message-Id: <20230208194700.11035-8-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230208194700.11035-1-farosas@suse.de> References: <20230208194700.11035-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.220.29; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1675885788199100003 Content-Type: text/plain; charset="utf-8" Signed-off-by: Fabiano Rosas Reviewed-by: Thomas Huth --- tests/qtest/device-plug-test.c | 33 +++++++++++++++++++++++++++------ 1 file changed, 27 insertions(+), 6 deletions(-) diff --git a/tests/qtest/device-plug-test.c b/tests/qtest/device-plug-test.c index 4f92617335..01cecd6e20 100644 --- a/tests/qtest/device-plug-test.c +++ b/tests/qtest/device-plug-test.c @@ -68,6 +68,11 @@ static void test_pci_unplug_request(void) const char *arch =3D qtest_get_arch(); const char *machine_addition =3D ""; =20 + if (!qtest_has_device("virtio-mouse-pci")) { + g_test_skip("Device virtio-mouse-pci not available"); + return; + } + if (strcmp(arch, "i386") =3D=3D 0 || strcmp(arch, "x86_64") =3D=3D 0) { machine_addition =3D "-machine pc"; } @@ -82,11 +87,17 @@ static void test_pci_unplug_request(void) =20 static void test_q35_pci_unplug_request(void) { + QTestState *qtest; + + if (!qtest_has_device("virtio-mouse-pci")) { + g_test_skip("Device virtio-mouse-pci not available"); + return; + } =20 - QTestState *qtest =3D qtest_initf("-machine q35 " - "-device pcie-root-port,id=3Dp1 " - "-device pcie-pci-bridge,bus=3Dp1,id= =3Db1 " - "-device virtio-mouse-pci,bus=3Db1,id= =3Ddev0"); + qtest =3D qtest_initf("-machine q35 " + "-device pcie-root-port,id=3Dp1 " + "-device pcie-pci-bridge,bus=3Dp1,id=3Db1 " + "-device virtio-mouse-pci,bus=3Db1,id=3Ddev0"); =20 process_device_remove(qtest, "dev0"); =20 @@ -99,6 +110,11 @@ static void test_pci_unplug_json_request(void) const char *arch =3D qtest_get_arch(); const char *machine_addition =3D ""; =20 + if (!qtest_has_device("virtio-mouse-pci")) { + g_test_skip("Device virtio-mouse-pci not available"); + return; + } + if (strcmp(arch, "i386") =3D=3D 0 || strcmp(arch, "x86_64") =3D=3D 0) { machine_addition =3D "-machine pc"; } @@ -114,6 +130,7 @@ static void test_pci_unplug_json_request(void) =20 static void test_q35_pci_unplug_json_request(void) { + QTestState *qtest; const char *port =3D "-device \"{'driver': 'pcie-root-port', " "'id': 'p1'}\""; =20 @@ -125,8 +142,12 @@ static void test_q35_pci_unplug_json_request(void) "'bus': 'b1', " "'id': 'dev0'}\""; =20 - QTestState *qtest =3D qtest_initf("-machine q35 %s %s %s", - port, bridge, device); + if (!qtest_has_device("virtio-mouse-pci")) { + g_test_skip("Device virtio-mouse-pci not available"); + return; + } + + qtest =3D qtest_initf("-machine q35 %s %s %s", port, bridge, device); =20 process_device_remove(qtest, "dev0"); =20 --=20 2.35.3