From nobody Mon Feb 9 20:12:27 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1675731718; cv=none; d=zohomail.com; s=zohoarc; b=CRtJ/qC8ent4fVjpfF22SoHdnlvQiHIquQe1nBENaGdOp9zDD27iH+wT1LqxfCD6/mSDSixbWev62u6HDaBsz4NVCVjWuqWrQyGQS688uWzR+5Vh+4PaQBvYSiROr2o4Jg6g89PnqH05pfrRMvZ4CEb5Nekq7vALxpz0m8KdLEg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1675731718; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=S8YJoHwNGFrow4yvZqYD9fJCjU9peOTc1LZupkn3uiI=; b=bYuFF7axAaWCm8H162YHqlqekJjLBdoyYWfMexWGT6TghFNPGIxDlwYCITNzg063C7wJWwzFwA7MNyUXymOzHFcP0QcREF7YsfBGAADCiqHP124V67ysk5QZZURGZJA1Kof8su5hrZAGEOJmUnbIMmNyvqY86qzWZ4aApskwfTM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1675731718398363.6668231300521; Mon, 6 Feb 2023 17:01:58 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPCJz-00079T-Ef; Mon, 06 Feb 2023 19:58:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPCJx-0006s2-8V for qemu-devel@nongnu.org; Mon, 06 Feb 2023 19:58:53 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPCJv-0003uS-Jk for qemu-devel@nongnu.org; Mon, 06 Feb 2023 19:58:52 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-70-S-TouU7AOKmBAmOzrg8efA-1; Mon, 06 Feb 2023 19:58:46 -0500 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 10DC41871D9A; Tue, 7 Feb 2023 00:58:46 +0000 (UTC) Received: from secure.mitica (unknown [10.39.192.29]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0EE12492C3C; Tue, 7 Feb 2023 00:58:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675731530; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S8YJoHwNGFrow4yvZqYD9fJCjU9peOTc1LZupkn3uiI=; b=iucYo/NMEweBafI2QK6Ny/sSoFTApuIq4a7elPAMfMIFLTnr8tObmHLu1X3XUHQFtmRJrg MNOsJyW2TZiHFTMLKmeZnqQ4TsTALtNWUk41J7ugUMAQ+pHt3FERmhIcGa6P44Kiyvtg4Q zdV8Q0ox5Qajxo6ebiVYsqL6tn1ssLE= X-MC-Unique: S-TouU7AOKmBAmOzrg8efA-1 From: Juan Quintela To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Stefan Berger , Stefan Hajnoczi , Halil Pasic , John Snow , David Hildenbrand , Fam Zheng , Thomas Huth , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Laurent Vivier , Vladimir Sementsov-Ogievskiy , qemu-s390x@nongnu.org, Christian Borntraeger , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Michael S. Tsirkin" , Juan Quintela , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Coiby Xu , Ilya Leoshkevich , Eduardo Habkost , Yanan Wang , Richard Henderson , Markus Armbruster , Paolo Bonzini , Alex Williamson , Eric Blake , Eric Farman , Peter Xu , Leonardo Bras Subject: [PULL 20/30] migration: Show downtime during postcopy phase Date: Tue, 7 Feb 2023 01:56:40 +0100 Message-Id: <20230207005650.1810-21-quintela@redhat.com> In-Reply-To: <20230207005650.1810-1-quintela@redhat.com> References: <20230207005650.1810-1-quintela@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1675731720022100003 Content-Type: text/plain; charset="utf-8" From: Peter Xu The downtime should be displayed during postcopy phase because the switchover phase is done. OTOH it's weird to show "expected downtime" which can confuse what does that mean if the switchover has already happened anyway. This is a slight ABI change on QMP, but I assume it shouldn't affect anyone. Reviewed-by: Leonardo Bras Reviewed-by: Juan Quintela Signed-off-by: Peter Xu Signed-off-by: Juan Quintela --- migration/migration.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index f321e419c7..4f4d798d3e 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -1051,20 +1051,30 @@ bool migration_is_running(int state) } } =20 +static bool migrate_show_downtime(MigrationState *s) +{ + return (s->state =3D=3D MIGRATION_STATUS_COMPLETED) || migration_in_po= stcopy(); +} + static void populate_time_info(MigrationInfo *info, MigrationState *s) { info->has_status =3D true; info->has_setup_time =3D true; info->setup_time =3D s->setup_time; + if (s->state =3D=3D MIGRATION_STATUS_COMPLETED) { info->has_total_time =3D true; info->total_time =3D s->total_time; - info->has_downtime =3D true; - info->downtime =3D s->downtime; } else { info->has_total_time =3D true; info->total_time =3D qemu_clock_get_ms(QEMU_CLOCK_REALTIME) - s->start_time; + } + + if (migrate_show_downtime(s)) { + info->has_downtime =3D true; + info->downtime =3D s->downtime; + } else { info->has_expected_downtime =3D true; info->expected_downtime =3D s->expected_downtime; } --=20 2.39.1