From nobody Tue Feb 10 19:49:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1674004335; cv=none; d=zohomail.com; s=zohoarc; b=W4IDlircQeF/ga+cIe09y0DI7zAlb9ZBEaV27dFpvMaVApuXVqf9bKY+krkNacPlMB449+4uhU9ehwm7/khAWtepdItkeoDGNZjPYeCy0rE7fWCaXWIMnk1RcGZNIfU0QUvf4a5sBcasgC3xgDFbjXqI9vW51L3MrviDN3Mcuu4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1674004335; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gExyabd9pGuUtJyQvwd0z6FyfSDRDLkdZQb2qbC5yco=; b=kdG8lH5Eg9FiZ+G84wmKoKUq1iIsMdjkchFqUJvBiLdJbaRRlnbeycBbSBGLH07GS+zvg6r97InFpm9hVfQCGkKkdZW99fD9FEXI7x4HCA7rimkqORY6qRWeHPtrU3RRiu4BsVLy347YYdZP7/RJ6wCCOf4uyMJmlJNaS7dx4xA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 167400433598893.31347585130322; Tue, 17 Jan 2023 17:12:15 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHwzN-00024Z-OQ; Tue, 17 Jan 2023 20:11:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHwzM-00023p-5s for qemu-devel@nongnu.org; Tue, 17 Jan 2023 20:11:40 -0500 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pHwzK-0002FC-BA for qemu-devel@nongnu.org; Tue, 17 Jan 2023 20:11:39 -0500 Received: by mail-pj1-x1029.google.com with SMTP id y3-20020a17090a390300b00229add7bb36so653027pjb.4 for ; Tue, 17 Jan 2023 17:11:37 -0800 (PST) Received: from stoup.. (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id s7-20020a170902988700b0017ec1b1bf9fsm21660259plp.217.2023.01.17.17.11.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jan 2023 17:11:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gExyabd9pGuUtJyQvwd0z6FyfSDRDLkdZQb2qbC5yco=; b=xOeBK20givcp1kwuiZRvPzEWTDCETB5hhwsJntKrSPV+NF3LEHNArMoAzgj6UzWmVu 9hskHrQ7iTKnqw1Zu5Mswj1U4AkQBkKJxQobD0yFizVCF6n3Vy1rOHDscGhGd0ad2M0P R0kktujnZ6GCB5qxKU7poWcPKyiRYIpVCPmYEmYZzixpnjAFGTorD5Hzq9DZWpi/Onud nIi0ElXTpkFSuxbEfn8oO/Vr70ZcHAgXXF8GvC9pqJKjChx5FUfnhmEtKNunaiQNmt+L UmaVazj8OVxb5nIhbKa+YEgOi4HW1mBuUxKLUfIKMnm3ti1PH0Haz9L7c1nTov7ImtGv Ub9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gExyabd9pGuUtJyQvwd0z6FyfSDRDLkdZQb2qbC5yco=; b=3oFCGfeXONO1qxPp2xKVqjVlxNPMzdhrQH8hjYKfpF1QRI/8luhZowqH0j/tWaO5CE CGMtatsYzd+VYMlTedGBMCpGsWlddDdleLuIv+hyR5ro+kQpdfGx2MhldUf2OBU/heQN bp0jYp+Jcu7Gm4xsmF1qrcxVxSxH3jL2vpTjKgYchvEKJSyRJHXkVtLiQk+9Hj9yCcWj NbeLx9ZqF+sXH3tHNIbUJIYJuNVj1RtQR+kVYmHmygIqXSb83uOlIK5hEQ1zpd+/dC9k EmCBgC5jrd/fxV9USqwBEIrNE7nppNKPlj1IPlrWuhM6EFtfqn94YDHx8En46liwa4uQ l6HQ== X-Gm-Message-State: AFqh2kp8twRsuOA1cTkX6kdkV6ohDseKo5MLm4h3NHfE7E8F5tdur9jN toFmCk8l4igCXj9sueRqJK00aHA8e6EtRzGS X-Google-Smtp-Source: AMrXdXsSBbHOcXuR/1l3LMauAuRMjZ/1ZbtNWxq5uQNxnj+9q7bdrJrP5JQsBgyAhpjbgELfctErPA== X-Received: by 2002:a17:903:2289:b0:194:9290:fa6f with SMTP id b9-20020a170903228900b001949290fa6fmr7831031plh.25.1674004296913; Tue, 17 Jan 2023 17:11:36 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: git@xen0n.name Subject: [PATCH v2 07/10] tcg/loongarch64: Improve setcond expansion Date: Tue, 17 Jan 2023 15:11:20 -1000 Message-Id: <20230118011123.392823-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230118011123.392823-1-richard.henderson@linaro.org> References: <20230118011123.392823-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1029; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1029.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1674004337736100003 Content-Type: text/plain; charset="utf-8" Split out a helper function, tcg_out_setcond_int, which does not always produce the complete boolean result, but returns a set of flags to do so. Accept all int32_t as constant input, so that LE/GT can adjust the constant to LT. Signed-off-by: Richard Henderson Reviewed-by: WANG Xuerui --- tcg/loongarch64/tcg-target.c.inc | 165 +++++++++++++++++++++---------- 1 file changed, 115 insertions(+), 50 deletions(-) diff --git a/tcg/loongarch64/tcg-target.c.inc b/tcg/loongarch64/tcg-target.= c.inc index 8cc6c5eec2..ccc1c0f392 100644 --- a/tcg/loongarch64/tcg-target.c.inc +++ b/tcg/loongarch64/tcg-target.c.inc @@ -469,64 +469,131 @@ static void tcg_out_clzctz(TCGContext *s, LoongArchI= nsn opc, tcg_out_opc_or(s, a0, TCG_REG_TMP0, a0); } =20 -static void tcg_out_setcond(TCGContext *s, TCGCond cond, TCGReg ret, - TCGReg arg1, TCGReg arg2, bool c2) -{ - TCGReg tmp; +#define SETCOND_INV TCG_TARGET_NB_REGS +#define SETCOND_NEZ (SETCOND_INV << 1) +#define SETCOND_FLAGS (SETCOND_INV | SETCOND_NEZ) =20 - if (c2) { - tcg_debug_assert(arg2 =3D=3D 0); +static int tcg_out_setcond_int(TCGContext *s, TCGCond cond, TCGReg ret, + TCGReg arg1, tcg_target_long arg2, bool c2) +{ + int flags =3D 0; + + switch (cond) { + case TCG_COND_EQ: /* -> NE */ + case TCG_COND_GE: /* -> LT */ + case TCG_COND_GEU: /* -> LTU */ + case TCG_COND_GT: /* -> LE */ + case TCG_COND_GTU: /* -> LEU */ + cond =3D tcg_invert_cond(cond); + flags ^=3D SETCOND_INV; + break; + default: + break; } =20 switch (cond) { - case TCG_COND_EQ: - if (c2) { - tmp =3D arg1; - } else { - tcg_out_opc_sub_d(s, ret, arg1, arg2); - tmp =3D ret; - } - tcg_out_opc_sltui(s, ret, tmp, 1); - break; - case TCG_COND_NE: - if (c2) { - tmp =3D arg1; - } else { - tcg_out_opc_sub_d(s, ret, arg1, arg2); - tmp =3D ret; - } - tcg_out_opc_sltu(s, ret, TCG_REG_ZERO, tmp); - break; - case TCG_COND_LT: - tcg_out_opc_slt(s, ret, arg1, arg2); - break; - case TCG_COND_GE: - tcg_out_opc_slt(s, ret, arg1, arg2); - tcg_out_opc_xori(s, ret, ret, 1); - break; case TCG_COND_LE: - tcg_out_setcond(s, TCG_COND_GE, ret, arg2, arg1, false); - break; - case TCG_COND_GT: - tcg_out_setcond(s, TCG_COND_LT, ret, arg2, arg1, false); - break; - case TCG_COND_LTU: - tcg_out_opc_sltu(s, ret, arg1, arg2); - break; - case TCG_COND_GEU: - tcg_out_opc_sltu(s, ret, arg1, arg2); - tcg_out_opc_xori(s, ret, ret, 1); - break; case TCG_COND_LEU: - tcg_out_setcond(s, TCG_COND_GEU, ret, arg2, arg1, false); + /* + * If we have a constant input, the most efficient way to implement + * LE is by adding 1 and using LT. Watch out for wrap around for = LEU. + * We don't need to care for this for LE because the constant input + * is still constrained to int32_t, and INT32_MAX+1 is representab= le + * in the 64-bit temporary register. + */ + if (c2) { + if (cond =3D=3D TCG_COND_LEU) { + /* unsigned <=3D -1 is true */ + if (arg2 =3D=3D -1) { + tcg_out_movi(s, TCG_TYPE_REG, ret, !(flags & SETCOND_I= NV)); + return ret; + } + cond =3D TCG_COND_LTU; + } else { + cond =3D TCG_COND_LT; + } + arg2 +=3D 1; + } else { + TCGReg tmp =3D arg2; + arg2 =3D arg1; + arg1 =3D tmp; + cond =3D tcg_swap_cond(cond); /* LE -> GE */ + cond =3D tcg_invert_cond(cond); /* GE -> LT */ + flags ^=3D SETCOND_INV; + } break; - case TCG_COND_GTU: - tcg_out_setcond(s, TCG_COND_LTU, ret, arg2, arg1, false); + default: break; + } + + switch (cond) { + case TCG_COND_NE: + flags |=3D SETCOND_NEZ; + if (!c2) { + tcg_out_opc_xor(s, ret, arg1, arg2); + } else if (arg2 =3D=3D 0) { + ret =3D arg1; + } else if (arg2 >=3D 0 && arg2 <=3D 0xfff) { + tcg_out_opc_xori(s, ret, arg1, arg2); + } else { + tcg_out_addi(s, TCG_TYPE_REG, ret, arg1, -arg2); + } + break; + + case TCG_COND_LT: + case TCG_COND_LTU: + if (c2) { + if (arg2 >=3D -0x800 && arg2 <=3D 0x7ff) { + if (cond =3D=3D TCG_COND_LT) { + tcg_out_opc_slti(s, ret, arg1, arg2); + } else { + tcg_out_opc_sltui(s, ret, arg1, arg2); + } + break; + } + tcg_out_movi(s, TCG_TYPE_REG, TCG_REG_TMP0, arg2); + arg2 =3D TCG_REG_TMP0; + } + if (cond =3D=3D TCG_COND_LT) { + tcg_out_opc_slt(s, ret, arg1, arg2); + } else { + tcg_out_opc_sltu(s, ret, arg1, arg2); + } + break; + default: g_assert_not_reached(); break; } + + return ret | flags; +} + +static void tcg_out_setcond(TCGContext *s, TCGCond cond, TCGReg ret, + TCGReg arg1, tcg_target_long arg2, bool c2) +{ + int tmpflags =3D tcg_out_setcond_int(s, cond, ret, arg1, arg2, c2); + + if (tmpflags !=3D ret) { + TCGReg tmp =3D tmpflags & ~SETCOND_FLAGS; + + switch (tmpflags & SETCOND_FLAGS) { + case SETCOND_INV: + /* Intermediate result is boolean: simply invert. */ + tcg_out_opc_xori(s, ret, tmp, 1); + break; + case SETCOND_NEZ: + /* Intermediate result is zero/non-zero: test !=3D 0. */ + tcg_out_opc_sltu(s, ret, TCG_REG_ZERO, tmp); + break; + case SETCOND_NEZ | SETCOND_INV: + /* Intermediate result is zero/non-zero: test =3D=3D 0. */ + tcg_out_opc_sltui(s, ret, tmp, 1); + break; + default: + g_assert_not_reached(); + } + } } =20 /* @@ -1646,18 +1713,16 @@ static TCGConstraintSetIndex tcg_target_op_def(TCGO= pcode op) case INDEX_op_ctz_i64: return C_O1_I2(r, r, rW); =20 - case INDEX_op_setcond_i32: - case INDEX_op_setcond_i64: - return C_O1_I2(r, r, rZ); - case INDEX_op_deposit_i32: case INDEX_op_deposit_i64: /* Must deposit into the same register as input */ return C_O1_I2(r, 0, rZ); =20 case INDEX_op_sub_i32: + case INDEX_op_setcond_i32: return C_O1_I2(r, rZ, ri); case INDEX_op_sub_i64: + case INDEX_op_setcond_i64: return C_O1_I2(r, rZ, rJ); =20 case INDEX_op_mul_i32: --=20 2.34.1