From nobody Wed Apr 16 23:23:31 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1673908689; cv=none; d=zohomail.com; s=zohoarc; b=iVLuWxTiO/L3RB9qDYGZYhrUyEmt4C2Ov3aPBE1AsBwOJqqYRhHQvfpIV6Fsx3mO6DvhU7W503m8mzAp8AJrOsQ7VpReuW9NsCu74HHr7LpZopdw0yU/yK/RIdL1waQVGOX1fdSA5sZfjxJV0I4IdHFDO81l64Kia/e43400s2A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1673908689; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=sVoQ+dZBxCCrOAQkIYFBP0Uz5/oWgbT60mps7v3rv5w=; b=kJA7iczEH40A+S3BrU4NLppiYtSdpwNWu8Ry0MBpGNduI7xAEkY6wkvRww9a0YpJsaENqn4pITszj/bcd/18u2Hh3vG8eISbdyH3cgKNcmUU2X9Kf61LE063kT8W1lXStQ5N/RisbMBxMd/B0rfvQYnYcB9frfgmvAU+SzVmdLA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1673908689134451.36545760692; Mon, 16 Jan 2023 14:38:09 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHY5v-0000Wb-Oe; Mon, 16 Jan 2023 17:36:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHY5t-0000PQ-87 for qemu-devel@nongnu.org; Mon, 16 Jan 2023 17:36:45 -0500 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pHY5r-0001MF-L1 for qemu-devel@nongnu.org; Mon, 16 Jan 2023 17:36:45 -0500 Received: by mail-pl1-x629.google.com with SMTP id k12so9586595plk.0 for ; Mon, 16 Jan 2023 14:36:43 -0800 (PST) Received: from stoup.. (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id n3-20020a170903110300b00189f2fdbdd0sm19742492plh.234.2023.01.16.14.36.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 14:36:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sVoQ+dZBxCCrOAQkIYFBP0Uz5/oWgbT60mps7v3rv5w=; b=kjQPhh7y6UmxHQT083q4jKpXzCOGnRVkRlBOiQfevp+dtKPpMRseWca1yXPQ9ZMx64 SuYh4/KLFO1mnSrjdjaxsKZSNDXRKrQk5qdfyqIz9kJf8jf3czzLieFL0pOmYAMtZzHq mE3pdJLo9z7dOpAoNGs9k3+GsE1Ts0ZLh1hxNGL/BLn9MzqrZZuoNPV44dxOLxdNR6di E4YE7Dt013/1JyU04xjOSmTvHxFn4rX04waA1K2cQ2KkzaMmg6e0HKcwCyKyTX5NDyGk lyH13LW0g22dcZk332w8tD/SPRFXqEZj7u9SVOMmkGevc3f1F+MS6XbJmdaITnBTHvr5 N94A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sVoQ+dZBxCCrOAQkIYFBP0Uz5/oWgbT60mps7v3rv5w=; b=o574qI2VOXx3Nmi1e+HExI308A5VRMqAoc/3qwWs9HN0M7gtv/M075anxePo7jfCHN ob65yXePOKXGFk0js7Fs7UMjIMHV9jEbrfEO1JZYu81w7kjbfnoFkmoFMu7aiqzzvtGE ulglzcoi6wr+AdbbbRKxwqzHHXrGFji+5twdBf1q8pxKDtNcwxdzUmRo+XllZcnQ4nA3 /0sA/IRKpwhB4tmCJzXzSSJpapl/sHD5WvzW/8Cn+S6SjYGUvsMF0r7l0SAG+8++2yIb fpaUKnvuop+YvfK8b3XMGYJWgDP3QOgmLIkvg6Uy7LMJ2Alr6qsGSz16BFoONWgeO0ZV OkSQ== X-Gm-Message-State: AFqh2krHjIaY+vqyC+bCbUhdBAj+HOv5mV1hB6FPV4rcDptZMk332byb FdWc/3j5qOjanahxDwJHQ+BYyqkXNtQO/jox X-Google-Smtp-Source: AMrXdXutWcFq9uL5iHxqxYiGQUf3tYGyYfG6dxDiQivgkbE2jygMwjHwNsHuSvVhEJoOE5xqejQb8g== X-Received: by 2002:a17:902:d50e:b0:191:4378:ec06 with SMTP id b14-20020a170902d50e00b001914378ec06mr30669211plg.61.1673908602048; Mon, 16 Jan 2023 14:36:42 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Ilya Leoshkevich , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PULL 1/5] linux-user: Clean up when exiting due to a signal Date: Mon, 16 Jan 2023 12:36:33 -1000 Message-Id: <20230116223637.3512814-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230116223637.3512814-1-richard.henderson@linaro.org> References: <20230116223637.3512814-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::629; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x629.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1673908690919100003 From: Ilya Leoshkevich When exiting due to an exit() syscall, qemu-user calls preexit_cleanup(), but this is currently not the case when exiting due to a signal. This leads to various buffers not being flushed (e.g., for gprof, for gcov, and for the upcoming perf support). Add the missing call. Signed-off-by: Ilya Leoshkevich Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Richard Henderson Message-Id: <20230112152013.125680-2-iii@linux.ibm.com> Signed-off-by: Richard Henderson --- linux-user/signal.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 61c6fa3fcf..098f3a787d 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -695,7 +695,7 @@ void cpu_loop_exit_sigbus(CPUState *cpu, target_ulong a= ddr, =20 /* abort execution with signal */ static G_NORETURN -void dump_core_and_abort(int target_sig) +void dump_core_and_abort(CPUArchState *cpu_env, int target_sig) { CPUState *cpu =3D thread_cpu; CPUArchState *env =3D cpu->env_ptr; @@ -724,6 +724,8 @@ void dump_core_and_abort(int target_sig) target_sig, strsignal(host_sig), "core dumped" ); } =20 + preexit_cleanup(cpu_env, 128 + target_sig); + /* The proper exit code for dying from an uncaught signal is * -. The kernel doesn't allow exit() or _exit() to pass * a negative value. To get the proper exit code we need to @@ -1058,12 +1060,12 @@ static void handle_pending_signal(CPUArchState *cpu= _env, int sig, sig !=3D TARGET_SIGURG && sig !=3D TARGET_SIGWINCH && sig !=3D TARGET_SIGCONT) { - dump_core_and_abort(sig); + dump_core_and_abort(cpu_env, sig); } } else if (handler =3D=3D TARGET_SIG_IGN) { /* ignore sig */ } else if (handler =3D=3D TARGET_SIG_ERR) { - dump_core_and_abort(sig); + dump_core_and_abort(cpu_env, sig); } else { /* compute the blocked signals during the handler execution */ sigset_t *blocked_set; --=20 2.34.1