From nobody Mon Feb 9 20:30:47 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1673626983; cv=none; d=zohomail.com; s=zohoarc; b=YeE0C3Kjx+etYkgOWHwDDaW4pg2gMFAsauUmP6/9NwqTj+3la+zNj7Ght/7IKkj4O4ZY7JvpQ5W28VWBJ32kI5Sef3jWZcjP+QHIAG7UNTF4wjy61u84I32CEDiR82DWY3KmP8PKLwUDNGlGUS6RypG//Btt4LHmNjdle/8i0gk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1673626983; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XPiLURC+pasBUtX+TWccqsO1skJM4eGW3ibva3hIUKc=; b=S+neMg42jyup28mOfDBrLVcQ4Bx937tfa9SipbHPK7l82KKshpqYxE9hH63XW/uPy5G+cfOV3M2whxcEM0VsRYT+7osmv3mvP9ULOnIimcvCgotzts59KKSEifjoF3fuuE2E5WOxvO0I71VrtoEdUAsv14adBy5Ck4HR3YSmwDI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 167362698361111.53452996919998; Fri, 13 Jan 2023 08:23:03 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-528-GknuiiboMv2F1h-L-6XLUw-1; Fri, 13 Jan 2023 11:22:10 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6DFF480D0F5; Fri, 13 Jan 2023 16:22:05 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id C42D64078905; Fri, 13 Jan 2023 16:22:03 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 8D8471947059; Fri, 13 Jan 2023 16:22:03 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 37AC81946A78 for ; Fri, 13 Jan 2023 16:22:02 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 1BDD040C2005; Fri, 13 Jan 2023 16:22:02 +0000 (UTC) Received: from virtlab420.virt.lab.eng.bos.redhat.com (virtlab420.virt.lab.eng.bos.redhat.com [10.19.152.148]) by smtp.corp.redhat.com (Postfix) with ESMTP id ABCB940C2004; Fri, 13 Jan 2023 16:22:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673626982; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=XPiLURC+pasBUtX+TWccqsO1skJM4eGW3ibva3hIUKc=; b=Qjnk8DGDndiLYlmdxeD4Fu56pEM8eS3pcV0NEuu5bFROPgdJLOj+tgD0b7vOsmdhanBCvA 4q174CMqoppUYwAlC41j25wF/aARC6CYnbHl67G6zF91Yp4QWJWlKtD4XpRgTq8Pfw3jLD yPewI4JANjaZploD2fPsTy8azPZFjYM= X-MC-Unique: GknuiiboMv2F1h-L-6XLUw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 1/9] audio: don't check qemu_add_vm_change_state_handler failure Date: Fri, 13 Jan 2023 11:21:52 -0500 Message-Id: <20230113162200.3010804-2-berrange@redhat.com> In-Reply-To: <20230113162200.3010804-1-berrange@redhat.com> References: <20230113162200.3010804-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Alexander Bulekov , libvir-list@redhat.com, Christian Schoenebeck , Qiuhao Li , Darren Kenny , Bandan Das , Gerd Hoffmann , Stefan Hajnoczi , Paolo Bonzini Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1673626985535100003 This function cannot fail since g_malloc0 aborts on OOM. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Volker R=C3=BCmelin --- audio/audio.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index d849a94a81..7b4b957945 100644 --- a/audio/audio.c +++ b/audio/audio.c @@ -1712,7 +1712,6 @@ static AudioState *audio_init(Audiodev *dev, const ch= ar *name) size_t i; int done =3D 0; const char *drvname =3D NULL; - VMChangeStateEntry *e; AudioState *s; struct audio_driver *driver; /* silence gcc warning about uninitialized variable */ @@ -1830,11 +1829,7 @@ static AudioState *audio_init(Audiodev *dev, const c= har *name) s->period_ticks =3D dev->timer_period * (int64_t)SCALE_US; } =20 - e =3D qemu_add_vm_change_state_handler (audio_vm_change_state_handler,= s); - if (!e) { - dolog ("warning: Could not register change state handler\n" - "(Audio can continue looping even after stopping the VM)\n"= ); - } + qemu_add_vm_change_state_handler (audio_vm_change_state_handler, s); =20 QTAILQ_INSERT_TAIL(&audio_states, s, list); QLIST_INIT (&s->card_head); --=20 2.38.1