From nobody Wed Feb 11 06:15:33 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1672937160; cv=none; d=zohomail.com; s=zohoarc; b=au6dGoA4/WmXPnC5eLqXPIBojPq0GBX1rYCnRY0vebcySutPG5yWueHty2+dcdAC4aImn0gkBUk5OkBYNB/Z09+rOjLQ33UNnCvZUiVNeDv+o8sf+rqVkoo7zo+Uw0TeElRtoxrs1bIRuiOkU1RIo/Fw9T/3YcoQtHZua2hIZAw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1672937160; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8lMJgjm1DvK1wLgcUqU/S1XJA9L6jfYX3fmzxSNKcYA=; b=TwJb8SzOaJEA7ay1k3Fl0iGgPhCEfDkkJ7w/zQKJ+8H7GXM+byWuBUdc/OVMC/6HVvxna3Ilc07HZqyX7p7f9mQaPI64lLZg2Xr5VVJyyqoAZcW2/xJUvQh7BTwMpgiJbIntRJQqM2X6Xr/ts+UKHRgipxqMBK9L2FJwQ6ZavI0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1672937160536237.0728149759501; Thu, 5 Jan 2023 08:46:00 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pDTLR-0007Tl-TX; Thu, 05 Jan 2023 11:43:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDTLO-0007Kq-OB for qemu-devel@nongnu.org; Thu, 05 Jan 2023 11:43:55 -0500 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pDTL0-00072b-8r for qemu-devel@nongnu.org; Thu, 05 Jan 2023 11:43:54 -0500 Received: by mail-wr1-x429.google.com with SMTP id co23so36730234wrb.4 for ; Thu, 05 Jan 2023 08:43:29 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id h10-20020a5d4fca000000b00281eab50380sm31319287wrw.117.2023.01.05.08.43.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 08:43:27 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 7D4F01FFC8; Thu, 5 Jan 2023 16:43:21 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8lMJgjm1DvK1wLgcUqU/S1XJA9L6jfYX3fmzxSNKcYA=; b=K9aYT+Ech1VA7Vzll9S5stHUFVnUBqi2CxjynyXAMpotngTRqLGLRBm+/BcaqOXz+d lGjihXtYfLk1uYVy6PymNIQ6yW3puCRhvjNI0xuIaH+xrDRG91haacTImhLwnlLc470T SqdSQPRtj+hDsA2H3d3iSJ/odVGf6wE25vJslv4qta9zV4OMP7LFaey6JtdGBfJX+ty/ 2Z/aeoXSog5TeTWPUANCAifaPNCD9IrStFGcbd4dR0efRKJLTdnLZZrHjRtZxSwaUFdJ klG144UdA8P0UFX5p6vB/juBM+A6Jb+dcxH3PI2ouimoZ9/ANupnePX8VbEkFb747sgo DdRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8lMJgjm1DvK1wLgcUqU/S1XJA9L6jfYX3fmzxSNKcYA=; b=7skLcenDTbU8aQMeC/QvULm7V9CrZ5ghI1r7cgjYXy1y9Y/NoyTxa5rSiZ/KVqHJlX 2YSiPutJdhkZK3g8IpRWKljOlhZg7nylyXYATM9+LDUWc4CxAb+seEKvgS3vpoIK1Tba n6XZGuk4OpsnPUvTTXKMF5Ul2c7RZJ0NOyO8FtM4matgz7ehhaCnFyQmq6M3tz+mh0Nv OHoVweELRHEUI7QQBivt+Qn9T7/bsFc1p7SQHO/vmqaut7Be8j1HC5CGC+JnGekZSVBi SdfJbQUK2Hjgy3Sz7GW4RaXqCQGwWbE4QafVYq1Bufg6wkE7epUTXf1C667W1Iu1oWu0 3teg== X-Gm-Message-State: AFqh2kobP68dVdEo8WafcCJyshAYod10OTS7NNqpA5kqfF1Km5EpcfCE DHuSFTHtWh8cv94lc/SMSaQAKQ== X-Google-Smtp-Source: AMrXdXtBpRGasXG645y3Si0iD+NiZ5BM3DOkgfDeT3h2du/8jKfyT878h8Lq3dpg20hRYn9wWrgLXQ== X-Received: by 2002:adf:e5c7:0:b0:270:de92:7962 with SMTP id a7-20020adfe5c7000000b00270de927962mr31319470wrn.60.1672937008513; Thu, 05 Jan 2023 08:43:28 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org, alex.bennee@gmail.com Cc: David Hildenbrand , Sunil Muthuswamy , Aurelien Jarno , Michael Rolnik , Aleksandar Rikalo , Greg Kurz , Ilya Leoshkevich , Thomas Huth , qemu-ppc@nongnu.org, Laurent Vivier , Max Filippov , Yanan Wang , Marek Vasut , Stafford Horne , Peter Maydell , Daniel Henrique Barboza , Palmer Dabbelt , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Taylor Simpson , Marcel Apfelbaum , Alexandre Iooss , Chris Wulff , Richard Henderson , Eduardo Habkost , Song Gao , Mark Cave-Ayland , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Artyom Tarasenko , Paolo Bonzini , qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, Alistair Francis , "Edgar E. Iglesias" , Bastian Koppelmann , Jiaxun Yang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Bin Meng , Mahmoud Mandour , David Gibson , Yoshinori Sato , Xiaojuan Yang , qemu-arm@nongnu.org Subject: [PATCH v2 17/21] gdbstub: fix address type of gdb_set_cpu_pc Date: Thu, 5 Jan 2023 16:43:16 +0000 Message-Id: <20230105164320.2164095-18-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230105164320.2164095-1-alex.bennee@linaro.org> References: <20230105164320.2164095-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1672937161415100001 The underlying call uses vaddr and the comms API uses unsigned long long which will always fit. We don't need to deal in target_ulong here. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- gdbstub/gdbstub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index c293b8e43c..4547ca3367 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -535,7 +535,7 @@ static void gdb_process_breakpoint_remove_all(GDBProces= s *p) } =20 =20 -static void gdb_set_cpu_pc(target_ulong pc) +static void gdb_set_cpu_pc(vaddr pc) { CPUState *cpu =3D gdbserver_state.c_cpu; =20 @@ -1289,7 +1289,7 @@ static void handle_file_io(GArray *params, void *user= _ctx) static void handle_step(GArray *params, void *user_ctx) { if (params->len) { - gdb_set_cpu_pc((target_ulong)get_param(params, 0)->val_ull); + gdb_set_cpu_pc(get_param(params, 0)->val_ull); } =20 cpu_single_step(gdbserver_state.c_cpu, gdbserver_state.sstep_flags); --=20 2.34.1