From nobody Wed Feb 11 02:13:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1672840021822477.48089406315376; Wed, 4 Jan 2023 05:47:01 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pD465-0000nX-86; Wed, 04 Jan 2023 08:46:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pD45x-0000lM-MZ for qemu-devel@nongnu.org; Wed, 04 Jan 2023 08:46:18 -0500 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pD45v-0005k2-Qo for qemu-devel@nongnu.org; Wed, 04 Jan 2023 08:46:16 -0500 Received: from [2a00:23c4:8baa:1d00:e655:fde:753f:696a] (helo=kentang.home) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pD45X-00099q-Ac; Wed, 04 Jan 2023 13:45:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=wDW9JK1AgcVGUr+D3xl31PU0Giu2aBKt72xModsfxWY=; b=m9pCK4s9U3w8OtyygtXoZWKau6 k7vWGdAMnT5hUW1ozkZwF+qyyinKWvUqKpa5kigDeRr6ACG9GooSe+Cz4wKbp9INFmdzKwKrfESWE MRxGiC2psQPaTZWjV887IXOiB1tOOH37jFN0H3K2WDudQs3kGSxrcy5qbJBMwe4MACuB7+kn3zgC0 fbFLmgA4lAXM1w81EN416RXNEiM4m+TcRI3QupxSrMQJzxYlsiW+qLxTu/TXsmMAeOT5u4o9Z8Ma/ qp2X+BV2loAKzGJu8pj3DM6Wxr5c48aY3TcI77XcBQcj4yN6j3ml8A5A/vL3SWB4jqv60W2SKN2+u AMnSi9hJ8ZFy9t8aoDXQ77jWgRPizujX/DY+tYe6ZIA2c31qU9RZTDfn5FN4s6UruraFzicfy9Zfh qYKQqdQ1zhsqD9k8CbcoCUpI66Ia8+nsT9JkUXgWfCSAEV7IZVswAk50K+5w0Qa7W54nBmk4t+yuF fdQIl+bFxOsHSsw5ZQRabpye5PCKcc8xvuuZYq5opd2M4+EmPdaMSeliB7SlPwUJzWFS7qWaQ9sOn H8MTIqF3bezDEj3BCFG6cs9ntj43zGJDS9P0Jauce2HpFkBWb+p0EeVFgLJG9nO18tB9F0sd42oeK u4o0CCM2sFFzxaJgAPGc1j7nqeXiCCvMF2w7zyycg=; From: Mark Cave-Ayland To: laurent@vivier.eu, qemu-devel@nongnu.org Date: Wed, 4 Jan 2023 13:45:53 +0000 Message-Id: <20230104134554.138012-4-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230104134554.138012-1-mark.cave-ayland@ilande.co.uk> References: <20230104134554.138012-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a00:23c4:8baa:1d00:e655:fde:753f:696a X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [PATCH v2 3/4] target/m68k: fix FPSR quotient byte for fmod instruction X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1672840022724100006 Content-Type: text/plain; charset="utf-8" The FPSR quotient byte should be set to the value of the quotient and not t= he result. Switch from using floatx80_mod() to floatx80_modrem() which returns the quotient as a uint64_t which can be used for the quotient byte. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Reviewed-by: Richard Henderson --- target/m68k/fpu_helper.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/target/m68k/fpu_helper.c b/target/m68k/fpu_helper.c index 76b34b8988..5fd094a33c 100644 --- a/target/m68k/fpu_helper.c +++ b/target/m68k/fpu_helper.c @@ -523,17 +523,16 @@ static void make_quotient(CPUM68KState *env, int sign= , uint32_t quotient) =20 void HELPER(fmod)(CPUM68KState *env, FPReg *res, FPReg *val0, FPReg *val1) { - uint32_t quotient; - int sign; + uint64_t quotient; + int sign =3D extractFloatx80Sign(val1->d) ^ extractFloatx80Sign(val0->= d); =20 - res->d =3D floatx80_mod(val1->d, val0->d, &env->fp_status); + res->d =3D floatx80_modrem(val1->d, val0->d, true, "ient, + &env->fp_status); =20 if (floatx80_is_any_nan(res->d)) { return; } =20 - sign =3D extractFloatx80Sign(res->d); - quotient =3D floatx80_to_int32(floatx80_abs(res->d), &env->fp_status); make_quotient(env, sign, quotient); } =20 --=20 2.30.2