From nobody Sat Feb 7 05:42:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=quicinc.com ARC-Seal: i=1; a=rsa-sha256; t=1672302134; cv=none; d=zohomail.com; s=zohoarc; b=BeaQUwl9T+L8xD35fLN+x9ab1IjYpHHMSva42TPfR5HQ16Rv1UgSewRTDGXkNxqzXtC9Eq5aaic9ZkNo1KoqdCUUwaAhop9tOgBRl2pSqXwluldRJ3bkDHRpGcYSda4fsHTcqB3VNtdxf2vtA2biu6cye3nR1H6ItTQNgpPDLWw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1672302134; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=GC4IOal/s9YVFlwBGPDQJHlpZuGhhb49QYJb04XVljQ=; b=WLAaZAzkz6o9xT4W6OhbGTgUTY0qA3dBEV8vrg7DCLcJbd9XkAAbVC+tnYM1fdzi9NOyU5aTxMYXCEu1Qw7I6ncDLWxnB8VPGdSavk51o1jih/5CoYIL30nYdSEiyJOTaf7qVd6hOEl8wW2BXRXyAiE7Oa6Y0p/7vMJDq4c3axk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1672302132429192.1206595085531; Thu, 29 Dec 2022 00:22:12 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pAoAP-0006Ce-D3; Thu, 29 Dec 2022 03:21:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAoAO-0006CR-16 for qemu-devel@nongnu.org; Thu, 29 Dec 2022 03:21:32 -0500 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAoAI-0003dY-DJ for qemu-devel@nongnu.org; Thu, 29 Dec 2022 03:21:31 -0500 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BT7Tp6b019827 for ; Thu, 29 Dec 2022 08:21:24 GMT Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3mrar2tsvg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 29 Dec 2022 08:21:24 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2BT8LNGh020355 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 29 Dec 2022 08:21:23 GMT Received: from mthiyaga-linux.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 29 Dec 2022 00:21:20 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=qcppdkim1; bh=GC4IOal/s9YVFlwBGPDQJHlpZuGhhb49QYJb04XVljQ=; b=TWd03ikeUV7jIBTNbcK/4RZdVsOj4FepHcMCaugkeNYPrvv/TAsoR8t2hoSkKhOxA0C6 xR8hpHRp9UMU1EyqfGojm/65mEj2BYg1hf/0JW3JjURCRU7yrO1NEYL1rSRauuChs8Fj POiit6HCO83fAIOfRJ0eCdv0HZAWj1YPzGv6nVdVDNHaJCUSvYEgLReflu+33Gi4B2r6 /v/GJQHQxjGLk1EPvTOq915bBPf9HP1ebJkG2RGu6aVJbJMaCxRi255wIyx93Bjw7arl fPEbmU+/ZEBZp+Yvh/PNj68SUUq/EX2v9az8RxJ0J4O1n185pI2xnd3X06Y/bovkxAw6 bg== From: Mukilan Thiyagarajan To: , CC: , , Mukilan Thiyagarajan Subject: [PATCH v2] tests/tcg/hexagon: fix underspecifed asm constraints Date: Thu, 29 Dec 2022 13:48:36 +0530 Message-ID: <20221229081836.12130-1-quic_mthiyaga@quicinc.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: IP2rPYUvL4fKinmtqpAwcqygm5oe6KzJ X-Proofpoint-GUID: IP2rPYUvL4fKinmtqpAwcqygm5oe6KzJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-29_04,2022-12-28_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 impostorscore=0 mlxlogscore=999 spamscore=0 suspectscore=0 mlxscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2212290069 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=quic_mthiyaga@quicinc.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @quicinc.com) X-ZM-MESSAGEID: 1672302135897000001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There are two test cases where the inline asm doesn't have the correct constraints causing them to fail. In misc.c, the 'result' output needs the early clobber modifier since the rest of the inputs are read after assignment to the output register. In mem_noshuf.c, the register r7 is written to but not specified in the clobber list. Signed-off-by: Mukilan Thiyagarajan Reviewed-by: Taylor Simpson --- tests/tcg/hexagon/mem_noshuf.c | 2 +- tests/tcg/hexagon/misc.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/tcg/hexagon/mem_noshuf.c b/tests/tcg/hexagon/mem_noshuf.c index 0f4064e700..210b2f1208 100644 --- a/tests/tcg/hexagon/mem_noshuf.c +++ b/tests/tcg/hexagon/mem_noshuf.c @@ -144,7 +144,7 @@ static inline long long pred_ld_sd_pi(int pred, long lo= ng *p, long long *q, "}:mem_noshuf\n" : "=3D&r"(ret) : "r"(p), "r"(q), "r"(x), "r"(y), "r"(pred) - : "p0", "memory"); + : "r7", "p0", "memory"); return ret; } =20 diff --git a/tests/tcg/hexagon/misc.c b/tests/tcg/hexagon/misc.c index f0b1947fb3..e73ab57334 100644 --- a/tests/tcg/hexagon/misc.c +++ b/tests/tcg/hexagon/misc.c @@ -186,10 +186,10 @@ static int L2_ploadrifnew_pi(void *p, int pred) int result; asm volatile("%0 =3D #31\n\t" "{\n\t" - " p0 =3D cmp.eq(%1, #1)\n\t" - " if (!p0.new) %0 =3D memw(%2++#4)\n\t" + " p0 =3D cmp.eq(%2, #1)\n\t" + " if (!p0.new) %0 =3D memw(%1++#4)\n\t" "}\n\t" - : "=3Dr"(result) : "r"(pred), "r"(p) + : "=3D&r"(result), "+r"(p) : "r"(pred) : "p0"); return result; } --=20 2.17.1