From nobody Fri May 17 01:11:33 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1671228466; cv=none; d=zohomail.com; s=zohoarc; b=BdO4/zT9p4EvtF89vMnqSDUI+cNWPs3ZOQwT4KHKD6K6oVM2uDa1VLlMVIQaM6ZA0EJA5QjgvafRn1Rb6dZTjQMndpZ+Xvp3rQPpe/DsxMFfaSwuosk9t5l0+hWriewKYsTQx9l1YvU3hPCf3zlUUG/KSsYvM+Ua792Fmzd7i3o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1671228466; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=smV2boftcCtD6CrVI7POMK9nIWSGbQbv5KmjP5LYN6w=; b=PWmq1yjc699cig5wCso228rdwacYwmow3mu/ICBCT8i445pqQGh2BqVOh3Biko6YB2qGMRA+qG/9Sg0zYe0g/3TetQ/7LUzFd0OFOh1RxZBntFbUdgopmCfgkxlxCiyUqnIsVLpw2tDi9338vBAzETJU5Q5dSK+bYFMYOCBS5gI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1671228466206222.71338054440582; Fri, 16 Dec 2022 14:07:46 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6ImV-0005u0-GG; Fri, 16 Dec 2022 17:02:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6ImS-0005pl-SP for qemu-devel@nongnu.org; Fri, 16 Dec 2022 17:02:12 -0500 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p6ImQ-0004Wv-HM for qemu-devel@nongnu.org; Fri, 16 Dec 2022 17:02:11 -0500 Received: by mail-ej1-x62a.google.com with SMTP id ud5so9283021ejc.4 for ; Fri, 16 Dec 2022 14:02:09 -0800 (PST) Received: from localhost.localdomain ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id g25-20020a170906539900b00738795e7d9bsm1299629ejo.2.2022.12.16.14.02.06 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 16 Dec 2022 14:02:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=smV2boftcCtD6CrVI7POMK9nIWSGbQbv5KmjP5LYN6w=; b=DaOMyhZ6fNpFrNXIfIEA8BNfsz9USKx8GXatFrOF1pclTTG+TpoggCFuWgJqA9c+5t bN+M/B8rT57GHfUBvghHx3yQqQZkBwRtb1hMQMxW/mfPFIx2UOxpeXWNAeGvU0c9vFKV 3drdogBgH9zKwQWF9Dg7UZxaQtL/Kb5BL7f2NPKorzyglxJ8iKDHbayQU0fOswWg+dbn dqbNx5uLMeS0oXSZaBa4L+jMcJPaigEzdULoZvILY3cKOjkoiG5+SeVCWr3Y4yDVgVOc DM9G+tLJ3XUUpin2EftSnBSZjjXZliG0kWgzHNbY1A0ImjHl0zWlzgxuM2wwUfe/uvYj MFxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=smV2boftcCtD6CrVI7POMK9nIWSGbQbv5KmjP5LYN6w=; b=Yv9fVIzZG/JlHZco4Wdys5rBR1Vn3TUXvLfGyXLpbJLUdTrZ59YuSfiJkj9+Tvjhd7 D6Q+u/apILciS0QYTnB05XV0gVks3DswNBCxZraBsWflZZbw5QaG9XR1n9rjGSErWP04 kl09pZSYSkayNEayU3HZtERqmHPkRZnk9IZ0oE1uDSsRAlRY/BHtsZ5fGL5VtaAzO7dN xOCRVbbrLUNslYPtB6HHr/UxDBkFqJ5mQAER5MZYsEY6eO2vUClJXAFxmzgVc73Tv0hx PiMtf2jdrXYl11tSPzOw4J87Sg+F8MKALFgwRKBTH1BFZdo4Dn/dbiDjyL0c5pml6+ZZ JPpQ== X-Gm-Message-State: ANoB5pliG6UHhqqEnJrsmwvcPU6YesHLQbue76RdyQWHrxkEEFDuNNvW DEMr90n8C4vEKsdZzYUF9zNNbe4vVNDzVn/ALkc= X-Google-Smtp-Source: AA0mqf7QAqCiH23adcIdxw8c57oTXKYq6VQ4tdsquZy5PRXss98D1c1irVpoc52DsP192AYwLK2G2g== X-Received: by 2002:a17:906:1805:b0:78d:f454:3855 with SMTP id v5-20020a170906180500b0078df4543855mr28504506eje.18.1671228128414; Fri, 16 Dec 2022 14:02:08 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Marcel Apfelbaum , Cameron Esfahani , "Michael S. Tsirkin" , Eduardo Habkost , haxm-team@intel.com, Roman Bolshakov , Paolo Bonzini , Richard Henderson , Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/5] target/i386: Remove NEED_CPU_H guard from target-specific headers Date: Fri, 16 Dec 2022 23:01:54 +0100 Message-Id: <20221216220158.6317-2-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221216220158.6317-1-philmd@linaro.org> References: <20221216220158.6317-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::62a; envelope-from=philmd@linaro.org; helo=mail-ej1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1671228466862100001 NEED_CPU_H is always defined for these target-specific headers. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/i386/hax/hax-i386.h | 2 -- target/i386/hvf/hvf-i386.h | 4 ---- 2 files changed, 6 deletions(-) diff --git a/target/i386/hax/hax-i386.h b/target/i386/hax/hax-i386.h index efbb346238..409ebdb4af 100644 --- a/target/i386/hax/hax-i386.h +++ b/target/i386/hax/hax-i386.h @@ -49,7 +49,6 @@ struct hax_vm { struct hax_vcpu_state **vcpus; }; =20 -#ifdef NEED_CPU_H /* Functions exported to host specific mode */ hax_fd hax_vcpu_get_fd(CPUArchState *env); int valid_hax_tunnel_size(uint16_t size); @@ -66,7 +65,6 @@ int hax_sync_vcpu_state(CPUArchState *env, struct vcpu_st= ate_t *state, int set); int hax_sync_msr(CPUArchState *env, struct hax_msr_data *msrs, int set); int hax_sync_fpu(CPUArchState *env, struct fx_layout *fl, int set); -#endif =20 int hax_vm_destroy(struct hax_vm *vm); int hax_capability(struct hax_state *hax, struct hax_capabilityinfo *cap); diff --git a/target/i386/hvf/hvf-i386.h b/target/i386/hvf/hvf-i386.h index 76e9235524..95b47c1c2e 100644 --- a/target/i386/hvf/hvf-i386.h +++ b/target/i386/hvf/hvf-i386.h @@ -24,11 +24,7 @@ =20 void hvf_handle_io(CPUArchState *, uint16_t, void *, int, int, int); =20 -#ifdef NEED_CPU_H -/* Functions exported to host specific mode */ - /* Host specific functions */ int hvf_inject_interrupt(CPUArchState *env, int vector); -#endif =20 #endif --=20 2.38.1 From nobody Fri May 17 01:11:33 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1671228657; cv=none; d=zohomail.com; s=zohoarc; b=cHFcOuP8t7o8mdi+8RZFduruFeYPjRzhMmqALGpXOS+2OTnnX7J1dFrcAxWL2EQYmgmb/iaTR2qTxe7pqTP/JW2EpBtqlQwc9dm5JIJURkTfiV8Cy4w+lPUkG824YZ3fRmbehVpSbQWr/4gyvHlDdNkU359BfYu6RIpPnQHnRfw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1671228657; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=rw+OSreaYKaK01l9H3rpbBUYYZyWmIr/QVbzMY71n0k=; b=EwFu1ll8Hdjo84gXpVLYJPRWAu96XUZOiO7874wGobZES+d47NzRb2bUsrpn7GFvsuSCE5MjI20OaehHukYgbs//hsnKjnHTOo2IUql3UwrITC84USoFG6W01pCFKUqQNuDpps3us/69UrQN6OZES46n4dLQc9wVOfWcFUchMSM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1671228657829657.0394562037139; Fri, 16 Dec 2022 14:10:57 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6ImX-0005ut-Tx; Fri, 16 Dec 2022 17:02:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6ImW-0005uM-JP for qemu-devel@nongnu.org; Fri, 16 Dec 2022 17:02:16 -0500 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p6ImU-0004Wv-Ss for qemu-devel@nongnu.org; Fri, 16 Dec 2022 17:02:16 -0500 Received: by mail-ej1-x62a.google.com with SMTP id ud5so9283478ejc.4 for ; Fri, 16 Dec 2022 14:02:14 -0800 (PST) Received: from localhost.localdomain ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id ku10-20020a170907788a00b007c0d4d3a0c1sm1278537ejc.32.2022.12.16.14.02.12 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 16 Dec 2022 14:02:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rw+OSreaYKaK01l9H3rpbBUYYZyWmIr/QVbzMY71n0k=; b=VOC2qmf7OPpDFDVkWgHbPSeEIJAC/EmuHhZKqqyjCBX5xnJNdOE4bv5OoRgHIE88r8 7ek6EjPAwNrBLL6V5uvSCSkwIRRqpOI5d/tNz754ajBMGPEdsKU5MyqBXLzRwM+B4ISI 0NrlMLKZC3vaOK39Nvsman4fh1Uf49PwpnIIZl/7VzPp1ZncmRkkH7N9YKVP3W7tIdbJ Va8GNZ1nlI9jHNSX8pJ+cuOS7K4jBshECa6ELozToGz75/M401G3HfVp2xl7rmHJMEQl RCk3pDLy3csARaFZvvaZFq782lrRqIaySQNAneXX8u0N1PpR1JeIWqO4tSaxposP8G8O fADA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rw+OSreaYKaK01l9H3rpbBUYYZyWmIr/QVbzMY71n0k=; b=D/NEpYILjadHFmuqP87IIJHlLkRhUCrf+EuEJnBMjq+zL98CIyuqZh0Dxuyo2uyXoU buPW5KnBmBYJw3mNQKgoSoFNxJRfOzdPpYen3d/0Y3MVNVbEw7wPreneol3ITQ8j8/wi WLmfn+MlunW1PGfyv/Lc88J0sqBCV5JsCZriLCiGdFqvL2YliIl9ZlZMZJOf71Z/1ZdT SB6jQ0gq5/30ZFtO7wto+ZVDeIP/aifRindyEeBKjTjR8ezg/Q+0ZoXOjcYNqRosavBN jmZNDTyZGxKDqn3GQiT5yFxG910skDVa4cRJyo43bKed6RMfsmOweETL5dGJwkKpzef0 52sw== X-Gm-Message-State: ANoB5pn33iZyvlKhhOPVt1toqzK+RYq5LBwrXskZaDzLIvWzeM7A6INk cZlx0L2OdFOgLQ8EDCcDIP0uB72KqMwCa3gDSKE= X-Google-Smtp-Source: AA0mqf7RA2oUxQRwnmkk9bvP1/0IDp3tPQ2jRy/yD+kcQ/9AIKzpuVdqm8QaDJMPBJCjBKcmUiNqgQ== X-Received: by 2002:a17:906:6ad7:b0:7c1:ac8:399 with SMTP id q23-20020a1709066ad700b007c10ac80399mr14403774ejs.55.1671228133933; Fri, 16 Dec 2022 14:02:13 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Marcel Apfelbaum , Cameron Esfahani , "Michael S. Tsirkin" , Eduardo Habkost , haxm-team@intel.com, Roman Bolshakov , Paolo Bonzini , Richard Henderson , Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/5] target/i386/cpu: Remove dead helper_lock() declaration Date: Fri, 16 Dec 2022 23:01:55 +0100 Message-Id: <20221216220158.6317-3-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221216220158.6317-1-philmd@linaro.org> References: <20221216220158.6317-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::62a; envelope-from=philmd@linaro.org; helo=mail-ej1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1671228660045100005 Missed in commit 37b995f6e7 ("target-i386: remove helper_lock()"). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/i386/cpu.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index f729e0f09c..9824b7f8f2 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -2313,9 +2313,6 @@ static inline void cpu_set_fpuc(CPUX86State *env, uin= t16_t fpuc) } } =20 -/* mem_helper.c */ -void helper_lock_init(void); - /* svm_helper.c */ #ifdef CONFIG_USER_ONLY static inline void --=20 2.38.1 From nobody Fri May 17 01:11:33 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1671228926; cv=none; d=zohomail.com; s=zohoarc; b=NXOzyIUJRyPAgyc62jBIBdEpicvNRJ3v0kurUTdzNK5tLNqS8XmYXfJZTr7yywDnodrxaPkhWskMOkwWr0w1Ueqbx1OEsmAsMROODsMn6BwJgxYgzo13BeaHZ9wONdvnZ/yNpLk6dja/sIbkINRFcWRQt2JU/DPvOKY3nD2SV2I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1671228926; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=bsYElVm876q/0ZqLXVB4BT+73LRGAkhD0hBlyKLVHqQ=; b=KaOYymwPs8uLV+mvNZY24UoXP2dJ4kNpY494Po9lAAr+dmEGUFDSGB84McCg0hbiC13hnRoQBuGgM6vA0LZBjO5r/ZVpBrQjzr0M2ULoeWRHraJv4kYp4zmXNZnZM4Mn2PHnItxiQF1xY46+lM5nTPrT8kkUDhPBoxxKxOp/tig= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1671228926080949.8894060477289; Fri, 16 Dec 2022 14:15:26 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6Img-0005wU-Us; Fri, 16 Dec 2022 17:02:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6Imd-0005vs-8Y for qemu-devel@nongnu.org; Fri, 16 Dec 2022 17:02:23 -0500 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p6Imb-0004Y8-GC for qemu-devel@nongnu.org; Fri, 16 Dec 2022 17:02:23 -0500 Received: by mail-ed1-x52a.google.com with SMTP id d14so5435861edj.11 for ; Fri, 16 Dec 2022 14:02:20 -0800 (PST) Received: from localhost.localdomain ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id cm12-20020a0564020c8c00b00463b9d47e1fsm1320516edb.71.2022.12.16.14.02.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 16 Dec 2022 14:02:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bsYElVm876q/0ZqLXVB4BT+73LRGAkhD0hBlyKLVHqQ=; b=flnntruX73Zzy0t/jROQZBggFAGJK88sjUttKc9z8TQjz092cNZRLRn74UUSbCMgtu RWSVq3NqNY2o/jn9IvKu6PWdO64WWHD6fQWziI10FCRaaFkri94Gm80Ve1xW3W/3HmL1 t5+sKIWTso2JyzoC2iBQ2z1VoBPj46YDe5Ay8/icRKATjGcpMNWfdYyadgS3JotVBH4h s6k1xcJ1RhrydnubUV5QzN//3TX3s0zDNk1w4swCd3vjEZwGdwcXuA1WOIG0ZZna6abl OXyBw7gL9c3jt7JH1H12Oz2paU6aXW0GORSMfLEKQlyrqVXPUmDdahQ2dEunvlno1wrv 4ozg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bsYElVm876q/0ZqLXVB4BT+73LRGAkhD0hBlyKLVHqQ=; b=GBuUC1ekz4CB+CGBhmQhbMPDMniruANcPJ+Xh00X0ZH0YYJ04OFAU3i9VJmCAzlWc8 oUvrcNariv/4HBlPGorNED95DDd/5eixS79jWJD/uvcOT+G7wecFqOCmYIrea7BJZ9qN VPaGzR4DdwG9x2qwajIDa6W04a+ld9wbSJCDJqf7f9vGXurAdOM/66MpHPlV3g0HCzsY HyXqoym0trSlYe2anLn3XzTUKlFGQYFdf3keDySFp4wdmlnTsMIgVgC7mteXZ4WvzjxN 2exwent2q+XAmmfD28QW0CKEpXIqHcitAynt4l8AMvxOC+n2smABNsgSo74MITtfbyNW rtoQ== X-Gm-Message-State: ANoB5pm4B4KzDlMSJUuSEFPZWnN6kKaQdy1hc6JUn6S8mT8yK+eQ+iwA aeiBzLiTXgpPf8+4bLTp5i7WfZZJmx3P684EeQM= X-Google-Smtp-Source: AA0mqf7jEwTTUCaptKy44fqGpvvN+j0b3E2kEg6UJ72iEBNB25rE+B9lGpK339BDGIOd5XCZKBXvDg== X-Received: by 2002:a05:6402:448f:b0:470:25cf:99d1 with SMTP id er15-20020a056402448f00b0047025cf99d1mr16674901edb.31.1671228139536; Fri, 16 Dec 2022 14:02:19 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Marcel Apfelbaum , Cameron Esfahani , "Michael S. Tsirkin" , Eduardo Habkost , haxm-team@intel.com, Roman Bolshakov , Paolo Bonzini , Richard Henderson , Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 3/5] target/i386/ops_sse: Include missing "cpu.h" header Date: Fri, 16 Dec 2022 23:01:56 +0100 Message-Id: <20221216220158.6317-4-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221216220158.6317-1-philmd@linaro.org> References: <20221216220158.6317-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52a; envelope-from=philmd@linaro.org; helo=mail-ed1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1671228927768100003 'Reg' is defined as 'MMXReg', itself declared in "cpu.h". Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/i386/ops_sse.h | 1 + target/i386/ops_sse_header.h | 3 +++ 2 files changed, 4 insertions(+) diff --git a/target/i386/ops_sse.h b/target/i386/ops_sse.h index 3cbc36a59d..68c88c9ee3 100644 --- a/target/i386/ops_sse.h +++ b/target/i386/ops_sse.h @@ -19,6 +19,7 @@ */ =20 #include "crypto/aes.h" +#include "cpu.h" =20 #if SHIFT =3D=3D 0 #define Reg MMXReg diff --git a/target/i386/ops_sse_header.h b/target/i386/ops_sse_header.h index 8a7b2f4e2f..5631a6d1e1 100644 --- a/target/i386/ops_sse_header.h +++ b/target/i386/ops_sse_header.h @@ -16,6 +16,9 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see . */ + +#include "cpu.h" + #if SHIFT =3D=3D 0 #define Reg MMXReg #define SUFFIX _mmx --=20 2.38.1 From nobody Fri May 17 01:11:33 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1671228898; cv=none; d=zohomail.com; s=zohoarc; b=C/dvy9S2mmf+njj9Gfjy6JQ31lJZxhibXQGVUXfodd+RkVZ3K7Cz7SF//E1Acpfz4tegfNILG8+Y1h8wWspWUtvLxUj/2pAJjbKP3NlVrNHrW4Gc/VCa5k24ZZxBNeotQDVmWC4/NONpEjv7EE4V57JnxxXm5smEvsbnRWGC3Bc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1671228898; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ubryi+kT4ZgfJta0po2rO0OCWUN41wpa/A7EK1wMX3A=; b=BsW4O/R9cjyFizNhFDBYhGAHhjUbAoj5i77fQv3wGr7kvOmaB+y9oGqm7a/rx3/OvFWtnvaHK4NQiECqsrbQWcPf4wn+nj/Q0EflGThs7Ht/z77kMz8WoWzhNuxrH4ERqhx449fH4355H50wiWWu+u+EwsCtyeBjvDk+PnLkp2E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1671228898438370.0955817935784; Fri, 16 Dec 2022 14:14:58 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6Imm-0005xy-37; Fri, 16 Dec 2022 17:02:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6Imj-0005xY-TW for qemu-devel@nongnu.org; Fri, 16 Dec 2022 17:02:29 -0500 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p6Imh-0004Yo-LR for qemu-devel@nongnu.org; Fri, 16 Dec 2022 17:02:29 -0500 Received: by mail-ed1-x529.google.com with SMTP id d20so5578190edn.0 for ; Fri, 16 Dec 2022 14:02:27 -0800 (PST) Received: from localhost.localdomain ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id r17-20020a056402019100b004722d7e8c7csm1323355edv.14.2022.12.16.14.02.24 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 16 Dec 2022 14:02:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ubryi+kT4ZgfJta0po2rO0OCWUN41wpa/A7EK1wMX3A=; b=CPXJdzqqTPQTVBAhjt52mM6Sr6Xb2LTSI4KR89AdwMhHcVAmf4Mp1len6K6NxdXMn6 UZs2G9WzLdjSLmcG7LMBJrmkYXE0xq/0WDA0EqkzUSJoVoUe6Ty7bR+RxNoXHb06FAcU 9zjZVvVuYfBTAcQ6XmZBQ1Rn/FmzkqtchgoNVkvcngRI3ngEAKOBhsrt88tEZayyBs95 0L2yBCjMWBqpEZzUUwJ3wy/AQCXSPtKmgVXba/JGHv5pgBCICijfsU+XTL3FbyhTi5BB 2nkqw76Gxx33g6P1WlVLOEVggs9LFB8b/rulK4aorqYsvPAp4H4liq7OmslsNi6ZkBYA nPmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ubryi+kT4ZgfJta0po2rO0OCWUN41wpa/A7EK1wMX3A=; b=ZA71hejDts7IAs4UNu1EwbmM44eDiH0657iD8eLZMgoH59mSUZ5ufbxj0uMO+9ccW1 /lv/hRaPf3hQKCydlYFn/bA0OxlECg0JOQZ3M4cmsFFwrV64JImuIORwzN41+iTKVMUk 72uCRg1jabkjG6N0bbKqU8aWgC/YNMBUYF2M8ThPbw4SgHTf5dwVhVFN1al7bNBR+01+ goEpczPH+PJEGxZNKT9QCfOwbSmeHUZg2XF27dJOBvRFBoJZKHMszu6ax0yd7RrY4xRi UsZpNV+yAzcChEra6+l1mQ7pyz0uET3gfrLz3xaNVKO4W6P2KCoT7pfCinfEmg3MAapN s4fg== X-Gm-Message-State: ANoB5pm1wMuntPAq2dsPRwVSWJB8DTh0OPYiHuiWdIc1rJxIKXlYg1fa 3ExO1kb8j0PwWfUItbX/2znrsF8+7K0FZiWcA+8= X-Google-Smtp-Source: AA0mqf7hbCF6/YLJgPUrP29bqDep1dHdTtfN9t1gEYNPFhIVhf0JIMK70cl7X0xfep0qFWR2Tt2EzQ== X-Received: by 2002:a05:6402:28a:b0:45c:be41:a473 with SMTP id l10-20020a056402028a00b0045cbe41a473mr28858111edv.29.1671228145924; Fri, 16 Dec 2022 14:02:25 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Marcel Apfelbaum , Cameron Esfahani , "Michael S. Tsirkin" , Eduardo Habkost , haxm-team@intel.com, Roman Bolshakov , Paolo Bonzini , Richard Henderson , Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 4/5] target/i386: Remove x86_cpu_dump_local_apic_state() dead stub Date: Fri, 16 Dec 2022 23:01:57 +0100 Message-Id: <20221216220158.6317-5-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221216220158.6317-1-philmd@linaro.org> References: <20221216220158.6317-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::529; envelope-from=philmd@linaro.org; helo=mail-ed1-x529.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1671228899604100005 x86_cpu_dump_local_apic_state() is called from monitor.c which is only compiled for system emulation since commit bf95728400 ("monitor: remove target-specific code from monitor.c"). Interestingly this stub was added few weeks later in commit 1f871d49e3 ("hmp: added local apic dump state") and was not necessary by that time. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/i386/cpu-dump.c | 5 +---- target/i386/cpu.h | 4 ++++ 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/target/i386/cpu-dump.c b/target/i386/cpu-dump.c index 08ac957e99..40697064d9 100644 --- a/target/i386/cpu-dump.c +++ b/target/i386/cpu-dump.c @@ -335,10 +335,7 @@ void x86_cpu_dump_local_apic_state(CPUState *cs, int f= lags) } qemu_printf(" PPR 0x%02x\n", apic_get_ppr(s)); } -#else -void x86_cpu_dump_local_apic_state(CPUState *cs, int flags) -{ -} + #endif /* !CONFIG_USER_ONLY */ =20 #define DUMP_CODE_BYTES_TOTAL 50 diff --git a/target/i386/cpu.h b/target/i386/cpu.h index 9824b7f8f2..32d048f326 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -2355,12 +2355,16 @@ typedef int X86CPUVersion; */ void x86_cpu_set_default_version(X86CPUVersion version); =20 +#ifndef CONFIG_USER_ONLY + #define APIC_DEFAULT_ADDRESS 0xfee00000 #define APIC_SPACE_SIZE 0x100000 =20 /* cpu-dump.c */ void x86_cpu_dump_local_apic_state(CPUState *cs, int flags); =20 +#endif + /* cpu.c */ bool cpu_is_bsp(X86CPU *cpu); =20 --=20 2.38.1 From nobody Fri May 17 01:11:33 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1671229163; cv=none; d=zohomail.com; s=zohoarc; b=JohHsYtThQdY13+eGAJDI7MTznuJlMDBGsl+iWQUIbPbuZx8utoLqMg6MjrLvp3BIziAM7shBvf5UkYqIT3olxdQauoQgtgY+5AzAGLCSz/rvzD3S6ux6D3gf2gQaQTGkkPP2OIgM+nJl5Np/90iXssghrpy8JV8ZEQUKw7VyGI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1671229163; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=onv9U82TXSCn9/lZOsBgvSuM1dZGKCW/DDceT29frZo=; b=McBDM6vIlXzPYkh1KRR74+Q0tiLRwYajyt0ggfLDE7IDtbVKV7kc8xuwWTqkOhR3VxYg3JvaaE0dZ5Kogu9CkTATjJ1vfn2W1+lyLoZD8ao6pyk4fW8KqVFmhI/pIRznIplqZkQPU6JSa6I3exZZKp5Ami32sRf+CnzYFVSCu5c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16712291634621016.3719978838197; Fri, 16 Dec 2022 14:19:23 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6Ims-0005zh-JZ; Fri, 16 Dec 2022 17:02:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6Imp-0005yt-HN for qemu-devel@nongnu.org; Fri, 16 Dec 2022 17:02:35 -0500 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p6Imn-0004ZL-Qb for qemu-devel@nongnu.org; Fri, 16 Dec 2022 17:02:35 -0500 Received: by mail-ej1-x634.google.com with SMTP id n20so9383086ejh.0 for ; Fri, 16 Dec 2022 14:02:33 -0800 (PST) Received: from localhost.localdomain ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id a14-20020a170906670e00b007c0f45ad6bcsm1279023ejp.109.2022.12.16.14.02.30 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 16 Dec 2022 14:02:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=onv9U82TXSCn9/lZOsBgvSuM1dZGKCW/DDceT29frZo=; b=Ky4iUHJlIfCfLsoL60cSkI2b4RH5kaJWH7u1YjPsKd5vB2IsV955ZBjKeQbx4fqYeI 4605/+ORXY6xUdzg/B2mu+kCIF4Hj28cGGXKzaQRry59U+ULfbYzi/6t3aAVQvnxCqEt y9ajqv645neBKAF6cyCnmUdpSu8LWPjieD3AnDoHqJFk1xHBPQHMk0rsS+kW3/BKeFBp E9GuxclM8wAnhWKl3nDJ5ELc9KZaxca7YCz6qtkKjAnaXsl/htrumlQvneazzbpQQTaK GWzP9zn8ghTz4kztjl5KF9WK3Ri4yLnySCBAvPqwFm13OQkkU+pUWHfhuduumIRsIDzL ZcMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=onv9U82TXSCn9/lZOsBgvSuM1dZGKCW/DDceT29frZo=; b=USDMe6v6ahccv25uL5G/UCx5NwGqPhKE6wJ86TWf15znliN4nTm9b+kPj/2D5fUUCi CrkyDmOpwrJ+qupTyxTEkeQXlRtJt2vm/77XaNTEepMgqrJXKWRo3Tb/A0Xx2Lakx2aJ V52EgGwmXzvYGHEdFjmoi3R5wnekOc115qpFrALbfS0FlrfyilglH8RnYtPRxZr/nLCF uhMNOr2p+cjkbiPd6/Zidtu/DqesQhBLDzFJ+gXfMokEEKSVaplLAWqwn7NnkcfQF1eU plqkpfhBKGH1vK4KghIWcyyFYiGLKxQhsJyfXMbWiVy4MW3IoV0FdzK/+EwtHlKU2xzE AT3A== X-Gm-Message-State: AFqh2kpC/rvRrZ37j6x21h0LVL55dIuGK3gujA9OG4b3JEXnPC77oehW lEltabWmNRy6/gBC84m9jrEDb8ksi0B81o9DNAM= X-Google-Smtp-Source: AMrXdXvVJ7MFT/wlpKssdiyDsQ2ooocTbBsdco7g2Val/Wjrgmy7bj9LvomubxJXiygqYSjklTykgg== X-Received: by 2002:a17:907:1b28:b0:7f7:a985:1838 with SMTP id mp40-20020a1709071b2800b007f7a9851838mr1014329ejc.44.1671228152085; Fri, 16 Dec 2022 14:02:32 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Marcel Apfelbaum , Cameron Esfahani , "Michael S. Tsirkin" , Eduardo Habkost , haxm-team@intel.com, Roman Bolshakov , Paolo Bonzini , Richard Henderson , Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Stefan Weil , Peter Maydell Subject: [PATCH 5/5] hw/i386/x86: Reduce init_topo_info() scope Date: Fri, 16 Dec 2022 23:01:58 +0100 Message-Id: <20221216220158.6317-6-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221216220158.6317-1-philmd@linaro.org> References: <20221216220158.6317-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::634; envelope-from=philmd@linaro.org; helo=mail-ej1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1671229165676100002 This function is not used anywhere outside this file, so we can delete the prototype from include/hw/i386/x86.h and make the function "static void". This fixes when building with -Wall and using Clang ("Apple clang version 14.0.0 (clang-1400.0.29.202)"): ../hw/i386/x86.c:70:24: error: static function 'MACHINE' is used in an in= line function with external linkage [-Werror,-Wstatic-in-inline] MachineState *ms =3D MACHINE(x86ms); ^ include/hw/i386/x86.h:101:1: note: use 'static' to give inline function '= init_topo_info' internal linkage void init_topo_info(X86CPUTopoInfo *topo_info, const X86MachineState *x86= ms); ^ static include/hw/boards.h:24:49: note: 'MACHINE' declared here OBJECT_DECLARE_TYPE(MachineState, MachineClass, MACHINE) ^ Reported-by: Stefan Weil Suggested-by: Peter Maydell Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/i386/x86.c | 2 +- include/hw/i386/x86.h | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/i386/x86.c b/hw/i386/x86.c index 78cc131926..b6ba0b2d00 100644 --- a/hw/i386/x86.c +++ b/hw/i386/x86.c @@ -64,7 +64,7 @@ /* Physical Address of PVH entry point read from kernel ELF NOTE */ static size_t pvh_start_addr; =20 -inline void init_topo_info(X86CPUTopoInfo *topo_info, +static void init_topo_info(X86CPUTopoInfo *topo_info, const X86MachineState *x86ms) { MachineState *ms =3D MACHINE(x86ms); diff --git a/include/hw/i386/x86.h b/include/hw/i386/x86.h index 62fa5774f8..5d3047a1d1 100644 --- a/include/hw/i386/x86.h +++ b/include/hw/i386/x86.h @@ -20,7 +20,6 @@ #include "exec/hwaddr.h" #include "qemu/notify.h" =20 -#include "hw/i386/topology.h" #include "hw/boards.h" #include "hw/nmi.h" #include "hw/isa/isa.h" @@ -98,8 +97,6 @@ struct X86MachineState { #define TYPE_X86_MACHINE MACHINE_TYPE_NAME("x86") OBJECT_DECLARE_TYPE(X86MachineState, X86MachineClass, X86_MACHINE) =20 -void init_topo_info(X86CPUTopoInfo *topo_info, const X86MachineState *x86m= s); - uint32_t x86_cpu_apic_id_from_index(X86MachineState *pcms, unsigned int cpu_index); =20 --=20 2.38.1