From nobody Tue Feb 10 06:44:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1670512347; cv=none; d=zohomail.com; s=zohoarc; b=YDM4lKQTkd7DGDzB6JvZBhlwG78QRcIrmRoRqHsXiOs31EQUYH5ca9xqIJYBDW4rhn8cTdYuugM+MM5AXkN2YVMW4fl/fPn3iPos3kUrem4hso/2FWxIpnVIgjuNiXkEg1cTOJJo+20sfIu1jGdSi+3Ibcial5ru80AWacF2kVY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1670512347; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=jhODE3C2yMutSLswzZ/L2Ho/OnXfz5BDeJuYMiTKS+o=; b=FyImI6+drCHPecZKyrl9qMm5znCQUSEkMpSavbo1YY1j5SHZN4JFa9au3jJkG/LeKnI9BKluFyRSFIpfyhlYpbqakjih/5UeRTue/nO3VZdulDhJaeMNLp5roVTCzXc8Ym6c9SIpedObZ11e2tIxflPISox6T9uqjR4jp9qnzrI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1670512347525275.8601701328506; Thu, 8 Dec 2022 07:12:27 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3IZJ-0004nS-92; Thu, 08 Dec 2022 10:12:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3IZF-0004mh-RT for qemu-devel@nongnu.org; Thu, 08 Dec 2022 10:12:09 -0500 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p3IZD-0001EQ-8H for qemu-devel@nongnu.org; Thu, 08 Dec 2022 10:12:09 -0500 Received: by mail-ej1-x62d.google.com with SMTP id vv4so4797593ejc.2 for ; Thu, 08 Dec 2022 07:12:06 -0800 (PST) Received: from beast.fritz.box (62-178-148-172.cable.dynamic.surfer.at. [62.178.148.172]) by smtp.gmail.com with ESMTPSA id cx16-20020a05640222b000b0046b9c536fc5sm3458151edb.63.2022.12.08.07.12.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Dec 2022 07:12:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jhODE3C2yMutSLswzZ/L2Ho/OnXfz5BDeJuYMiTKS+o=; b=Rm6KemZ/MzGBBAHPG3eAup/Ix03v3ppiWFHtwaU75BhaNiOBfbyo9kK2jpF2gGORBi cmjKkXBICyrF8GoYOB9HJzhOk8N4S1YtuKVbuw68K0QVIv+VFtuwwPYysndwfWuRMdP0 kEJB+5ivmvwkRJR1qTh1loly+ynLM/6aOAyaaId6wUvlWFLwRfQIDATSrrGSHTdw5vkA rCqzPzNPNObxtrm2omZ3aIg9aMPjjVhxMEB1nBQPXBKIbpDDGDUs9UsmGFbIh6D08PFq KFMoanYfc5znq1zbZo3oCUeWi+7UBWbZSFqP8jHM+D0h146jzL5zzzj9EyjyinSNMxsy SNKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jhODE3C2yMutSLswzZ/L2Ho/OnXfz5BDeJuYMiTKS+o=; b=XoGcveRGY3uR4cGp273dTSRTlzXni2rmthSE0GM0tWnNzpXlR7Hb3mQvWLhoO5Y4Wh tkXoHW5EsxMdnjLjbZYXw5vTvMjNiHLGZ3NI868K+9tu/CmsauDc4K+u5svYwwYa/ljl xopzPNCDQlKi9V8fmCePgbPx4lclxpcf3k7YuR67VbX7J5NzZUZUs4HXVCqXnMdvcMRs CpVR2h3PHnwMtcDPLfX+qaf7yRrul0BoNkWbDfWwwMXxUisqNzlJlVbRBwwpQN4eWpxs hdBM8bHPl2X+sViLsooT8lf4hphofL8uhVZv3vlRSEi0SRocANDPGrc3LSRg8EwS4LCQ ZO/g== X-Gm-Message-State: ANoB5pkuvuHOBcFd98TWDK06miYQnQ5dbD6RwIoIw5EWmv8o0LdebrBn 31yHZCVssl8AZ7y5Dr7DgjDcSQ== X-Google-Smtp-Source: AA0mqf7byLaZGdBnhVHpLmyv4YNxWr/5HSh0aJtSCrLZpbBqxPdPA8m7SvUfUqqGxvB5J1JYzB9r+A== X-Received: by 2002:a17:907:2c75:b0:7c0:bbab:a550 with SMTP id ib21-20020a1709072c7500b007c0bbaba550mr21358064ejc.168.1670512325313; Thu, 08 Dec 2022 07:12:05 -0800 (PST) From: Christoph Muellner To: qemu-riscv@nongnu.org, qemu-devel@nongnu.org, Richard Henderson , Palmer Dabbelt , Alistair Francis , Bin Meng , Philipp Tomsich , Zhiwei Liu Cc: =?UTF-8?q?Christoph=20M=C3=BCllner?= Subject: [RFC PATCH] RISC-V: Save mmu_idx using FIELD_DP32 not OR Date: Thu, 8 Dec 2022 16:11:59 +0100 Message-Id: <20221208151159.1155471-1-christoph.muellner@vrull.eu> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::62d; envelope-from=christoph.muellner@vrull.eu; helo=mail-ej1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @vrull.eu) X-ZM-MESSAGEID: 1670512350645100003 From: Christoph M=C3=BCllner Setting flags using OR might work, but is not optimal for a couple of reasons: * No way grep for stores to the field MEM_IDX. * The return value of cpu_mmu_index() is not masked (not a real problem as long as cpu_mmu_index() returns only valid values). * If the offset of MEM_IDX would get moved to non-0, then this code would not work anymore. Let's use the FIELD_DP32() macro instead of the OR, which is already used for most other flags. Signed-off-by: Christoph M=C3=BCllner Reviewed-by: Alistair Francis Reviewed-by: LIU Zhiwei --- target/riscv/cpu_helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c index 278d163803..d68b6b351d 100644 --- a/target/riscv/cpu_helper.c +++ b/target/riscv/cpu_helper.c @@ -80,7 +80,8 @@ void cpu_get_tb_cpu_state(CPURISCVState *env, target_ulon= g *pc, flags |=3D TB_FLAGS_MSTATUS_FS; flags |=3D TB_FLAGS_MSTATUS_VS; #else - flags |=3D cpu_mmu_index(env, 0); + flags =3D FIELD_DP32(flags, TB_FLAGS, MEM_IDX, cpu_mmu_index(env, 0)); + if (riscv_cpu_fp_enabled(env)) { flags |=3D env->mstatus & MSTATUS_FS; } --=20 2.38.1