From nobody Sat May 18 21:00:24 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1670354721; cv=none; d=zohomail.com; s=zohoarc; b=TcWPdtT/Qnl7canwYRJ19JFTg8QBvInLUB+KeP5rk/ELewMVCQQNccHElOBRrQlqZEKoCabrNgEsoLww0qsSH7Ds0O6ykZxv3hD0iPNzR3uOYUN86Zzu6q11v7FZ28vlsEhIM1qNUV9mdtEbsf58Zm5W2Hw/CELyWl16t7nFq48= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1670354721; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=O+t0DzQBDIRFjteKA8ZVji5cWeBe/gnnf53ejIaoJ3A=; b=dlosCMuUiTkJ/h90ExS9kP8Zzdg1Bnn9o2RGyzhsLzig3E6yxdsSPLhmRUvIDnGQK0EjWj6BLKezn49vzA2iJYA0tmQp2FcIUTOQgapMlnRc4Uu5iaHOnPbjsAXrtwEG4b8np0dKtYpIv9ZvdCYBMkrQFQv5IwPJ3b6Rau3o6m4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1670354721394446.11381543688344; Tue, 6 Dec 2022 11:25:21 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2dY4-0007uv-EX; Tue, 06 Dec 2022 14:24:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2dXz-0007ud-SW; Tue, 06 Dec 2022 14:24:07 -0500 Received: from forwardcorp1c.mail.yandex.net ([178.154.239.200]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2dXv-00052u-Cw; Tue, 06 Dec 2022 14:24:07 -0500 Received: from sas1-7470331623bb.qloud-c.yandex.net (sas1-7470331623bb.qloud-c.yandex.net [IPv6:2a02:6b8:c08:bd1e:0:640:7470:3316]) by forwardcorp1c.mail.yandex.net (Yandex) with ESMTP id AEBB25F58E; Tue, 6 Dec 2022 22:23:51 +0300 (MSK) Received: from vsementsov-win.yandex-team.ru (unknown [2a02:6b8:b081:b491::1:20]) by sas1-7470331623bb.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id bNd0J10QCiE1-QBspPmb5; Tue, 06 Dec 2022 22:23:51 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1670354631; bh=O+t0DzQBDIRFjteKA8ZVji5cWeBe/gnnf53ejIaoJ3A=; h=Message-Id:Date:Cc:Subject:To:From; b=IA3t+hy0PnnT+SS6qwgq0oxyWSJS8ryDCkVKiYDfR2CjqpXgmsKeUBkMW2Zf8r1nA P9PyIZLBa/wRryXXF9Kavl1oopybcBwa1FmNDkrBLwZwo8mFOCIrpPC35FWYqTLDl1 WKspO5wsnQRi+3s1qZQu6TSq7koR941pb3VVW0/k= Authentication-Results: sas1-7470331623bb.qloud-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Cc: kraxel@redhat.com, qemu-trivial@nongnu.org, vsementsov@yandex-team.ru Subject: [PATCH for-8.0] ui/vnc: fix bad address parsing Date: Tue, 6 Dec 2022 22:23:34 +0300 Message-Id: <20221206192334.65012-1-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=178.154.239.200; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1c.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1670354724329100003 Content-Type: text/plain; charset="utf-8" IF addrstr =3D=3D "[" and websocket is true, hostlen becomes 0 and we try to access addrstr[hostlen-1] which is bad idea. Signed-off-by: Vladimir Sementsov-Ogievskiy --- ui/vnc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c index 88f55cbf3c..8830bfe382 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3765,7 +3765,7 @@ static int vnc_display_get_address(const char *addrst= r, =20 addr->type =3D SOCKET_ADDRESS_TYPE_INET; inet =3D &addr->u.inet; - if (addrstr[0] =3D=3D '[' && addrstr[hostlen - 1] =3D=3D ']') { + if (hostlen >=3D 2 && addrstr[0] =3D=3D '[' && addrstr[hostlen - 1= ] =3D=3D ']') { inet->host =3D g_strndup(addrstr + 1, hostlen - 2); } else { inet->host =3D g_strndup(addrstr, hostlen); --=20 2.34.1