From nobody Tue Feb 10 06:57:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1670261673476962.1978438438506; Mon, 5 Dec 2022 09:34:33 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2FL2-0008Dq-G8; Mon, 05 Dec 2022 12:33:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2FKT-0007x6-W8 for qemu-devel@nongnu.org; Mon, 05 Dec 2022 12:32:34 -0500 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2FK6-0007QR-OQ for qemu-devel@nongnu.org; Mon, 05 Dec 2022 12:32:33 -0500 Received: from i7.infradead.org ([2001:8b0:10b:1:21e:67ff:fecb:7a92]) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2FJp-007fzW-4j; Mon, 05 Dec 2022 17:31:53 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2FJo-002YKz-SE; Mon, 05 Dec 2022 17:31:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=t064sWCmPUZXmo6ZkmmkCyQGKm+KF/mmsLLFsp5yinI=; b=YjeMJGGNtCMQYjjNloyLiLzgWT DGjK3D4jb9qvytrZB7tpE5WRSGx/jTl4QYIjxxHaQHiiFFdrDLOB4chaa9HIJwxHZUg+Hpj9fYzb1 9VyjMaY7vx93nf01iQ3QytvggSfbcwnZ0dbnNHTAPZe7NNA2eaHZyA1SuujF8nveIanC+1tLCZ3UV 4XEESbV9SsdxJ5e47ixc/+bw+K/H+y9vmqBcOs2rI774YIMsI6keg5Ljfk3lnh0Dp6mkEvZpTd9rA DGcWQuyNfq1TnZAUe3VQk1Jl912IETMA9iwTABiW92yxTS8ngGOfpEiBvHvLxIIrwGSsltrun5zbn HPdR+Ocw==; From: David Woodhouse To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Paul Durrant , Joao Martins , Ankur Arora Subject: [RFC PATCH 21/21] i386/xen: implement HYPERVISOR_sched_op Date: Mon, 5 Dec 2022 17:31:37 +0000 Message-Id: <20221205173137.607044-22-dwmw2@infradead.org> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221205173137.607044-1-dwmw2@infradead.org> References: <20221205173137.607044-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; envelope-from=BATV+0f5700dbc1736e95d806+7043+infradead.org+dwmw2@desiato.srs.infradead.org; helo=desiato.infradead.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1670261673814100001 Content-Type: text/plain; charset="utf-8" From: Joao Martins It allows to shutdown itself via hypercall with any of the 3 reasons: 1) self-reboot 2) shutdown 3) crash Implementing SCHEDOP_shutdown sub op let us handle crashes gracefully rather than leading to triple faults if it remains unimplemented. Signed-off-by: Joao Martins Signed-off-by: David Woodhouse --- target/i386/xen.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/target/i386/xen.c b/target/i386/xen.c index f3cc240bff..9606f5978a 100644 --- a/target/i386/xen.c +++ b/target/i386/xen.c @@ -15,6 +15,7 @@ #include "xen.h" #include "trace.h" #include "sysemu/sysemu.h" +#include "sysemu/runstate.h" =20 #define __XEN_INTERFACE_VERSION__ 0x00040400 =20 @@ -23,6 +24,7 @@ #include "standard-headers/xen/hvm/hvm_op.h" #include "standard-headers/xen/hvm/params.h" #include "standard-headers/xen/vcpu.h" +#include "standard-headers/xen/sched.h" #include "standard-headers/xen/event_channel.h" =20 #define PAGE_OFFSET 0xffffffff80000000UL @@ -476,6 +478,44 @@ static int kvm_xen_hcall_evtchn_op(struct kvm_xen_exit= *exit, return err ? HCALL_ERR : 0; } =20 +static int schedop_shutdown(CPUState *cs, uint64_t arg) +{ + struct sched_shutdown *shutdown; + + shutdown =3D gva_to_hva(cs, arg); + if (!shutdown) { + return -EFAULT; + } + + if (shutdown->reason =3D=3D SHUTDOWN_crash) { + cpu_dump_state(cs, stderr, CPU_DUMP_CODE); + qemu_system_guest_panicked(NULL); + } else if (shutdown->reason =3D=3D SHUTDOWN_reboot) { + qemu_system_reset_request(SHUTDOWN_CAUSE_GUEST_RESET); + } else if (shutdown->reason =3D=3D SHUTDOWN_poweroff) { + qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN); + } + + return 0; +} + +static int kvm_xen_hcall_sched_op(struct kvm_xen_exit *exit, X86CPU *cpu, + int cmd, uint64_t arg) +{ + CPUState *cs =3D CPU(cpu); + int err =3D -ENOSYS; + + switch (cmd) { + case SCHEDOP_shutdown: { + err =3D schedop_shutdown(cs, arg); + break; + } + } + + exit->u.hcall.result =3D err; + return err; +} + static int __kvm_xen_handle_exit(X86CPU *cpu, struct kvm_xen_exit *exit) { uint16_t code =3D exit->u.hcall.input; @@ -489,6 +529,10 @@ static int __kvm_xen_handle_exit(X86CPU *cpu, struct k= vm_xen_exit *exit) case HVMOP_set_evtchn_upcall_vector: return kvm_xen_hcall_evtchn_upcall_vector(exit, cpu, exit->u.hcall.params[0]); + case __HYPERVISOR_sched_op_compat: + case __HYPERVISOR_sched_op: + return kvm_xen_hcall_sched_op(exit, cpu, exit->u.hcall.params[0], + exit->u.hcall.params[1]); case __HYPERVISOR_event_channel_op_compat: return kvm_xen_hcall_evtchn_op_compat(exit, cpu, exit->u.hcall.params[0]); --=20 2.35.3