From nobody Tue Feb 10 20:30:51 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1669959791; cv=none; d=zohomail.com; s=zohoarc; b=SaEFiCYsNKo1eosu220FYORwHd+pScqy9xVaPtxEWvuzBGzQoDHTFLC9VJNCJfRQJAoOdviahmSgK4YfepEt2hkNyV4STUFs/y2i1IGROTabtVcA+7/QZzK+X1wSno63hu7Gusu0IIuI/r7Wenip8CH2KVOgTHVim4cnZas81ds= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1669959791; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ubo08p5oxlcYFeE84Rh/1/JAKSwpqaTGcXF5lplXqUE=; b=E2o1nH7Rkop+lHAFQswj4kI8k8+LljpitYuXvsyrxq+xydwUmI8roHeVjLo4dSt0O/1SGuNjW+Ucwgtpsv5yVd7m12tWAJqEJFBvVKoYEG8T4V6v6LKsaEoAJUADcg+syQYT7WZJXyrpyMiwhTUYMToI8pgAqHKJPKuv5jwZS/w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 166995979111119.369441643946516; Thu, 1 Dec 2022 21:43:11 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0ymP-0002XF-Uv; Fri, 02 Dec 2022 00:40:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0ymO-0002WR-0T for qemu-devel@nongnu.org; Fri, 02 Dec 2022 00:40:08 -0500 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0ymM-0003Jv-8W for qemu-devel@nongnu.org; Fri, 02 Dec 2022 00:40:07 -0500 Received: by mail-pl1-x62b.google.com with SMTP id d3so3700852plr.10 for ; Thu, 01 Dec 2022 21:40:05 -0800 (PST) Received: from stoup.. ([2602:47:d48a:1201:e3cc:2e37:17d4:f1d5]) by smtp.gmail.com with ESMTPSA id d12-20020a170903230c00b00186f0f59c85sm4637075plh.235.2022.12.01.21.40.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 21:40:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=ubo08p5oxlcYFeE84Rh/1/JAKSwpqaTGcXF5lplXqUE=; b=se85c88E/4JZCgeYUOJfR49v03FoPWYHU+VbI75ZE10TWracAi2+P2IrmTHO/+v6W4 K9poU++hE3QZbDTa2zfzNkH6KSx/iMtU2chpeUIcLbJYc0gKwsTWOvEEoApRJnvDSgYb fsJRUdCwuVGwhbH317+/NV6BxahwxjYTl6JesM3OXgvh2ZKorASAr8/hTLtL2QJz6XpY uwROIFAF5wJU5t38qBzcfaNxyqQ+kK4abzTAKnGBU/kueYsxr+J37r8u8Wwdrt7mnGpf A12mphCJg0Vww7oqkCTusXWBcU1T7FbW5kjhMWeqEaoKR82RQ2Iv/8WnHIOe2CJ26Zpl dwOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ubo08p5oxlcYFeE84Rh/1/JAKSwpqaTGcXF5lplXqUE=; b=VVJ20iBguNRXv1NKTKr08YEXxQ5QgAaPBynOQMq+eSF107tIccSHZGg3+pyOlKEYQe e3p8wjaWEUqVmSu5WbzVTRzXhQHB5NgCHsEhkDA6IqefTUeg5fyPrcUzX0EWXdS1aFza yH1Sk3DjrfXbXG4Nurm5hIqNuobYdnSYTqiopRPzyRPvH+eQbAUA8Q4d7JRBCKdaPMC8 ka1MaDrWzQ9dHqDxZhFJk9o7kaDLNVMJuuri+/LxSCgm9V0imxwHEtUXOeCbKz7YM+67 LbLcDCm20qu6zWL8Poq8ohRO2P1ucEORJB4f9krYuxBT+K7JtHhgyAwRBUqvvAqqfcIy cbOw== X-Gm-Message-State: ANoB5pkdbzZlLRjIlULkj6gc4G+oMV/IwoKo/c0knsz3wjMTsBvXjMfj 3IXmYzX91/IDsCtS9OIKF/Mis4MBCKC5fj9c X-Google-Smtp-Source: AA0mqf6fD7udkKXTLCuuYfn8ayi0Sko0HEgJKyk6yvs/T89IbhgaA3YXC9aSLAcMFP35XZlk12KeSQ== X-Received: by 2002:a17:90a:2f62:b0:219:14b9:ac05 with SMTP id s89-20020a17090a2f6200b0021914b9ac05mr33972800pjd.175.1669959605010; Thu, 01 Dec 2022 21:40:05 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v3 05/34] tcg: Fix tcg_reg_alloc_dup* Date: Thu, 1 Dec 2022 21:39:29 -0800 Message-Id: <20221202053958.223890-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221202053958.223890-1-richard.henderson@linaro.org> References: <20221202053958.223890-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62b; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1669959791974100001 Content-Type: text/plain; charset="utf-8" The assignment to mem_coherent should be done with any modification, not simply with a newly allocated register. Signed-off-by: Richard Henderson --- tcg/tcg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index db64799e03..d1e91b8acc 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -3515,7 +3515,6 @@ static void tcg_reg_alloc_dup(TCGContext *s, const TC= GOp *op) ots->reg =3D tcg_reg_alloc(s, dup_out_regs, allocated_regs, op->output_pref[0], ots->indirect_base); ots->val_type =3D TEMP_VAL_REG; - ots->mem_coherent =3D 0; s->reg_to_temp[ots->reg] =3D ots; } =20 @@ -3569,6 +3568,7 @@ static void tcg_reg_alloc_dup(TCGContext *s, const TC= GOp *op) tcg_debug_assert(ok); =20 done: + ots->mem_coherent =3D 0; if (IS_DEAD_ARG(1)) { temp_dead(s, its); } @@ -3799,7 +3799,6 @@ static bool tcg_reg_alloc_dup2(TCGContext *s, const T= CGOp *op) ots->reg =3D tcg_reg_alloc(s, dup_out_regs, allocated_regs, op->output_pref[0], ots->indirect_base); ots->val_type =3D TEMP_VAL_REG; - ots->mem_coherent =3D 0; s->reg_to_temp[ots->reg] =3D ots; } =20 @@ -3843,6 +3842,7 @@ static bool tcg_reg_alloc_dup2(TCGContext *s, const T= CGOp *op) return false; =20 done: + ots->mem_coherent =3D 0; if (IS_DEAD_ARG(1)) { temp_dead(s, itsl); } --=20 2.34.1