From nobody Mon May 6 12:32:24 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1669890025; cv=none; d=zohomail.com; s=zohoarc; b=PZ5C77nZyhHmBEuM7guFYW2XiXrZwGVLpeM9Wol2yp0EOaHtnIrZNQjn46n4w5KF10zhrie0ECfxfSs9fm0Dt7uwFcCIoaNQGV305ZMoRjrkuGDADVF2YkRZi7Tcr4AVXstnj3c5G9eT+savnaNS4wLL2lvSIeEVNk2kRLXDJrs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1669890025; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=BxWdceZVkvMSao5c21nPBOAg8xKBEqGtd/xWk9Y1Z8k=; b=fecv18LTHqk+kc4H6hU4jFdUKVPuqiWDRX5+DKXuiIjTpa5vng3rxDPYFGhrca/QUl744rESRN7FUNmU5//tpZnj7HOoNOfcDGzDf/ZBwMzrVUqYg/+WwsPXZ1MmdsEM2TLtmms4Jh/sFdZZnqmiIP33liLfdpHDdD2/IDIjSLI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1669890025410851.874196588302; Thu, 1 Dec 2022 02:20:25 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-388-aRC0tze4N7SFWtIxDwbljQ-1; Thu, 01 Dec 2022 05:20:17 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8309B886063; Thu, 1 Dec 2022 10:20:14 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6ED841121314; Thu, 1 Dec 2022 10:20:14 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 2286419465B2; Thu, 1 Dec 2022 10:20:14 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 31CB719465A8 for ; Thu, 1 Dec 2022 10:20:01 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 415622166B2C; Thu, 1 Dec 2022 10:20:01 +0000 (UTC) Received: from virtlab420.virt.lab.eng.bos.redhat.com (virtlab420.virt.lab.eng.bos.redhat.com [10.19.152.148]) by smtp.corp.redhat.com (Postfix) with ESMTP id E6F572166BA5; Thu, 1 Dec 2022 10:20:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669890024; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=BxWdceZVkvMSao5c21nPBOAg8xKBEqGtd/xWk9Y1Z8k=; b=bNHYA8moF2i32UB722As37Bhy42WE8t3E8knYeeBWHxWhEW19cVycy/7PvudGa6kl3cD1b XUs3BnAIicm7JAl61drPE7hecNKTKbrjTaBxVpD+MVYCB8KTg4Rd8CzNYP6Us4pNjD5tD/ JWaSZS9RCl7LgcL67FqiJm/LcihB5hs= X-MC-Unique: aRC0tze4N7SFWtIxDwbljQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 1/3] block: mention 'password-secret' option for -iscsi Date: Thu, 1 Dec 2022 05:19:57 -0500 Message-Id: <20221201101959.419545-2-berrange@redhat.com> In-Reply-To: <20221201101959.419545-1-berrange@redhat.com> References: <20221201101959.419545-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, libvir-list@redhat.com, Peter Lieven , Hanna Reitz , Gerd Hoffmann , Ronnie Sahlberg , Paolo Bonzini Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1669890025738100001 The 'password-secret' option was added commit b189346eb1784df95ed6fed610411dbf23d19e1f Author: Daniel P. Berrang=C3=A9 Date: Thu Jan 21 14:19:21 2016 +0000 iscsi: add support for getting CHAP password via QCryptoSecret API but was not mentioned in the command line docs Signed-off-by: Daniel P. Berrang=C3=A9 --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 7f99d15b23..055df73306 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1889,7 +1889,7 @@ SRST ERST =20 DEF("iscsi", HAS_ARG, QEMU_OPTION_iscsi, - "-iscsi [user=3Duser][,password=3Dpassword]\n" + "-iscsi [user=3Duser][,password=3Dpassword],password-secret=3Dsecret-i= d]\n" " [,header-digest=3DCRC32C|CR32C-NONE|NONE-CRC32C|NONE\n" " [,initiator-name=3Dinitiator-iqn][,id=3Dtarget-iqn]\n" " [,timeout=3Dtimeout]\n" --=20 2.38.1 From nobody Mon May 6 12:32:24 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1669890023; cv=none; d=zohomail.com; s=zohoarc; b=WTOYzp6Zw55kikQFUqAwlnuTqz5H/GIywq3tlBsnqD6Nrx4fDw9X1wpSua4xfd4cYRp+dH3Vz1sJ8B8qEkSXMei/BDSKhhi3Hkg0U9wUeGL0ZtFyiRmNA05NGw7DeeBFSe3HV6gacXVgiEnl3QkpwwVk1fW6XBETpucg03dPIxU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1669890023; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=BPZJf5zp+vLhlwNhFFgRjX0pW2FfO0Ou2P4DPGMvnhA=; b=oLk0RUJizwSP8gEuUIOwB/FZHYeoHQ+FyfgHMN+ZznsOXUiSd1if/Kr1Xnfsxv+lZpeWkqrerucs27IM08AtLZk9lYBP7SaOn9BHii9RspLLn5RtFWiS1lS0XbjP9og6KfmsGyNNM9j9/tjtlBWd/w/JP7OSDIOA0iRDyuK+Dhg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1669890023456226.38045324007544; Thu, 1 Dec 2022 02:20:23 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-377--joDKjPdP4uar0NDdecCZA-1; Thu, 01 Dec 2022 05:20:19 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6A1A6101E9B2; Thu, 1 Dec 2022 10:20:15 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5466840C6EC4; Thu, 1 Dec 2022 10:20:15 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 7A10C1946A70; Thu, 1 Dec 2022 10:20:14 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 31D5A19465B1 for ; Thu, 1 Dec 2022 10:20:01 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 98ACE2166BA3; Thu, 1 Dec 2022 10:20:01 +0000 (UTC) Received: from virtlab420.virt.lab.eng.bos.redhat.com (virtlab420.virt.lab.eng.bos.redhat.com [10.19.152.148]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4897B2166B49; Thu, 1 Dec 2022 10:20:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669890022; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=BPZJf5zp+vLhlwNhFFgRjX0pW2FfO0Ou2P4DPGMvnhA=; b=PRV4oL5/ea5ACZTIq9/JgN36Bhj76SsPtAz33OsCF6qtwyPA2ZKL3eh4Y2lMa6wCx9rLnm pAYKSN86EYnlnvzogenhg/OSxoBX1U9YGN6HnrH4WjG/0I060HNFgXdNEVolEh6ZyiEu7i 2G0Xltox36pDXDni/U68G6RS2AZomEA= X-MC-Unique: -joDKjPdP4uar0NDdecCZA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 2/3] block: deprecate iSCSI 'password' in favour of 'password-secret' Date: Thu, 1 Dec 2022 05:19:58 -0500 Message-Id: <20221201101959.419545-3-berrange@redhat.com> In-Reply-To: <20221201101959.419545-1-berrange@redhat.com> References: <20221201101959.419545-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, libvir-list@redhat.com, Peter Lieven , Hanna Reitz , Gerd Hoffmann , Ronnie Sahlberg , Paolo Bonzini Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1669890023702100001 Support for referencing secret objects was added in commit b189346eb1784df95ed6fed610411dbf23d19e1f Author: Daniel P. Berrang=C3=A9 Date: Thu Jan 21 14:19:21 2016 +0000 iscsi: add support for getting CHAP password via QCryptoSecret API The existing 'password' option is overdue for deprecation and subsequent removal. Signed-off-by: Daniel P. Berrang=C3=A9 --- block/iscsi.c | 3 +++ docs/about/deprecated.rst | 11 +++++++++++ 2 files changed, 14 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index a316d46d96..58c0623052 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1352,6 +1352,9 @@ static void apply_chap(struct iscsi_context *iscsi, Q= emuOpts *opts, } else if (!password) { error_setg(errp, "CHAP username specified but no password was give= n"); return; + } else { + warn_report("iSCSI block driver 'password' option is deprecated, " + "use 'password-secret' instead"); } =20 if (iscsi_set_initiator_username_pwd(iscsi, user, password)) { diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 93affe3669..2cc8924fe9 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -267,6 +267,17 @@ Options are: - move backing file to NVDIMM storage and keep ``pmem=3Don`` (to have NVDIMM with persistence guaranties). =20 +Block driver options +-------------------- + +``iscsi,password=3Dxxx`` (since 8.0) +'''''''''''''''''''''''''''''''''' + +Specifying the iSCSI password in plain text on the command line using the +``password`` option is insecure. The ``password-secret`` option should be +used instead, to refer to a ``--object secret...`` instance that provides +a password via a file, or encrypted. + Device options -------------- =20 --=20 2.38.1 From nobody Mon May 6 12:32:24 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1669890025; cv=none; d=zohomail.com; s=zohoarc; b=LaDBvJYKfcCPaeWOZq/pg6GAY0HhzKJYRuyHSKW69LidNZCQrSL3dKjuVy9JEHaJGga8WIXnFRfDmSnQ7fsqhi7AkFNLfqwlj3SwQKKUmctbDhaRp8qwb8BmRno6IIYBXfyCtrg9L0ol/SU7ypOdt84STWxASoaNBC/1yD08AFU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1669890025; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+Kn+tNmmscq5cwH/JccS5h+jn40kG1PqnRKxOuC5oGU=; b=WqFaqvDHQnxb8YVEb+ga5qaEj+7DvqPp4eLBK0J86xE/tADSvH30og2yypE58soL7QAaWeo2bTWGHQovwhloWKXcBoN/hDoi3EmAhJH6WS8hPU1tdO/A3Tnu9AhRwa5YZY0iCFbf7d0XG5XfKrlZoeif0hVHMZzBNe5nTX7hmDQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1669890025764795.2207247228; Thu, 1 Dec 2022 02:20:25 -0800 (PST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-439-Im64wAzaMwyrSKTgYmUQ9Q-1; Thu, 01 Dec 2022 05:20:18 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7E7E13C0D86E; Thu, 1 Dec 2022 10:20:15 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6716640C845D; Thu, 1 Dec 2022 10:20:15 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 7E93D1946A78; Thu, 1 Dec 2022 10:20:14 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 322A219465B2 for ; Thu, 1 Dec 2022 10:20:02 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id EF4CD2166BAD; Thu, 1 Dec 2022 10:20:01 +0000 (UTC) Received: from virtlab420.virt.lab.eng.bos.redhat.com (virtlab420.virt.lab.eng.bos.redhat.com [10.19.152.148]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9F8C52166B49; Thu, 1 Dec 2022 10:20:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669890024; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=+Kn+tNmmscq5cwH/JccS5h+jn40kG1PqnRKxOuC5oGU=; b=Bzb49knSUh3PabpM1KzWxrxmj920KQpbFi9UIBGNW+jUJo9+Sfi7Mp0HezlnklRTLuAZ1G xpMaqQhtDhY7+bRFCqBIz2tnnM+H8r9pOHoil06xf+nwKS1sG3tKug5LDbEPokapDMQ0tn jfFJVhTtFlWqnMHpq6RyDgRcJ38XXn4= X-MC-Unique: Im64wAzaMwyrSKTgYmUQ9Q-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 3/3] ui: remove deprecated 'password' option for SPICE Date: Thu, 1 Dec 2022 05:19:59 -0500 Message-Id: <20221201101959.419545-4-berrange@redhat.com> In-Reply-To: <20221201101959.419545-1-berrange@redhat.com> References: <20221201101959.419545-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, libvir-list@redhat.com, Peter Lieven , Hanna Reitz , Gerd Hoffmann , Ronnie Sahlberg , Paolo Bonzini Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1669890027712100003 This has been replaced by the 'password-secret' option, which references a 'secret' object instance. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Markus Armbruster --- docs/about/deprecated.rst | 8 -------- docs/about/removed-features.rst | 7 +++++++ qemu-options.hx | 9 +-------- ui/spice-core.c | 15 --------------- 4 files changed, 8 insertions(+), 31 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 2cc8924fe9..ee4301f96d 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -73,14 +73,6 @@ Input parameters that take a size value should only use = a size suffix the value is hexadecimal. That is, '0x20M' is deprecated, and should be written either as '32M' or as '0x2000000'. =20 -``-spice password=3Dstring`` (since 6.0) -'''''''''''''''''''''''''''''''''''''' - -This option is insecure because the SPICE password remains visible in -the process listing. This is replaced by the new ``password-secret`` -option which lets the password be securely provided on the command -line using a ``secret`` object instance. - ``-smp`` ("parameter=3D0" SMP configurations) (since 6.2) ''''''''''''''''''''''''''''''''''''''''''''''''''''''' =20 diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.= rst index 63df9848fd..e04e095320 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -408,6 +408,13 @@ pcspk-audiodev=3D``. =20 Use ``-device`` instead. =20 +``-spice password=3Dstring`` (removed in 8.0) +''''''''''''''''''''''''''''''''''''''''''' + +This option is insecure because the SPICE password remains visible in +the process listing. This is replaced by the new ``password-secret`` +option which lets the password be securely provided on the command +line using a ``secret`` object instance. =20 QEMU Machine Protocol (QMP) commands ------------------------------------ diff --git a/qemu-options.hx b/qemu-options.hx index 055df73306..8a326f4dbb 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2132,7 +2132,7 @@ DEF("spice", HAS_ARG, QEMU_OPTION_spice, " [,tls-channel=3D[main|display|cursor|inputs|record|playback]]\= n" " [,plaintext-channel=3D[main|display|cursor|inputs|record|playb= ack]]\n" " [,sasl=3Don|off][,disable-ticketing=3Don|off]\n" - " [,password=3D][,password-secret=3D]\n" + " [,password-secret=3D]\n" " [,image-compression=3D[auto_glz|auto_lz|quic|glz|lz|off]]\n" " [,jpeg-wan-compression=3D[auto|never|always]]\n" " [,zlib-glz-wan-compression=3D[auto|never|always]]\n" @@ -2158,13 +2158,6 @@ SRST ``ipv4=3Don|off``; \ ``ipv6=3Don|off``; \ ``unix=3Don|off`` Force using the specified IP version. =20 - ``password=3D`` - Set the password you need to authenticate. - - This option is deprecated and insecure because it leaves the - password visible in the process listing. Use ``password-secret`` - instead. - ``password-secret=3D`` Set the ID of the ``secret`` object containing the password you need to authenticate. diff --git a/ui/spice-core.c b/ui/spice-core.c index c3ac20ad43..15fba68e31 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -413,9 +413,6 @@ static QemuOptsList qemu_spice_opts =3D { .name =3D "unix", .type =3D QEMU_OPT_BOOL, #endif - },{ - .name =3D "password", - .type =3D QEMU_OPT_STRING, },{ .name =3D "password-secret", .type =3D QEMU_OPT_STRING, @@ -671,20 +668,8 @@ static void qemu_spice_init(void) } passwordSecret =3D qemu_opt_get(opts, "password-secret"); if (passwordSecret) { - if (qemu_opt_get(opts, "password")) { - error_report("'password' option is mutually exclusive with " - "'password-secret'"); - exit(1); - } password =3D qcrypto_secret_lookup_as_utf8(passwordSecret, &error_fatal); - } else { - str =3D qemu_opt_get(opts, "password"); - if (str) { - warn_report("'password' option is deprecated and insecure, " - "use 'password-secret' instead"); - password =3D g_strdup(str); - } } =20 if (tls_port) { --=20 2.38.1