From nobody Thu May 2 09:41:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1669788034506416.74428850717743; Tue, 29 Nov 2022 22:00:34 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0G87-000699-99; Wed, 30 Nov 2022 00:59:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0G82-00068w-EP for qemu-devel@nongnu.org; Wed, 30 Nov 2022 00:59:31 -0500 Received: from [124.126.103.232] (helo=mailgw.kylinos.cn) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0G7y-00017m-Vb for qemu-devel@nongnu.org; Wed, 30 Nov 2022 00:59:29 -0500 Received: from localhost.localdomain [(116.128.244.169)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 702307408; Wed, 30 Nov 2022 13:54:02 +0800 X-UUID: 4b67dd9531db4257890c8bfaf0803694-20221130 X-CPASD-INFO: 1131c7cd861e4f3bb6d27664d017a6c2@eoFtUZBpkZRkVnOxg6l-nIJnlGJnYla DpmpRZ49mj1KVhH5xTV5nX1V9gnNXZF5dXFV3dnBQYmBhXVJ3i3-XblBgXoZgUZB3gHNtUZNlkw== X-CLOUD-ID: 1131c7cd861e4f3bb6d27664d017a6c2 X-CPASD-SUMMARY: SIP:-1, APTIP:-2.0, KEY:0.0, FROMBLOCK:1, OB:0.0, URL:-5, TVAL:180. 0, ESV:0.0, ECOM:-5.0, ML:0.0, FD:0.0, CUTS:74.0, IP:-2.0, MAL:-5.0, PHF:-5.0, PHC:-5. 0, SPF:4.0, EDMS:-5, IPLABEL:4480.0, FROMTO:1, AD:0, FFOB:0.0, CFOB:0.0, SPC:0, SIG:-5 , AUF:1, DUF:9498, ACD:157, DCD:157, SL:0, EISP:0, AG:0, CFC:0.428, CFSR:0.058, UAT:0, R AF:0, IMG:-5.0, DFA:0, DTA:0, IBL:-2.0, ADI:-5, SBL:0, REDM:0, REIP:0, ESB:0, ATTNUM:0, EAF:0,CID:-5.0,VERSION:2.3.17 X-CPASD-ID: 4b67dd9531db4257890c8bfaf0803694-20221130 X-CPASD-BLOCK: 1000 X-CPASD-STAGE: 1 X-UUID: 4b67dd9531db4257890c8bfaf0803694-20221130 X-User: leixiang@kylinos.cn From: leixiang To: leixiang@kylinos.cn Cc: mst@redhat.com, qemu-devel@nongnu.org, xieming@kylinos.cn, zengchi@kylinos.cn Subject: [RESEND PATCH] virtio-pci: fix vector_irqfd leak in virtio_pci_set_guest_notifiers Date: Wed, 30 Nov 2022 13:52:40 +0800 Message-Id: <20221130055240.1036842-1-leixiang@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220826030646.1003059-1-leixiang@kylinos.cn> References: <20220826030646.1003059-1-leixiang@kylinos.cn> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 124.126.103.232 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=124.126.103.232; envelope-from=leixiang@kylinos.cn; helo=mailgw.kylinos.cn X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1669788036443100003 Content-Type: text/plain; charset="utf-8" proxy->vector_irqfd did not free when set guest notifier failed. Signed-off-by: Lei Xiang Tested-by: Zeng Chi Suggested-by: Xie Ming --- hw/virtio/virtio-pci.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index c6b47a9c..4862f83b 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c @@ -1038,6 +1038,12 @@ assign_error: while (--n >=3D 0) { virtio_pci_set_guest_notifier(d, n, !assign, with_irqfd); } + + g_free(proxy->vector_irqfd); + proxy->vector_irqfd =3D NULL; + return r; } =20 --=20 No virus found Checked by Hillstone Network AntiVirus