From nobody Tue May 14 21:02:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1668706190; cv=none; d=zohomail.com; s=zohoarc; b=X7IF7O4bmxDYXouqKd7DRBxNTpJKlWY1Whs2NhOEmmMnwbyJQzcQTyqn43NpHOtAIAY08xVit4+96+K6h37LGw0E0CfOfgE/lbHcZeGo65gaOl+NfG9kymTXK/8tCown7xc8MZq9WwxdlcnwVqQbDSmW16jEgYdTCQh4MlQMU5w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668706190; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0janOlTSK9f2YU19w2PIDrRXkTKP3g2+mNpYWnPVHh4=; b=j5/WyMNc8dJrexEf6emsvXfaMFjyNQ5CFD7O0h5To2QPU5YYnpPRTh6U1kJrgWCFl0RPUq6G24m4X4VSggfobe0PkBqStjmxjKUUeEaazefxVaROmN1NpWKP2Hg2iLHj2UGaHmkMDpcQj4mstsB2PdIrxtpox1xM/n9bTz5dlYg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1668706190176999.9732623660112; Thu, 17 Nov 2022 09:29:50 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovieE-0006Ph-CQ; Thu, 17 Nov 2022 12:25:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovidu-0006HR-Me for qemu-devel@nongnu.org; Thu, 17 Nov 2022 12:25:40 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovidr-0006Dc-Vd for qemu-devel@nongnu.org; Thu, 17 Nov 2022 12:25:38 -0500 Received: by mail-wm1-x32a.google.com with SMTP id v124-20020a1cac82000000b003cf7a4ea2caso5624592wme.5 for ; Thu, 17 Nov 2022 09:25:35 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id q5-20020a5d61c5000000b002362f6fcaf5sm1543712wrv.48.2022.11.17.09.25.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 09:25:33 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id E7ED71FFB8; Thu, 17 Nov 2022 17:25:32 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0janOlTSK9f2YU19w2PIDrRXkTKP3g2+mNpYWnPVHh4=; b=Xj9r//p85ViHct1+SZq+cQ5mxkpNPgF/rQ8S4yad3+Arwpg1jwZTnUQEephsL6Ix01 9Ad02SwAc8A2Tijgqmo3QEs6EOslKvMGPc3PkqRjJ2yGwuLmtK144p5X63T4xzBANtSG dbfM7WPqf91PqtnQrTMVFU/7/jVJeKOOStX04Fjn2SM4fpLReFNpWqmrG8kWxRchc62S jVMdQK+JgX8MZf96T7Xcu7qrFFHiGpmbFGPDk7ZMiuPN1wdYDAHAkItXAwn9W8QshJU7 3Dxch5fQmO4+oFXYSBoyoRceGcbBGmQXFHZogPNvml9Tnhoih3sNZ6AiIiZmrjFRgPsb NQaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0janOlTSK9f2YU19w2PIDrRXkTKP3g2+mNpYWnPVHh4=; b=f+67+1nLhQD/MhSUiHzZV7wknR4rvOl1IXCBq7mXvYodvD7kEGMWWNMYlnPhwKxjPD maIRwkjrZvqIFDPEdHR0yqIcisuDoKTn2z3ckNh43LuG8+1xpYosAh2JYv7kRls70qpN FgpDI9R24XRTAXr+6YUqGbYADCEvR45ZgXQNaymUfHRd/UmrFWIe/V5xzk0w4yW48lXa 9ZmVTS4USjK+eauNlG1gCf7FXtfX2eEC/z6hjWsmPHL8rTxv10yX5WG2keYDlkHHRXoG hPrG+O2c6zbc1j230lW944NxvWrST6qoZxyoONpFc/WCsISai78arz8KZVhZoMuuTshn a4iQ== X-Gm-Message-State: ANoB5pma9dNUvyadbfH1OJ4vkXKGgBhedpccFKNlhAl8X9yNTCl9rJVd aehGeinp5TCbkvqS8U3LITsppA== X-Google-Smtp-Source: AA0mqf6QnVz51Fr6r+ZBaW7hW6fTQnyyhYhEbvvoMa+XhqIQQ6Be8Re/4GgRlw/GF+9G7jcxJjdKNg== X-Received: by 2002:a05:600c:15d6:b0:3cf:54a5:b7ee with SMTP id v22-20020a05600c15d600b003cf54a5b7eemr5949174wmf.106.1668705934111; Thu, 17 Nov 2022 09:25:34 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: fam@euphon.net, berrange@redhat.com, f4bug@amsat.org, aurelien@aurel32.net, pbonzini@redhat.com, stefanha@redhat.com, crosa@redhat.com, Stefan Weil , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Thomas Huth Subject: [PATCH v3 01/13] Run docker probe only if docker or podman are available Date: Thu, 17 Nov 2022 17:25:20 +0000 Message-Id: <20221117172532.538149-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221117172532.538149-1-alex.bennee@linaro.org> References: <20221117172532.538149-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1668706191287100003 From: Stefan Weil The docker probe uses "sudo -n" which can cause an e-mail with a security w= arning each time when configure is run. Therefore run docker probe only if either = docker or podman are available. That avoids the problematic "sudo -n" on build environments which have neit= her docker nor podman installed. Fixes: c4575b59155e2e00 ("configure: store container engine in config-host.= mak") Signed-off-by: Stefan Weil Message-Id: <20221030083510.310584-1-sw@weilnetz.de> Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Thomas Huth Message-Id: <20221111145529.4020801-2-alex.bennee@linaro.org> --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 66928692b0..26c7bc5154 100755 --- a/configure +++ b/configure @@ -1780,7 +1780,7 @@ fi # functions to probe cross compilers =20 container=3D"no" -if test $use_containers =3D "yes"; then +if test $use_containers =3D "yes" && (has "docker" || has "podman"); then case $($python "$source_path"/tests/docker/docker.py probe) in *docker) container=3Ddocker ;; podman) container=3Dpodman ;; --=20 2.34.1 From nobody Tue May 14 21:02:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1668705993; cv=none; d=zohomail.com; s=zohoarc; b=YGbRw5FNGKvSY07ol0T43mc11WK9fof/aUoMmak0SnKUqAnlUqG9PxmAHY6keS39OYE3AHu7fE+AkwqrTRSuYpq6WGsrxYa/0VFKDfVYE5jt7Ozuc39D3m3L89d/8d7Ng4gh4d0vf+GKRqxFxG2hIE2UoDwdExoaWjUNLvy6ijs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668705993; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=TUmxKKupzWW40b+PE4O2JXEtmFVLtKng4SrYWCxYHqo=; b=AVueaWd8XxaMZFXS/+RKFwfvXYulHaWmP9vomu4E/+j4kgNZ5HGf1KDEQ9ThXCgrLlr+hcrnjNkezWf3zp1moTjwREebvy9R5ZDKvIXVJK+fFGgyNX4lS8D0jtnON8klVK7qeEK43k3GKrVqFRhRJoFLBZBNsSAnRpDxrD1Uy7g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1668705993362900.1885257546633; Thu, 17 Nov 2022 09:26:33 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovieC-0006Nt-Ce; Thu, 17 Nov 2022 12:25:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovidu-0006HO-3l for qemu-devel@nongnu.org; Thu, 17 Nov 2022 12:25:38 -0500 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovidr-0006DU-CZ for qemu-devel@nongnu.org; Thu, 17 Nov 2022 12:25:37 -0500 Received: by mail-wr1-x429.google.com with SMTP id bs21so4977417wrb.4 for ; Thu, 17 Nov 2022 09:25:34 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id l24-20020a05600c1d1800b003cf878c4468sm7265846wms.5.2022.11.17.09.25.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 09:25:33 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 0A7BE1FFBA; Thu, 17 Nov 2022 17:25:33 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TUmxKKupzWW40b+PE4O2JXEtmFVLtKng4SrYWCxYHqo=; b=DegIAvdQiHWEZQiTfemoqQ0Gpyp1faaDm5g7reLzxrMBiKw0AoB277uXcEqjInqJnt L+En6UpTlL+kbZbkyI522UBzi+GXmzcQ4DpD3st3iyzse2JyLd02xIBKGDUsrBOHm/J/ I/KMdNthDw4JiCVaQ1JrnJ27XI7gMzlaTmFxnSeMaecO2tzJsimmAg0NVgK9aHYx1XGJ 89IvG+8rOg5OcOat1TbyIiW/W5Nmu4j4C6ax953gHLo8os8mnEX42vShbJ5cZqUBwzHk 9vnIeaMOyQ6BfD5RwFOL5Z6czCcATF+KS2f+dM9SeALD/RZ34AieA2n9tDlB5ZqPM8y7 fivA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TUmxKKupzWW40b+PE4O2JXEtmFVLtKng4SrYWCxYHqo=; b=BPCS9upQkf/CVhOK8WZfLAZ7XTVdM26rQ2/jNYBQeK1vSTPuDC+r96YQ6Yg1ysMaZa eoyqR3NCpER8JhFyIzr5lzqyZTusF267E/0skv1men+euHddyi6J4VOrdR4bZWAZNl5S p+qCw6m9RcknfmZTihH+LLqCmmD6KkRXUHJRIF8pEDOD9lp4g6TZpYgM7jZ3d8ZqwikP PLeGpLM81h90Dxnq9QWv7/MROgabsHhV6HFEPFLMGDgsFaFadQn0IL07Bmg6ioibdvfe 3N0KhI251xB1+WfIHQQaKUipJcEm4PRJJBssnxKBEetijkz1J8qx05LHh7fZsWbr/4by 2zsA== X-Gm-Message-State: ANoB5pldWtBP9PlzQjVpCe+UdkyOkzxwjldqWI5a9diVGqnNAX7K+fSA nwbWXgAyprOV1DyMSs1kJjz2JA== X-Google-Smtp-Source: AA0mqf4YxERPpTjonbWiWPFiKw8CfDWDHgirNOPOL2lqCsi9KUFVLFtVzNsho/yJuwByOLM1fCeDIw== X-Received: by 2002:a5d:4c4d:0:b0:235:25b7:5084 with SMTP id n13-20020a5d4c4d000000b0023525b75084mr2119232wrt.135.1668705933801; Thu, 17 Nov 2022 09:25:33 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: fam@euphon.net, berrange@redhat.com, f4bug@amsat.org, aurelien@aurel32.net, pbonzini@redhat.com, stefanha@redhat.com, crosa@redhat.com, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Wainer dos Santos Moschetta , Beraldo Leal Subject: [PATCH v3 02/13] tests/avocado/machine_aspeed.py: Reduce noise on the console for SDK tests Date: Thu, 17 Nov 2022 17:25:21 +0000 Message-Id: <20221117172532.538149-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221117172532.538149-1-alex.bennee@linaro.org> References: <20221117172532.538149-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1668705993984100001 From: C=C3=A9dric Le Goater The Aspeed SDK images are based on OpenBMC which starts a lot of services. The output noise on the console can break from time to time the test waiting for the logging prompt. Change the U-Boot bootargs variable to add "quiet" to the kernel command line and reduce the output volume. This also drops the test on the CPU id which was nice to have but not essential. Signed-off-by: C=C3=A9dric Le Goater Message-Id: <20221104075347.370503-1-clg@kaod.org> Signed-off-by: Alex Benn=C3=A9e Message-Id: <20221111145529.4020801-4-alex.bennee@linaro.org> --- tests/avocado/machine_aspeed.py | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/tests/avocado/machine_aspeed.py b/tests/avocado/machine_aspeed= .py index fba6527026..1fc385e1c8 100644 --- a/tests/avocado/machine_aspeed.py +++ b/tests/avocado/machine_aspeed.py @@ -12,6 +12,7 @@ from avocado_qemu import wait_for_console_pattern from avocado_qemu import exec_command from avocado_qemu import exec_command_and_wait_for_pattern +from avocado_qemu import interrupt_interactive_console_until_pattern from avocado.utils import archive from avocado import skipIf =20 @@ -182,6 +183,8 @@ def test_arm_ast2600_evb_buildroot(self): =20 class AST2x00MachineSDK(QemuSystemTest): =20 + EXTRA_BOOTARGS =3D ' quiet' + # FIXME: Although these tests boot a whole distro they are still # slower than comparable machine models. There may be some # optimisations which bring down the runtime. In the meantime they @@ -194,7 +197,7 @@ def wait_for_console_pattern(self, success_message, vm= =3DNone): failure_message=3D'Kernel panic - not syn= cing', vm=3Dvm) =20 - def do_test_arm_aspeed_sdk_start(self, image, cpu_id): + def do_test_arm_aspeed_sdk_start(self, image): self.require_netdev('user') self.vm.set_console() self.vm.add_args('-drive', 'file=3D' + image + ',if=3Dmtd,format= =3Draw', @@ -202,9 +205,13 @@ def do_test_arm_aspeed_sdk_start(self, image, cpu_id): self.vm.launch() =20 self.wait_for_console_pattern('U-Boot 2019.04') - self.wait_for_console_pattern('## Loading kernel from FIT Image') + interrupt_interactive_console_until_pattern( + self, 'Hit any key to stop autoboot:', 'ast#') + exec_command_and_wait_for_pattern( + self, 'setenv bootargs ${bootargs}' + self.EXTRA_BOOTARGS, 'as= t#') + exec_command_and_wait_for_pattern( + self, 'boot', '## Loading kernel from FIT Image') self.wait_for_console_pattern('Starting kernel ...') - self.wait_for_console_pattern('Booting Linux on physical CPU ' + c= pu_id) =20 @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') def test_arm_ast2500_evb_sdk(self): @@ -221,7 +228,7 @@ def test_arm_ast2500_evb_sdk(self): archive.extract(image_path, self.workdir) =20 self.do_test_arm_aspeed_sdk_start( - self.workdir + '/ast2500-default/image-bmc', '0x0') + self.workdir + '/ast2500-default/image-bmc') self.wait_for_console_pattern('ast2500-default login:') =20 @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') @@ -243,7 +250,7 @@ def test_arm_ast2600_evb_sdk(self): self.vm.add_args('-device', 'ds1338,bus=3Daspeed.i2c.bus.5,address=3D0x32'); self.do_test_arm_aspeed_sdk_start( - self.workdir + '/ast2600-default/image-bmc', '0xf00') + self.workdir + '/ast2600-default/image-bmc') self.wait_for_console_pattern('ast2600-default login:') exec_command_and_wait_for_pattern(self, 'root', 'Password:') exec_command_and_wait_for_pattern(self, '0penBmc', 'root@ast2600-d= efault:~#') --=20 2.34.1 From nobody Tue May 14 21:02:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1668706143; cv=none; d=zohomail.com; s=zohoarc; b=nntcS7EbyLqEblOdUdtcuCDgBTVBncXnv/68jl1vGVi+OzxVxgZVz89qReqSv3orekaJiRl/8k0R4zNomKVhtysqvVaYdpJglIkn1qVbCCYcgWgzTlIlDn99OL8YTqrGZfbDxbf4dwtY/MHW45ZvsUZRrKVbIoaqU8CsL0UicaA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668706143; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hCWUi2imTcF7NdRj0zJ1YkRrLEYeaUzgFlh+Cacz5b8=; b=SCNUJ8edH3CzB0at87507DoUCdYktS8uI7HL0VmsK+aYpBACEPaseX9WQRLfOE1+TLxnRv3csgz84oXCZZgFqzQ+UFVwUHNOL1m3hnEvtWyjiaKXM7KrFhIFZbbEoOPSHS50Ikudicpqljcu0bLV4qGl01SuiCrHqL8weG0pSUU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1668706143138713.8928797685971; Thu, 17 Nov 2022 09:29:03 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovieE-0006Pg-94; Thu, 17 Nov 2022 12:25:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovie5-0006LX-4P for qemu-devel@nongnu.org; Thu, 17 Nov 2022 12:25:49 -0500 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovidt-0006Dp-St for qemu-devel@nongnu.org; Thu, 17 Nov 2022 12:25:48 -0500 Received: by mail-wr1-x42b.google.com with SMTP id a14so5004094wru.5 for ; Thu, 17 Nov 2022 09:25:37 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id 23-20020a05600c229700b003cf75213bb9sm6084440wmf.8.2022.11.17.09.25.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 09:25:33 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 231A91FFBB; Thu, 17 Nov 2022 17:25:33 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hCWUi2imTcF7NdRj0zJ1YkRrLEYeaUzgFlh+Cacz5b8=; b=WVB7VvZyOVYZY+RFjsC/MI5GSCK343nuKrVag8qRuoikhe1LnQmKF+JvNSvPXXfDdo smIyDbAsWluB1kbgi7jRli1v3884lcx5RFft79v/jHQ4pI2lSs1JeUAZ449lfoUIlpcg RYInTVUKYwuq+ClNxFXy4rbzoQDpScwQrqfaMaxsY0nN4corUuT8I1DBLJzi7M1Neme6 /Y4PgxrSAnzbZ0xZApigaUScuZn4bRnM3Zj/XRHaM/Byb2+njJ88xZfPgi+dClVHwWyG VA92oxK2aHOs3uAAh+OeuxjrwM8JAtXNbYA6/Z7q7cu+dRKvYTbwwFcSWeWcxKmwNfRG TQng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hCWUi2imTcF7NdRj0zJ1YkRrLEYeaUzgFlh+Cacz5b8=; b=avnMSTY2zikQ1/deGP2EtlrQaqMp1S7WaSV8goOrWB1lxcj2cZzo3Zaxv9iMddpj6R UhDvi+Uvsfbwwb/CN727ZNgQ3xv1IJe0Ls54tPWMG5fZA9PkE9txlJzKchluqE9wLHOG eLr7FL3ovx1dMp5LeFpg7X/nDdmv4+9DyrWJXnwW4VsbEV6gtFTAqNFNhghafzKpS1UD Idhrbz0rVDweT94kr0cSmlYKBE9Rwbwgywgm0J3pAKkEvk9DZaxPX8O7HaHm7BKHWPAw 8AriQHgRNokuhCL7PsJn8llrhbpJJn5QMxZfb/jvP5pk6XiNB2vr6ZzNh1/+rMOCVZ85 z5/g== X-Gm-Message-State: ANoB5pkA4VcFFop//UtjEx4zeWQq2NzBH7yIFHukR9x4OOd6740BIQK1 sW1ykKtT8aQYhvyp/xCh5ALoWg== X-Google-Smtp-Source: AA0mqf7K8YRq/K1q4hgFKaeLkI83c8ib0dMUFLmRNZ+ASHmhjC62or8SWFcemTym6Jp4COJrw/pbQQ== X-Received: by 2002:a05:6000:10c3:b0:241:bee0:c56e with SMTP id b3-20020a05600010c300b00241bee0c56emr304205wrx.534.1668705935297; Thu, 17 Nov 2022 09:25:35 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: fam@euphon.net, berrange@redhat.com, f4bug@amsat.org, aurelien@aurel32.net, pbonzini@redhat.com, stefanha@redhat.com, crosa@redhat.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth , Wainer dos Santos Moschetta , Beraldo Leal Subject: [PATCH v3 03/13] tests/docker: allow user to override check target Date: Thu, 17 Nov 2022 17:25:22 +0000 Message-Id: <20221117172532.538149-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221117172532.538149-1-alex.bennee@linaro.org> References: <20221117172532.538149-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1668706144937100003 This is useful when trying to bisect a particular failing test behind a docker run. For example: make docker-test-clang@fedora \ TARGET_LIST=3Darm-softmmu \ TEST_COMMAND=3D"meson test qtest-arm/qos-test" \ J=3D9 V=3D1 Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20221111145529.4020801-5-alex.bennee@linaro.org> --- tests/docker/Makefile.include | 2 ++ tests/docker/common.rc | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index c87f14477a..fc7a3b7e71 100644 --- a/tests/docker/Makefile.include +++ b/tests/docker/Makefile.include @@ -184,6 +184,7 @@ docker: @echo ' TARGET_LIST=3Da,b,c Override target list in builds.' @echo ' EXTRA_CONFIGURE_OPTS=3D"..."' @echo ' Extra configure options.' + @echo ' TEST_COMMAND=3D"..." Override the default `make check` targe= t.' @echo ' IMAGES=3D"a b c ..": Restrict available images to subset.' @echo ' TESTS=3D"x y z .." Restrict available tests to subset.' @echo ' J=3D[0..9]* Overrides the -jN parameter for make co= mmands' @@ -230,6 +231,7 @@ docker-run: docker-qemu-src $(if $(NETWORK),$(if $(subst $(NETWORK),,1),--net=3D$(NETWORK)),--net= =3Dnone) \ -e TARGET_LIST=3D$(subst $(SPACE),$(COMMA),$(TARGET_LIST)) \ -e EXTRA_CONFIGURE_OPTS=3D"$(EXTRA_CONFIGURE_OPTS)" \ + -e TEST_COMMAND=3D"$(TEST_COMMAND)" \ -e V=3D$V -e J=3D$J -e DEBUG=3D$(DEBUG) \ -e SHOW_ENV=3D$(SHOW_ENV) \ $(if $(NOUSER),, \ diff --git a/tests/docker/common.rc b/tests/docker/common.rc index e6f8cee0d6..9a33df2832 100755 --- a/tests/docker/common.rc +++ b/tests/docker/common.rc @@ -63,12 +63,12 @@ check_qemu() { # default to make check unless the caller specifies if [ $# =3D 0 ]; then - INVOCATION=3D"check" + INVOCATION=3D"${TEST_COMMAND:-make $MAKEFLAGS check}" else - INVOCATION=3D"$@" + INVOCATION=3D"make $MAKEFLAGS $@" fi =20 - make $MAKEFLAGS $INVOCATION + $INVOCATION } =20 test_fail() --=20 2.34.1 From nobody Tue May 14 21:02:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1668706133; cv=none; d=zohomail.com; s=zohoarc; b=gJVEaVk0ilU812aC/nYke5eVkEWbsZQXy7VFk4JpNjCLiVVm2nbPrL01HmLnqaMd5J9jwfdBbpnj+WZBAL1whvYgRRTzQdC2DTj+f2JhKPdkbIi8MjLQnhim/7peFHir2t7ofd8cxToekrtLBOkn8d6w4/62XXxUVMhARMU9lfE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668706133; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DfPQ6iqjiMv5CIUl9rrkSxsv2TCIqblfNK7K93d8LNw=; b=In705DIHiuE9HPGIAHS8Owi6Mr31QBtn8T/BozlfiC4uE6miM9a69m4gnJZutfFEnHI1zWGPdr14BGLymuKsw5vMewvSUjXjjIjsJ+zzgvApSnjWLm6hzBsk8buYrtr/6hFxK02oM9N7M6Y8d0ZVcwt7FiVurZZwNcb/EBRjRmo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1668706133137733.4908965411893; Thu, 17 Nov 2022 09:28:53 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovieF-0006Qb-6F; Thu, 17 Nov 2022 12:25:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovie2-0006KU-BZ for qemu-devel@nongnu.org; Thu, 17 Nov 2022 12:25:47 -0500 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovidw-0006Dt-Ao for qemu-devel@nongnu.org; Thu, 17 Nov 2022 12:25:42 -0500 Received: by mail-wm1-x334.google.com with SMTP id c65-20020a1c3544000000b003cfffd00fc0so1646811wma.1 for ; Thu, 17 Nov 2022 09:25:39 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id b14-20020a5d4d8e000000b0022cbf4cda62sm1754578wru.27.2022.11.17.09.25.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 09:25:34 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 410331FFBC; Thu, 17 Nov 2022 17:25:33 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DfPQ6iqjiMv5CIUl9rrkSxsv2TCIqblfNK7K93d8LNw=; b=GiX+HdQ8ICAOH0wbyGJdP+LITz50WYFdYyecRJchGoeEuyq3rFSOS48SGitfN+1tIT qzNYlm8u7ciKvWM5xXC33HBOkfbNgi5BG52IZzHCmgTIn3CCofSIM8E/2ZLwFp1vAkiZ yjorQOqwwE2NMrHh3YMzxIat0PEfyOwRsyrBzrV6TXJRSmQKcwAXQ4otgT7cofauDDNS Vv6cfviLfK+AHXXdISGOhInnMpu9IfQK6MpH+RukPmkPszNEJC8ZOwnfER/iRjvvjWR1 DL12IWBEAjWz2w09p47+eS0BDpqLnerbWjvLf+wnvXMrEIGP43lqEwZ2U4B68rnlYiZD V8XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DfPQ6iqjiMv5CIUl9rrkSxsv2TCIqblfNK7K93d8LNw=; b=hHL49sB5d3b9B4P37yR0U6wFfaLfHvyW+H8uDCb61tbcQcLDN6AiqCTDyUagMnyxHP m4S4lUYoO9x5W1N647eP821IfIgcasmZ1hXRT42R3l231rwSxERucW03DVDfK7gqLvUQ a6meXjglgI/jaHguts2Bd4A3uklkW0NdLhJGdReiEG276JKI/Y0mkF5IGuf7G5bLMOsg APUe3skeOcQy4SuZG5FeVdo3Ii8fGU4QwZw3EwM96Ynfpb+/ZQy4wPE4nurQfOb/qLHC 1fsgzuqL3pevyH71dM5bhVb3A6GPMkSzfVyLuVX26/tCPOQd7jHIRSTi0YlTpRcIgyqf qudQ== X-Gm-Message-State: ANoB5pnDKwz75E/zUtyx4Hs8YQ/oHkqItdevlJOkBfK8TBgP/S8DUUY3 pDRDzzRE27pUvtnfJY+zrT/f2w== X-Google-Smtp-Source: AA0mqf50T+Ix7WDqwsPNbB/mCWrHL05GAAy5RZfJpHW0QOjnbkB/n+VENp7Fnq6nTtd/dz0w8rf0MA== X-Received: by 2002:a05:600c:1603:b0:3cf:8279:c80c with SMTP id m3-20020a05600c160300b003cf8279c80cmr2427444wmn.169.1668705936154; Thu, 17 Nov 2022 09:25:36 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: fam@euphon.net, berrange@redhat.com, f4bug@amsat.org, aurelien@aurel32.net, pbonzini@redhat.com, stefanha@redhat.com, crosa@redhat.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PATCH v3 04/13] docs/devel: add a maintainers section to development process Date: Thu, 17 Nov 2022 17:25:23 +0000 Message-Id: <20221117172532.538149-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221117172532.538149-1-alex.bennee@linaro.org> References: <20221117172532.538149-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1668706134870100003 We don't currently have a clear place in the documentation to describe the roles and responsibilities of a maintainer. Lets create one so we can. I've moved a few small bits out of other files to try and keep everything in one place. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini Message-Id: <20221111145529.4020801-6-alex.bennee@linaro.org> Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- docs/devel/code-of-conduct.rst | 2 + docs/devel/index-process.rst | 1 + docs/devel/maintainers.rst | 106 +++++++++++++++++++++++ docs/devel/submitting-a-pull-request.rst | 12 +-- 4 files changed, 113 insertions(+), 8 deletions(-) create mode 100644 docs/devel/maintainers.rst diff --git a/docs/devel/code-of-conduct.rst b/docs/devel/code-of-conduct.rst index 195444d1b4..f734ed0317 100644 --- a/docs/devel/code-of-conduct.rst +++ b/docs/devel/code-of-conduct.rst @@ -1,3 +1,5 @@ +.. _code_of_conduct: + Code of Conduct =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 diff --git a/docs/devel/index-process.rst b/docs/devel/index-process.rst index d0d7a200fd..d50dd74c3e 100644 --- a/docs/devel/index-process.rst +++ b/docs/devel/index-process.rst @@ -8,6 +8,7 @@ Notes about how to interact with the community and how and = where to submit patch =20 code-of-conduct conflict-resolution + maintainers style submitting-a-patch trivial-patches diff --git a/docs/devel/maintainers.rst b/docs/devel/maintainers.rst new file mode 100644 index 0000000000..05110909d1 --- /dev/null +++ b/docs/devel/maintainers.rst @@ -0,0 +1,106 @@ +.. _maintainers: + +The Role of Maintainers +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D + +Maintainers are a critical part of the project's contributor ecosystem. +They come from a wide range of backgrounds from unpaid hobbyists +working in their spare time to employees who work on the project as +part of their job. Maintainer activities include: + + - reviewing patches and suggesting changes + - collecting patches and preparing pull requests + - tending to the long term health of their area + - participating in other project activities + +They are also human and subject to the same pressures as everyone else +including overload and burnout. Like everyone else they are subject +to project's :ref:`code_of_conduct` and should also be exemplars of +excellent community collaborators. + +The MAINTAINERS file +-------------------- + +The `MAINTAINERS +`__ +file contains the canonical list of who is a maintainer. The file +is machine readable so an appropriately configured git (see +:ref:`cc_the_relevant_maintainer`) can automatically Cc them on +patches that touch their area of code. + +The file also describes the status of the area of code to give an idea +of how actively that section is maintained. + +.. list-table:: Meaning of support status in MAINTAINERS + :widths: 25 75 + :header-rows: 1 + + * - Status + - Meaning + * - Supported + - Someone is actually paid to look after this. + * - Maintained + - Someone actually looks after it. + * - Odd Fixes + - It has a maintainer but they don't have time to do + much other than throw the odd patch in. + * - Orphan + - No current maintainer. + * - Obsolete + - Old obsolete code, should use something else. + +Please bear in mind that even if someone is paid to support something +it does not mean they are paid to support you. This is open source and +the code comes with no warranty and the project makes no guarantees +about dealing with bugs or features requests. + + + +Becoming a reviewer +------------------- + +Most maintainers start by becoming subsystem reviewers. While anyone +is welcome to review code on the mailing list getting added to the +MAINTAINERS file with a line like:: + + R: Random Hacker + +will ensure that patches touching a given subsystem will automatically +be CC'd to you. + +Becoming a maintainer +--------------------- + +Maintainers are volunteers who put themselves forward or have been +asked by others to keep an eye on an area of code. They have generally +demonstrated to the community, usually via contributions and code +reviews, that they have a good understanding of the subsystem. They +are also trusted to make a positive contribution to the project and +work well with the other contributors. + +The process is simple - simply send a patch to the list that updates +the ``MAINTAINERS`` file. Sometimes this is done as part of a larger +series when a new sub-system is being added to the code base. This can +also be done by a retiring maintainer who nominates their replacement +after discussion with other contributors. + +Once the patch is reviewed and merged the only other step is to make +sure your GPG key is signed. + +.. _maintainer_keys: + +Maintainer GPG Keys +~~~~~~~~~~~~~~~~~~~ + +GPG is used to sign pull requests so they can be identified as really +coming from the maintainer. If your key is not already signed by +members of the QEMU community, you should make arrangements to attend +a `KeySigningParty `__ (for +example at KVM Forum) or make alternative arrangements to have your +key signed by an attendee. Key signing requires meeting another +community member **in person** [#]_ so please make appropriate +arrangements. + +.. [#] In recent pandemic times we have had to exercise some + flexibility here. Maintainers still need to sign their pull + requests though. diff --git a/docs/devel/submitting-a-pull-request.rst b/docs/devel/submitti= ng-a-pull-request.rst index c9d1e8afd9..a4cd7ebbb6 100644 --- a/docs/devel/submitting-a-pull-request.rst +++ b/docs/devel/submitting-a-pull-request.rst @@ -53,14 +53,10 @@ series) and that "make check" passes before sending out= the pull request. As a submaintainer you're one of QEMU's lines of defense against bad code, so double check the details. =20 -**All pull requests must be signed**. If your key is not already signed -by members of the QEMU community, you should make arrangements to attend -a `KeySigningParty `__ (for -example at KVM Forum) or make alternative arrangements to have your key -signed by an attendee. Key signing requires meeting another community -member \*in person\* so please make appropriate arrangements. By -"signed" here we mean that the pullreq email should quote a tag which is -a GPG-signed tag (as created with 'gpg tag -s ...'). +**All pull requests must be signed**. By "signed" here we mean that +the pullreq email should quote a tag which is a GPG-signed tag (as +created with 'gpg tag -s ...'). See :ref:`maintainer_keys` for +details. =20 **Pull requests not for master should say "not for master" and have "PULL SUBSYSTEM whatever" in the subject tag**. If your pull request is --=20 2.34.1 From nobody Tue May 14 21:02:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1668706027; cv=none; d=zohomail.com; s=zohoarc; b=PB+PWxUcGZqB2fekv3qYHiu+NewgFRgXCMv/v374aKvOns0w3yYGZtQYJS4juOXvPI6u+omIBmw8MEKEOfJ9Fj01cjHqzDC0JCQXDwmjuavrvqaiEWBQfTGLuDjdUQP5lGZHSUUCC4xsP5dHrPAxZcQp8DVaPV1AdtfkRcZ4cBY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668706027; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=tqH/LJ8p6IB5IgfabSHUA1BeTb2LXLwtHowvhXmA9sY=; b=NOnmw62MjjOW63wgpcvlym4nrYajulQYfyvrHZaFSdhr6lFCzm1p3fcCQb4r0tavIb3P05g6FxM9q4mhCjdiuCt4yV0OlToRzZAymybTyyCVaAV/9xExF1LJ42Qyk5bkgAwYw0UqlOHk7QWroFu3aplcnmp7T3rU+ijpgWotfbU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1668706027137947.8384603265171; Thu, 17 Nov 2022 09:27:07 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovieF-0006Qa-60; Thu, 17 Nov 2022 12:25:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovidw-0006Hm-Ht for qemu-devel@nongnu.org; Thu, 17 Nov 2022 12:25:42 -0500 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovidu-0006E1-RI for qemu-devel@nongnu.org; Thu, 17 Nov 2022 12:25:40 -0500 Received: by mail-wm1-x334.google.com with SMTP id ay14-20020a05600c1e0e00b003cf6ab34b61so5640244wmb.2 for ; Thu, 17 Nov 2022 09:25:38 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id q5-20020a5d61c5000000b002362f6fcaf5sm1543746wrv.48.2022.11.17.09.25.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 09:25:35 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 579C61FFBD; Thu, 17 Nov 2022 17:25:33 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tqH/LJ8p6IB5IgfabSHUA1BeTb2LXLwtHowvhXmA9sY=; b=cAwayni7W2Reiyq1nU2mig5YDDVjYgCQiYSm3bY7mBuktSZPTvRg4y1AaC7DGioKzK WV8aZz8omzIFVFVnK0fgsJr4781hhvQfLOTWHRXmplqELWslFl53Ii7T+ioLRQtq+qBq HQ+HeYK2TZ8tmuJXKiWX7ENgnYm8jY/2EZwlyrfb6mdpiuk8nJ5Psy/2ankF1G9Bi8hl v77MRw0w/8DWtsTbyV6Knj4LFGIJy9Qfdgby+dGpUR/HrGglEEK91vUklO0wIOz2ufWA lTb8m1SWkBak94a2Bt9z2n3lqzfCG1k/hPIC0ch+qGcwMI7CxIQoIKWhX2hRWFCbZK3u Cw0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tqH/LJ8p6IB5IgfabSHUA1BeTb2LXLwtHowvhXmA9sY=; b=fEqQz0xgEvT6vpxW5pUpuI5hNdPHuGW/AQJ4wGvDK8bEkizp/w+y0ArHM/ImhVByuz rn7xkhtBgoVNAxxCxQU5UCk0/EthlGpj8RDJItiorf4L9WZTX1yevPT/ZocS9M7id2sK v5rRIu/gjUNyeD1h7vi6OO+Jp7G8hxBoLdFgv8lXUng1UUKXCW/tx4wL+NbSIoW8lf51 7l5gUVM8A0ZvzBY80iuhw8rgpREuxof+xOHKXJdUeRS4HjrAz3sP5ccvMl3BELsIUoHE Cr6CCixh0e+/o9itDj+1QdpUE+9zabwpPZJcOg6+nQx9+U6jCAN5r7/svrGQLJyg4+sp ezpA== X-Gm-Message-State: ANoB5pmY/3ZrVIDr7spNNWCw1mnCuBn06INyV+FgbvJ2jP18CdgYgcuJ ClVgcCntJt9YrayjMmqzIRlvkg== X-Google-Smtp-Source: AA0mqf6ALdOURewTTGYyEvtxLK86qiLjP4P5PqKO1lVRufYO2gv0CyhNQh5g/jERZIgG3LeH0i1ShA== X-Received: by 2002:a1c:1907:0:b0:3cf:91fe:25a2 with SMTP id 7-20020a1c1907000000b003cf91fe25a2mr5930378wmz.69.1668705937184; Thu, 17 Nov 2022 09:25:37 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: fam@euphon.net, berrange@redhat.com, f4bug@amsat.org, aurelien@aurel32.net, pbonzini@redhat.com, stefanha@redhat.com, crosa@redhat.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PATCH v3 05/13] docs/devel: make language a little less code centric Date: Thu, 17 Nov 2022 17:25:24 +0000 Message-Id: <20221117172532.538149-6-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221117172532.538149-1-alex.bennee@linaro.org> References: <20221117172532.538149-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1668706028170100003 We welcome all sorts of patches. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini Message-Id: <20221111145529.4020801-7-alex.bennee@linaro.org> Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- docs/devel/submitting-a-patch.rst | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/devel/submitting-a-patch.rst b/docs/devel/submitting-a-pa= tch.rst index fec33ce148..9c7c4331f3 100644 --- a/docs/devel/submitting-a-patch.rst +++ b/docs/devel/submitting-a-patch.rst @@ -3,11 +3,11 @@ Submitting a Patch =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 -QEMU welcomes contributions of code (either fixing bugs or adding new -functionality). However, we get a lot of patches, and so we have some -guidelines about submitting patches. If you follow these, you'll help -make our task of code review easier and your patch is likely to be -committed faster. +QEMU welcomes contributions to fix bugs, add functionality or improve +the documentation. However, we get a lot of patches, and so we have +some guidelines about submitting them. If you follow these, you'll +help make our task of code review easier and your patch is likely to +be committed faster. =20 This page seems very long, so if you are only trying to post a quick one-shot fix, the bare minimum we ask is that: --=20 2.34.1 From nobody Tue May 14 21:02:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1668706213; cv=none; d=zohomail.com; s=zohoarc; b=Hr+UxNQkTyaume5epwNbKE4ozNAHZiuSm5hP8znHBNnFAfg5jo0lfDqFA3Y1eisrKUQYCdzJtAIloDCWaZizDNx2CXsymW0VeiJ2Ta0pCofLsvtIjx016iKZAu4SNaUXRBAQspukgLKgMe3AkTTfd6ko6q2pIsUlRUfUa90S+kU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668706213; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7dn3LYPsrO5MbYIeyGRbprma5QBVCnZAiF7XUQjrkFs=; b=ZYXZQOPpvyuxs3gGPwPKKqmijxTLSLMfwWvnyf6/OfhyiM5viwiPScnTUF3kb7oW68vFKOfIKLFtPSgvV+rMg6pASzPSHkcc3HMCImb3TstTFwFmyijFaVosZGCR6/qvC1kXpXCmj8OTno05NqM0r6OREcYoFK5PukihGhit740= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1668706213176907.3901824736349; Thu, 17 Nov 2022 09:30:13 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovieD-0006PL-De; Thu, 17 Nov 2022 12:25:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovie2-0006KX-Ct for qemu-devel@nongnu.org; Thu, 17 Nov 2022 12:25:47 -0500 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovidw-0006ED-BI for qemu-devel@nongnu.org; Thu, 17 Nov 2022 12:25:43 -0500 Received: by mail-wm1-x333.google.com with SMTP id i186-20020a1c3bc3000000b003cfe29a5733so5626173wma.3 for ; Thu, 17 Nov 2022 09:25:39 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id d5-20020adffbc5000000b002417e7f0685sm1798388wrs.9.2022.11.17.09.25.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 09:25:35 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 707CB1FFBE; Thu, 17 Nov 2022 17:25:33 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7dn3LYPsrO5MbYIeyGRbprma5QBVCnZAiF7XUQjrkFs=; b=pcGoj9oWj8iaNBySHG7ylm7ymDRkm8WhOsUWj8R8twOBzx1uO6W5KAGZ+vDJBLn0rK LWMu+lfP/sw45YHGphUw9a0/ex1LAFGI2rNaW0irAd03c54ITLxHbfJzu2DWIlQXOaHq 3pvYUH8PogbzNVkoKiDObhAgSp1cTcOZQyniw1/eLTGmIvFdOsWq+4m7jm6ebJnIELgx Y+xHZmd/e6xENHdxkQYh9WvjJJFWYy24rR0wvEv7RtFJLYCaJSogN2+ibBLjYCVRU5ae t/nAA8bjUOIaT5IYZIoNOLPor5B+sNppIDi7/cAnoWvBMwJGsQQMY5dNyk+7pKPDcq4T fm7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7dn3LYPsrO5MbYIeyGRbprma5QBVCnZAiF7XUQjrkFs=; b=oTBNT6sYaIQbMU7pqlNWQTBvrflxhu68Yst/j0uAAH4uHwFleANi2CggtFCz2qDqMG hls5yxBSEnIlIsB1+JM2703mmOR6qEQaS0hBELaiSdNPqKHvYz9ZTZFa7ry5yZGK73Ar RapV7RO19ju3rtFthbONBsl5KMs5Qp1Yg+CWMOEiwkfR49Zz976YP8VPbGTSMQlwNYrE OuzpK69NRTWDBxB4NPnqwg362CjzV9Cd6kyfzQJGqmC2NcIcpfwgpgsxEYjjnrM5ubWH vNUPCYhLeKJXdgedR2/7fL//zjiKSMNlofMA7F86Q3tSlSw4tDt64RiFmGlPXi4BKf9w 8VeQ== X-Gm-Message-State: ANoB5pmyAx+RA5QpySTiWDC82FhPOz+yeC4ydDm6MLm201eb3aJUwL4n iwu9D77Z5hQ/bE9oLDDvkGvNTQ== X-Google-Smtp-Source: AA0mqf5WjSp23sAi2K1HXdkUD060IjHn+F6YexypS1Q3/Ft++cfMK3YpwSyDaG0F5BNeD2Y2xEbmzQ== X-Received: by 2002:a05:600c:3ba1:b0:3d0:47c:9ff5 with SMTP id n33-20020a05600c3ba100b003d0047c9ff5mr1290265wms.121.1668705937511; Thu, 17 Nov 2022 09:25:37 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: fam@euphon.net, berrange@redhat.com, f4bug@amsat.org, aurelien@aurel32.net, pbonzini@redhat.com, stefanha@redhat.com, crosa@redhat.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PATCH v3 06/13] docs/devel: simplify the minimal checklist Date: Thu, 17 Nov 2022 17:25:25 +0000 Message-Id: <20221117172532.538149-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221117172532.538149-1-alex.bennee@linaro.org> References: <20221117172532.538149-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1668706213501100001 The bullet points are quite long and contain process tips. Move those bits of the bullet to the relevant sections and link to them. Use a table for nicer formatting of the checklist. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini Message-Id: <20221111145529.4020801-8-alex.bennee@linaro.org> Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- docs/devel/submitting-a-patch.rst | 75 ++++++++++++++++++++----------- 1 file changed, 49 insertions(+), 26 deletions(-) diff --git a/docs/devel/submitting-a-patch.rst b/docs/devel/submitting-a-pa= tch.rst index 9c7c4331f3..1f2bde0625 100644 --- a/docs/devel/submitting-a-patch.rst +++ b/docs/devel/submitting-a-patch.rst @@ -12,25 +12,18 @@ be committed faster. This page seems very long, so if you are only trying to post a quick one-shot fix, the bare minimum we ask is that: =20 -- You **must** provide a Signed-off-by: line (this is a hard - requirement because it's how you say "I'm legally okay to contribute - this and happy for it to go into QEMU", modeled after the `Linux kernel - `__ - policy.) ``git commit -s`` or ``git format-patch -s`` will add one. -- All contributions to QEMU must be **sent as patches** to the - qemu-devel `mailing list `__. - Patch contributions should not be posted on the bug tracker, posted on - forums, or externally hosted and linked to. (We have other mailing list= s too, - but all patches must go to qemu-devel, possibly with a Cc: to another - list.) ``git send-email`` (`step-by-step setup - guide `__ and `hints and - tips `__) - works best for delivering the patch without mangling it, but - attachments can be used as a last resort on a first-time submission. -- You must read replies to your message, and be willing to act on them. - Note, however, that maintainers are often willing to manually fix up - first-time contributions, since there is a learning curve involved in - making an ideal patch submission. +.. list-table:: Minimal Checklist for Patches + :widths: 35 65 + :header-rows: 1 + + * - Check + - Reason + * - Patches contain Signed-off-by: Real Name + - States you are legally able to contribute the code. See :ref:`patch= _emails_must_include_a_signed_off_by_line` + * - Sent as patch emails to ``qemu-devel@nongnu.org`` + - The project uses an email list based workflow. See :ref:`submitting= _your_patches` + * - Be prepared to respond to review comments + - Code that doesn't pass review will not get merged. See :ref:`partic= ipating_in_code_review` =20 You do not have to subscribe to post (list policy is to reply-to-all to preserve CCs and keep non-subscribers in the loop on the threads they @@ -229,6 +222,19 @@ bisection doesn't land on a known-broken state. Submitting your Patches ----------------------- =20 +The QEMU project uses a public email based workflow for reviewing and +merging patches. As a result all contributions to QEMU must be **sent +as patches** to the qemu-devel `mailing list +`__. Patch +contributions should not be posted on the bug tracker, posted on +forums, or externally hosted and linked to. (We have other mailing +lists too, but all patches must go to qemu-devel, possibly with a Cc: +to another list.) ``git send-email`` (`step-by-step setup guide +`__ and `hints and tips +`__) +works best for delivering the patch without mangling it, but +attachments can be used as a last resort on a first-time submission. + .. _if_you_cannot_send_patch_emails: =20 If you cannot send patch emails @@ -314,10 +320,12 @@ git repository to fetch the original commit. Patch emails must include a ``Signed-off-by:`` line ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ =20 -For more information see `SubmittingPatches 1.12 -`__. -This is vital or we will not be able to apply your patch! Please use -your real name to sign a patch (not an alias or acronym). +Your patches **must** include a Signed-off-by: line. This is a hard +requirement because it's how you say "I'm legally okay to contribute +this and happy for it to go into QEMU". The process is modelled after +the `Linux kernel +`__ +policy. =20 If you wrote the patch, make sure your "From:" and "Signed-off-by:" lines use the same spelling. It's okay if you subscribe or contribute to @@ -327,6 +335,11 @@ include a "From:" line in the body of the email (diffe= rent from your envelope From:) that will give credit to the correct author; but again, that author's Signed-off-by: line is mandatory, with the same spelling. =20 +There are various tooling options for automatically adding these tags +include using ``git commit -s`` or ``git format-patch -s``. For more +information see `SubmittingPatches 1.12 +`__. + .. _include_a_meaningful_cover_letter: =20 Include a meaningful cover letter @@ -397,9 +410,19 @@ Participating in Code Review ---------------------------- =20 All patches submitted to the QEMU project go through a code review -process before they are accepted. Some areas of code that are well -maintained may review patches quickly, lesser-loved areas of code may -have a longer delay. +process before they are accepted. This will often mean a series will +go through a number of iterations before being picked up by +:ref:`maintainers`. You therefore should be prepared to +read replies to your messages and be willing to act on them. + +Maintainers are often willing to manually fix up first-time +contributions, since there is a learning curve involved in making an +ideal patch submission. However for the best results you should +proactively respond to suggestions with changes or justifications for +your current approach. + +Some areas of code that are well maintained may review patches +quickly, lesser-loved areas of code may have a longer delay. =20 .. _stay_around_to_fix_problems_raised_in_code_review: =20 --=20 2.34.1 From nobody Tue May 14 21:02:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1668706100; cv=none; d=zohomail.com; s=zohoarc; b=XRhyZi2wq5R2pWNdc6/bqQFXW3jdRZoz/CTJSrxjk1PeV3k9LYh15eR45Od6jm0poj9I7TJiWuLNMaAP5lfMasNT9dmxae+dArAAsr3+3AM9IpoZQpnTe0oNB5zHF0tASg7C/NMe1GD9M1MgSy/40Yy2zu2ASaAf6xdwy2LA2Yc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668706100; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=a1Pj8Pcso9OCC5jDWRBbmf7M1aOUY8qcP9iBCC6JI9I=; b=UnEBJUOwsHXyhyQRFcczbV/nLh0y2iWHKpUQRE51wRygJv3BVCP279oQOgR/rulaA/RH2ssjZkCyme8RPmkssZJ5y3/bYsXFLM64fQypcjn49cMcAHTL76GgFN2cynRhbMTEX1lPo1KF3eKzS8FwI1s99ds6tZ9ZNG52/zAp5go= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1668706100407486.14707797773144; Thu, 17 Nov 2022 09:28:20 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovieE-0006Pe-49; Thu, 17 Nov 2022 12:25:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovie2-0006KW-Bs for qemu-devel@nongnu.org; Thu, 17 Nov 2022 12:25:48 -0500 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovidw-0006EO-GI for qemu-devel@nongnu.org; Thu, 17 Nov 2022 12:25:43 -0500 Received: by mail-wm1-x32c.google.com with SMTP id ja4-20020a05600c556400b003cf6e77f89cso5026175wmb.0 for ; Thu, 17 Nov 2022 09:25:39 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id e16-20020adffd10000000b00241b933f8cesm1473859wrr.74.2022.11.17.09.25.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 09:25:35 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 857EF1FFBF; Thu, 17 Nov 2022 17:25:33 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=a1Pj8Pcso9OCC5jDWRBbmf7M1aOUY8qcP9iBCC6JI9I=; b=BIXXAqCRgV8XLbwgfKsl5T7yi/UBZBzUZ/EyDas9cEVyUzgSjKEf1jq8fnETxjjwlu nzLIQmUfep6Ok2/NvcbQKNd6Q96B4hr98o+H+qJ8e1SDeZsLVm6ERzkcXpIe7lqsIlcW BqRoIwTkxo1EiBfYpmjhE/mMLYV+hxbs+4LbHwp1rr8df6PVnkZvG/C2yBfXq9CYNcwa r5iPl/cGIPQc5feDGMOctp/eCizw5uOykmS8U8JXXHeMfheM1NQdMvQ3xPZRoS1u+oBH lpe4CEn02TVw3ecfy/29ZdcXhoISO8fLzcT61bJ6bNVBt64EtbH0CThjuFaeICJx7WTM yqYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a1Pj8Pcso9OCC5jDWRBbmf7M1aOUY8qcP9iBCC6JI9I=; b=jcznV/sWfukc+tsT47UPQy+9DfLcptT0Q7so1qNMPxnDm3vgKN3CSlK9m55xZJJZQW CYJvoGF+MeREVucNI0QrhKchwdBqdDYlSsWvbCNdSY0vxMFGH6wB/k+3evcDFdhY+vaN Ca0wwxhvcby5J1EnBJL6zG9JeaLdYZnn7gyEzn7QDGvlMpDP/UPK3u6GzVcxFxyY+T8j w3jYV4gvgW9O1W84O6sIE/+TaJ/RdDVJYnAXI4sKIrzIfz6r1x5z+0APnDzW6Lozhp2o J43gSDz8KSGaEiIopLxz2emdKJ6lpnkxq7s9HG04sDSER5bm7d5QkGyLzZJ2Gn0/2LKk BTRw== X-Gm-Message-State: ANoB5pmoJaSJZ0b/FwGVpjfDEW8EQ5WmssBOunwbUND2b93cXQ7btyqG 2msNox1PuWkTDH/CFTGzAfcRFg== X-Google-Smtp-Source: AA0mqf56+aODP8jDjDjOWvExZJAkrK64R3TjrQX/+W1HpVJ46V2xqbqVIG98QMdJSoPb+ddliyG6ow== X-Received: by 2002:a05:600c:3b1e:b0:3c6:c182:b125 with SMTP id m30-20020a05600c3b1e00b003c6c182b125mr2433826wms.145.1668705938326; Thu, 17 Nov 2022 09:25:38 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: fam@euphon.net, berrange@redhat.com, f4bug@amsat.org, aurelien@aurel32.net, pbonzini@redhat.com, stefanha@redhat.com, crosa@redhat.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Markus Armbruster Subject: [PATCH v3 07/13] docs/devel: try and improve the language around patch review Date: Thu, 17 Nov 2022 17:25:26 +0000 Message-Id: <20221117172532.538149-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221117172532.538149-1-alex.bennee@linaro.org> References: <20221117172532.538149-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1668706100740100001 It is important that contributors take the review process seriously and we collaborate in a respectful way while avoiding personal attacks. Try and make this clear in the language. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Markus Armbruster Reviewed-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini Message-Id: <20221111145529.4020801-9-alex.bennee@linaro.org> Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- docs/devel/submitting-a-patch.rst | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/docs/devel/submitting-a-patch.rst b/docs/devel/submitting-a-pa= tch.rst index 1f2bde0625..80e8693bb6 100644 --- a/docs/devel/submitting-a-patch.rst +++ b/docs/devel/submitting-a-patch.rst @@ -434,14 +434,20 @@ developers will identify bugs, or suggest a cleaner a= pproach, or even just point out code style issues or commit message typos. You'll need to respond to these, and then send a second version of your patches with the issues fixed. This takes a little time and effort on your part, but -if you don't do it then your changes will never get into QEMU. It's also -just polite -- it is quite disheartening for a developer to spend time -reviewing your code and suggesting improvements, only to find that -you're not going to do anything further and it was all wasted effort. +if you don't do it then your changes will never get into QEMU. + +Remember that a maintainer is under no obligation to take your +patches. If someone has spent the time reviewing your code and +suggesting improvements and you simply re-post without either +addressing the comment directly or providing additional justification +for the change then it becomes wasted effort. You cannot demand others +merge and then fix up your code after the fact. =20 When replying to comments on your patches **reply to all and not just the sender** -- keeping discussion on the mailing list means everybody -can follow it. +can follow it. Remember the spirit of the :ref:`code_of_conduct` and +keep discussions respectful and collaborative and avoid making +personal comments. =20 .. _pay_attention_to_review_comments: =20 --=20 2.34.1 From nobody Tue May 14 21:02:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1668706213; cv=none; d=zohomail.com; s=zohoarc; b=f05pwgFqOmt6UvkdXcwprXwckAi3SUCavwftgHPzqRktvfsb7tskCjOcoA6kZecBNMSABEwpcxoqM8JVK3xeYoX3o5nw+pEdxRS9MdEELjECs9K8QW0ZC/SsemBrB88o3qgC1bU77+z/mHriteXvIW2k+lNSLnE5u8fa5RCbfck= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668706213; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=r0gPi4afo9I5YmqQbfJD2lj3D8+SZO0B+Jf+mMaPF0M=; b=e+YnykNiafUFLYRVqxHwl+k1n+qzpScqo7l1GU6b/rr+gb0GSz2/hcDDcWJX2Oq2UcdlQwckE88tP2h1/XnOMp5rjSBg6pS0u8mNQt5f4XP0Usi096Tgi4VXbTL5oAs4j/s0oeQD4wxv2u9S1uCFM5vBJI2MPTCI+ka3zUkD6tw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 166870621361131.97607619698033; Thu, 17 Nov 2022 09:30:13 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovieD-0006PN-FJ; Thu, 17 Nov 2022 12:25:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovie2-0006KT-AW for qemu-devel@nongnu.org; Thu, 17 Nov 2022 12:25:47 -0500 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovidw-0006ES-BO for qemu-devel@nongnu.org; Thu, 17 Nov 2022 12:25:42 -0500 Received: by mail-wr1-x433.google.com with SMTP id y16so4938807wrt.12 for ; Thu, 17 Nov 2022 09:25:39 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id c15-20020a05600c0acf00b003c21ba7d7d6sm1825646wmr.44.2022.11.17.09.25.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 09:25:35 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 9CAF81FFC0; Thu, 17 Nov 2022 17:25:33 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r0gPi4afo9I5YmqQbfJD2lj3D8+SZO0B+Jf+mMaPF0M=; b=IK6HqqXH4W+Z+SESWgOgyKL4VJlhgoQrJwo1tlKBWpaN2FEmg0KcJdykUePY5uHv9I OA3TYA6zBCqHs6rBgQ4V963SQJJVG3U0reoSiz/d4AH2esKqR8Yjtn3DN1syUsdD8Rzu zOOTSRyBYtJV0fySCj0n3f2DlVGpHTvL2vc0sor1ChIOfmv2sAnx/izSh/ASrDaSYrOX j5wxLuTG9gu85yIkHuCtF1a8rb7DVdIm/7z3A6qPcGj4wqAWr5HsHHDPHd0H8qRf9y4d xjztEJCPj+k/2OJw/yccEawdrwXFyceDKCQVvnVB/OfPBh0lWUlrfi/rhZskms3f1S2h 8h1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r0gPi4afo9I5YmqQbfJD2lj3D8+SZO0B+Jf+mMaPF0M=; b=5EWVnLNKohc0DbivcGD06rw+jcR4MU8FaFUOqshLQmYfZvK2s7G4N+2ckYEqAThoRR AyTZTbsWNaARBAx6yJ4dHM780FWvbH2mRr3WJ1XM8pGTZ4mp7U7L07LzZnPuM7cMu3G0 IW8CZGPe7/GaAMfRnPKACA9drS1pd26OdDQDTHxkAnvZ1HtRUGwXw6D6Sz3rbJbZneu5 bHTZKBThZwQpLL2OaiHowQlmIVL/66JuWLwdR3KsF8zTieNb9mOPUSxucSHLSnnnbOEy 07dbBkLWBGej880UyZjj2PX9OYhA6VfKDJmbbSIajXfLDyWlWW59xnpRi8DHB3+F/6d+ Q1dA== X-Gm-Message-State: ANoB5plCC7fdRGR7ohadw2XRYeV9oFDBZiiIEjgXROoflDSGuC2W/ckH punovaeMGGCAD/z+Mgh/+vMJIYgojDtBxQ== X-Google-Smtp-Source: AA0mqf6bv0wd6xECNqc/BhQ9d30g2soJqQODk5MAgSDN44MUCAbAhvEhgytpcpptIzK8EUYI82zx8g== X-Received: by 2002:adf:f601:0:b0:236:55a7:348f with SMTP id t1-20020adff601000000b0023655a7348fmr2164163wrp.331.1668705938658; Thu, 17 Nov 2022 09:25:38 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: fam@euphon.net, berrange@redhat.com, f4bug@amsat.org, aurelien@aurel32.net, pbonzini@redhat.com, stefanha@redhat.com, crosa@redhat.com, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Wainer dos Santos Moschetta , Beraldo Leal Subject: [PATCH v3 08/13] tests/avocado: Raise timeout for boot_linux.py:BootLinuxPPC64.test_pseries_tcg Date: Thu, 17 Nov 2022 17:25:27 +0000 Message-Id: <20221117172532.538149-9-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221117172532.538149-1-alex.bennee@linaro.org> References: <20221117172532.538149-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1668706215409100007 From: Peter Maydell On my machine, a debug build of QEMU takes about 260 seconds to complete this test, so with the current timeout value of 180 seconds it always times out. Double the timeout value to 360 so the test definitely has enough time to complete. Signed-off-by: Peter Maydell Signed-off-by: Alex Benn=C3=A9e Message-Id: <20221110142901.3832318-1-peter.maydell@linaro.org> Message-Id: <20221111145529.4020801-11-alex.bennee@linaro.org> --- tests/avocado/boot_linux.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/avocado/boot_linux.py b/tests/avocado/boot_linux.py index 571d33882a..2be4be395d 100644 --- a/tests/avocado/boot_linux.py +++ b/tests/avocado/boot_linux.py @@ -116,7 +116,7 @@ class BootLinuxPPC64(LinuxTest): :avocado: tags=3Darch:ppc64 """ =20 - timeout =3D 180 + timeout =3D 360 =20 def test_pseries_tcg(self): """ --=20 2.34.1 From nobody Tue May 14 21:02:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1668706027; cv=none; d=zohomail.com; s=zohoarc; b=WbCb/p1cL4sIcJac5X10/FNMcifAALTpNx0m8w3hiSoKUu8bBwTogd5eBgFpsogqwABUlLoaXy6+JtsN744QXEp1RqD3Cc2H/qQgVAJOdtCvxZmOhNHppJ9v4YnFWVgxxa03zDbqj3ZH6eDlf140EqEovwVXRM6369RkcCrdUt0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668706027; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=26+j95KhNnRg/9welD9ngC/SIn1nmwD8VeCvoiMe1LU=; b=WOWrQIPJGyAlbKze71W7wmFC4W3H9EbNW3lj04yuylUlNdnA+ISrnoMLgvotTXKvprlrf9+TRyvxR9Ev6r8M9kvpXwN6nI+lOIgvAaF9vtn+FOn0gDpnmaLaYsUKPEd3kiW5gXauuWLReo6K8ynJf4ySCsjT8GG+i7UVGMaFtOc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1668706027230615.1258728079165; Thu, 17 Nov 2022 09:27:07 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovieF-0006Qs-F5; Thu, 17 Nov 2022 12:25:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovie4-0006LO-7w for qemu-devel@nongnu.org; Thu, 17 Nov 2022 12:25:49 -0500 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovie0-0006Es-7w for qemu-devel@nongnu.org; Thu, 17 Nov 2022 12:25:47 -0500 Received: by mail-wm1-x32d.google.com with SMTP id c65-20020a1c3544000000b003cfffd00fc0so1646921wma.1 for ; Thu, 17 Nov 2022 09:25:40 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id l32-20020a05600c1d2000b003cfbbd54178sm11306161wms.2.2022.11.17.09.25.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 09:25:36 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id B30041FFC1; Thu, 17 Nov 2022 17:25:33 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=26+j95KhNnRg/9welD9ngC/SIn1nmwD8VeCvoiMe1LU=; b=YgCe2PVQijyi04ajtrLo84dw7mATzK7TD4mOOLljMpfS2dbUa3JswIAy0VJMUigvJB pRCxy4n1+Gy08IDESPCJX4B1Tt7Ubm280y04JZjI6xlRKYjrd4OtcgEVBquZXBketgBc uKgVB27+gNt8Sevvo3nHl/27k7/uR8DaBkpjevLd6to+Q1Tm5ukvxoT1ZXAyGU/OhCdf 6pAXx4Hhgvy9RnFxnkGB0ye3h2PUmldHAq9sCVqRyYuCLC3SFsq13h8PtDxMqWpZl+pr zJQ6qOeg0svxQqzfCjdzOEtYw2mNwDfgDMBf5pj53HxPJ+HBpXnvT3jgCOz/7W7y1DjK ///w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=26+j95KhNnRg/9welD9ngC/SIn1nmwD8VeCvoiMe1LU=; b=HqDflufN/+sjK4WhILSpuvQLMqwrlB1aIQ1E2gAXWJyTQK7AF4bP4zcANjpQfDkLqq cb1/qD0crLGHaPWK+4OqTv3BWLqJ3nW67TiyK22pUGdGxHprynGroBjY24Su+3SpRHvs jsAWR/xbxbaRQY9TpHRBUhSPHW88Uylf+xVlPWKSgUHKLcYoyO7qSBney2Ux3SERlhBg z1TKzN+djZjSNqjFiRNko9Rl/siA8oYy5XJl3Lol4RdHwxr1UeYav5Hz/5GNbvY40TWt HbRZvOQLonO90k1VJlQ3kfhjzWFeglCEBPmIEF9O+NYUJt9V10nTEXeaGgmFt9fcTgiB 9NSQ== X-Gm-Message-State: ANoB5pnUmvSpouE2vnaSZ4gc38duAusVuiDEFGBjNykRENM74niIcX1U mfsdq0y9TblgwN6wg47RZCj/OA== X-Google-Smtp-Source: AA0mqf6BAIyDT6V+BVpmqlC9Fkrod7xaA8slwcSzX9S6bvKfv2hzsZ6Omf+lyF7bAPL5UZVfdZSXpQ== X-Received: by 2002:a7b:c456:0:b0:3a5:f600:502e with SMTP id l22-20020a7bc456000000b003a5f600502emr2479667wmi.39.1668705939518; Thu, 17 Nov 2022 09:25:39 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: fam@euphon.net, berrange@redhat.com, f4bug@amsat.org, aurelien@aurel32.net, pbonzini@redhat.com, stefanha@redhat.com, crosa@redhat.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Wainer dos Santos Moschetta , Beraldo Leal , qemu-arm@nongnu.org (open list:Virt) Subject: [PATCH v3 09/13] tests/avocado: introduce alpine virt test for CI Date: Thu, 17 Nov 2022 17:25:28 +0000 Message-Id: <20221117172532.538149-10-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221117172532.538149-1-alex.bennee@linaro.org> References: <20221117172532.538149-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1668706028199100004 The boot_linux tests download and run a full cloud image boot and start a full distro. While the ability to test the full boot chain is worthwhile it is perhaps a little too heavy weight and causes issues in CI. Fix this by introducing a new alpine linux ISO boot in machine_aarch64_virt. This boots a fully loaded -cpu max with all the bells and whistles in 31s on my machine. A full debug build takes around 180s on my machine so we set a more generous timeout to cover that. We don't add a test for lesser GIC versions although there is some coverage for that already in the boot_xen.py tests. If we want to introduce more comprehensive testing we can do it with a custom kernel and initrd rather than a full distro boot. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- v1 - use "virt" image instead (even faster) - don't drop boot_linux (it is now disabled for CI) - re-phrase commit message - add alpine to the test name --- tests/avocado/machine_aarch64_virt.py | 46 ++++++++++++++++++++++++++- 1 file changed, 45 insertions(+), 1 deletion(-) diff --git a/tests/avocado/machine_aarch64_virt.py b/tests/avocado/machine_= aarch64_virt.py index 21848cba70..c2b2ba2cf8 100644 --- a/tests/avocado/machine_aarch64_virt.py +++ b/tests/avocado/machine_aarch64_virt.py @@ -1,4 +1,5 @@ -# Functional test that boots a Linux kernel and checks the console +# Functional test that boots a various Linux systems and checks the +# console output. # # Copyright (c) 2022 Linaro Ltd. # @@ -8,19 +9,62 @@ # SPDX-License-Identifier: GPL-2.0-or-later =20 import time +import os =20 from avocado_qemu import QemuSystemTest from avocado_qemu import wait_for_console_pattern from avocado_qemu import exec_command +from avocado_qemu import BUILD_DIR =20 class Aarch64VirtMachine(QemuSystemTest): KERNEL_COMMON_COMMAND_LINE =3D 'printk.time=3D0 ' + timeout =3D 360 =20 def wait_for_console_pattern(self, success_message, vm=3DNone): wait_for_console_pattern(self, success_message, failure_message=3D'Kernel panic - not syn= cing', vm=3Dvm) =20 + # This tests the whole boot chain from EFI to Userspace + # We only boot a whole OS for the current top level CPU and GIC + # Other test profiles should use more minimal boots + def test_alpine_virt_tcg_gic_max(self): + """ + :avocado: tags=3Darch:aarch64 + :avocado: tags=3Dmachine:virt + :avocado: tags=3Daccel:tcg + """ + iso_url =3D ('https://dl-cdn.alpinelinux.org/' + 'alpine/v3.16/releases/aarch64/' + 'alpine-virt-3.16.3-aarch64.iso') + + # Alpine use sha256 so I recalculated this myself + iso_sha1 =3D '0683bc089486d55c91bf6607d5ecb93925769bc0' + iso_path =3D self.fetch_asset(iso_url, asset_hash=3Diso_sha1) + + self.vm.set_console() + kernel_command_line =3D (self.KERNEL_COMMON_COMMAND_LINE + + 'console=3DttyAMA0') + self.require_accelerator("tcg") + + self.vm.add_args("-accel", "tcg") + self.vm.add_args("-cpu", "max,pauth-impdef=3Don") + self.vm.add_args("-machine", + "virt,acpi=3Don," + "virtualization=3Don," + "mte=3Don," + "gic-version=3Dmax,iommu=3Dsmmuv3") + self.vm.add_args("-smp", "2", "-m", "1024") + self.vm.add_args('-bios', os.path.join(BUILD_DIR, 'pc-bios', + 'edk2-aarch64-code.fd')) + self.vm.add_args("-drive", f"file=3D{iso_path},format=3Draw") + self.vm.add_args('-device', 'virtio-rng-pci,rng=3Drng0') + self.vm.add_args('-object', 'rng-random,id=3Drng0,filename=3D/dev/= urandom') + + self.vm.launch() + self.wait_for_console_pattern('Welcome to Alpine Linux 3.16') + + def test_aarch64_virt(self): """ :avocado: tags=3Darch:aarch64 --=20 2.34.1 From nobody Tue May 14 21:02:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1668706065; cv=none; d=zohomail.com; s=zohoarc; b=FD4dekywA5HvT34tL+vTd7fEciQb+8sBf8CR8RYN3Fteod4G+QNL/o2/QLfyNaO4A8Z9ceHwZqatlIwjo/rJ/AjSU26XfXIDsmgK3jYew9eo7Gn4YwzhzKNtsxwBkUSccPfO4gMZJsaGbUj6tEHUU0EBTlPz3Ef4LrKySV3dBAw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668706065; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qC/VoVqNlKC3sjWCOYbeWRAUuEITkY8ByQXqJYDIr5s=; b=iRM8Ikk0w6ypYgMmEdsFv2VThMoXTH+E4pDLUqcNa/wJxDvgn35dfr5a6eivjVG75kFmwmJwk6lT9NsIefyj/Ncx/Pp+4xePOGimambZ6rcInCwZYJjGgkKxfd9Z4HERKmt1IMztHxDdNGralm892H5yqIem3cfrdVRTJitBXzA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16687060657660.64214462011455; Thu, 17 Nov 2022 09:27:45 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovieH-0006R5-PN; Thu, 17 Nov 2022 12:26:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovie5-0006LW-3k for qemu-devel@nongnu.org; Thu, 17 Nov 2022 12:25:49 -0500 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovie2-0006Ex-2s for qemu-devel@nongnu.org; Thu, 17 Nov 2022 12:25:48 -0500 Received: by mail-wm1-x331.google.com with SMTP id j5-20020a05600c410500b003cfa9c0ea76so2254671wmi.3 for ; Thu, 17 Nov 2022 09:25:40 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id o19-20020a1c7513000000b003b4a699ce8esm6006010wmc.6.2022.11.17.09.25.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 09:25:36 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id C9B421FFC2; Thu, 17 Nov 2022 17:25:33 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qC/VoVqNlKC3sjWCOYbeWRAUuEITkY8ByQXqJYDIr5s=; b=HHJgyU1NDgzpyLbfiLzF/Ksi3Qeh7v6JkzLWhz+E4EEjTCSAGpp9wgX1TcXBlobrt9 9eme352cQ1YfbGjocS4aSzur2e6UH+bRejS8u4uU9XR2xOZ52Qk1juIMQLSYDzy23UhE nW3txn70pLi9xPwoREeMkM8AaojWrN2n7wgjzBG0ImIFox8YxnB/KXdcnAoMq1yFuDnN 82A4SJ2Di0+jVj2t8mNUqShbPZMpMRjZ4bTJnZMBufaFa3XqhbXg2QSYFcjpq0VJiVFr kyMMZhIzZeZEMEeZOEmcKAL5FV2SZSyWZgTM3Z6C8kShbjh8QCmAyfX6JomTsGR6Vcwp qqvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qC/VoVqNlKC3sjWCOYbeWRAUuEITkY8ByQXqJYDIr5s=; b=K0KQta/oMoy71URLSLAQtW8c7TEKFgat89Lh/q3FENw80IiecfdUXKtwrA2QCcovhQ gIVpr0WldZvAEjc3AOf4y3yJefzS6NpB2Zf1PHrJvaNSP+LBvr2HaJ++rw9swAGnMUee VBMWT6y0+vP+F6debixYKZMfoL+T8ZCgtM5Seva4COLs85ISzrqjcO87ld5cid1a7y47 Z4jNFShZ8fAyV5e0w+5CZTpLXDOKqYt22jMuTZ7VEnbAuKWN94/mbGCWR1vBCNzI205Q U92MVQuZQ/944p3pp08vCDjVDSjO4voqSlFIZlBWauJI0Z1YY46ncXdt8L2RwkAqZ0kD HxmA== X-Gm-Message-State: ANoB5plWim7h9JpSr7qMiSVRzLDxtJEDruv9lJxoVo/Q5IrQT9E+Dvgz kvVKMgW2DfRnk/Iwdvfqw61jWg== X-Google-Smtp-Source: AA0mqf6l3sZDvl8yUPEKJkZoNzQos5e31e5E/p7ADJcYo0N5JnEM8bHxKUe5YcjZ4IBKdBbIZzHjZg== X-Received: by 2002:a05:600c:3b0c:b0:3cf:8df2:63b7 with SMTP id m12-20020a05600c3b0c00b003cf8df263b7mr5907423wms.11.1668705939965; Thu, 17 Nov 2022 09:25:39 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: fam@euphon.net, berrange@redhat.com, f4bug@amsat.org, aurelien@aurel32.net, pbonzini@redhat.com, stefanha@redhat.com, crosa@redhat.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Wainer dos Santos Moschetta , Beraldo Leal Subject: [PATCH v3 10/13] tests/avocado: skip aarch64 cloud TCG tests in CI Date: Thu, 17 Nov 2022 17:25:29 +0000 Message-Id: <20221117172532.538149-11-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221117172532.538149-1-alex.bennee@linaro.org> References: <20221117172532.538149-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1668706066692100001 We now have a much lighter weight test in machine_aarch64_virt which tests the full boot chain in less time. Rename the tests while we are at it to make it clear it is a Fedora cloud image. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tests/avocado/boot_linux.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tests/avocado/boot_linux.py b/tests/avocado/boot_linux.py index 2be4be395d..79810be942 100644 --- a/tests/avocado/boot_linux.py +++ b/tests/avocado/boot_linux.py @@ -58,6 +58,9 @@ def test_pc_q35_kvm(self): self.launch_and_wait(set_up_ssh_connection=3DFalse) =20 =20 +# For Aarch64 we only boot KVM tests in CI as the TCG tests are very +# heavyweight. There are lighter weight distros which we use in the +# machine_aarch64_virt.py tests. class BootLinuxAarch64(LinuxTest): """ :avocado: tags=3Darch:aarch64 @@ -73,7 +76,8 @@ def add_common_args(self): self.vm.add_args('-device', 'virtio-rng-pci,rng=3Drng0') self.vm.add_args('-object', 'rng-random,id=3Drng0,filename=3D/dev/= urandom') =20 - def test_virt_tcg_gicv2(self): + @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') + def test_fedora_cloud_tcg_gicv2(self): """ :avocado: tags=3Daccel:tcg :avocado: tags=3Dcpu:max @@ -86,7 +90,8 @@ def test_virt_tcg_gicv2(self): self.add_common_args() self.launch_and_wait(set_up_ssh_connection=3DFalse) =20 - def test_virt_tcg_gicv3(self): + @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') + def test_fedora_cloud_tcg_gicv3(self): """ :avocado: tags=3Daccel:tcg :avocado: tags=3Dcpu:max --=20 2.34.1 From nobody Tue May 14 21:02:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1668706083; cv=none; d=zohomail.com; s=zohoarc; b=ByEJI918Gj3dle7zCWxrv8kmWD408I2cg1PuVlL96yPliHYkQxOyV+s3WYOA9t8ikvU+4YDU96YcEYyV+QYL4GdgPJutzuSHSTFD9bg/RKw8T3u1ORq/+K12Y+B1/oBnF+XqZHGOYOrM+CAtvhEelSnPYAMlWrZBC3GJnrIoSN4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668706083; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=KsoXyv/ps+YbWahAkHox+gO9CbRysA54OuU4lgnIP2M=; b=A3ZbO9XGGleWQUahpgGo5WyxDcCPw+ydh65mHB9C2UKUzYf0PbA0SNC53HrtluV4//psbdKoKUVz8+hN/NHdMxBlvK5CW9+oR5bp9x42fy5OoFfFzQUa7aPL6LfZMqfu1AfSZRuDdQAiyHU4tozFalOjQRXRZMfhrcJO9UgP+fI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1668706083855859.2492112406602; Thu, 17 Nov 2022 09:28:03 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovieI-0006SL-CT; Thu, 17 Nov 2022 12:26:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovie8-0006NT-I2 for qemu-devel@nongnu.org; Thu, 17 Nov 2022 12:25:56 -0500 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovie2-0006FL-A8 for qemu-devel@nongnu.org; Thu, 17 Nov 2022 12:25:52 -0500 Received: by mail-wm1-x334.google.com with SMTP id m7-20020a05600c090700b003cf8a105d9eso2246001wmp.5 for ; Thu, 17 Nov 2022 09:25:42 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id q125-20020a1c4383000000b003c6cd82596esm6259337wma.43.2022.11.17.09.25.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 09:25:38 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id E43C41FFBA; Thu, 17 Nov 2022 17:25:33 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KsoXyv/ps+YbWahAkHox+gO9CbRysA54OuU4lgnIP2M=; b=LrNMXYZh4HdY6xoENMuEilMMzR92JAiCLd4VXmwV8jKL9uxrm/+867pSNs1Tp2+cZa GEaglqS6AYsmmhVpS+rjlqsX3u0F+RefnXFfpGF8Df738R34fsR9rdFcNnrSRQvCLA9U OX2hgL6zPvrPNyYmPjhIszHS2IKm9bGQTaVCwPAkcHu0vR222tAWNuyj2ut500U3ONhf 6pbQOFk7XjyXo4v9EVMitxFUX04e2lshbJrnT8ltl0yCJCgaxYwJPKaTEmQCzh/9Dgfk DT/c5KPiiMXJtnSK3WV0Cbk2zh8ttRHPG04pC043i9NAJcJ4bv9N8Ta8CA0IY661kKHQ JPFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KsoXyv/ps+YbWahAkHox+gO9CbRysA54OuU4lgnIP2M=; b=nAiGfCpnDKbYMKRDLmqTHrJcDEtHsChxJWl+8FjaUVfwq6ZUhNB7ImdQ3SN9G3kn4o v0hQ8OYBeh+CYdT4bDwIYDZgG5PsvG8T8O9phECY3Z2qv+uioEMTE6+NWwIxPlHHrPVX QL3sjMkKWy50foqwxkY7zN549EJBDUaFWysuTTT73ZCdcz6vFaONbtdXXBsQBXfCni1I OCiydi+LfjB6sKyQuEd0Fat+q3E8Pl/RdskPjvZFtvk7IhN5sEGZsWb98bIqUCfBObzs 6doDrsQ3+oXfJ4CoUILhddc1X50YDnTrfp0Wfx2DbC4aRE+sO91XiEufuixskf5emlhf SeWA== X-Gm-Message-State: ANoB5plJ9ocaNRVYzxn9FezMpsaKR2vaUF4eqfOfvuofUaIq0xXUnQ1m tKbcRe0vb3Lm102e9BW+PYDe9w== X-Google-Smtp-Source: AA0mqf5nlv2dzoIOYBWyUk+hFDnNOMTWXjJgLqmICih2Rgp2uO5xMl4yjVkOETCIEYjQyNw6jnLcQQ== X-Received: by 2002:a05:600c:4891:b0:3cf:d367:2765 with SMTP id j17-20020a05600c489100b003cfd3672765mr6071371wmp.12.1668705941418; Thu, 17 Nov 2022 09:25:41 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: fam@euphon.net, berrange@redhat.com, f4bug@amsat.org, aurelien@aurel32.net, pbonzini@redhat.com, stefanha@redhat.com, crosa@redhat.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth , Wainer dos Santos Moschetta , Beraldo Leal Subject: [PATCH v3 11/13] gitlab: integrate coverage report Date: Thu, 17 Nov 2022 17:25:30 +0000 Message-Id: <20221117172532.538149-12-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221117172532.538149-1-alex.bennee@linaro.org> References: <20221117172532.538149-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1668706084598100003 This should hopefully give is nice coverage information about what our tests (or at least the subset we are running) have hit. Ideally we would want a way to trigger coverage on tests likely to be affected by the current commit. Signed-off-by: Alex Benn=C3=A9e Acked-by: Stefan Hajnoczi Message-Id: <20221111145529.4020801-12-alex.bennee@linaro.org> --- .gitlab-ci.d/buildtest.yml | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index 7173749c52..d21b4a1fd4 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -494,7 +494,17 @@ check-gprof-gcov: IMAGE: ubuntu2004 MAKE_CHECK_ARGS: check after_script: - - ${CI_PROJECT_DIR}/scripts/ci/coverage-summary.sh + - cd build + - gcovr --xml-pretty --exclude-unreachable-branches --print-summary + -o coverage.xml --root ${CI_PROJECT_DIR} . *.p + coverage: /^\s*lines:\s*\d+.\d+\%/ + artifacts: + name: ${CI_JOB_NAME}-${CI_COMMIT_REF_NAME}-${CI_COMMIT_SHA} + expire_in: 2 days + reports: + coverage_report: + coverage_format: cobertura + path: build/coverage.xml =20 build-oss-fuzz: extends: .native_build_job_template --=20 2.34.1 From nobody Tue May 14 21:02:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1668706099; cv=none; d=zohomail.com; s=zohoarc; b=OGhjQiF85zjfIvmTFtwvrhXovh+hnXa082GGSKn0Ob7/2ySQ68eCGHAGhiYlJI7vcRj5GKl/knWCzL+NdeVHJ1j07eRhmUd3HdW6OMqqsvLom6X3XEqhH/M6Na4a69soC5LNL+5L8BFs+bKPI64pDYzQHFSPkAYSfDwOYW3Hf/M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668706099; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ZN0cS2zXnFlCnu9gVWFbK/ag61x7K3nHdyQ6BLwUiic=; b=ie/JSP7MEHeIHLj5Lw2LeReRHaJ11Z+3S4PPZZnnwtUOvmXX3RrpFipJ+Rz5szVJ/r3iyBCvU1C3mP90hXMgPSFh82JUBtwYMoq6WLtb7VtlU/0M9ImLoBj4JqfQpT6KpjmtnyxwoqHxVD6zWgEw/AZpD94HaOAtcJMBZeXPmp0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1668706099740618.7138470159488; Thu, 17 Nov 2022 09:28:19 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovieF-0006Qx-WD; Thu, 17 Nov 2022 12:26:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovie8-0006NR-G5 for qemu-devel@nongnu.org; Thu, 17 Nov 2022 12:25:56 -0500 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovie2-0006FG-BT for qemu-devel@nongnu.org; Thu, 17 Nov 2022 12:25:51 -0500 Received: by mail-wr1-x431.google.com with SMTP id a14so5004532wru.5 for ; Thu, 17 Nov 2022 09:25:41 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id c3-20020adffb43000000b00225307f43fbsm1443818wrs.44.2022.11.17.09.25.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 09:25:38 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 089651FFC3; Thu, 17 Nov 2022 17:25:34 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZN0cS2zXnFlCnu9gVWFbK/ag61x7K3nHdyQ6BLwUiic=; b=u/Z5GGL2M0gCN1Ty+kJ7A9PiLKiQBLd7VCIuLi3xWkHW00rSLCwQ7qeLW9rOM4xgm1 AsAsdvNRFGGEdKJoC16KyUS4zqpMRhhnSMjnFGZEmCpatDALgFL9U/9iwwvGFJNZGEeH xCDdWW23Cf9CbMKCQZyJy/K0LlMcs4wYh+41X57UttzpTwjwpRilqj6ofMbYAvHawXJo f2sp1sIxCCwPW2XfhmMiPkmzfG4sp6JBOL8XtRHWU0v9u31BvDo5Po4LCdnr8yE5mHcX TdOoRavG/Tg48FlrIeyuB5UwKPk4kly4Gk5obyozV/5J024xCuqSFKB/qLM9OGi5lq1K IWsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZN0cS2zXnFlCnu9gVWFbK/ag61x7K3nHdyQ6BLwUiic=; b=ZFy/Kc1W8W89mQ6l04FotgSnYyQvtT6IolDloSGKmHv5Ka952/uGpQcfjXEGLFyv1u G3cTgg4aWYiryVW2mW+TPJis4IxEg7p9i2HDmXp5afdY5IGftW2369H2Q2mW3XLfpyT5 +GQk8qW53Du6UlSLRNYcjLk3ZJd0a5T8mnbJUR6qu24WoFNG9NEwH85nONuoAjvhDwaA 3MGx+pGAE2YWejR+0qV98zenrb3AofNOMXJ0RAehL/REeiu/fr1iVuFW5v4Juwn/7mMV Atnyg8rPzJIioW0zff60YUDRxhTZOiwTH0a66RhSs607BXg0+WQDxEtomud7xwEftdMW P9sw== X-Gm-Message-State: ANoB5pkrpgDopgHxfKE0KoO1nElxDTNANsrjoailWF0FMy6ntlrQa0Qb nl6DXkiAv/WT5UhwyABJ+jf+iA== X-Google-Smtp-Source: AA0mqf5crmOkYbyf6eFslq2sHko3ooKWVGh+eB+j3ugyiYl+CcSEDp3Ms+bX7swbSwCp7ZUkOwbSHw== X-Received: by 2002:a05:6000:1d94:b0:238:3d85:8e2c with SMTP id bk20-20020a0560001d9400b002383d858e2cmr2144693wrb.650.1668705941117; Thu, 17 Nov 2022 09:25:41 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: fam@euphon.net, berrange@redhat.com, f4bug@amsat.org, aurelien@aurel32.net, pbonzini@redhat.com, stefanha@redhat.com, crosa@redhat.com, Peter Maydell , Thomas Huth , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Wainer dos Santos Moschetta , Beraldo Leal Subject: [PATCH v3 12/13] tests/avocado/boot_linux.py: Bump aarch64 virt test timeout to 720s Date: Thu, 17 Nov 2022 17:25:31 +0000 Message-Id: <20221117172532.538149-13-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221117172532.538149-1-alex.bennee@linaro.org> References: <20221117172532.538149-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1668706100740100002 From: Peter Maydell The two tests tests/avocado/boot_linux.py:BootLinuxAarch64.test_virt_tcg_gicv2 tests/avocado/boot_linux.py:BootLinuxAarch64.test_virt_tcg_gicv3 take quite a long time to run, and the current timeout of 240s is not enough for the tests to complete on slow machines: we've seen these tests time out in the gitlab CI in the 'avocado-system-alpine' CI job, for instance. The timeout is also insufficient for running the test with a debug build of QEMU: on my machine the tests take over 10 minutes to run in that config. Push the timeout up to 720s so that the test definitely has enough time to complete. Signed-off-by: Peter Maydell Reviewed-by: Thomas Huth Message-Id: <20221117111628.911686-1-peter.maydell@linaro.org> Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tests/avocado/boot_linux.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/avocado/boot_linux.py b/tests/avocado/boot_linux.py index 79810be942..b3e58fa309 100644 --- a/tests/avocado/boot_linux.py +++ b/tests/avocado/boot_linux.py @@ -67,7 +67,7 @@ class BootLinuxAarch64(LinuxTest): :avocado: tags=3Dmachine:virt :avocado: tags=3Dmachine:gic-version=3D2 """ - timeout =3D 240 + timeout =3D 720 =20 def add_common_args(self): self.vm.add_args('-bios', --=20 2.34.1 From nobody Tue May 14 21:02:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1668705984; cv=none; d=zohomail.com; s=zohoarc; b=nX3tOfYor/URXyUa2lv85CweI4aGeBUkMxHi8s0JOvF2JUqpjWfGNBciOlmfGPNS4g79llqBPTTbhDkpo+mdwRhoKz/DM8CZxZJVEU8+8mSoxViw9vcLe4Ii5h6JL/3+hlxK/gNuzl8gJU0f2y64I6BS87tqjIYVHRIQotRxL8w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668705984; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=oMlvtnFEABWg8w92G/8HRIs95GXnsgMR5Vml1n/BCPw=; b=LCknBvD1Gk5w58WGBle9dpfmm4qf7a+fWbPCk5O64xcdtOP6m4VeAOPB0sJzh5WpaokuOSLnRmKB4IawChT8TrMPBQLO9Bhbc3emHy91RpQTxEEGsONBcJVKc+ccZPrAWHVpZvpe7Ir9rbQHGtLFLiJGzEj/mbDcEJRV4Jg0/uQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16687059840431006.8378205645151; Thu, 17 Nov 2022 09:26:24 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovieG-0006Qy-3N; Thu, 17 Nov 2022 12:26:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovie5-0006Lr-Mx for qemu-devel@nongnu.org; Thu, 17 Nov 2022 12:25:49 -0500 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovie2-0006FW-Bd for qemu-devel@nongnu.org; Thu, 17 Nov 2022 12:25:49 -0500 Received: by mail-wr1-x42e.google.com with SMTP id v1so4923656wrt.11 for ; Thu, 17 Nov 2022 09:25:43 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id b14-20020a5d4d8e000000b0022cbf4cda62sm1754696wru.27.2022.11.17.09.25.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 09:25:39 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 26A771FFC4; Thu, 17 Nov 2022 17:25:34 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oMlvtnFEABWg8w92G/8HRIs95GXnsgMR5Vml1n/BCPw=; b=dWSPr9U14LI9Lv3mBmWZtcjDj3ICSFiaSrIZzGqEbWuR0Rk1k/93d2FGzCP+dM7DTs lvhGLGPJKPuUwS31VjeZAfMd0+3TF/CB6Mfn365UZreSGRO9cG2OKsXq0ES2MWdInaAJ Snq9NwSke0nSk0LSuT8olP9rMPaVieTmM3YgiJynOg7972NyERrMfr60CWPETu57ONsr /9UCcj+aRZsEbGlyzn2lTi1cxodkxwRMe6fN0Y/fyPt6hywkVhAVaPYM7cH2ueHpMkqU yzzntf54nPnDt+hAicS5Gs0nIezjyp3grVh8PJcY2jg73boqsLade2GbOva2fkdgdGMg nduw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oMlvtnFEABWg8w92G/8HRIs95GXnsgMR5Vml1n/BCPw=; b=KDUcbu7mlo0J5COHf2lrxBDCxIJPNBKMbZQIQ6vn4vRCfN0srTZEesNLPb/eLMNv+G K/bAjcseoiSsNzKhbwqNSLnYG8kJyFq8wgMEsu1S6kb5ZMYq1M5ZYB74I15QpKsalmYs Ql3OaWkge/qhCeuvls2aC0WPO9JEK5rN2yrq8ig4/N3DX1Ftu6d1e9ybIHYH3PdDT/QL 0IaqovN6016b0KHn8T39y3HR+bOyMwfUdTgc+3bK8Y3XnQ4WZWJSDkTbIA808hmxMDmL q2knh+iDjMxmXdoSuQttVQfJUO9HlPqcVF/XmdG+zDnpBMKlfrU248+lmIrLXokrk+HU HzLg== X-Gm-Message-State: ANoB5plPMIw+cVon1c4nOabZ0+tNSnFECLSXq/i+/YPzkmSNl2vbQ5k8 06BtVpqCF/YmteQm7hTSyxqLeA== X-Google-Smtp-Source: AA0mqf6w03dmOokpDf2zEvyjyh+JeNtx5PVKaeqJeAy3oiIBN740CXhUBnGzSxFXUaOSb2OyLDy6zw== X-Received: by 2002:adf:ff89:0:b0:22e:38b:95ff with SMTP id j9-20020adfff89000000b0022e038b95ffmr2009971wrr.202.1668705942142; Thu, 17 Nov 2022 09:25:42 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: fam@euphon.net, berrange@redhat.com, f4bug@amsat.org, aurelien@aurel32.net, pbonzini@redhat.com, stefanha@redhat.com, crosa@redhat.com, Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Wainer dos Santos Moschetta , Beraldo Leal Subject: [PATCH v3 13/13] ci: replace x86_64 macos-11 with aarch64 macos-12 Date: Thu, 17 Nov 2022 17:25:32 +0000 Message-Id: <20221117172532.538149-14-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221117172532.538149-1-alex.bennee@linaro.org> References: <20221117172532.538149-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1668705985818100003 From: Daniel P. Berrang=C3=A9 The Cirrus CI service has announced the intent to discontinue support for x86_64 macOS CI runners. They already have aarch64 runners available and require all projects to switch to these images before Jan 1st 2023. The different architecture is merely determined by the image name requested. For aarch64 they only support macOS 12 onwards. At the same time our support policy only guarantees the most recent 2 major versions, so macOS 12 is already technically our min version. https://cirrus-ci.org/blog/2022/11/08/sunsetting-intel-macos-instances/ Signed-off-by: Daniel P. Berrang=C3=A9 Tested-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20221116175023.80627-1-berrange@redhat.com> Signed-off-by: Alex Benn=C3=A9e --- .gitlab-ci.d/cirrus.yml | 12 ++++++------ .gitlab-ci.d/cirrus/{macos-11.vars =3D> macos-12.vars} | 12 ++++++------ tests/lcitool/libvirt-ci | 2 +- tests/lcitool/refresh | 2 +- 4 files changed, 14 insertions(+), 14 deletions(-) rename .gitlab-ci.d/cirrus/{macos-11.vars =3D> macos-12.vars} (74%) diff --git a/.gitlab-ci.d/cirrus.yml b/.gitlab-ci.d/cirrus.yml index d70da61248..634a73a742 100644 --- a/.gitlab-ci.d/cirrus.yml +++ b/.gitlab-ci.d/cirrus.yml @@ -70,19 +70,19 @@ x64-freebsd-13-build: INSTALL_COMMAND: pkg install -y TEST_TARGETS: check =20 -x64-macos-11-base-build: +aarch64-macos-12-base-build: extends: .cirrus_build_job variables: - NAME: macos-11 - CIRRUS_VM_INSTANCE_TYPE: osx_instance + NAME: macos-12 + CIRRUS_VM_INSTANCE_TYPE: macos_instance CIRRUS_VM_IMAGE_SELECTOR: image - CIRRUS_VM_IMAGE_NAME: big-sur-base + CIRRUS_VM_IMAGE_NAME: ghcr.io/cirruslabs/macos-monterey-base:latest CIRRUS_VM_CPUS: 12 CIRRUS_VM_RAM: 24G UPDATE_COMMAND: brew update INSTALL_COMMAND: brew install - PATH_EXTRA: /usr/local/opt/ccache/libexec:/usr/local/opt/gettext/bin - PKG_CONFIG_PATH: /usr/local/opt/curl/lib/pkgconfig:/usr/local/opt/ncur= ses/lib/pkgconfig:/usr/local/opt/readline/lib/pkgconfig + PATH_EXTRA: /opt/homebrew/ccache/libexec:/opt/homebrew/gettext/bin + PKG_CONFIG_PATH: /opt/homebrew/curl/lib/pkgconfig:/opt/homebrew/ncurse= s/lib/pkgconfig:/opt/homebrew/readline/lib/pkgconfig TEST_TARGETS: check-unit check-block check-qapi-schema check-softfloat= check-qtest-x86_64 =20 =20 diff --git a/.gitlab-ci.d/cirrus/macos-11.vars b/.gitlab-ci.d/cirrus/macos-= 12.vars similarity index 74% rename from .gitlab-ci.d/cirrus/macos-11.vars rename to .gitlab-ci.d/cirrus/macos-12.vars index aee9f50de6..ef9e14b373 100644 --- a/.gitlab-ci.d/cirrus/macos-11.vars +++ b/.gitlab-ci.d/cirrus/macos-12.vars @@ -1,16 +1,16 @@ # THIS FILE WAS AUTO-GENERATED # -# $ lcitool variables macos-11 qemu +# $ lcitool variables macos-12 qemu # # https://gitlab.com/libvirt/libvirt-ci =20 -CCACHE=3D'/usr/local/bin/ccache' +CCACHE=3D'/opt/homebrew/bin/ccache' CPAN_PKGS=3D'' CROSS_PKGS=3D'' -MAKE=3D'/usr/local/bin/gmake' -NINJA=3D'/usr/local/bin/ninja' +MAKE=3D'/opt/homebrew/bin/gmake' +NINJA=3D'/opt/homebrew/bin/ninja' PACKAGING_COMMAND=3D'brew' -PIP3=3D'/usr/local/bin/pip3' +PIP3=3D'/opt/homebrew/bin/pip3' PKGS=3D'bash bc bison bzip2 capstone ccache cmocka ctags curl dbus diffuti= ls dtc flex gcovr gettext git glib gnu-sed gnutls gtk+3 jemalloc jpeg-turbo= json-c libepoxy libffi libgcrypt libiscsi libnfs libpng libslirp libssh li= btasn1 libusb llvm lzo make meson ncurses nettle ninja perl pixman pkg-conf= ig python3 rpm2cpio sdl2 sdl2_image snappy sparse spice-protocol tesseract = texinfo usbredir vde vte3 zlib zstd' PYPI_PKGS=3D'PyYAML numpy pillow sphinx sphinx-rtd-theme' -PYTHON=3D'/usr/local/bin/python3' +PYTHON=3D'/opt/homebrew/bin/python3' diff --git a/tests/lcitool/libvirt-ci b/tests/lcitool/libvirt-ci index d40e203631..e3eb28cf2e 160000 --- a/tests/lcitool/libvirt-ci +++ b/tests/lcitool/libvirt-ci @@ -1 +1 @@ -Subproject commit d40e203631eb3eacee17e8cf8fd20aa5152db62a +Subproject commit e3eb28cf2e17fbcf7fe7e19505ee432b8ec5bbb5 diff --git a/tests/lcitool/refresh b/tests/lcitool/refresh index ce0b24c0b1..fa966e4009 100755 --- a/tests/lcitool/refresh +++ b/tests/lcitool/refresh @@ -176,7 +176,7 @@ try: # generate_cirrus("freebsd-12") generate_cirrus("freebsd-13") - generate_cirrus("macos-11") + generate_cirrus("macos-12") =20 sys.exit(0) except Exception as ex: --=20 2.34.1