From nobody Tue Feb 10 21:41:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1668162711; cv=none; d=zohomail.com; s=zohoarc; b=g+TYQii6tIEZGrZnfaaHfddV1Jte/DwTWvGi/4YD9dq4h8Y5F5L9peMjTNhbVeZoPb7VG9YpmKqcqKh7cn45xqR0ridX7wOah0M8JATh1+tN4qf3xwvck7eqH0ir6gy7V1Q88rix3DGypci3HVupc1/70ouJK3LYH0TmLdbBtsE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668162711; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Cwe5B57sWClZbcai1js1rXky9401kBIE+zgEgWTZFcw=; b=XrwlA4TvTOgmn+O4qrWzPLuRdLHOeB397URzD7OZ7s/brFOOkPEGOMBpfRw57hcL6MJIf+Wd545RjbsPDEOz9BRTZzuDztf9GJez+t8ygAt9BEh8aoQV4n7vHTEdG+KbJgNwowfuNj2hzeqLPP5SYFuTHjEktIIvsn0TZ1XmlWE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1668162711740341.91580136610276; Fri, 11 Nov 2022 02:31:51 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otRJN-0007XE-Rp; Fri, 11 Nov 2022 05:31:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otRJJ-0007UB-Qw for qemu-devel@nongnu.org; Fri, 11 Nov 2022 05:30:57 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otRJI-0000f6-81 for qemu-devel@nongnu.org; Fri, 11 Nov 2022 05:30:57 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-251-YrGSbagSO8m9TKjx-dnMAA-1; Fri, 11 Nov 2022 05:30:54 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CFBE785A5B6 for ; Fri, 11 Nov 2022 10:30:53 +0000 (UTC) Received: from thuth.com (dhcp-192-232.str.redhat.com [10.33.192.232]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4D93B2023272; Fri, 11 Nov 2022 10:30:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668162655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cwe5B57sWClZbcai1js1rXky9401kBIE+zgEgWTZFcw=; b=d/1KZL75IoIddoaIcCysSjTRSeNDSeFFbFvYsRD2RvZzrjICKu1RYkwQtc3fzJ0fS0jI4E GT/+fkWzNH3tG99l4Hmd/eXBXlsER4VyooYcUbhY77MrAadOPYYZcWfskZ6Vq8QZzkGS3/ wN89Nu8kFHpQu45WQOjLbwMU/9eROYg= X-MC-Unique: YrGSbagSO8m9TKjx-dnMAA-1 From: Thomas Huth To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Miroslav Rezanina Subject: [PULL 4/8] host-libusb: Remove unused variable Date: Fri, 11 Nov 2022 11:30:44 +0100 Message-Id: <20221111103048.202519-5-thuth@redhat.com> In-Reply-To: <20221111103048.202519-1-thuth@redhat.com> References: <20221111103048.202519-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1668162712564100001 Content-Type: text/plain; charset="utf-8" From: Miroslav Rezanina Variable unconnected used in usb_host_auto_check function is only increment= ed but never read as line where it is read was disabled since introducing the = code. This causes 'Unused but set variable' warning on Clang 15.0.1 compiler. Removing the variable and disabled code to prevent the warning. Signed-off-by: Miroslav Rezanina Reviewed-by: Thomas Huth Message-Id: <00df0db69ff9167d38bac81f6d03281955bd861a.1668009030.git.mrezan= in@redhat.com> Signed-off-by: Thomas Huth --- hw/usb/host-libusb.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index 28f8af8941..176868d345 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -1837,7 +1837,6 @@ static void usb_host_auto_check(void *unused) struct USBAutoFilter *f; libusb_device **devs =3D NULL; struct libusb_device_descriptor ddesc; - int unconnected =3D 0; int i, n; =20 if (usb_host_init() !=3D 0) { @@ -1897,9 +1896,6 @@ static void usb_host_auto_check(void *unused) libusb_free_device_list(devs, 1); =20 QTAILQ_FOREACH(s, &hostdevs, next) { - if (s->dh =3D=3D NULL) { - unconnected++; - } if (s->seen =3D=3D 0) { if (s->dh) { usb_host_close(s); @@ -1908,17 +1904,6 @@ static void usb_host_auto_check(void *unused) } s->seen =3D 0; } - -#if 0 - if (unconnected =3D=3D 0) { - /* nothing to watch */ - if (usb_auto_timer) { - timer_del(usb_auto_timer); - trace_usb_host_auto_scan_disabled(); - } - return; - } -#endif } =20 if (!usb_vmstate) { --=20 2.31.1