From nobody Tue Feb 10 17:08:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1667483091; cv=none; d=zohomail.com; s=zohoarc; b=bqbCBP7f4cE34AV7SJcfTDpuuH+CCu7iTbslVLo/vjWLTre0Dw4H3fcoV0LPgnrQ5nj7/vV3Km36NUWaK64KLOUlx3eSZHhrmJO7DOToD/wr/aw+HARO7B6omzgqotAQkLTO5SJHfnB3VEbyvsqsbXhaWRPLeibhBC1+GMPv/gE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1667483091; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MxSYuQsbp/lTdxsuWIZ2njnzhmLoVdg96ID1GpwwD9I=; b=mJvraMGBPxdkjXzsmbi8CaKt6Rv1LiqU0vZH15zFF37UVWo2ECwHhUDRkS440WrlWfPXm59NwK0hpXgj3P4w/pt7IDPgFm75PIC8m3oFawqpIMIk4cXEbTOdwAMQcjYKmhB8vwv7CA5lcRgxRR3rB8lUWVsAk2f3DLdIQS+4Vso= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1667483091403524.8368180801526; Thu, 3 Nov 2022 06:44:51 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqaUd-0001Ys-34; Thu, 03 Nov 2022 09:42:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqaUH-0001Ow-59 for qemu-devel@nongnu.org; Thu, 03 Nov 2022 09:42:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqaU9-0002AW-0c for qemu-devel@nongnu.org; Thu, 03 Nov 2022 09:42:27 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-73-Eb3nd6bmP4GjC0HkYHekBQ-1; Thu, 03 Nov 2022 09:42:09 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1651C3C0F24B; Thu, 3 Nov 2022 13:42:09 +0000 (UTC) Received: from virtlab701.virt.lab.eng.bos.redhat.com (virtlab701.virt.lab.eng.bos.redhat.com [10.19.152.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id CF88B40C6EC3; Thu, 3 Nov 2022 13:42:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667482932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MxSYuQsbp/lTdxsuWIZ2njnzhmLoVdg96ID1GpwwD9I=; b=cfSmxPr4SIGI82405mNX08uH/oMUJGuY0ipyoSI+ftwC9luyRFpeLOrSviRAvsYLMJ6gzt 4qLuH+SUrtqyiZ1MWfWC97aB+7duPiZn0Lg7SQNutga4Dp0EerkqhW935+3vfjrUyouprr jNu3yuN15mNo+j83q688Ni2oyCEzlHQ= X-MC-Unique: Eb3nd6bmP4GjC0HkYHekBQ-1 From: Emanuele Giuseppe Esposito To: qemu-block@nongnu.org Cc: Kevin Wolf , Hanna Reitz , John Snow , Vladimir Sementsov-Ogievskiy , Eric Blake , Fam Zheng , qemu-devel@nongnu.org, Emanuele Giuseppe Esposito Subject: [PATCH 1/9] block: call bdrv_co_drain_begin in a coroutine Date: Thu, 3 Nov 2022 09:41:58 -0400 Message-Id: <20221103134206.4041928-2-eesposit@redhat.com> In-Reply-To: <20221103134206.4041928-1-eesposit@redhat.com> References: <20221103134206.4041928-1-eesposit@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=eesposit@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.047, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Qemu-devel" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1667483094650100007 Content-Type: text/plain; charset="utf-8" It seems that bdrv_open_driver() forgot to create a coroutine where to call bs->drv->bdrv_co_drain_begin(), a callback marked as coroutine_fn. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Paolo Bonzini --- block.c | 32 +++++++++++++++++++++++++++----- 1 file changed, 27 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index 5311b21f8e..7211f62001 100644 --- a/block.c +++ b/block.c @@ -1637,12 +1637,34 @@ out: g_free(gen_node_name); } =20 +typedef struct DrainCo { + BlockDriverState *bs; + int ret; +} DrainCo; + +static void coroutine_fn bdrv_co_drain_begin(void *opaque) +{ + int i; + DrainCo *co =3D opaque; + BlockDriverState *bs =3D co->bs; + + for (i =3D 0; i < bs->quiesce_counter; i++) { + bs->drv->bdrv_co_drain_begin(bs); + } + co->ret =3D 0; +} + static int bdrv_open_driver(BlockDriverState *bs, BlockDriver *drv, const char *node_name, QDict *options, int open_flags, Error **errp) { Error *local_err =3D NULL; - int i, ret; + int ret; + Coroutine *co; + DrainCo dco =3D { + .bs =3D bs, + .ret =3D NOT_DONE, + }; GLOBAL_STATE_CODE(); =20 bdrv_assign_node_name(bs, node_name, &local_err); @@ -1690,10 +1712,10 @@ static int bdrv_open_driver(BlockDriverState *bs, B= lockDriver *drv, assert(bdrv_min_mem_align(bs) !=3D 0); assert(is_power_of_2(bs->bl.request_alignment)); =20 - for (i =3D 0; i < bs->quiesce_counter; i++) { - if (drv->bdrv_co_drain_begin) { - drv->bdrv_co_drain_begin(bs); - } + if (drv->bdrv_co_drain_begin) { + co =3D qemu_coroutine_create(bdrv_co_drain_begin, &dco); + qemu_coroutine_enter(co); + AIO_WAIT_WHILE(qemu_get_aio_context(), dco.ret =3D=3D NOT_DONE); } =20 return 0; --=20 2.31.1