From nobody Tue Feb 10 08:28:02 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1667379269; cv=none; d=zohomail.com; s=zohoarc; b=ZkZqPwrcLMNHIkSX98Jz5CUSLNq8xIrZyMyejlikshyMw+CcxlGJVARDx7R8ESsHgzANbdTBBcUU6p9bdd4Wh+8qQln0LxNiAUZNOjSf004e1WjipfGD+fvixYWhmQ8HJDXtu90kGZJRNiVYLtgOH3MUrEg+86sHXYKtdfKkbbg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1667379269; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MmCJ2U12tzo+Wbt2m0n4AHSfoDwhIatJeRbP5EkKA7A=; b=MsS/SYPSFd6hwjJ7Rq11gHtQglbmd/e5W9jBVY4ZT4vgdu1Dz4lqTlr2YJU+ZKICAt+vGItiPO69DYtLduZhaK7TASN4rbKfHmO+T7YM/2GAOaZTyajtixM8khxZsJUwk7kdzasqv0x5D2BmC+XU5bDSpxfV1tztrVIvpUtr8UE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1667379269404950.0858941493395; Wed, 2 Nov 2022 01:54:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oq9V4-0005P5-2G; Wed, 02 Nov 2022 04:53:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oq9Uv-0005Ne-CR for qemu-devel@nongnu.org; Wed, 02 Nov 2022 04:53:22 -0400 Received: from mga04.intel.com ([192.55.52.120]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oq9Ut-0008AD-JQ for qemu-devel@nongnu.org; Wed, 02 Nov 2022 04:53:21 -0400 Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2022 01:52:57 -0700 Received: from b49691a74b20.jf.intel.com ([10.45.76.123]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2022 01:52:57 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667379199; x=1698915199; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=UyZWp1kELLoxMAnHvZybWFAVmfkD9Fko8h5Vk+D9uTQ=; b=bBkscSrwt9Ihpb8w6S0mlzZRntt8fn9J9SZQgf6zWL73iih38j5IhpQT AR7W+7prQNhSyr4H/0/yPE5prO5qg29MDJGdzMjejfKWgZMPUgdq4kT5N VlQcMOLoCjp+wZmf21NItTeXL32JaowjvFKvJyp2AV6Z0PJWmlnif09cg LF/88Y4B1gGHzUSAPrgEJ+AnObRZRDdKjt9oFfjGQhRF7dKjIzsif8GGO 8RKp2QEhtwg4+ZlvemCNPWHC6WkXkzuv6f15l91dMvPpoJ2VhmD5Vpoc1 5ChlNtnb8UZHccAOx55uNiMYN5XLAP1QbrlfqU7Zo1ZAGfmccUcEBqctr A==; X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="308072273" X-IronPort-AV: E=Sophos;i="5.95,232,1661842800"; d="scan'208";a="308072273" X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="963447212" X-IronPort-AV: E=Sophos;i="5.95,232,1661842800"; d="scan'208";a="963447212" From: "Wang, Lei" To: pbonzini@redhat.com Cc: qemu-devel@nongnu.org, dgilbert@redhat.com, berrange@redhat.com, xiaoyao.li@intel.com, yang.zhong@linux.intel.com Subject: [PATCH v2 1/6] i386: Introduce FeatureWordInfo for AMX CPUID leaf 0x1D and 0x1E Date: Wed, 2 Nov 2022 01:52:51 -0700 Message-Id: <20221102085256.81139-2-lei4.wang@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221102085256.81139-1-lei4.wang@intel.com> References: <20221102085256.81139-1-lei4.wang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=192.55.52.120; envelope-from=lei4.wang@intel.com; helo=mga04.intel.com X-Spam_score_int: -53 X-Spam_score: -5.4 X-Spam_bar: ----- X-Spam_report: (-5.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.051, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UPPERCASE_50_75=0.008 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Qemu-devel" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1667379272144100003 Content-Type: text/plain; charset="utf-8" CPUID leaf 0x1D and 0x1E enumerate tile and TMUL information for AMX. Introduce FeatureWord FEAT_1D_1_EAX, FEAT_1D_1_EBX, FEAT_1D_1_ECX and FEAT_1E_0_EBX. Thus these features of AMX can be expanded when "-cpu host/max" and can be configured in named CPU model. Signed-off-by: Wang, Lei --- target/i386/cpu.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++ target/i386/cpu.h | 12 +++++++++++ 2 files changed, 67 insertions(+) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 8a11470507..e98780773c 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -1002,6 +1002,45 @@ FeatureWordInfo feature_word_info[FEATURE_WORDS] =3D= { }, .tcg_features =3D ~0U, }, + [FEAT_1D_1_EAX] =3D { + .type =3D CPUID_FEATURE_WORD, + .cpuid =3D { + .eax =3D 0x1D, + .needs_ecx =3D true, .ecx =3D 1, + .reg =3D R_EAX, + }, + .migratable_flags =3D CPUID_AMX_PALETTE_1_TOTAL_TILE_BYTES_MASK | + CPUID_AMX_PALETTE_1_BYTES_PER_TILE_MASK, + }, + [FEAT_1D_1_EBX] =3D { + .type =3D CPUID_FEATURE_WORD, + .cpuid =3D { + .eax =3D 0x1D, + .needs_ecx =3D true, .ecx =3D 1, + .reg =3D R_EBX, + }, + .migratable_flags =3D CPUID_AMX_PALETTE_1_BYTES_PER_ROW_MASK | + CPUID_AMX_PALETTE_1_MAX_NAMES_MASK, + }, + [FEAT_1D_1_ECX] =3D { + .type =3D CPUID_FEATURE_WORD, + .cpuid =3D { + .eax =3D 0x1D, + .needs_ecx =3D true, .ecx =3D 1, + .reg =3D R_ECX, + }, + .migratable_flags =3D CPUID_AMX_PALETTE_1_MAX_ROWS_MASK, + }, + [FEAT_1E_0_EBX] =3D { + .type =3D CPUID_FEATURE_WORD, + .cpuid =3D { + .eax =3D 0x1E, + .needs_ecx =3D true, .ecx =3D 0, + .reg =3D R_EBX, + }, + .migratable_flags =3D CPUID_AMX_TMUL_MAX_K_MASK | + CPUID_AMX_TMUL_MAX_N_MASK, + }, /*Below are MSR exposed features*/ [FEAT_ARCH_CAPABILITIES] =3D { .type =3D MSR_FEATURE_WORD, @@ -1371,6 +1410,22 @@ static FeatureDep feature_dependencies[] =3D { .from =3D { FEAT_7_0_EBX, CPUID_7_0_EBX_INTEL_PT }, .to =3D { FEAT_14_0_ECX, ~0ull }, }, + { + .from =3D { FEAT_7_0_EDX, CPUID_7_0_EDX_AMX_TILE }, + .to =3D { FEAT_1D_1_EAX, ~0ull }, + }, + { + .from =3D { FEAT_7_0_EDX, CPUID_7_0_EDX_AMX_TILE }, + .to =3D { FEAT_1D_1_EBX, ~0ull }, + }, + { + .from =3D { FEAT_7_0_EDX, CPUID_7_0_EDX_AMX_TILE }, + .to =3D { FEAT_1D_1_ECX, ~0ull }, + }, + { + .from =3D { FEAT_7_0_EDX, CPUID_7_0_EDX_AMX_TILE }, + .to =3D { FEAT_1E_0_EBX, ~0ull }, + }, { .from =3D { FEAT_8000_0001_EDX, CPUID_EXT2_RDTSCP }, .to =3D { FEAT_VMX_SECONDARY_CTLS, VMX_SECONDARY_EXEC_RDTSCP }, diff --git a/target/i386/cpu.h b/target/i386/cpu.h index 7edf5dfac3..1c90fb6c9d 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -583,6 +583,14 @@ typedef enum X86Seg { XSTATE_Hi16_ZMM_MASK | XSTATE_PKRU_MASK |= \ XSTATE_XTILE_CFG_MASK | XSTATE_XTILE_DATA= _MASK) =20 +#define CPUID_AMX_PALETTE_1_TOTAL_TILE_BYTES_MASK 0xffffU +#define CPUID_AMX_PALETTE_1_BYTES_PER_TILE_MASK (0xffffU << 16) +#define CPUID_AMX_PALETTE_1_BYTES_PER_ROW_MASK 0xffffU +#define CPUID_AMX_PALETTE_1_MAX_NAMES_MASK (0xffffU << 16) +#define CPUID_AMX_PALETTE_1_MAX_ROWS_MASK 0xffffU +#define CPUID_AMX_TMUL_MAX_K_MASK 0xffU +#define CPUID_AMX_TMUL_MAX_N_MASK (0xffffU << 8) + /* CPUID feature words */ typedef enum FeatureWord { FEAT_1_EDX, /* CPUID[1].EDX */ @@ -603,6 +611,10 @@ typedef enum FeatureWord { FEAT_6_EAX, /* CPUID[6].EAX */ FEAT_XSAVE_XCR0_LO, /* CPUID[EAX=3D0xd,ECX=3D0].EAX */ FEAT_XSAVE_XCR0_HI, /* CPUID[EAX=3D0xd,ECX=3D0].EDX */ + FEAT_1D_1_EAX, /* CPUID[EAX=3D0x1d,ECX=3D1].EAX */ + FEAT_1D_1_EBX, /* CPUID[EAX=3D0x1d,ECX=3D1].EBX */ + FEAT_1D_1_ECX, /* CPUID[EAX=3D0x1d,ECX=3D1].ECX */ + FEAT_1E_0_EBX, /* CPUID[EAX=3D0x1e,ECX=3D0].EBX */ FEAT_ARCH_CAPABILITIES, FEAT_CORE_CAPABILITY, FEAT_PERF_CAPABILITIES, --=20 2.34.1