From nobody Mon Feb 9 06:45:51 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1666937556; cv=none; d=zohomail.com; s=zohoarc; b=mfrHS2ZsMEbkvul/vkl3t8YpMO2CPO5Z5xNVcF5eg1Gv5M9/ONMmIcHS2CYXv8NdMcQh1E7YD6Ou/nz6Ubs0DIdgP0bScArqaRt66eud1dgFHzwkgyEbm/mYVr+lH0A4wzLmfG1vTZkRomLL+cUUMg8+6mqn1HX3qoBzREs6V4s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1666937556; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=TSwDoQyZm2FvzfZUy7L+FCrik6XLBXN1qbdZ3KrCO8U=; b=G55r4MxkEuz9/bQVOeNlBXrOlY/wP+rayDIjfpr90S+37JSGur9Mtjs0mM7ryS2eDsWhtkJ6PmyoM2zmAjJfjWZ0AF5EWmiTtsIviqFWzyJWfY6NnUm2yyPM2utR4+X3LAo4+kC7j5rwotCQImLkvJWB7SYvd5H2JqJJmNCsLyE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1666937556342562.4666392550782; Thu, 27 Oct 2022 23:12:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooIYm-0005DA-B2; Fri, 28 Oct 2022 02:09:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooIXt-0004su-P6 for qemu-devel@nongnu.org; Fri, 28 Oct 2022 02:08:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooIXa-0006yW-2S for qemu-devel@nongnu.org; Fri, 28 Oct 2022 02:08:36 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-650-RwVwdjNBP0q92BjQ3Ic8JA-1; Fri, 28 Oct 2022 02:08:17 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 99257101A52A for ; Fri, 28 Oct 2022 06:08:17 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.195.118]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6AF5940C206B; Fri, 28 Oct 2022 06:08:17 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 5728721E6930; Fri, 28 Oct 2022 08:08:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666937299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TSwDoQyZm2FvzfZUy7L+FCrik6XLBXN1qbdZ3KrCO8U=; b=fIxbOc+JdAySCdSBo4lbNidkU4uclMWlqH9MfvZOE4+iQCAkFuZyTd9sezITRVFK2vDukA 9WZuSofOcg80qfmcskJI8UiTiaCd/O4CgXD/qF6Q6xbjV/DVcTrS127JtBo64b6bp4zEXg eFMxf7nuATUYBYfNY7f3EQCm/wXcYLQ= X-MC-Unique: RwVwdjNBP0q92BjQ3Ic8JA-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, David Hildenbrand Subject: [PULL 1/4] qom: Improve error messages when property has no getter or setter Date: Fri, 28 Oct 2022 08:08:13 +0200 Message-Id: <20221028060816.641399-2-armbru@redhat.com> In-Reply-To: <20221028060816.641399-1-armbru@redhat.com> References: <20221028060816.641399-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.515, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Qemu-devel" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1666937558062100003 Content-Type: text/plain; charset="utf-8" When you try to set a property that has no setter, the error message blames "insufficient permission": $ qemu-system-x86_64 -S -display none -nodefaults -monitor stdio QEMU 7.1.50 monitor - type 'help' for more information (qemu) qom-set /machine type q35 Error: Insufficient permission to perform this operation This implies it could work with "sufficient permission". It can't. Change the error message to: Error: Property 'pc-i440fx-7.2-machine.type' is not writable Do the same for getting a property that has no getter. Signed-off-by: Markus Armbruster Message-Id: <20221012153801.2604340-2-armbru@redhat.com> Reviewed-by: David Hildenbrand --- qom/object.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/qom/object.c b/qom/object.c index d34608558e..e5cef30f6d 100644 --- a/qom/object.c +++ b/qom/object.c @@ -1383,7 +1383,8 @@ bool object_property_get(Object *obj, const char *nam= e, Visitor *v, } =20 if (!prop->get) { - error_setg(errp, QERR_PERMISSION_DENIED); + error_setg(errp, "Property '%s.%s' is not readable", + object_get_typename(obj), name); return false; } prop->get(obj, v, name, prop->opaque, &err); @@ -1402,7 +1403,8 @@ bool object_property_set(Object *obj, const char *nam= e, Visitor *v, } =20 if (!prop->set) { - error_setg(errp, QERR_PERMISSION_DENIED); + error_setg(errp, "Property '%s.%s' is not writable", + object_get_typename(obj), name); return false; } prop->set(obj, v, name, prop->opaque, errp); --=20 2.37.3 From nobody Mon Feb 9 06:45:51 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1666937524; cv=none; d=zohomail.com; s=zohoarc; b=n6tjXYRJwyDu7vr168u0MUEIrmJyHJ369vgURkBzq7TdHf7wj9ejy8jimBjAupaYheB/kUEli/j3W08hh2XCq3Il46QxVzb/xywu7IC44/6Gfew7zYkyP2rQ20iyRjhIN6vDCF1s3HtmpsNwjaGg6j36zOXtbi9jkLsX0x77shs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1666937524; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5D1UX9nevBRlIVhEGGKzRQonkoN6RM26Jymu1RxkV6s=; b=ENotJw26aiKJoi7XvVwNBC4Bi5DTXhpBxRhKt9uaMduvIErYRxbUTXxWRhvW6pMa+XH2M4YgC8gBCqg1kDqxtnBbnWqS9lVNqMBefnoO/F8xGS5ZZtIrF5OZMqjRJxrRhhEoeb/gTqR2chuDIrMy5kC/wqVrlEECCFT4r9BZqj8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1666937524404802.8291854072428; Thu, 27 Oct 2022 23:12:04 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooIYk-0005BS-Lf; Fri, 28 Oct 2022 02:09:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooIXu-0004ti-1j for qemu-devel@nongnu.org; Fri, 28 Oct 2022 02:08:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooIXZ-0006yj-VQ for qemu-devel@nongnu.org; Fri, 28 Oct 2022 02:08:43 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-662-6INatJ7uN96hPHOp_J998A-1; Fri, 28 Oct 2022 02:08:17 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A0BE5185A794 for ; Fri, 28 Oct 2022 06:08:17 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.195.118]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6AE644221F; Fri, 28 Oct 2022 06:08:17 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 5989A21E6936; Fri, 28 Oct 2022 08:08:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666937299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5D1UX9nevBRlIVhEGGKzRQonkoN6RM26Jymu1RxkV6s=; b=WbOEbVt2dXcWA+VFk0NL+VZr3SpCWi2xYAnblcW7JWPbmxqgoYuYnxARanr9jv55vd+ZQL sfLwg1E4s7RO5geWsMdXjwklyTkAO546coW9k7zrCz1eYRD7Pfxk7sNgNmOlZcgVe2UeJT j4o4upLlEwiL7OpUhptnR3+mv8PEemU= X-MC-Unique: 6INatJ7uN96hPHOp_J998A-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, "Michael S . Tsirkin" Subject: [PULL 2/4] backends: Improve error messages when property can no longer be set Date: Fri, 28 Oct 2022 08:08:14 +0200 Message-Id: <20221028060816.641399-3-armbru@redhat.com> In-Reply-To: <20221028060816.641399-1-armbru@redhat.com> References: <20221028060816.641399-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.515, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Qemu-devel" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1666937526272100001 Content-Type: text/plain; charset="utf-8" When you try to set virtio-rng property "filename" after the backend has been completed with user_creatable_complete(), the error message blames "insufficient permission": $ qemu-system-x86_64 -S -display none -nodefaults -monitor stdio -objec= t rng-random,id=3Drng0 -device virtio-rng,id=3Dvrng0,rng=3Drng0 QEMU 7.1.50 monitor - type 'help' for more information (qemu) qom-set /objects/rng0 filename /dev/random Error: Insufficient permission to perform this operation This implies it could work with "sufficient permission". It can't. Change the error message to: Error: Property 'filename' can no longer be set Same for cryptodev-vhost-user property "chardev", rng-egd property "chardev", and vhost-user-backend property "chardev". Signed-off-by: Markus Armbruster Message-Id: <20221012153801.2604340-3-armbru@redhat.com> Acked-by: Michael S. Tsirkin [Commit message tidied up] --- backends/cryptodev-vhost-user.c | 2 +- backends/rng-egd.c | 2 +- backends/rng-random.c | 2 +- backends/vhost-user.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/backends/cryptodev-vhost-user.c b/backends/cryptodev-vhost-use= r.c index 5443a59153..f9c5867e38 100644 --- a/backends/cryptodev-vhost-user.c +++ b/backends/cryptodev-vhost-user.c @@ -339,7 +339,7 @@ static void cryptodev_vhost_user_set_chardev(Object *ob= j, CRYPTODEV_BACKEND_VHOST_USER(obj); =20 if (s->opened) { - error_setg(errp, QERR_PERMISSION_DENIED); + error_setg(errp, "Property 'chardev' can no longer be set"); } else { g_free(s->chr_name); s->chr_name =3D g_strdup(value); diff --git a/backends/rng-egd.c b/backends/rng-egd.c index 4de142b9dc..684c3cf3d6 100644 --- a/backends/rng-egd.c +++ b/backends/rng-egd.c @@ -116,7 +116,7 @@ static void rng_egd_set_chardev(Object *obj, const char= *value, Error **errp) RngEgd *s =3D RNG_EGD(b); =20 if (b->opened) { - error_setg(errp, QERR_PERMISSION_DENIED); + error_setg(errp, "Property 'chardev' can no longer be set"); } else { g_free(s->chr_name); s->chr_name =3D g_strdup(value); diff --git a/backends/rng-random.c b/backends/rng-random.c index 7add272edd..80eb5be138 100644 --- a/backends/rng-random.c +++ b/backends/rng-random.c @@ -96,7 +96,7 @@ static void rng_random_set_filename(Object *obj, const ch= ar *filename, RngRandom *s =3D RNG_RANDOM(obj); =20 if (b->opened) { - error_setg(errp, QERR_PERMISSION_DENIED); + error_setg(errp, "Property 'filename' can no longer be set"); return; } =20 diff --git a/backends/vhost-user.c b/backends/vhost-user.c index 10b39992d2..5dedb2d987 100644 --- a/backends/vhost-user.c +++ b/backends/vhost-user.c @@ -141,7 +141,7 @@ static void set_chardev(Object *obj, const char *value,= Error **errp) Chardev *chr; =20 if (b->completed) { - error_setg(errp, QERR_PERMISSION_DENIED); + error_setg(errp, "Property 'chardev' can no longer be set"); return; } =20 --=20 2.37.3 From nobody Mon Feb 9 06:45:51 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1666937549; cv=none; d=zohomail.com; s=zohoarc; b=eL9dTiZ7AalXKMwZwou1aSjgEv07TjdgDsVz2Umn6HFr2taB4ug27O51ZlDlenmR0706mjWJslXdJuxPXY+PnqGxS9vvUb/PkcpaVR5xWAelVU+McScjYZg5VI+kbyGkTqd+XttHRAzdJUeb0Dx8DjNwzP+3zTikXXX6+VyyfjE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1666937549; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=HQIOg0IJDrsVSSxvGbrVgwvlQSv57Iyq/aXrNe8zlEs=; b=jT98yz6tGhmCwLe0JI6gfjV3bQhqYJtedaIE971ijt1D1YEB4KSmbMDDYhZh/fbROMTKold1ewI35ZFXvQ7KlAT8wiV6uhh2JjslduJBjMtkr5ug1TYNzZaBnSWFqxXZ/hpdAnyIKvlUsRsNr2A7I1hHs5PN8Jl48XrWfRHV6YE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1666937549260218.80187968203063; Thu, 27 Oct 2022 23:12:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooIYX-00055S-I4; Fri, 28 Oct 2022 02:09:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooIXt-0004sr-P7 for qemu-devel@nongnu.org; Fri, 28 Oct 2022 02:08:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooIXa-0006yi-48 for qemu-devel@nongnu.org; Fri, 28 Oct 2022 02:08:36 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-648-tQ3ra5ltPXORxAzS1NzyWw-1; Fri, 28 Oct 2022 02:08:17 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 98BF9800B23 for ; Fri, 28 Oct 2022 06:08:17 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.195.118]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6AE9BC15BA8; Fri, 28 Oct 2022 06:08:17 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 5BB5821E688F; Fri, 28 Oct 2022 08:08:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666937299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HQIOg0IJDrsVSSxvGbrVgwvlQSv57Iyq/aXrNe8zlEs=; b=KHd/h+ic5Z453hAYo5EL5whq0USXvpl/+gepBjc87GCYhquBDFunbakDgAyAl+PN5lnyHn Px6ShEKtt2PHWQsD7YcDxz8U/UeNjU549DDaLgn31GOPi463WA3fxyTAJPveJPYznPwnYy elwVJ2nAxJVilthE9Duq/8CkEPNwwaE= X-MC-Unique: tQ3ra5ltPXORxAzS1NzyWw-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: stefanha@redhat.com Subject: [PULL 3/4] qtest: Improve error messages when property can not be set right now Date: Fri, 28 Oct 2022 08:08:15 +0200 Message-Id: <20221028060816.641399-4-armbru@redhat.com> In-Reply-To: <20221028060816.641399-1-armbru@redhat.com> References: <20221028060816.641399-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.515, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Qemu-devel" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1666937550018100001 Content-Type: text/plain; charset="utf-8" When you try to set qtest property "log" while the qtest object is active, the error message blames "insufficient permission": $ qemu-system-x86_64 -S -display none -nodefaults -monitor stdio -chard= ev socket,id=3Dchrqt0,path=3Dqtest.socket,server=3Don,wait=3Doff -object qt= est,id=3Dqt0,chardev=3Dchrqt0,log=3D/dev/null QEMU 7.1.50 monitor - type 'help' for more information (qemu) qom-set /objects/qt0 log qtest.log Error: Insufficient permission to perform this operation This implies it could work with "sufficient permission". It can't. Change the error message to: Error: Property 'log' can not be set now Same for property "chardev". Signed-off-by: Markus Armbruster Message-Id: <20221012153801.2604340-4-armbru@redhat.com> --- softmmu/qtest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/softmmu/qtest.c b/softmmu/qtest.c index f8acef2628..afea7693d0 100644 --- a/softmmu/qtest.c +++ b/softmmu/qtest.c @@ -977,7 +977,7 @@ static void qtest_set_log(Object *obj, const char *valu= e, Error **errp) QTest *q =3D QTEST(obj); =20 if (qtest =3D=3D q) { - error_setg(errp, QERR_PERMISSION_DENIED); + error_setg(errp, "Property 'log' can not be set now"); } else { g_free(q->log); q->log =3D g_strdup(value); @@ -997,7 +997,7 @@ static void qtest_set_chardev(Object *obj, const char *= value, Error **errp) Chardev *chr; =20 if (qtest =3D=3D q) { - error_setg(errp, QERR_PERMISSION_DENIED); + error_setg(errp, "Property 'chardev' can not be set now"); return; } =20 --=20 2.37.3 From nobody Mon Feb 9 06:45:51 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1666937589; cv=none; d=zohomail.com; s=zohoarc; b=PrGn0X2nRYC4gXqji2b8cAoEkAd/S0nXl/EpJyaf5iv03caBH5TH9/yC1/D621JUPD/l+VbA1nNI1g/tK2MYtEK15b82rtbVaZ2tMSRF+HWogDJirdGTYbf6IGH5H5o/de/psMTVDa58Luqooys1rpN2Y+DECYpudS0tRfRLo6Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1666937589; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=l2soYJS97zP5IMjky3u9OMSz3hnCt8AfLRFeC6G2srw=; b=HBaBjFDs5iqBhl6QCyRowDDia1r+noIre7qqdmEos4FsCmzUGlCwJsCitU89I2F+mtHygrpIEsr5WWUPPc2hG0X3eDwybH6kad72YIsI9ymONguM7LahWIRAkfY99Dq6Lq3tt7DzRIFmCWzxON9WI8gFGPD7hoUBz2InifnGzXg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1666937589291690.5104562828831; Thu, 27 Oct 2022 23:13:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooIYl-0005C1-JF; Fri, 28 Oct 2022 02:09:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooIXl-0004sF-4S for qemu-devel@nongnu.org; Fri, 28 Oct 2022 02:08:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooIXd-000721-A0 for qemu-devel@nongnu.org; Fri, 28 Oct 2022 02:08:35 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-299-sMLPuXGjNoSsWBVMjM_BLw-1; Fri, 28 Oct 2022 02:08:17 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 95A1529AB3E1 for ; Fri, 28 Oct 2022 06:08:17 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.195.118]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6AE8A1121315; Fri, 28 Oct 2022 06:08:17 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 5DE7321E68BD; Fri, 28 Oct 2022 08:08:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666937307; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l2soYJS97zP5IMjky3u9OMSz3hnCt8AfLRFeC6G2srw=; b=FQa7nOg8Xlsik1JrRzQmmGKrdy0G9RriWFrIH9vL1eRKnnpGpYSjOOSUCDp3+q1RXU/3ec 18EAABoD1xFaKJOpqmqHj8nop4E9E3qQ4sH9T+PgREf32cWYhaPYlkURMU9AEB+jsh92C+ w/JKCtd1OR+4OCFPbMDDAiX5H4IzUec= X-MC-Unique: sMLPuXGjNoSsWBVMjM_BLw-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: stefanha@redhat.com Subject: [PULL 4/4] qerror: QERR_PERMISSION_DENIED is no longer used, drop Date: Fri, 28 Oct 2022 08:08:16 +0200 Message-Id: <20221028060816.641399-5-armbru@redhat.com> In-Reply-To: <20221028060816.641399-1-armbru@redhat.com> References: <20221028060816.641399-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.515, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Qemu-devel" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1666937590208100003 Content-Type: text/plain; charset="utf-8" Signed-off-by: Markus Armbruster Message-Id: <20221012153801.2604340-5-armbru@redhat.com> --- include/qapi/qmp/qerror.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h index 596fce0c54..87ca83b155 100644 --- a/include/qapi/qmp/qerror.h +++ b/include/qapi/qmp/qerror.h @@ -50,9 +50,6 @@ #define QERR_MISSING_PARAMETER \ "Parameter '%s' is missing" =20 -#define QERR_PERMISSION_DENIED \ - "Insufficient permission to perform this operation" - #define QERR_PROPERTY_VALUE_BAD \ "Property '%s.%s' doesn't take value '%s'" =20 --=20 2.37.3