From nobody Tue Sep 9 23:04:39 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1666580603; cv=none; d=zohomail.com; s=zohoarc; b=DmB1UQFt+NHs228QFlA6Cg84Ds8hM+3rTfIdfnESM+m5pnIjKpXvI0OiKUpnVFpp0m3/U8CRPEs7rC5oNRFMLESxxSearWJ8V8jcqc8BkVrvsomDOPy6CPelgUy+Dq4kvMRhFsu61/QL4tE2miaN1n/sUjZ+9TX7yqPRjQrot+o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1666580603; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=i+AebeFOfesGzGmerljH4b4Mq6WvaWrxPBHXjbT4N00=; b=jzQ/6HPdE8L4yDErewElS8CLvX539r58ja5cvw09gdPfADOXkwqp9knN23OvZrxpY5AiFAjkHvM+njudS7sCiH2WGiNCD4hBWzOI8XaF/oP/5R4polY3PBEzdKNcYyMpVf5d2WxwVQqqn/Jk8ldj8w2AMGSWjITzozr6RPZTTSY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1666580603978300.1037391843987; Sun, 23 Oct 2022 20:03:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1omh4H-0004bK-U2 for importer@patchew.org; Sun, 23 Oct 2022 15:55:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omG51-00079s-6p; Sat, 22 Oct 2022 11:06:31 -0400 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1omG4z-00022R-MN; Sat, 22 Oct 2022 11:06:30 -0400 Received: by mail-ed1-x52d.google.com with SMTP id z97so16070692ede.8; Sat, 22 Oct 2022 08:06:28 -0700 (PDT) Received: from localhost.localdomain (dynamic-077-191-171-138.77.191.pool.telefonica.de. [77.191.171.138]) by smtp.gmail.com with ESMTPSA id 4-20020a170906310400b00780ab5a9116sm13021558ejx.211.2022.10.22.08.06.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Oct 2022 08:06:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=i+AebeFOfesGzGmerljH4b4Mq6WvaWrxPBHXjbT4N00=; b=KN1c35O719IAcStT6PnLYlv1Wv3CJggvhDtD9OCNXo1/iwXxLYAY8v8Sov+snUrKlg bREXZz80f7BLRJd4l2YWW56jToi/os3T6vTcRNNXh3P0OMcqLTvLS5Rbo/Zj72c6daQZ vkVYYadq/mQMqoEHxa/Uw5spb1Z0tDTz0yfo+HGfgo9RriG6WqfCcP7Ipq9usvLFpiTd iKrDJrOqvPCUUWhgdvBp4x4dX11OvbhZwt2SOUYV/Enaa0rjwLazegw+KGnPDXI9macV qoounF3e/zp96lJ5wonufGXbujUN99XwAZDjYvVzg3vVmcp8xrA+hq3Rpl1IAI/A4H4Q 0cEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i+AebeFOfesGzGmerljH4b4Mq6WvaWrxPBHXjbT4N00=; b=rapf8LNXNAsHz/Hg/bs3/0qBUNkfjXoDcI4d/+B5oJD+meuCNckOm/ll8WiTMzAN6K 9BD2ToNahSJdJxOB+59BbKBJ/Lhgzz/SyiUS8+dPyQroVW/sv5y+AJHLBcdfOgOeKJk+ gAO7Ic4OzEB5tYHsIEmE5KZk5MZjFBzOxzvtqONFzR26nnbbBp4Tbsyo8FGx/l8A7wth kaa4Cuew9vHMrwY1xJgItHeTaXsrpqjyT3kINl+r/fylnoMnA/+0GMNK/hHgJiw7Br2X gbmazbNPt8v70xAbJ0d+XhQngmbOncxJ+kqgdncor3TBmQh0+BuKD/7PBC+IFe0WDBJB caZg== X-Gm-Message-State: ACrzQf1cLiFlJIXzo9dYPAs2NizeuITa0n6DjukRUEosV+89ZOPL5Vpz hBR22SEn+7QADaHEuiGHlgyoyPBptAk9Jg== X-Google-Smtp-Source: AMsMyM69OCLk2cUh1llsIYpD6y1w3KZ/6Que7iNjju0UECnO7ZZGNq40oz5bqLG0P5fvCwEkVYKmuA== X-Received: by 2002:a17:907:7ba8:b0:78e:1b38:6b1b with SMTP id ne40-20020a1709077ba800b0078e1b386b1bmr19646684ejc.626.1666451188346; Sat, 22 Oct 2022 08:06:28 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Eduardo Habkost , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Aurelien Jarno , Igor Mammedov , Gerd Hoffmann , John Snow , Jiaxun Yang , Ani Sinha , Marcel Apfelbaum , qemu-block@nongnu.org, Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Michael S. Tsirkin" , Paolo Bonzini , Bernhard Beschow Subject: [PATCH v2 14/43] hw/intc/i8259: Introduce i8259 proxy "isa-pic" Date: Sat, 22 Oct 2022 17:04:39 +0200 Message-Id: <20221022150508.26830-15-shentey@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221022150508.26830-1-shentey@gmail.com> References: <20221022150508.26830-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52d; envelope-from=shentey@gmail.com; helo=mail-ed1-x52d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1666580605443100001 Content-Type: text/plain; charset="utf-8" Having an i8259 proxy allows for ISA PICs to be created and wired up in southbridges. This is especially interesting for PIIX3 for two reasons: First, the southbridge doesn't need to care about the virtualization technology used (KVM, TCG, Xen) due to in-IRQs (where devices get attached) and out-IRQs (which will trigger the IRQs of the respective virtzalization technology) are separated. Second, since the in-IRQs are populated with fully initialized qemu_irq's, they can already be wired up inside PIIX3. Signed-off-by: Bernhard Beschow --- hw/intc/i8259.c | 27 +++++++++++++++++++++++++++ include/hw/intc/i8259.h | 14 ++++++++++++++ 2 files changed, 41 insertions(+) diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index cc4e21ffec..531f6cca53 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -458,9 +458,36 @@ static const TypeInfo i8259_info =3D { .class_size =3D sizeof(PICClass), }; =20 +static void isapic_set_irq(void *opaque, int irq, int level) +{ + ISAPICState *s =3D opaque; + + qemu_set_irq(s->out_irqs[irq], level); +} + +static void isapic_init(Object *obj) +{ + ISAPICState *s =3D ISA_PIC(obj); + + qdev_init_gpio_in(DEVICE(s), isapic_set_irq, ISA_NUM_IRQS); + qdev_init_gpio_out(DEVICE(s), s->out_irqs, ISA_NUM_IRQS); + + for (int i =3D 0; i < ISA_NUM_IRQS; ++i) { + s->in_irqs[i] =3D qdev_get_gpio_in(DEVICE(s), i); + } +} + +static const TypeInfo isapic_info =3D { + .name =3D TYPE_ISA_PIC, + .parent =3D TYPE_ISA_DEVICE, + .instance_size =3D sizeof(ISAPICState), + .instance_init =3D isapic_init, +}; + static void pic_register_types(void) { type_register_static(&i8259_info); + type_register_static(&isapic_info); } =20 type_init(pic_register_types) diff --git a/include/hw/intc/i8259.h b/include/hw/intc/i8259.h index e2b1e8c59a..0246ab6ac6 100644 --- a/include/hw/intc/i8259.h +++ b/include/hw/intc/i8259.h @@ -1,6 +1,20 @@ #ifndef HW_I8259_H #define HW_I8259_H =20 +#include "qom/object.h" +#include "hw/isa/isa.h" +#include "qemu/typedefs.h" + +#define TYPE_ISA_PIC "isa-pic" +OBJECT_DECLARE_SIMPLE_TYPE(ISAPICState, ISA_PIC) + +struct ISAPICState { + ISADevice parent_obj; + + qemu_irq in_irqs[ISA_NUM_IRQS]; + qemu_irq out_irqs[ISA_NUM_IRQS]; +}; + /* i8259.c */ =20 extern DeviceState *isa_pic; --=20 2.38.1