From nobody Mon Feb 9 20:32:32 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1666101148; cv=none; d=zohomail.com; s=zohoarc; b=ebjBoa4N9KyObBNjn8lMbw3r5HB2Hi/3ui2HqJR1+9GZLLXZ0ugDBdGiPZ7Askkd8jFVAyC1Hw6wAy3Gsmv/lQRTXim995cyVZ2N/cwFNfbOqM1QwIEd7q+bHKQNk87SEsRfGYXDui8GvYl8uFHVDQ/yN8HEPcKjffG7wgZfyZo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1666101148; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=mSQBdP9IGP+TdAX9n1NZnZIRnFodu3yh9ZLqZkjo+kA=; b=jZNXZ+f+7XTO2nmY1sl2r2p5zXq6rsNV4MKaTkMkK2t0A1qYhP/P2QLXCu6QQKPFu6Gk2EkqTuDqjiN2EgHtJzT/sX5QU3tb369wG2Tmtyv4s3130WR8e1dEHvmeF6CKvTqOpsxzPMKbpuZujnaY5Oj4IJSOPbF0ZpQnmYRnSIo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1666101148618501.03290499316097; Tue, 18 Oct 2022 06:52:28 -0700 (PDT) Received: from localhost ([::1]:34684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1okn16-0001ro-AY for importer@patchew.org; Tue, 18 Oct 2022 09:52:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50456) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okmiS-0004Rl-1G for qemu-devel@nongnu.org; Tue, 18 Oct 2022 09:33:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:58630) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okmiH-0005Ns-8d for qemu-devel@nongnu.org; Tue, 18 Oct 2022 09:32:59 -0400 Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-146-yz2FtVmbPFSq_HIIkqZTdw-1; Tue, 18 Oct 2022 09:32:55 -0400 Received: by mail-ej1-f70.google.com with SMTP id hc43-20020a17090716ab00b0078e28567ffbso4750168ejc.15 for ; Tue, 18 Oct 2022 06:32:55 -0700 (PDT) Received: from avogadro.local ([2001:b07:6468:f312:2f4b:62da:3159:e077]) by smtp.gmail.com with ESMTPSA id x24-20020a170906b09800b0078d46aa3b82sm7496210ejy.21.2022.10.18.06.32.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Oct 2022 06:32:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666099976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mSQBdP9IGP+TdAX9n1NZnZIRnFodu3yh9ZLqZkjo+kA=; b=CzcmMuHl3yI+Hcx5Hi0ko/lQZGeizzHDUDeEx4Texwjlr5tvdNegFjJ7nXYyO2RNQqwWru sYIPfxm6RCg7gMGLbGUgyj6+d1TPXYkQXNuo465f6ZxJh6gWeUlk+oWh92fE5EGq9yyOdf d5lNiSLS2aMn+gi11oz4dpG6KqSs0Rk= X-MC-Unique: yz2FtVmbPFSq_HIIkqZTdw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mSQBdP9IGP+TdAX9n1NZnZIRnFodu3yh9ZLqZkjo+kA=; b=4rsAiAJroqE+Si2PyNafDxfHCTV9tCqD0ZkL+Nq7JJO9kTEC4p/YAlLL8MyaXmJOoD tJ3vOu/PO1AN3UKbCAxe8GZfWklNy55wwuWfLdYrawiAqeA/M4gLZoNEEpCBb5X2GMuY JtqsFtiWtKL3WzYUlD9TpzLwVB+Mz/s3FxQwgwVht8HUnqPDSt8pHEwqPU8iV58r1wjV f396hYr8wZG+YahOYnbDh/5zMwT1J+O/3f8+b/SE8TBXOjMVxMp3gO04FsjhWeO7+LzM u1cLEmKIEIJebjYHSo/MOY+5q9MKYXLQnlCLPS+4DmGOvNctyIU5DKJjqtXcNBQKvRmT V3fw== X-Gm-Message-State: ACrzQf1cmJvhWvL5Ge+z4cQezw7/KRFWxKHszqizdc7XAUjDGwBBehU7 nSWI8Ee1lU0u9U1GPwrYdbThyJ7ISipzWXuoHZQRc1LA7AQ9C4jfkHEPrTk/ewc/uzQ6aceFmS8 2hO+wMKpfdIbVijdJgVM0hqNNCyblnqZiRhB/rJZwv5jS/qRqsAuY6198dF46W7fL7R8= X-Received: by 2002:aa7:c314:0:b0:458:dc90:467a with SMTP id l20-20020aa7c314000000b00458dc90467amr2528511edq.284.1666099973515; Tue, 18 Oct 2022 06:32:53 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4RVoWl1POI2R/Ggp0gtAKx5Ltme0REFeL4Glh/NViESYnJQK0uAx/sfXVQwFW1h5ocbl23Hg== X-Received: by 2002:aa7:c314:0:b0:458:dc90:467a with SMTP id l20-20020aa7c314000000b00458dc90467amr2528480edq.284.1666099973120; Tue, 18 Oct 2022 06:32:53 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Richard Henderson Subject: [PULL 40/53] target/i386: reimplement 0x0f 0xd0-0xd7, 0xe0-0xe7, 0xf0-0xf7, add AVX Date: Tue, 18 Oct 2022 15:30:29 +0200 Message-Id: <20221018133042.856368-41-pbonzini@redhat.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221018133042.856368-1-pbonzini@redhat.com> References: <20221018133042.856368-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.256, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1666101149481100004 Content-Type: text/plain; charset="utf-8" The more complicated ones here are d6-d7, e6-e7, f7. The others are trivial. For LDDQU, using gen_load_sse directly might corrupt the register if the second part of the load fails. Therefore, add a custom X86_TYPE_WM value; like X86_TYPE_W it does call gen_load(), but it also rejects a value of 11 in the ModRM field like X86_TYPE_M. Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- target/i386/tcg/decode-new.c.inc | 53 ++++++++++++++++++++++ target/i386/tcg/decode-new.h | 1 + target/i386/tcg/emit.c.inc | 77 +++++++++++++++++++++++++++----- target/i386/tcg/translate.c | 2 +- 4 files changed, 122 insertions(+), 11 deletions(-) diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.= c.inc index 306a9f344e..c1534719fa 100644 --- a/target/i386/tcg/decode-new.c.inc +++ b/target/i386/tcg/decode-new.c.inc @@ -289,6 +289,18 @@ static void decode_0F7F(DisasContext *s, CPUX86State *= env, X86OpEntry *entry, ui *entry =3D *decode_by_prefix(s, opcodes_0F7F); } =20 +static void decode_0FD6(DisasContext *s, CPUX86State *env, X86OpEntry *ent= ry, uint8_t *b) +{ + static const X86OpEntry movq[4] =3D { + {}, + X86_OP_ENTRY3(MOVQ, W,x, None, None, V,q, vex5), + X86_OP_ENTRY3(MOVq_dq, V,dq, None, None, N,q), + X86_OP_ENTRY3(MOVq_dq, P,q, None, None, U,q), + }; + + *entry =3D *decode_by_prefix(s, movq); +} + static const X86OpEntry opcodes_0F38_00toEF[240] =3D { }; =20 @@ -398,6 +410,17 @@ static void decode_0F5B(DisasContext *s, CPUX86State *= env, X86OpEntry *entry, ui *entry =3D *decode_by_prefix(s, opcodes_0F5B); } =20 +static void decode_0FE6(DisasContext *s, CPUX86State *env, X86OpEntry *ent= ry, uint8_t *b) +{ + static const X86OpEntry opcodes_0FE6[4] =3D { + {}, + X86_OP_ENTRY2(VCVTTPD2DQ, V,x, W,x, vex2), + X86_OP_ENTRY2(VCVTDQ2PD, V,x, W,x, vex2), + X86_OP_ENTRY2(VCVTPD2DQ, V,x, W,x, vex2), + }; + *entry =3D *decode_by_prefix(s, opcodes_0FE6); +} + static const X86OpEntry opcodes_0F[256] =3D { [0x50] =3D X86_OP_ENTRY3(MOVMSK, G,y, None,None, U,x, vex7 p_00_66= ), [0x51] =3D X86_OP_GROUP3(sse_unary, V,x, H,x, W,x, vex2_rep3 p_00_66_= f3_f2), @@ -454,6 +477,33 @@ static const X86OpEntry opcodes_0F[256] =3D { [0x7e] =3D X86_OP_GROUP0(0F7E), [0x7f] =3D X86_OP_GROUP0(0F7F), =20 + [0xd0] =3D X86_OP_ENTRY3(VADDSUB, V,x, H,x, W,x, vex2 cpuid(S= SE3) p_66_f2), + [0xd1] =3D X86_OP_ENTRY3(PSRLW_r, V,x, H,x, W,x, vex4 mmx avx= 2_256 p_00_66), + [0xd2] =3D X86_OP_ENTRY3(PSRLD_r, V,x, H,x, W,x, vex4 mmx avx= 2_256 p_00_66), + [0xd3] =3D X86_OP_ENTRY3(PSRLQ_r, V,x, H,x, W,x, vex4 mmx avx= 2_256 p_00_66), + [0xd4] =3D X86_OP_ENTRY3(PADDQ, V,x, H,x, W,x, vex4 mmx avx= 2_256 p_00_66), + [0xd5] =3D X86_OP_ENTRY3(PMULLW, V,x, H,x, W,x, vex4 mmx avx= 2_256 p_00_66), + [0xd6] =3D X86_OP_GROUP0(0FD6), + [0xd7] =3D X86_OP_ENTRY3(PMOVMSKB, G,d, None,None, U,x, vex7 mmx avx= 2_256 p_00_66), + + [0xe0] =3D X86_OP_ENTRY3(PAVGB, V,x, H,x, W,x, vex4 mmx avx= 2_256 p_00_66), + [0xe1] =3D X86_OP_ENTRY3(PSRAW_r, V,x, H,x, W,x, vex7 mmx avx= 2_256 p_00_66), + [0xe2] =3D X86_OP_ENTRY3(PSRAD_r, V,x, H,x, W,x, vex7 mmx avx= 2_256 p_00_66), + [0xe3] =3D X86_OP_ENTRY3(PAVGW, V,x, H,x, W,x, vex4 mmx avx= 2_256 p_00_66), + [0xe4] =3D X86_OP_ENTRY3(PMULHUW, V,x, H,x, W,x, vex4 mmx avx= 2_256 p_00_66), + [0xe5] =3D X86_OP_ENTRY3(PMULHW, V,x, H,x, W,x, vex4 mmx avx= 2_256 p_00_66), + [0xe6] =3D X86_OP_GROUP0(0FE6), + [0xe7] =3D X86_OP_ENTRY3(MOVDQ, W,x, None,None, V,x, vex1 mmx p_0= 0_66), /* MOVNTQ/MOVNTDQ */ + + [0xf0] =3D X86_OP_ENTRY3(MOVDQ, V,x, None,None, WM,x, vex4_unal cp= uid(SSE3) p_f2), /* LDDQU */ + [0xf1] =3D X86_OP_ENTRY3(PSLLW_r, V,x, H,x, W,x, vex7 mmx avx= 2_256 p_00_66), + [0xf2] =3D X86_OP_ENTRY3(PSLLD_r, V,x, H,x, W,x, vex7 mmx avx= 2_256 p_00_66), + [0xf3] =3D X86_OP_ENTRY3(PSLLQ_r, V,x, H,x, W,x, vex7 mmx avx= 2_256 p_00_66), + [0xf4] =3D X86_OP_ENTRY3(PMULUDQ, V,x, H,x, W,x, vex4 mmx avx= 2_256 p_00_66), + [0xf5] =3D X86_OP_ENTRY3(PMADDWD, V,x, H,x, W,x, vex4 mmx avx= 2_256 p_00_66), + [0xf6] =3D X86_OP_ENTRY3(PSADBW, V,x, H,x, W,x, vex4 mmx avx= 2_256 p_00_66), + [0xf7] =3D X86_OP_ENTRY3(MASKMOV, None,None, V,dq, U,dq, vex4_unal av= x2_256 mmx p_00_66), + /* Incorrectly missing from 2-17 */ [0xd8] =3D X86_OP_ENTRY3(PSUBUSB, V,x, H,x, W,x, vex4 mmx avx2_256 p= _00_66), [0xd9] =3D X86_OP_ENTRY3(PSUBUSW, V,x, H,x, W,x, vex4 mmx avx2_256 p= _00_66), @@ -710,6 +760,9 @@ static bool decode_op(DisasContext *s, CPUX86State *env= , X86DecodedInsn *decode, } goto get_modrm; =20 + case X86_TYPE_WM: /* modrm byte selects an XMM/YMM memory operand */ + op->unit =3D X86_OP_SSE; + /* fall through */ case X86_TYPE_M: /* modrm byte selects a memory operand */ modrm =3D get_modrm(s, env); if ((modrm >> 6) =3D=3D 3) { diff --git a/target/i386/tcg/decode-new.h b/target/i386/tcg/decode-new.h index 8456ae67ad..ef318a00ed 100644 --- a/target/i386/tcg/decode-new.h +++ b/target/i386/tcg/decode-new.h @@ -47,6 +47,7 @@ typedef enum X86OpType { X86_TYPE_Y, /* string destination */ =20 /* Custom */ + X86_TYPE_WM, /* modrm byte selects an XMM/YMM memory operand */ X86_TYPE_2op, /* 2-operand RMW instruction */ X86_TYPE_LoBits, /* encoded in bits 0-2 of the operand + REX.B */ X86_TYPE_0, /* Hard-coded GPRs (RAX..RDI) */ diff --git a/target/i386/tcg/emit.c.inc b/target/i386/tcg/emit.c.inc index 0d437686e6..4227ddd9f3 100644 --- a/target/i386/tcg/emit.c.inc +++ b/target/i386/tcg/emit.c.inc @@ -471,6 +471,7 @@ static void gen_##uname(DisasContext *s, CPUX86State *e= nv, X86DecodedInsn *decod } HORIZONTAL_FP_SSE(VHADD, hadd) HORIZONTAL_FP_SSE(VHSUB, hsub) +HORIZONTAL_FP_SSE(VADDSUB, addsub) =20 #define BINARY_INT_GVEC(uname, func, ...) = \ static void gen_##uname(DisasContext *s, CPUX86State *env, X86DecodedInsn = *decode) \ @@ -485,6 +486,7 @@ static void gen_##uname(DisasContext *s, CPUX86State *e= nv, X86DecodedInsn *decod BINARY_INT_GVEC(PADDB, tcg_gen_gvec_add, MO_8) BINARY_INT_GVEC(PADDW, tcg_gen_gvec_add, MO_16) BINARY_INT_GVEC(PADDD, tcg_gen_gvec_add, MO_32) +BINARY_INT_GVEC(PADDQ, tcg_gen_gvec_add, MO_64) BINARY_INT_GVEC(PADDSB, tcg_gen_gvec_ssadd, MO_8) BINARY_INT_GVEC(PADDSW, tcg_gen_gvec_ssadd, MO_16) BINARY_INT_GVEC(PADDUSB, tcg_gen_gvec_usadd, MO_8) @@ -500,6 +502,7 @@ BINARY_INT_GVEC(PMAXSW, tcg_gen_gvec_smax, MO_16) BINARY_INT_GVEC(PMAXUB, tcg_gen_gvec_umax, MO_8) BINARY_INT_GVEC(PMINSW, tcg_gen_gvec_smin, MO_16) BINARY_INT_GVEC(PMINUB, tcg_gen_gvec_umin, MO_8) +BINARY_INT_GVEC(PMULLW, tcg_gen_gvec_mul, MO_16) BINARY_INT_GVEC(POR, tcg_gen_gvec_or, MO_64) BINARY_INT_GVEC(PSUBB, tcg_gen_gvec_sub, MO_8) BINARY_INT_GVEC(PSUBW, tcg_gen_gvec_sub, MO_16) @@ -557,6 +560,23 @@ BINARY_INT_MMX(PUNPCKHWD, punpckhwd) BINARY_INT_MMX(PUNPCKHDQ, punpckhdq) BINARY_INT_MMX(PACKSSDW, packssdw) =20 +BINARY_INT_MMX(PAVGB, pavgb) +BINARY_INT_MMX(PAVGW, pavgw) +BINARY_INT_MMX(PMADDWD, pmaddwd) +BINARY_INT_MMX(PMULHUW, pmulhuw) +BINARY_INT_MMX(PMULHW, pmulhw) +BINARY_INT_MMX(PMULUDQ, pmuludq) +BINARY_INT_MMX(PSADBW, psadbw) + +BINARY_INT_MMX(PSLLW_r, psllw) +BINARY_INT_MMX(PSLLD_r, pslld) +BINARY_INT_MMX(PSLLQ_r, psllq) +BINARY_INT_MMX(PSRLW_r, psrlw) +BINARY_INT_MMX(PSRLD_r, psrld) +BINARY_INT_MMX(PSRLQ_r, psrlq) +BINARY_INT_MMX(PSRAW_r, psraw) +BINARY_INT_MMX(PSRAD_r, psrad) + /* Instructions with no MMX equivalent. */ #define BINARY_INT_SSE(uname, lname) = \ static void gen_##uname(DisasContext *s, CPUX86State *env, X86DecodedInsn = *decode) \ @@ -588,6 +608,9 @@ static void gen_##uname(DisasContext *s, CPUX86State *e= nv, X86DecodedInsn *decod gen_helper_##lname##_ymm); = \ } =20 +UNARY_INT_SSE(VCVTDQ2PD, cvtdq2pd) +UNARY_INT_SSE(VCVTPD2DQ, cvtpd2dq) +UNARY_INT_SSE(VCVTTPD2DQ, cvttpd2dq) UNARY_INT_SSE(VCVTDQ2PS, cvtdq2ps) UNARY_INT_SSE(VCVTPS2DQ, cvtps2dq) UNARY_INT_SSE(VCVTTPS2DQ, cvttps2dq) @@ -802,6 +825,19 @@ static void gen_INSERTQ_r(DisasContext *s, CPUX86State= *env, X86DecodedInsn *dec gen_helper_insertq_r(cpu_env, OP_PTR0, OP_PTR2); } =20 +static void gen_MASKMOV(DisasContext *s, CPUX86State *env, X86DecodedInsn = *decode) +{ + tcg_gen_mov_tl(s->A0, cpu_regs[R_EDI]); + gen_extu(s->aflag, s->A0); + gen_add_A0_ds_seg(s); + + if (s->prefix & PREFIX_DATA) { + gen_helper_maskmov_xmm(cpu_env, OP_PTR1, OP_PTR2, s->A0); + } else { + gen_helper_maskmov_mmx(cpu_env, OP_PTR1, OP_PTR2, s->A0); + } +} + static void gen_MOVBE(DisasContext *s, CPUX86State *env, X86DecodedInsn *d= ecode) { MemOp ot =3D decode->op[0].ot; @@ -875,16 +911,27 @@ static void gen_MOVQ(DisasContext *s, CPUX86State *en= v, X86DecodedInsn *decode) int lo_ofs =3D vector_elem_offset(&decode->op[0], MO_64, 0); =20 tcg_gen_ld_i64(s->tmp1_i64, cpu_env, decode->op[2].offset); - /* - * tcg_gen_gvec_dup_i64(MO_64, op0.offset, 8, vec_len, s->tmp1_64) wou= ld - * seem to work, but it does not on big-endian platforms; the cleared = parts - * are always at higher addresses, but cross-endian emulation inverts = the - * byte order so that the cleared parts need to be at *lower* addresse= s. - * Because oprsz is 8, we see this here even for SSE; but more in gene= ral, - * it disqualifies using oprsz < maxsz to emulate VEX128. - */ - tcg_gen_gvec_dup_imm(MO_64, decode->op[0].offset, vec_len, vec_len, 0); - tcg_gen_st_i64(s->tmp1_i64, cpu_env, lo_ofs); + if (decode->op[0].has_ea) { + tcg_gen_qemu_st_i64(s->tmp1_i64, s->A0, s->mem_index, MO_LEUQ); + } else { + /* + * tcg_gen_gvec_dup_i64(MO_64, op0.offset, 8, vec_len, s->tmp1_64)= would + * seem to work, but it does not on big-endian platforms; the clea= red parts + * are always at higher addresses, but cross-endian emulation inve= rts the + * byte order so that the cleared parts need to be at *lower* addr= esses. + * Because oprsz is 8, we see this here even for SSE; but more in = general, + * it disqualifies using oprsz < maxsz to emulate VEX128. + */ + tcg_gen_gvec_dup_imm(MO_64, decode->op[0].offset, vec_len, vec_len= , 0); + tcg_gen_st_i64(s->tmp1_i64, cpu_env, lo_ofs); + } +} + +static void gen_MOVq_dq(DisasContext *s, CPUX86State *env, X86DecodedInsn = *decode) +{ + gen_helper_enter_mmx(cpu_env); + /* Otherwise the same as any other movq. */ + return gen_MOVQ(s, env, decode); } =20 static void gen_MULX(DisasContext *s, CPUX86State *env, X86DecodedInsn *de= code) @@ -938,6 +985,16 @@ static void gen_PEXT(DisasContext *s, CPUX86State *env= , X86DecodedInsn *decode) gen_helper_pext(s->T0, s->T0, s->T1); } =20 +static void gen_PMOVMSKB(DisasContext *s, CPUX86State *env, X86DecodedInsn= *decode) +{ + if (s->prefix & PREFIX_DATA) { + gen_helper_pmovmskb_xmm(s->tmp2_i32, cpu_env, OP_PTR2); + } else { + gen_helper_pmovmskb_mmx(s->tmp2_i32, cpu_env, OP_PTR2); + } + tcg_gen_extu_i32_tl(s->T0, s->tmp2_i32); +} + static void gen_PSHUFW(DisasContext *s, CPUX86State *env, X86DecodedInsn *= decode) { TCGv_i32 imm =3D tcg_constant8u_i32(decode->immediate); diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index defae79d3b..95d48eb508 100644 --- a/target/i386/tcg/translate.c +++ b/target/i386/tcg/translate.c @@ -4783,7 +4783,7 @@ static bool disas_insn(DisasContext *s, CPUState *cpu) #endif if (use_new && ((b >=3D 0x150 && b <=3D 0x17f) || - (b >=3D 0x1d8 && b <=3D 0x1ff && (b & 8)))) { + (b >=3D 0x1d0 && b <=3D 0x1ff))) { disas_insn_new(s, cpu, b + 0x100); return s->pc; } --=20 2.37.3