From nobody Sun Feb 8 16:44:33 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1665600257; cv=none; d=zohomail.com; s=zohoarc; b=Gi8bwdM2JjwkTcAHHkKvpaLH8HPL5FY0FPtKPauoQUNd6A9QUPnlR5AwgwE1xC+bf29QYQxXrr/itQLFQIF6jTbOy8PGXhzQ0LuFLOfAwxtr+ngtTQAj/O94fDcsnijTkdBxFOypJz9lTN8uQN6cBqwjvc92bpDLfBQlgyxpO90= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1665600257; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GYrWjblCHmULZSazFrPa6IAwo3d8fCc6y5fvFxhGKUA=; b=PhKW5twDzkZQxDIVH7mIFVgmkJGafxvstATha4rqgQASiKZcj1zstsisqAzU0Ir+QkdLegVfULx/8IyJCoB/RcUq1zkYdmLPZCtZIDZLaxCViyd7wBU+pLS/g3AjYqHo04BwvbSVlrUH3NhlmPc6U+lZP0HMdxNgW7R0ZmZqlo8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 166560025749419.120190682562452; Wed, 12 Oct 2022 11:44:17 -0700 (PDT) Received: from localhost ([::1]:40322 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oigiG-0007Vh-FB for importer@patchew.org; Wed, 12 Oct 2022 14:44:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55370) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oigSd-0002BR-8I for qemu-devel@nongnu.org; Wed, 12 Oct 2022 14:28:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:39274) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oigSb-0002x8-LE for qemu-devel@nongnu.org; Wed, 12 Oct 2022 14:28:06 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-362-u4QtYEh1OBmKOyspJP-JOw-1; Wed, 12 Oct 2022 14:28:01 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E0096811E87; Wed, 12 Oct 2022 18:28:00 +0000 (UTC) Received: from thuth.com (unknown [10.39.192.49]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2B77040449D5; Wed, 12 Oct 2022 18:27:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665599284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GYrWjblCHmULZSazFrPa6IAwo3d8fCc6y5fvFxhGKUA=; b=dYy9IRQyOWi722aIiV8gO9qNBDOjNkKA4I4GB60pSczw05TGPw/JMmsj3FLZR1NxxSOCP7 CWtFyFlt26hqE0eh2VHxuiX+GwlzJEvprU6IxthKBCRXBhSXpwLJcgdSFpFXP2u5rfXGqX ELrldw7IYM5lgDEevdRXaGN+iKlCqdc= X-MC-Unique: u4QtYEh1OBmKOyspJP-JOw-1 From: Thomas Huth To: qemu-s390x@nongnu.org, David Hildenbrand , Richard Henderson Cc: qemu-devel@nongnu.org Subject: [PATCH 1/3] tests/tcg/s390x: Test compiler flags only once, not every time Date: Wed, 12 Oct 2022 20:27:53 +0200 Message-Id: <20221012182755.1014853-2-thuth@redhat.com> In-Reply-To: <20221012182755.1014853-1-thuth@redhat.com> References: <20221012182755.1014853-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1665600259115100001 This is common practice, see the Makefile.target in the aarch64 folder for example. Suggested-by: Alex Benn=C3=A9e Signed-off-by: Thomas Huth Reviewed-by: David Hildenbrand Reviewed-by: Richard Henderson --- tests/tcg/s390x/Makefile.target | 27 +++++++++++++++++---------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/tests/tcg/s390x/Makefile.target b/tests/tcg/s390x/Makefile.tar= get index c830313e67..29c8af8207 100644 --- a/tests/tcg/s390x/Makefile.target +++ b/tests/tcg/s390x/Makefile.target @@ -1,6 +1,13 @@ S390X_SRC=3D$(SRC_PATH)/tests/tcg/s390x VPATH+=3D$(S390X_SRC) CFLAGS+=3D-march=3DzEC12 -m64 + +config-cc.mak: Makefile + $(quiet-@)( \ + $(call cc-option,-march=3Dz14, CROSS_CC_HAS_Z14); \ + $(call cc-option,-march=3Dz15, CROSS_CC_HAS_Z15)) 3> config-cc.mak +-include config-cc.mak + TESTS+=3Dhello-s390x TESTS+=3Dcsst TESTS+=3Dipm @@ -18,20 +25,20 @@ TESTS+=3Dsignals-s390x TESTS+=3Dbranch-relative-long TESTS+=3Dnoexec =20 +ifneq ($(CROSS_CC_HAS_Z14),) Z14_TESTS=3Dvfminmax vfminmax: LDFLAGS+=3D-lm $(Z14_TESTS): CFLAGS+=3D-march=3Dz14 -O2 +TESTS+=3D$(Z14_TESTS) +endif =20 -TESTS+=3D$(if $(shell $(CC) -march=3Dz14 -S -o /dev/null -xc /dev/null \ - >/dev/null 2>&1 && echo OK),$(Z14_TESTS)) - -VECTOR_TESTS=3Dvxeh2_vs -VECTOR_TESTS+=3Dvxeh2_vcvt -VECTOR_TESTS+=3Dvxeh2_vlstr -$(VECTOR_TESTS): CFLAGS+=3D-march=3Dz15 -O2 - -TESTS+=3D$(if $(shell $(CC) -march=3Dz15 -S -o /dev/null -xc /dev/null \ - >/dev/null 2>&1 && echo OK),$(VECTOR_TESTS)) +ifneq ($(CROSS_CC_HAS_Z15),) +Z15_TESTS=3Dvxeh2_vs +Z15_TESTS+=3Dvxeh2_vcvt +Z15_TESTS+=3Dvxeh2_vlstr +$(Z15_TESTS): CFLAGS+=3D-march=3Dz15 -O2 +TESTS+=3D$(Z15_TESTS) +endif =20 ifneq ($(HAVE_GDB_BIN),) GDB_SCRIPT=3D$(SRC_PATH)/tests/guest-debug/run-test.py --=20 2.31.1 From nobody Sun Feb 8 16:44:33 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1665599740; cv=none; d=zohomail.com; s=zohoarc; b=ed8UvMHcf1JLg4DmQtbuzPmrXlbZc6cBGcOxTOiM8rqPS73esGzDShSR0eZW6k/PpDkvSqWNZNn462JG9iBDTMSQO4vxbUao19gxFkxDKB2ZKJ/oKTm35Vz8ioQzSLt48DV8Avk1sXphdz+NoVXh/aClI1AzDDANXKUCb92a96k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1665599740; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=noJzKbbdefCfLpUbj0cOlOZkwGegKHgpzZnm4rGIAwY=; b=B27n/JoSdZF+9DrszbXLn0k9V57Sou8Iq5JxO5COCm+Eqw/VHF8Jy9c9Fy6WM5koTw+QBJOXb+M1nkyulEpmCD2ceV8y+Q8cA0iPk89cr83vUNDD+kfGmxnc5bbIpxkVst0LaIptYpQrcDxi6733zyI7OHr7Xgcfj32sSmxtyo8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1665599740986985.6394073789438; Wed, 12 Oct 2022 11:35:40 -0700 (PDT) Received: from localhost ([::1]:38784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oigZv-0007D9-QE for importer@patchew.org; Wed, 12 Oct 2022 14:35:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55368) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oigSc-00029I-HJ for qemu-devel@nongnu.org; Wed, 12 Oct 2022 14:28:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:59662) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oigSa-0002wQ-Ml for qemu-devel@nongnu.org; Wed, 12 Oct 2022 14:28:06 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-497-BlR0IwCVOzy7CvJNFGb3GQ-1; Wed, 12 Oct 2022 14:28:02 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 538D0804186; Wed, 12 Oct 2022 18:28:02 +0000 (UTC) Received: from thuth.com (unknown [10.39.192.49]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5E30E40449D5; Wed, 12 Oct 2022 18:28:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665599284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=noJzKbbdefCfLpUbj0cOlOZkwGegKHgpzZnm4rGIAwY=; b=WlTpP40Rg1rdjzsxTjBMfE9kPLh/AOq4PO1DTWq5ierpH2dqQgdLjoBrj14Q+FB2coPB9T JlblvRIrffCjnK8iZwgJBqugQRC+5xwH2VXLCDSh6Lw4PECn6GBBHaA4LYjBEL3e+czd18 fexJZBZk9AEwONp3Fq8INQ5MGqhemdI= X-MC-Unique: BlR0IwCVOzy7CvJNFGb3GQ-1 From: Thomas Huth To: qemu-s390x@nongnu.org, David Hildenbrand , Richard Henderson Cc: qemu-devel@nongnu.org Subject: [PATCH 2/3] target/s390x: Fix emulation of the VISTR instruction Date: Wed, 12 Oct 2022 20:27:54 +0200 Message-Id: <20221012182755.1014853-3-thuth@redhat.com> In-Reply-To: <20221012182755.1014853-1-thuth@redhat.com> References: <20221012182755.1014853-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1665599741936100001 Content-Type: text/plain; charset="utf-8" The element size is encoded in the M3 field, not in the M4 field. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1248 Fixes: be6324c6b734 ("s390x/tcg: Implement VECTOR ISOLATE STRING") Reviewed-by: Richard Henderson Signed-off-by: Thomas Huth Reviewed-by: David Hildenbrand --- target/s390x/tcg/translate_vx.c.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/tcg/translate_vx.c.inc b/target/s390x/tcg/transla= te_vx.c.inc index 3526ba3e3b..b69c1a111c 100644 --- a/target/s390x/tcg/translate_vx.c.inc +++ b/target/s390x/tcg/translate_vx.c.inc @@ -2723,7 +2723,7 @@ static DisasJumpType op_vfene(DisasContext *s, DisasO= ps *o) =20 static DisasJumpType op_vistr(DisasContext *s, DisasOps *o) { - const uint8_t es =3D get_field(s, m4); + const uint8_t es =3D get_field(s, m3); const uint8_t m5 =3D get_field(s, m5); static gen_helper_gvec_2 * const g[3] =3D { gen_helper_gvec_vistr8, --=20 2.31.1 From nobody Sun Feb 8 16:44:33 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1665599945; cv=none; d=zohomail.com; s=zohoarc; b=OyUvx52usrXK06GKV6AoRy/lFz/7uEVWzJqSztLA4I9sb7BwuSIeSPCfGmYz9g+/tK0JnaR8Je8fIHNDR22nCk1KC3ZLzF1ZHutAbi0ZNdyST9P1soI6LoJX1tY08Gi7Ro4obI/gftjKCp7hnRK7SkfJvQfouEO3Ds/0tZ7Z0Xo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1665599945; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ic1Z/fuoED9JpLTkBXsxU+qPtK+cLrnnrf/sxAUcYwY=; b=jNeWpmBVZel+EgnBL8cZh3SjAfj4Udvi9JyS12tCZWavghpxzvUu6cyLav1m5dFoI6mqFo94aPHCDx137AEZCyYUNVsmSqJYs3iPpOGqinNRETjdhHF4rIJzbt9ek1svlMJh7ImuIKexJ0r874L3K78oJk0qbdq+8oj/pwb0y7w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1665599945738294.3885851951352; Wed, 12 Oct 2022 11:39:05 -0700 (PDT) Received: from localhost ([::1]:42818 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oigdE-0002Ca-KE for importer@patchew.org; Wed, 12 Oct 2022 14:39:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55376) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oigSg-0002Jn-AK for qemu-devel@nongnu.org; Wed, 12 Oct 2022 14:28:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:26319) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oigSe-0002yz-R7 for qemu-devel@nongnu.org; Wed, 12 Oct 2022 14:28:10 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-614-3Aa1n8NBMIiWJrWxq_fYQA-1; Wed, 12 Oct 2022 14:28:05 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 95EFC803D48; Wed, 12 Oct 2022 18:28:04 +0000 (UTC) Received: from thuth.com (unknown [10.39.192.49]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9F3D540449D8; Wed, 12 Oct 2022 18:28:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665599288; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ic1Z/fuoED9JpLTkBXsxU+qPtK+cLrnnrf/sxAUcYwY=; b=Xdl0rc2eVpvjW7RUBwAyU6xqyf0Bg9klFDlbq4jp2P8KffK162d0ST55/Wxcc0q+Bj/oZc HGzGV2h5u2Z/KxQzEpjNrIffgreoacGtKo8bVXwey+aYw2J6njPwO1A2ZP0Gy1ZLaPgKjb 20+bEgErxyaOcqd65WKmgu+T+Gy/yZI= X-MC-Unique: 3Aa1n8NBMIiWJrWxq_fYQA-1 From: Thomas Huth To: qemu-s390x@nongnu.org, David Hildenbrand , Richard Henderson Cc: qemu-devel@nongnu.org Subject: [PATCH 3/3] tests/tcg/s390x: Add a test for the vistr instruction Date: Wed, 12 Oct 2022 20:27:55 +0200 Message-Id: <20221012182755.1014853-4-thuth@redhat.com> In-Reply-To: <20221012182755.1014853-1-thuth@redhat.com> References: <20221012182755.1014853-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1665599947372100001 Content-Type: text/plain; charset="utf-8" This test can be used to verify that the change in the previous commit is indeed fixing the problem with the M3 vs. M4 field mixup. Signed-off-by: Thomas Huth Reviewed-by: David Hildenbrand Reviewed-by: Richard Henderson --- tests/tcg/s390x/vistr.c | 45 +++++++++++++++++++++++++++++++++ tests/tcg/s390x/Makefile.target | 4 +++ 2 files changed, 49 insertions(+) create mode 100644 tests/tcg/s390x/vistr.c diff --git a/tests/tcg/s390x/vistr.c b/tests/tcg/s390x/vistr.c new file mode 100644 index 0000000000..8e3e987d71 --- /dev/null +++ b/tests/tcg/s390x/vistr.c @@ -0,0 +1,45 @@ +/* + * Test the VECTOR ISOLATE STRING (vistr) instruction + */ +#include +#include +#include "vx.h" + +static inline void vistr(S390Vector *v1, S390Vector *v2, + const uint8_t m3, const uint8_t m5) +{ + asm volatile("vistr %[v1], %[v2], %[m3], %[m5]\n" + : [v1] "=3Dv" (v1->v) + : [v2] "v" (v2->v) + , [m3] "i" (m3) + , [m5] "i" (m5) + : "cc"); +} + +int main(int argc, char *argv[]) +{ + S390Vector vd =3D {}; + S390Vector vs16 =3D { + .h[0] =3D 0x1234, .h[1] =3D 0x0056, .h[2] =3D 0x7800, .h[3] =3D 0x= 0000, + .h[4] =3D 0x0078, .h[5] =3D 0x0000, .h[6] =3D 0x6543, .h[7] =3D 0x= 2100 + }; + S390Vector vs32 =3D { + .w[0] =3D 0x12340000, .w[1] =3D 0x78654300, + .w[2] =3D 0x0, .w[3] =3D 0x12, + }; + + vistr(&vd, &vs16, 1, 0); + if (vd.h[0] !=3D 0x1234 || vd.h[1] !=3D 0x0056 || vd.h[2] !=3D 0x7800 = || + vd.h[3] || vd.h[4] || vd.h[5] || vd.h[6] || vd.h[7]) { + puts("ERROR: vitrh failed!"); + return 1; + } + + vistr(&vd, &vs32, 2, 0); + if (vd.w[0] !=3D 0x12340000 || vd.w[1] !=3D 0x78654300 || vd.w[2] || v= d.w[3]) { + puts("ERROR: vitrf failed!"); + return 1; + } + + return 0; +} diff --git a/tests/tcg/s390x/Makefile.target b/tests/tcg/s390x/Makefile.tar= get index 29c8af8207..07fcc6d0ce 100644 --- a/tests/tcg/s390x/Makefile.target +++ b/tests/tcg/s390x/Makefile.target @@ -25,6 +25,10 @@ TESTS+=3Dsignals-s390x TESTS+=3Dbranch-relative-long TESTS+=3Dnoexec =20 +Z13_TESTS=3Dvistr +$(Z13_TESTS): CFLAGS+=3D-march=3Dz13 -O2 +TESTS+=3D$(Z13_TESTS) + ifneq ($(CROSS_CC_HAS_Z14),) Z14_TESTS=3Dvfminmax vfminmax: LDFLAGS+=3D-lm --=20 2.31.1