From nobody Mon Feb 9 03:29:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1665589361; cv=none; d=zohomail.com; s=zohoarc; b=eLDyWDvB42W/0PN/+R1xzUZO2QlMDrSngaVLxo71D+BuNFqgGbZqhz94o6Cjb/ctFoaT3ztM3CS/NcXGk5b5Cxn0ZHdP3x64Tf4Iw/AsANK/c9zYIj1jZgqlcbm8LarZTPixe5EyBdDXVWNnPcEWInd7DDNHp1SwKbTrcdeU0m8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1665589361; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=CGyiNRcDvp1yt2vo5ajS0q1H+fALnTj+obGbwNJPbJw=; b=oA1vQlAElOmGsrfdwjWduMR3ycZRsmSGIjvaDeFzJsg9645Hhph2Bot0omDF7je9TaJfDVf3gfKZlOpk975ncfC72PK2MNMjsm4J0XmhbbwLKHnoj5bhiXoiZrpHdD2QK5gdRp+EYH9SW3IcyhZdCFxwx2hodIY6IhGCd5ZEOJE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1665589361856535.5179634461381; Wed, 12 Oct 2022 08:42:41 -0700 (PDT) Received: from localhost ([::1]:41830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oidsW-0005ZG-OG for importer@patchew.org; Wed, 12 Oct 2022 11:42:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52972) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oidoH-0006pT-Bi for qemu-devel@nongnu.org; Wed, 12 Oct 2022 11:38:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:45140) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oido8-0001EK-IT for qemu-devel@nongnu.org; Wed, 12 Oct 2022 11:38:15 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-173-V6GUV4scO_Sf-i0YpMKDPA-1; Wed, 12 Oct 2022 11:38:03 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4E0E4185A7A3; Wed, 12 Oct 2022 15:38:03 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.110]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D1BFF111E3FD; Wed, 12 Oct 2022 15:38:02 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 6DEF121E6928; Wed, 12 Oct 2022 17:38:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665589088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CGyiNRcDvp1yt2vo5ajS0q1H+fALnTj+obGbwNJPbJw=; b=KZVij3Usc7DpEsvqvJlwZjvkIQyw4S633jXBSLdhuPU69KV3UGlr7uEyKEQ3URVJx34KfF FgatCMD+TqaFpagh6kIUJn9UDuAF/EtMcx5UDVRASCekVjx5H9fixgumcnGVhiuBoiz7tV qT/k0oUcbrFpf7F/NPVATbbRvqi3eOI= X-MC-Unique: V6GUV4scO_Sf-i0YpMKDPA-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: arei.gonglei@huawei.com, lvivier@redhat.com, amit@kernel.org, mst@redhat.com, pbonzini@redhat.com, berrange@redhat.com, eduardo@habkost.net, thuth@redhat.com, david@redhat.com Subject: [PATCH 1/4] qom: Improve error messages when property has no getter or setter Date: Wed, 12 Oct 2022 17:37:58 +0200 Message-Id: <20221012153801.2604340-2-armbru@redhat.com> In-Reply-To: <20221012153801.2604340-1-armbru@redhat.com> References: <20221012153801.2604340-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1665589362380100001 Content-Type: text/plain; charset="utf-8" When you try to set a property that has no setter, the error message blames "insufficient permission": $ qemu-system-x86_64 -S -display none -nodefaults -monitor stdio QEMU 7.1.50 monitor - type 'help' for more information (qemu) qom-set /machine type q35 Error: Insufficient permission to perform this operation This implies it could work with "sufficient permission". It can't. Change the error message to: Error: Property 'pc-i440fx-7.2-machine.type' is not writable Do the same for getting a property that has no getter. Signed-off-by: Markus Armbruster Acked-by: Michael S. Tsirkin Reviewed-by: David Hildenbrand --- qom/object.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/qom/object.c b/qom/object.c index d34608558e..e5cef30f6d 100644 --- a/qom/object.c +++ b/qom/object.c @@ -1383,7 +1383,8 @@ bool object_property_get(Object *obj, const char *nam= e, Visitor *v, } =20 if (!prop->get) { - error_setg(errp, QERR_PERMISSION_DENIED); + error_setg(errp, "Property '%s.%s' is not readable", + object_get_typename(obj), name); return false; } prop->get(obj, v, name, prop->opaque, &err); @@ -1402,7 +1403,8 @@ bool object_property_set(Object *obj, const char *nam= e, Visitor *v, } =20 if (!prop->set) { - error_setg(errp, QERR_PERMISSION_DENIED); + error_setg(errp, "Property '%s.%s' is not writable", + object_get_typename(obj), name); return false; } prop->set(obj, v, name, prop->opaque, errp); --=20 2.37.2 From nobody Mon Feb 9 03:29:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1665589230; cv=none; d=zohomail.com; s=zohoarc; b=dlTmMYEHapJ5d1UvYxo2g7a+LmuHmJ7RW1ttwToVComuDPrWMM41K08YRSLyzDk88Hy6QiW5Tjzh1E6eTFhygY5SVlx87oPxPOE1JrR9xoApyF8ekH7hyA1I4jrlimDslk8+e2X0yubEeLw2/Rmlc/bfl+3cV0xxcJDdNTnUOgk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1665589230; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=AshRl0qff47RtQHimqHVJFq8Vb6NhZReyz43xzowdD0=; b=RQHQcgHo3cXY0m/UT4VL1KLRKJPyy9Tpfv6OFmuBnn43AxwgpYQ2pAxV2ADPkoEWb7V4AtaBw8FCbDDNDNXbNdicnptKBbsQatp8vRuITtnTGcTAffN5dz76zA0TcWc/27M8FT77Jqx7BX2/4A+Zsl5gPw+WTIq39re1v6oq8cQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1665589230282269.1206786495285; Wed, 12 Oct 2022 08:40:30 -0700 (PDT) Received: from localhost ([::1]:41088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oidqP-0001C3-8o for importer@patchew.org; Wed, 12 Oct 2022 11:40:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59252) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oidoC-0006iC-Rv for qemu-devel@nongnu.org; Wed, 12 Oct 2022 11:38:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:33921) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oido8-0001E7-8P for qemu-devel@nongnu.org; Wed, 12 Oct 2022 11:38:12 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-548-7k5oZr4EM72H3My-TIP5IQ-1; Wed, 12 Oct 2022 11:38:03 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4E0E6811E75; Wed, 12 Oct 2022 15:38:03 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.110]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D1C77111E407; Wed, 12 Oct 2022 15:38:02 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 70A7B21E6931; Wed, 12 Oct 2022 17:38:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665589086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AshRl0qff47RtQHimqHVJFq8Vb6NhZReyz43xzowdD0=; b=QuvkrGWned5RoziPi00qR7VLJwDXi3R1uoMv4LY0f/gPsViRNokGndykGydikYAC2mloIR urPbYmqdy2PXk41FoBkmTVsGAAryKt4myhFFb+DxOBOF2bPjRYuqR+OtGX5yPYhPdabMF2 8NbPFv/M/HNVjlU+BQoEgNjbJFqZkmQ= X-MC-Unique: 7k5oZr4EM72H3My-TIP5IQ-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: arei.gonglei@huawei.com, lvivier@redhat.com, amit@kernel.org, mst@redhat.com, pbonzini@redhat.com, berrange@redhat.com, eduardo@habkost.net, thuth@redhat.com, david@redhat.com Subject: [PATCH 2/4] backends: Improve error messages when property can no longer be set Date: Wed, 12 Oct 2022 17:37:59 +0200 Message-Id: <20221012153801.2604340-3-armbru@redhat.com> In-Reply-To: <20221012153801.2604340-1-armbru@redhat.com> References: <20221012153801.2604340-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1665589232320100001 Content-Type: text/plain; charset="utf-8" When you try to set virtio-rng property "filename" after the backend has been completed with user_creatable_complete(), the error message blames "insufficient permission": $ qemu-system-x86_64 -S -display none -nodefaults -monitor stdio -objec= t rng-random,id=3Drng0 -device virtio-rng,id=3Dvrng0,rng=3Drng0 QEMU 7.1.50 monitor - type 'help' for more information (qemu) qom-set /objects/rng0 filename /dev/random Error: Insufficient permission to perform this operation This implies it could work with "sufficient permission". It can't. Change the error message to: Error: Property 'filename' can no longer be set Same for cryptodev-vhost-user property "chardev", rng-egd property "chardev", and vhost-user-backend property "chardev". Signed-off-by: Markus Armbruster # This is the commit message #2: # fixup! backends: Improve error messages when property can no longer be set Acked-by: Michael S. Tsirkin --- backends/cryptodev-vhost-user.c | 2 +- backends/rng-egd.c | 2 +- backends/rng-random.c | 2 +- backends/vhost-user.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/backends/cryptodev-vhost-user.c b/backends/cryptodev-vhost-use= r.c index 5443a59153..f9c5867e38 100644 --- a/backends/cryptodev-vhost-user.c +++ b/backends/cryptodev-vhost-user.c @@ -339,7 +339,7 @@ static void cryptodev_vhost_user_set_chardev(Object *ob= j, CRYPTODEV_BACKEND_VHOST_USER(obj); =20 if (s->opened) { - error_setg(errp, QERR_PERMISSION_DENIED); + error_setg(errp, "Property 'chardev' can no longer be set"); } else { g_free(s->chr_name); s->chr_name =3D g_strdup(value); diff --git a/backends/rng-egd.c b/backends/rng-egd.c index 4de142b9dc..684c3cf3d6 100644 --- a/backends/rng-egd.c +++ b/backends/rng-egd.c @@ -116,7 +116,7 @@ static void rng_egd_set_chardev(Object *obj, const char= *value, Error **errp) RngEgd *s =3D RNG_EGD(b); =20 if (b->opened) { - error_setg(errp, QERR_PERMISSION_DENIED); + error_setg(errp, "Property 'chardev' can no longer be set"); } else { g_free(s->chr_name); s->chr_name =3D g_strdup(value); diff --git a/backends/rng-random.c b/backends/rng-random.c index 7add272edd..80eb5be138 100644 --- a/backends/rng-random.c +++ b/backends/rng-random.c @@ -96,7 +96,7 @@ static void rng_random_set_filename(Object *obj, const ch= ar *filename, RngRandom *s =3D RNG_RANDOM(obj); =20 if (b->opened) { - error_setg(errp, QERR_PERMISSION_DENIED); + error_setg(errp, "Property 'filename' can no longer be set"); return; } =20 diff --git a/backends/vhost-user.c b/backends/vhost-user.c index 10b39992d2..5dedb2d987 100644 --- a/backends/vhost-user.c +++ b/backends/vhost-user.c @@ -141,7 +141,7 @@ static void set_chardev(Object *obj, const char *value,= Error **errp) Chardev *chr; =20 if (b->completed) { - error_setg(errp, QERR_PERMISSION_DENIED); + error_setg(errp, "Property 'chardev' can no longer be set"); return; } =20 --=20 2.37.2 From nobody Mon Feb 9 03:29:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1665589235; cv=none; d=zohomail.com; s=zohoarc; b=ZpD12sY/g8iNWoYW3QRWFvmvzHglIwrT3018e8j3riNPFxbsjIALpWy2r01S0iMAwYinYQWDwftWOSuzRBAYIuo9xI6jNhSqOSe5qBCtvXXLiECTcyNhTkNbTP+i1uy096I2zJjw99obKNu1dPVqENBKT92rH9exxItD7H6ccVc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1665589235; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Vu2BDGvGheYQIOeqRYZ1hohehzucKNLtNnhUERa5vag=; b=bbYwWm3N09RPUx+OLjhbKKVq1gBNh1BKtFMCKMCaadlTKwlH4I0ONi+Xyy6fPsEop79Nx+pYpcn8t9U1pT5TYp/JjIPPmN6WaD5G9X3kUONAJ6S9NUf3CaQSWapKcaW5Cu0effQK6xJ7VXZru0IyfOveHBr3/QhbJgNzD6YdPww= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1665589235809138.8070542837205; Wed, 12 Oct 2022 08:40:35 -0700 (PDT) Received: from localhost ([::1]:38986 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oidqU-0001Xj-Nj for importer@patchew.org; Wed, 12 Oct 2022 11:40:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59254) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oidoD-0006ia-HX for qemu-devel@nongnu.org; Wed, 12 Oct 2022 11:38:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:22485) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oido8-0001E5-C8 for qemu-devel@nongnu.org; Wed, 12 Oct 2022 11:38:13 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-215-vZZZFTI4PyWhAb4x1vliSw-1; Wed, 12 Oct 2022 11:38:03 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4D415381A722; Wed, 12 Oct 2022 15:38:03 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.110]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D1CC92156897; Wed, 12 Oct 2022 15:38:02 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 735CF21E6939; Wed, 12 Oct 2022 17:38:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665589086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vu2BDGvGheYQIOeqRYZ1hohehzucKNLtNnhUERa5vag=; b=c+lPyJVkoGQUi7sCm1WTC+Ri2/GTsKK6ZyzDFUJS4lvLdVGdbEgqdXmuU93XIogBsWIW4N zdb3XwwFcCnzqxolIyJZB2Dym8P/sK2dHAZ5YIGPGyHUIeMKKzcJvn3/cSEeMAHozGHd6M IQTzS7gqKfd31tRcS80Wg33EL5aU/F4= X-MC-Unique: vZZZFTI4PyWhAb4x1vliSw-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: arei.gonglei@huawei.com, lvivier@redhat.com, amit@kernel.org, mst@redhat.com, pbonzini@redhat.com, berrange@redhat.com, eduardo@habkost.net, thuth@redhat.com, david@redhat.com Subject: [PATCH 3/4] qtest: Improve error messages when property can not be set right now Date: Wed, 12 Oct 2022 17:38:00 +0200 Message-Id: <20221012153801.2604340-4-armbru@redhat.com> In-Reply-To: <20221012153801.2604340-1-armbru@redhat.com> References: <20221012153801.2604340-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1665589236299100005 Content-Type: text/plain; charset="utf-8" When you try to set qtest property "log" while the qtest object is active, the error message blames "insufficient permission": $ qemu-system-x86_64 -S -display none -nodefaults -monitor stdio -chard= ev socket,id=3Dchrqt0,path=3Dqtest.socket,server=3Don,wait=3Doff -object qt= est,id=3Dqt0,chardev=3Dchrqt0,log=3D/dev/null QEMU 7.1.50 monitor - type 'help' for more information (qemu) qom-set /objects/qt0 log qtest.log Error: Insufficient permission to perform this operation This implies it could work with "sufficient permission". It can't. Change the error message to: Error: Property 'log' can not be set now Same for property "chardev". Signed-off-by: Markus Armbruster Acked-by: Michael S. Tsirkin --- softmmu/qtest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/softmmu/qtest.c b/softmmu/qtest.c index f8acef2628..afea7693d0 100644 --- a/softmmu/qtest.c +++ b/softmmu/qtest.c @@ -977,7 +977,7 @@ static void qtest_set_log(Object *obj, const char *valu= e, Error **errp) QTest *q =3D QTEST(obj); =20 if (qtest =3D=3D q) { - error_setg(errp, QERR_PERMISSION_DENIED); + error_setg(errp, "Property 'log' can not be set now"); } else { g_free(q->log); q->log =3D g_strdup(value); @@ -997,7 +997,7 @@ static void qtest_set_chardev(Object *obj, const char *= value, Error **errp) Chardev *chr; =20 if (qtest =3D=3D q) { - error_setg(errp, QERR_PERMISSION_DENIED); + error_setg(errp, "Property 'chardev' can not be set now"); return; } =20 --=20 2.37.2 From nobody Mon Feb 9 03:29:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1665589277; cv=none; d=zohomail.com; s=zohoarc; b=Kdt96EwqanZV1qb3YGp/tSoOt9CMW+sjVBaU9iegy28pDMzs6DX/3gR4S6+fsaQFzbVkDj9njOyoQOP9pUa5h6I3tF/juAr5Fsg/MofNZV4k6cg8rGPs2onhxjnc9ZbIN8W5F4XeofjA74ZaoTeCy3/uyWpdPPEyE1ffJ1N2T+M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1665589277; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=YIvDcrxlins/ENDK7DqxpRIFOz5Xmkq25RXSfjK+BAE=; b=VF9snQWaart2msDxVmVSlPDozye0RcFVolRRHkb5gSPfz2D8zQ9AuLF+YehyF6UxjjZ+45xCyJj38P9TUSjfd0Iflcxuoxt1R3eY/3eT7LunvD1vXPqY2orSSpe3ZE0W9K8V6947majCU0qXllTt1mV9oz5NN5WnFFxQnIitiVY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16655892779281000.8119289824745; Wed, 12 Oct 2022 08:41:17 -0700 (PDT) Received: from localhost ([::1]:58740 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oidr8-0002zl-OW for importer@patchew.org; Wed, 12 Oct 2022 11:41:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59250) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oidoC-0006eV-4g for qemu-devel@nongnu.org; Wed, 12 Oct 2022 11:38:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:56163) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oido8-0001E4-30 for qemu-devel@nongnu.org; Wed, 12 Oct 2022 11:38:10 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-356-F72bLJF0OvWMG-4MG7odYg-1; Wed, 12 Oct 2022 11:38:03 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4EFA6804186; Wed, 12 Oct 2022 15:38:03 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.110]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D1E534EA53; Wed, 12 Oct 2022 15:38:02 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 7612C21E693E; Wed, 12 Oct 2022 17:38:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665589086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YIvDcrxlins/ENDK7DqxpRIFOz5Xmkq25RXSfjK+BAE=; b=G7cH0zh5ecyGnNs26ZJnf9Ig4gDuP8zCr+WAMsYA8EQUPXHr0tMMPGLT7r5mSWXgvK4U0I okZ1DUGXyZVyQY4RM5p4SWHr2YNahuy7YtdYYLFu56eKBfLEqAbrbW4I8/eeGDj4POtoT/ Ei8PqrDCFUlqnnucVa8YvMQMqmzBS0c= X-MC-Unique: F72bLJF0OvWMG-4MG7odYg-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: arei.gonglei@huawei.com, lvivier@redhat.com, amit@kernel.org, mst@redhat.com, pbonzini@redhat.com, berrange@redhat.com, eduardo@habkost.net, thuth@redhat.com, david@redhat.com Subject: [PATCH 4/4] qerror: QERR_PERMISSION_DENIED is no longer used, drop Date: Wed, 12 Oct 2022 17:38:01 +0200 Message-Id: <20221012153801.2604340-5-armbru@redhat.com> In-Reply-To: <20221012153801.2604340-1-armbru@redhat.com> References: <20221012153801.2604340-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1665589280519100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Markus Armbruster Acked-by: Michael S. Tsirkin --- include/qapi/qmp/qerror.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h index 596fce0c54..87ca83b155 100644 --- a/include/qapi/qmp/qerror.h +++ b/include/qapi/qmp/qerror.h @@ -50,9 +50,6 @@ #define QERR_MISSING_PARAMETER \ "Parameter '%s' is missing" =20 -#define QERR_PERMISSION_DENIED \ - "Insufficient permission to perform this operation" - #define QERR_PROPERTY_VALUE_BAD \ "Property '%s.%s' doesn't take value '%s'" =20 --=20 2.37.2