From nobody Mon Feb 9 19:07:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1665409338; cv=none; d=zohomail.com; s=zohoarc; b=YSKWPWg8oGt1NbcUBL7d2JnkHD3MVazSKzpWXQ2CxaO4nU9/Rfg/ZhtQXtNBFBv4nF2Dc4m+XBLGX6epPyoBXpABSyywcRJizCOhichHHGKvgNYyV5jESEzBoOv8Ib0cAOGa6UKhUIM249k0FNGhkPf2Rb+YBm9RJf4HUHBC5N4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1665409338; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wQIQjZe3/s5Z7h2Qk9gj7o9NRBQIR6PIhbUVeetfc3Q=; b=KzK9k55fSVBq054uTFi4NsqPtd33raBPSQmaZiUjDYVNryXtK3376ZNOeBejMMylntg+G/APJB8xI+DVMPqKF7v0HTbKjpC3acxzN4DxCVVJ3hRMWvIw3+p3WXc3GJfT/h6edcrgTYr6PJyPhHLdd+EaKpAZqSJ0Ssn4N5zgwcA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1665409338602187.0470322146001; Mon, 10 Oct 2022 06:42:18 -0700 (PDT) Received: from localhost ([::1]:43980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oht2t-0001j1-BW for importer@patchew.org; Mon, 10 Oct 2022 09:42:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40940) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohsvG-0000zu-NO for qemu-devel@nongnu.org; Mon, 10 Oct 2022 09:34:23 -0400 Received: from smtp-out1.suse.de ([2001:67c:2178:6::1c]:58906) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohsvB-0005KD-0Z for qemu-devel@nongnu.org; Mon, 10 Oct 2022 09:34:18 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9A6DD219C4; Mon, 10 Oct 2022 13:34:15 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2B7AD13AF4; Mon, 10 Oct 2022 13:34:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id gKGBB1cfRGNsAwAAMHmgww (envelope-from ); Mon, 10 Oct 2022 13:34:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1665408855; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wQIQjZe3/s5Z7h2Qk9gj7o9NRBQIR6PIhbUVeetfc3Q=; b=UjuzJSm2yR1T1iPvkR4a+LginrO7nRkQY5bk0Fczed//hmhpScHOjDiWk8ui+TR/wQNM7C SYnWdBT3rMIE2CGq7rmS4OU3hR4sIjR6Xgv4cZjh2559efzZi3rG5TKJJ8Zru82hA30cf7 JN11d/EVFWocXnn/pjSPdWhgTAGx8hE= From: Nikolay Borisov To: dgilbert@redhat.com, berrange@redhat.com Cc: qemu-devel@nongnu.org, jfehlig@suse.com, Claudio.Fontana@suse.com, dfaggioli@suse.com, Nikolay Borisov Subject: [PATCH v2 04/11] io: add pwritev support to QIOChannelFile Date: Mon, 10 Oct 2022 16:34:01 +0300 Message-Id: <20221010133408.3214433-5-nborisov@suse.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221010133408.3214433-1-nborisov@suse.com> References: <20221010133408.3214433-1-nborisov@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:67c:2178:6::1c; envelope-from=nborisov@suse.com; helo=smtp-out1.suse.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1665409338862100003 Content-Type: text/plain; charset="utf-8" The upcoming 'fixed-ram' feature would require qemu to write data at specific offsets of the file. This is currently missing so this patch adds it. I've chosen to implement it as a type-specific function rather than plumb it through the generic channel interface as it relies on being able to do seeks. Signed-off-by: Nikolay Borisov --- include/io/channel-file.h | 5 +++++ io/channel-file.c | 24 ++++++++++++++++++++++++ 2 files changed, 29 insertions(+) diff --git a/include/io/channel-file.h b/include/io/channel-file.h index 50e8eb113868..0a5d54f5e58e 100644 --- a/include/io/channel-file.h +++ b/include/io/channel-file.h @@ -89,4 +89,9 @@ qio_channel_file_new_path(const char *path, mode_t mode, Error **errp); =20 +ssize_t qio_channel_file_pwritev(QIOChannel *ioc, + const struct iovec *iov, + size_t niov, + off_t offset, + Error **errp); #endif /* QIO_CHANNEL_FILE_H */ diff --git a/io/channel-file.c b/io/channel-file.c index b67687c2aa64..da17d0a11ba7 100644 --- a/io/channel-file.c +++ b/io/channel-file.c @@ -136,6 +136,30 @@ static ssize_t qio_channel_file_writev(QIOChannel *ioc, return ret; } =20 +ssize_t qio_channel_file_pwritev(QIOChannel *ioc, + const struct iovec *iov, + size_t niov, + off_t offset, + Error **errp) +{ + QIOChannelFile *fioc =3D QIO_CHANNEL_FILE(ioc); + ssize_t ret; + + retry: + ret =3D pwritev(fioc->fd, iov, niov, offset); + if (ret <=3D 0) { + if (errno =3D=3D EAGAIN) { + return QIO_CHANNEL_ERR_BLOCK; + } + if (errno =3D=3D EINTR) { + goto retry; + } + error_setg_errno(errp, errno, "Unable to write to file"); + return -1; + } + return ret; +} + static int qio_channel_file_set_blocking(QIOChannel *ioc, bool enabled, Error **errp) --=20 2.34.1