From nobody Mon Feb 9 12:11:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1665234560; cv=none; d=zohomail.com; s=zohoarc; b=eDtyRARXoxqyieomR7HX/ODNnE35z1aNLbq3PzHEdC/YjKhAc07E7B3xQLF/UWcQ1AbxyVO4RoCJkS4dJnRzxwezQA1Em1lfpYxK6y8C2tYGU+Ca6YU+aOm4OhEqSfUjJx/mF+5w0HUAg3CyDmLbb748RlBeVti99VZ2GYoC4pk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1665234560; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=vAROz0sAFRZA2tLTAQPXPO1fuYDIUeuWvfgiObT8Qxg=; b=E+5KOJ13TAoIhIsxBOc+qx8LxfuR05EUDhMIFd5j4SP5jPkTtOwz2qN372C6+gpvLzC+kDKKj7igySae2/NcetavVqSZvqu0KjDQ92R8BiuKM1m740Qr9wLhHaOnMyxC+Wu+JME6349XPZ8QU81dTnfgO4R7a5V6zCIuzySQ7Vw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1665234560286629.3184473897672; Sat, 8 Oct 2022 06:09:20 -0700 (PDT) Received: from localhost ([::1]:34902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oh9Zu-0003wG-RR for importer@patchew.org; Sat, 08 Oct 2022 09:09:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oh9Yd-0002yz-On for qemu-devel@nongnu.org; Sat, 08 Oct 2022 09:07:59 -0400 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]:43777) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oh9Yb-0004Rk-Bj for qemu-devel@nongnu.org; Sat, 08 Oct 2022 09:07:59 -0400 Received: by mail-pj1-x1030.google.com with SMTP id g1-20020a17090a708100b00203c1c66ae3so6888384pjk.2 for ; Sat, 08 Oct 2022 06:07:56 -0700 (PDT) Received: from DESKTOP-8TCEJFK.localdomain (215.134.178.217.shared.user.transix.jp. [217.178.134.215]) by smtp.gmail.com with ESMTPSA id u204-20020a6279d5000000b00535da15a252sm3458718pfc.165.2022.10.08.06.07.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Oct 2022 06:07:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=isshiki-clinic-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vAROz0sAFRZA2tLTAQPXPO1fuYDIUeuWvfgiObT8Qxg=; b=eHMD6canhjiaKP29pHC9gkrM1elTz46gEyxcS5O9fcQ1wlXXZy3eEZEqSBJBu6/5n/ mSehoDC30KDUBjYu9wptzGKBxt/Jz9he4a5m821SD4tGFDXAoJKcoBjfZ+GRc9AoYE7N DBu7/P/cS33g9kwBOgOOAfA/eEp2djgHyGP91ac0F3RVAh9gWq4iEZkzaXte06zVnoAP bwNnLHlkSsvNs4gKzWzsgrR7chbBwLS0nj4rSIuzb2ND5qxvbWmgOT4+XeZAkDRdWC63 hCqMYulUpypB404pReid3HvzFRbxLtWULWnl9FgQXwxQUsmUlgEN1WWQS2DurYX5eg33 E6+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vAROz0sAFRZA2tLTAQPXPO1fuYDIUeuWvfgiObT8Qxg=; b=3NEXnKA+1gOJxVEiYBLRPMmtt92s1nveVRpWY1xnVtLPXW8dBWm+PF9bIUvlBL4BO6 V9tOWd00aF6pzwkyEWyz0XP10Lu5gGpm6FnEqUgEzxkOzBr2WXefBS43esa7QL8KcG18 Fy4LSOXJaUBn/ORkBm+IbGur0VTP/Xn+CRjyV26rqpDn0w6kQq5IGeHMXZbHy5PQZ2my vJnn7KdOy9EC8v/kSQ4l4as0wA65gMweYjNxrdQSJb3xKgd70asRHZ3RWQmp1A7Bfl2h K0SEmFKDEQB0mVKD1oWLhsz0pAPJVUkuPOcNkvpbJE7jBBarWSf2IXQv8JBRqndKQonY XcgA== X-Gm-Message-State: ACrzQf0fi1vzW0AVkvYl0Rg4KWpP0tFcbUvkjQllYXM6B1DmqtY+xeKk NXYr6N3yCsvphrWC0gupnXwDzw== X-Google-Smtp-Source: AMsMyM5858reGsNJRJWxWON8fbmM4KdBVQcgTQQThVR2YcewTVS4pVBeZ50uPwkDZbpmJ+41GhJneA== X-Received: by 2002:a17:902:a611:b0:178:6b71:2ee5 with SMTP id u17-20020a170902a61100b001786b712ee5mr9716531plq.53.1665234474570; Sat, 08 Oct 2022 06:07:54 -0700 (PDT) From: Soichiro Isshiki X-Google-Original-From: Soichiro Isshiki To: Richard Henderson , Peter Maydell , qemu-devel@nongnu.org, qemu-trivial@nongnu.org Cc: Soichiro Isshiki Subject: [PATCH v3] linux-user: mprotect() should returns 0 when len is 0. Date: Sat, 8 Oct 2022 22:06:43 +0900 Message-Id: <20221008130642.2158-1-sisshiki@mac.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=2607:f8b0:4864:20::1030; envelope-from=sisshiki@isshiki-clinic.com; helo=mail-pj1-x1030.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @isshiki-clinic-com.20210112.gappssmtp.com) X-ZM-MESSAGEID: 1665234561638100001 Content-Type: text/plain; charset="utf-8" On Sat, Oct 8, 2022 at 12:41 AM Soichiro Isshiki wrote: > A validation for wrap-around was added, I think it is neccesory. I noticed the validation for wrap-around is *not* necessary, because it is = done by guest_range_valid_untagged(). Signed-off-by: Soichiro Isshiki --- linux-user/mmap.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/linux-user/mmap.c b/linux-user/mmap.c index 28f3bc85ed..6f23a1ac39 100644 --- a/linux-user/mmap.c +++ b/linux-user/mmap.c @@ -124,17 +124,17 @@ int target_mprotect(abi_ulong start, abi_ulong len, i= nt target_prot) if ((start & ~TARGET_PAGE_MASK) !=3D 0) { return -TARGET_EINVAL; } - page_flags =3D validate_prot_to_pageflags(&host_prot, target_prot); - if (!page_flags) { - return -TARGET_EINVAL; + if (len =3D=3D 0) { + return 0; } len =3D TARGET_PAGE_ALIGN(len); - end =3D start + len; if (!guest_range_valid_untagged(start, len)) { return -TARGET_ENOMEM; } - if (len =3D=3D 0) { - return 0; + end =3D start + len; + page_flags =3D validate_prot_to_pageflags(&host_prot, target_prot); + if (!page_flags) { + return -TARGET_EINVAL; } =20 mmap_lock(); --=20 2.25.1