From nobody Mon Feb 9 19:06:15 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=oracle.com ARC-Seal: i=1; a=rsa-sha256; t=1665156572; cv=none; d=zohomail.com; s=zohoarc; b=IbWBhlB5egZb9trvGiYLKVUCyYGfDCzp+I38t9Sb/oaa72LA8gbNamnuMWNMkx9Q7zO5ixyIiwJDh8OTvYOEuiXBRMFKLnwhIi33bqeJic6QtRtt7BBJuYKqxKTO+1kV3DS+3D+2hoR288kOR8fe+3Z4HMteZ3rSWpEVeDi5bLs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1665156572; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=5n4daUCclTBq2xuK7UvGBMyCxgG/DJzl1LFOnvJ29CM=; b=J7xPD9PXpBBrTz3QOKM5ucyR9tbqd9QWuxWf69yYutaKJUOHkWiINQElW3SqMzbQLobSklLdLh9uZyib+dM4Tv7X6C6TrsoWTi6DtZ9wjP8ZDQ8PkIkGFVq701OE15bIcnJhSzDryQ22uJ9b+nAPeBmO+WSz3v/vbr6YEeXfJNw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1665156572531977.9730269537267; Fri, 7 Oct 2022 08:29:32 -0700 (PDT) Received: from localhost ([::1]:54300 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ogpI3-0002tD-Fb for importer@patchew.org; Fri, 07 Oct 2022 11:29:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56722) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogocU-00088c-SC; Fri, 07 Oct 2022 10:46:36 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:36546) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogocT-0000BA-9v; Fri, 07 Oct 2022 10:46:34 -0400 Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 297Bx3X0031958; Fri, 7 Oct 2022 14:46:30 GMT Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3jxd5tq7tc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 07 Oct 2022 14:46:29 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 297DEJei002779; Fri, 7 Oct 2022 14:46:29 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3jxc0d8n81-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 07 Oct 2022 14:46:29 +0000 Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 297EkCYK028446; Fri, 7 Oct 2022 14:46:28 GMT Received: from mlluis-mac.uk.oracle.com (dhcp-10-175-212-78.vpn.oracle.com [10.175.212.78]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 3jxc0d8n08-3; Fri, 07 Oct 2022 14:46:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : reply-to : mime-version : content-transfer-encoding; s=corp-2022-7-12; bh=5n4daUCclTBq2xuK7UvGBMyCxgG/DJzl1LFOnvJ29CM=; b=Kzi9vmGRfiZEF66mf/JTmvUDAsaEHdLixpo4FMIZTgdwzbSB53TAR4Xe5rfrLEXIOn0f unm0kgMecOxLR3CRQ/f31qTrGcWxkDbP7+opq8Ehql9Kn4Uoc483FarFFx+R/dXWTHkr h0sXlUpFs6OaMN3e1dhfvHQp1haCKg0309HTnMAzRVafyCctgiEW6x4nUwzigonBWDxa /isAi+ILQIkp60vs9Tf09Sd/3l6dYYJJZAMPbUYZpJzEvdxI8s3GsQ7eDaZZYHauo74V wiQOwo/bVWGz11N9lrKfbzxJbcFSACRIx8iZIkvGZ0w8NTVNVISOIqnWxx01ngLLlyax Vg== From: Miguel Luis To: qemu-devel@nongnu.org, qemu-arm@nongnu.org Cc: mst@redhat.com, imammedo@redhat.com, ani@anisinha.ca, shannon.zhaosl@gmail.com, peter.maydell@linaro.org, miguel.luis@oracle.com Subject: [PATCH v2 2/3] acpi: arm/virt: build_gtdt: fix invalid 64-bit physical addresses Date: Fri, 7 Oct 2022 14:45:52 +0000 Message-Id: <20221007144553.79648-3-miguel.luis@oracle.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221007144553.79648-1-miguel.luis@oracle.com> References: <20221007144553.79648-1-miguel.luis@oracle.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-10-06_05,2022-10-07_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 mlxscore=0 malwarescore=0 adultscore=0 spamscore=0 mlxlogscore=817 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210070088 X-Proofpoint-ORIG-GUID: cY1BAUbd0ngOOo97zakNSNzR45L6bruE X-Proofpoint-GUID: cY1BAUbd0ngOOo97zakNSNzR45L6bruE Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.177.32; envelope-from=miguel.luis@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: miguel.luis@oracle.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @oracle.com) X-ZM-MESSAGEID: 1665156573901100001 Content-Type: text/plain; charset="utf-8" Per the ACPI 6.5 specification, on the GTDT Table Structure, the Counter Co= ntrol Block Address and Counter Read Block Address fields of the GTDT table shoul= d be set to 0xFFFFFFFFFFFFFFFF if not provided, rather than 0x0. Fixes: 41041e57085 ("acpi: arm/virt: build_gtdt: use acpi_table_begin()/acp= i_table_end() instead of build_header()") Signed-off-by: Miguel Luis Reviewed-by: Ani Sinha --- hw/arm/virt-acpi-build.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index 9b3aee01bf..13c6e3e468 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -592,8 +592,7 @@ build_gtdt(GArray *table_data, BIOSLinker *linker, Virt= MachineState *vms) acpi_table_begin(&table, table_data); =20 /* CntControlBase Physical Address */ - /* FIXME: invalid value, should be 0xFFFFFFFFFFFFFFFF if not impl. ? */ - build_append_int_noprefix(table_data, 0, 8); + build_append_int_noprefix(table_data, 0xFFFFFFFFFFFFFFFF, 8); build_append_int_noprefix(table_data, 0, 4); /* Reserved */ /* * FIXME: clarify comment: @@ -618,7 +617,7 @@ build_gtdt(GArray *table_data, BIOSLinker *linker, Virt= MachineState *vms) /* Non-Secure EL2 timer Flags */ build_append_int_noprefix(table_data, irqflags, 4); /* CntReadBase Physical address */ - build_append_int_noprefix(table_data, 0, 8); + build_append_int_noprefix(table_data, 0xFFFFFFFFFFFFFFFF, 8); /* Platform Timer Count */ build_append_int_noprefix(table_data, 0, 4); /* Platform Timer Offset */ --=20 2.37.3