From nobody Sat Apr 12 01:25:41 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1665140824; cv=none; d=zohomail.com; s=zohoarc; b=Uvuej5K4cfJT9vDxL/STu+WilFBOu8/Eh31Ml6zNgoDL9wDwcwLxQyUS4qDMBP24VguJVsGQwXak2Bll1vA3e803fl1LMWJEZQgNhkuH8kHyym+AYsCBhIzRJcTD9XdZ1zkbqV8XEvDuQoFq7lnZ9QAP1j/x/qhQ2VhkzxeOmZI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1665140824; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0lnpcvVks2bsy6qvNvZjYGGTISVVcqMyRRyF850AK9U=; b=Eo5b5leS7n+5R1DS2TQFri2FXNoTmKn19FyEjOM7LvX1lt2hJP1MMntXIy/6HZevHsNp08t1DEcMfX4xQm/gS8+NVHXe9/ODBkBz5QxKfhHzcyoBTEpnHjlnvqKdDaapu5a8+FTz/x6hU1o5ziSv+r8qE5FMAB/t2J3wM5OV2z8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1665140824578512.8935622087926; Fri, 7 Oct 2022 04:07:04 -0700 (PDT) Received: from localhost ([::1]:49618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oglC2-0007wj-Pf for importer@patchew.org; Fri, 07 Oct 2022 07:07:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34528) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogktu-0005Pa-I1 for qemu-devel@nongnu.org; Fri, 07 Oct 2022 06:48:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:23558) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogktq-00037A-Hu for qemu-devel@nongnu.org; Fri, 07 Oct 2022 06:48:18 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-60-m06fXfdxM6-xa4bIu0VCHw-1; Fri, 07 Oct 2022 06:48:10 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 838481C0515C; Fri, 7 Oct 2022 10:48:10 +0000 (UTC) Received: from merkur.fritz.box (unknown [10.39.192.109]) by smtp.corp.redhat.com (Postfix) with ESMTP id C1F2F2024CBB; Fri, 7 Oct 2022 10:48:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665139694; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0lnpcvVks2bsy6qvNvZjYGGTISVVcqMyRRyF850AK9U=; b=HrXuHYFXqrzUUO2/8aNmGIi241flo5XX8czgW7esxdco/hNYI/rjzVaBN+Xo6GRBLzsK1b Ag1TpX+3IdvbJ4kZMNID1rhQN4CGnMuD2xnW6vRhzUtagjyhX3tDRjlwHSYVBxDuk8rCbs IRA02x+YX46d3iJtFozJtcNdwBcrXt4= X-MC-Unique: m06fXfdxM6-xa4bIu0VCHw-1 From: Kevin Wolf To: qemu-block@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org Subject: [PULL 10/50] iscsi: add missing coroutine_fn annotations Date: Fri, 7 Oct 2022 12:47:12 +0200 Message-Id: <20221007104752.141361-11-kwolf@redhat.com> In-Reply-To: <20221007104752.141361-1-kwolf@redhat.com> References: <20221007104752.141361-1-kwolf@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1665140826479100001 Content-Type: text/plain; charset="utf-8" From: Paolo Bonzini Callers of coroutine_fn must be coroutine_fn themselves, or the call must be within "if (qemu_in_coroutine())". Apply coroutine_fn to functions where this holds. Reviewed-by: Alberto Faria Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Message-Id: <20220922084924.201610-10-pbonzini@redhat.com> [kwolf: Fixed up coding style] Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- block/iscsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index 612de127e5..a316d46d96 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -290,7 +290,8 @@ iscsi_co_generic_cb(struct iscsi_context *iscsi, int st= atus, } } =20 -static void iscsi_co_init_iscsitask(IscsiLun *iscsilun, struct IscsiTask *= iTask) +static void coroutine_fn +iscsi_co_init_iscsitask(IscsiLun *iscsilun, struct IscsiTask *iTask) { *iTask =3D (struct IscsiTask) { .co =3D qemu_coroutine_self(), --=20 2.37.3