From nobody Thu May 9 03:51:30 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1664882695; cv=none; d=zohomail.com; s=zohoarc; b=oLB5kTDTwlKlVVyQOWQXl4b6yAc3s+VhnYtgIHzIqNwyDuEhhLRNQ3IZW/E+ecEUNDdOueIB1FlaGIcw8316z7lrQBT5xUsdxCw8TupOi2MIi81B9Ob+BuIKOmDj04B9Q7u7zs2nQuL7JnpJEjhujsY6nMS4PCnzUgUWpBhoAME= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664882695; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=58AJXZJceEK3bk8qEwX1wYGn/BgTphikEpZfGGH5jh0=; b=M6oPqj87E5c7tC2e26jPhUZeNCzzJrrFud6EDWTUAmR/Rpz6J2zC8+9v5ud58FdpCr3XnXquvruuju7JPJxIvMwDfSBGQzMbb4Mrgj7wTL1z2dbEiCodOT5fsocR145+UAdNh+Tt39jyS+fOm3q5XJN6ZQeuW7lqvi0uIAF82Ds= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1664882695387216.49211447831294; Tue, 4 Oct 2022 04:24:55 -0700 (PDT) Received: from localhost ([::1]:40832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ofg2f-000094-Q9 for importer@patchew.org; Tue, 04 Oct 2022 07:24:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46368) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1offz5-0005et-HK for qemu-devel@nongnu.org; Tue, 04 Oct 2022 07:21:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:36181) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1offyy-0007fW-8L for qemu-devel@nongnu.org; Tue, 04 Oct 2022 07:21:09 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-34-Lu2dcwilNfSFt2z0SCkl1w-1; Tue, 04 Oct 2022 07:21:02 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E6FD1811E67; Tue, 4 Oct 2022 11:21:01 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A35721402BDB; Tue, 4 Oct 2022 11:21:01 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 7349C180060F; Tue, 4 Oct 2022 13:21:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664882463; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=58AJXZJceEK3bk8qEwX1wYGn/BgTphikEpZfGGH5jh0=; b=dFvCRn/pCWOG01rvqktP7qdSNqzhDsOicwrvAJC0FRYbnpPstOU8MeXHvgsE2tcuA1jODM uegXzJO3krAuc0JidHLJ3ymYf3PckZiLcIEVFR4UrXeazIdSEcXmeZDFdR1KwUZIIEnnC8 8rjPFlxCUCRSqUx7YTS22sOQWNFWyR8= X-MC-Unique: Lu2dcwilNfSFt2z0SCkl1w-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Marcel Apfelbaum , "Michael S. Tsirkin" , David Hildenbrand , Eric Auger , peter.maydell@linaro.org, Gerd Hoffmann Subject: [PATCH v3 1/5] pci-ids: drop PCI_DEVICE_ID_VIRTIO_IOMMU Date: Tue, 4 Oct 2022 13:20:56 +0200 Message-Id: <20221004112100.301935-2-kraxel@redhat.com> In-Reply-To: <20221004112100.301935-1-kraxel@redhat.com> References: <20221004112100.301935-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1664882696259100002 Content-Type: text/plain; charset="utf-8" Not needed for a virtio 1.0 device. virtio_pci_device_plugged() overrides them anyway (so no functional change). Signed-off-by: Gerd Hoffmann Reviewed-by: Eric Auger Tested-by: Eric Auger --- include/hw/pci/pci.h | 1 - hw/virtio/virtio-iommu-pci.c | 4 +--- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index b54b6ef88fc3..89eaca429389 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h @@ -85,7 +85,6 @@ extern bool pci_available; #define PCI_DEVICE_ID_VIRTIO_9P 0x1009 #define PCI_DEVICE_ID_VIRTIO_VSOCK 0x1012 #define PCI_DEVICE_ID_VIRTIO_PMEM 0x1013 -#define PCI_DEVICE_ID_VIRTIO_IOMMU 0x1014 #define PCI_DEVICE_ID_VIRTIO_MEM 0x1015 =20 #define PCI_VENDOR_ID_REDHAT 0x1b36 diff --git a/hw/virtio/virtio-iommu-pci.c b/hw/virtio/virtio-iommu-pci.c index 844d64770406..79ea8334f04e 100644 --- a/hw/virtio/virtio-iommu-pci.c +++ b/hw/virtio/virtio-iommu-pci.c @@ -74,8 +74,6 @@ static void virtio_iommu_pci_class_init(ObjectClass *klas= s, void *data) k->realize =3D virtio_iommu_pci_realize; set_bit(DEVICE_CATEGORY_MISC, dc->categories); device_class_set_props(dc, virtio_iommu_pci_properties); - pcidev_k->vendor_id =3D PCI_VENDOR_ID_REDHAT_QUMRANET; - pcidev_k->device_id =3D PCI_DEVICE_ID_VIRTIO_IOMMU; pcidev_k->revision =3D VIRTIO_PCI_ABI_VERSION; pcidev_k->class_id =3D PCI_CLASS_OTHERS; dc->hotpluggable =3D false; @@ -90,7 +88,7 @@ static void virtio_iommu_pci_instance_init(Object *obj) } =20 static const VirtioPCIDeviceTypeInfo virtio_iommu_pci_info =3D { - .generic_name =3D TYPE_VIRTIO_IOMMU_PCI, + .generic_name =3D TYPE_VIRTIO_IOMMU_PCI, .instance_size =3D sizeof(VirtIOIOMMUPCI), .instance_init =3D virtio_iommu_pci_instance_init, .class_init =3D virtio_iommu_pci_class_init, --=20 2.37.3 From nobody Thu May 9 03:51:30 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1664882695; cv=none; d=zohomail.com; s=zohoarc; b=gvGF40zi1rbW1gtV3gB4T2lmpxcPob14bUYUcThUweC9MPzCY1zUPLeA2pX97QfYGWvEOnHOpR+i1D3QHWpsHvwwe0T4P7nJt95D6mKyo1m8IJ6oj4odPQy7e0JL5QNBT3pg4kxkl6Njwlwi3WHJC3lyM7VtlscU0KtSmHX+IWk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664882695; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GEkOloB4baIi/51hPzceH4bCVxljRlhlsqVRhpVKGYE=; b=UCbEEZDbHvdWn0mwVkhtnCVWic2wb2usdlppmT8duAxpa4dT7C5ES/TcJcwuN2aSezw6uwjjxsYTOXQorYvrVojKhW3MDLmvIkyEVzW/Hyjb2528/I0YXNEKbw4YSL63RNwCVLjrRUYalQahIn3/FwUpSzX4G8vvHCsM82m9cEA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1664882695463191.6807679655759; Tue, 4 Oct 2022 04:24:55 -0700 (PDT) Received: from localhost ([::1]:40834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ofg2g-0000CF-9h for importer@patchew.org; Tue, 04 Oct 2022 07:24:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1offz5-0005hH-G6 for qemu-devel@nongnu.org; Tue, 04 Oct 2022 07:21:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:37428) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1offz2-0007fq-Ip for qemu-devel@nongnu.org; Tue, 04 Oct 2022 07:21:10 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-592-scWVY2J5OOaO5srNm1UGtA-1; Tue, 04 Oct 2022 07:21:03 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 707D285A59D; Tue, 4 Oct 2022 11:21:03 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 205AE2166B26; Tue, 4 Oct 2022 11:21:03 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 8280E1800848; Tue, 4 Oct 2022 13:21:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664882467; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GEkOloB4baIi/51hPzceH4bCVxljRlhlsqVRhpVKGYE=; b=f7yLqidQWV7csV/WLu9/1g/7TzbkwpxfLJd9LW+5mmIOTbNmXDlEy9k96aFp+uw8nov7zn IWiRBwH56q8pvm+tQf+8C/9FeIMslKq3M7jcjprlRwglAxSiqPQTcVV9FiQi8jWGarJ8M7 35NA8k3f6lx/9ieUVk6ohzDOOIQnIOg= X-MC-Unique: scWVY2J5OOaO5srNm1UGtA-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Marcel Apfelbaum , "Michael S. Tsirkin" , David Hildenbrand , Eric Auger , peter.maydell@linaro.org, Gerd Hoffmann Subject: [PATCH v3 2/5] pci-ids: drop PCI_DEVICE_ID_VIRTIO_MEM Date: Tue, 4 Oct 2022 13:20:57 +0200 Message-Id: <20221004112100.301935-3-kraxel@redhat.com> In-Reply-To: <20221004112100.301935-1-kraxel@redhat.com> References: <20221004112100.301935-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1664882696257100001 Content-Type: text/plain; charset="utf-8" Not needed for a virtio 1.0 device. virtio_pci_device_plugged() overrides them anyway (so no functional change). Signed-off-by: Gerd Hoffmann Reviewed-by: David Hildenbrand --- include/hw/pci/pci.h | 1 - hw/virtio/virtio-mem-pci.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index 89eaca429389..b6aefb33fb17 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h @@ -85,7 +85,6 @@ extern bool pci_available; #define PCI_DEVICE_ID_VIRTIO_9P 0x1009 #define PCI_DEVICE_ID_VIRTIO_VSOCK 0x1012 #define PCI_DEVICE_ID_VIRTIO_PMEM 0x1013 -#define PCI_DEVICE_ID_VIRTIO_MEM 0x1015 =20 #define PCI_VENDOR_ID_REDHAT 0x1b36 #define PCI_DEVICE_ID_REDHAT_BRIDGE 0x0001 diff --git a/hw/virtio/virtio-mem-pci.c b/hw/virtio/virtio-mem-pci.c index be2383b0c522..5c5c1e3ae3da 100644 --- a/hw/virtio/virtio-mem-pci.c +++ b/hw/virtio/virtio-mem-pci.c @@ -104,8 +104,6 @@ static void virtio_mem_pci_class_init(ObjectClass *klas= s, void *data) =20 k->realize =3D virtio_mem_pci_realize; set_bit(DEVICE_CATEGORY_MISC, dc->categories); - pcidev_k->vendor_id =3D PCI_VENDOR_ID_REDHAT_QUMRANET; - pcidev_k->device_id =3D PCI_DEVICE_ID_VIRTIO_MEM; pcidev_k->revision =3D VIRTIO_PCI_ABI_VERSION; pcidev_k->class_id =3D PCI_CLASS_OTHERS; =20 --=20 2.37.3 From nobody Thu May 9 03:51:30 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1664882696; cv=none; d=zohomail.com; s=zohoarc; b=SWfV6jbh2G2618uOXTlOqg58T/tX0GePK5pUIMMO20Q4fmSkFh4ypTxc8ZlCDsu43xd8htaxnskHggppKZEtzjh99cp2QhfRW3UN1khOPnC349gSpf7i3OuGJa544sdYW2y7Yb2xCNxMHKSQw9ffzYTHg6PGLQQ7v0+5e8sezl8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664882696; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9InghcT15qdHxz05tAYaIvWLbkY1HN3xvSc/VXL0Rmw=; b=VAW1a1WEe1TBQz3Ocb3K5xdJLGlC3ZnIsHeQFt/IxsLeJSRba8xOdgG+15f1IOUjlpIFRk0eMkYdOFWVFvU4YgWrlPI6Ao3BBtQSw4WDEV5nIw8/+diU30GfTpheEYTFio+TDRDpljdoH9oHZtsgPAamYE0UUIBSjZvJ2GThvmc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1664882696420359.2157824270537; Tue, 4 Oct 2022 04:24:56 -0700 (PDT) Received: from localhost ([::1]:40836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ofg2g-0000I1-E0 for importer@patchew.org; Tue, 04 Oct 2022 07:24:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46376) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1offz5-0005hG-Fa for qemu-devel@nongnu.org; Tue, 04 Oct 2022 07:21:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:20767) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1offz1-0007fl-Ir for qemu-devel@nongnu.org; Tue, 04 Oct 2022 07:21:10 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-651-987Wp8eWPfOFM1pP5SuYtA-1; Tue, 04 Oct 2022 07:21:03 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 76C9B86E91F; Tue, 4 Oct 2022 11:21:03 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 22211112132D; Tue, 4 Oct 2022 11:21:03 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 91497180084D; Tue, 4 Oct 2022 13:21:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664882466; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9InghcT15qdHxz05tAYaIvWLbkY1HN3xvSc/VXL0Rmw=; b=WC5x+fwF82KWspO7IQi7lIiAq/pkUcxDSJqyQRs7yGi9r0UDUzHZMVeD/LRrTBPc4GJfjA o5VZ5nmoKfVT9VpIPjYWc8qXBSWViIDL3gLgYGEhHaPMIiJPvCL4jSFgD4Ije09ACarfTQ 14HvTXVLRIDtViU5A3ulS0mRH7YAyLE= X-MC-Unique: 987Wp8eWPfOFM1pP5SuYtA-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Marcel Apfelbaum , "Michael S. Tsirkin" , David Hildenbrand , Eric Auger , peter.maydell@linaro.org, Gerd Hoffmann , Pankaj Gupta Subject: [PATCH v3 3/5] pci-ids: drop PCI_DEVICE_ID_VIRTIO_PMEM Date: Tue, 4 Oct 2022 13:20:58 +0200 Message-Id: <20221004112100.301935-4-kraxel@redhat.com> In-Reply-To: <20221004112100.301935-1-kraxel@redhat.com> References: <20221004112100.301935-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1664882698172100005 Content-Type: text/plain; charset="utf-8" Not needed for a virtio 1.0 device. virtio_pci_device_plugged() overrides them anyway (so no functional change). Signed-off-by: Gerd Hoffmann Reviewed-by: David Hildenbrand Reviewed-by: Pankaj Gupta Tested-by: Pankaj Gupta --- include/hw/pci/pci.h | 1 - hw/virtio/virtio-pmem-pci.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index b6aefb33fb17..42c83cb5ed00 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h @@ -84,7 +84,6 @@ extern bool pci_available; #define PCI_DEVICE_ID_VIRTIO_RNG 0x1005 #define PCI_DEVICE_ID_VIRTIO_9P 0x1009 #define PCI_DEVICE_ID_VIRTIO_VSOCK 0x1012 -#define PCI_DEVICE_ID_VIRTIO_PMEM 0x1013 =20 #define PCI_VENDOR_ID_REDHAT 0x1b36 #define PCI_DEVICE_ID_REDHAT_BRIDGE 0x0001 diff --git a/hw/virtio/virtio-pmem-pci.c b/hw/virtio/virtio-pmem-pci.c index 2b2a0b1eae10..7d9f4ec189b9 100644 --- a/hw/virtio/virtio-pmem-pci.c +++ b/hw/virtio/virtio-pmem-pci.c @@ -90,8 +90,6 @@ static void virtio_pmem_pci_class_init(ObjectClass *klass= , void *data) =20 k->realize =3D virtio_pmem_pci_realize; set_bit(DEVICE_CATEGORY_MISC, dc->categories); - pcidev_k->vendor_id =3D PCI_VENDOR_ID_REDHAT_QUMRANET; - pcidev_k->device_id =3D PCI_DEVICE_ID_VIRTIO_PMEM; pcidev_k->revision =3D VIRTIO_PCI_ABI_VERSION; pcidev_k->class_id =3D PCI_CLASS_OTHERS; =20 --=20 2.37.3 From nobody Thu May 9 03:51:30 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1664882906; cv=none; d=zohomail.com; s=zohoarc; b=Tzn625rCI3hbx07fNE27YMgwtM2WzGi7PtigZ+sPIGeg1H9O89fZ4jdhGjxkjfnyvs7OU92zaCgvodcaDgN9WCxfgO4SGPHCmi2VEFBMrIYkjIdF18246+zx0MgzaLvheiRjUs899LkGGJ54KsCHPjBLwYrteehsQoYJplKdaDs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664882906; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=926SWnSLMccgBjkjxqbW8eiulrqp6UsBpHGdDxmGoIQ=; b=egEj/8G0gNKE84Z8EpfS3hrUzVlT8+A1hHudrzKXy60nddKcfm6UA20Zd9Y6xTyMyroyR3deE3W76RdjmLbz31eeKX5PhCiFPke2OfIfhtw7BwobH2xklQtEY1q2OghZjHnEevn8BCmLNjO6Z669QVUPoSwjViau6X9Ed8hhe20= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1664882906079977.9423678671856; Tue, 4 Oct 2022 04:28:26 -0700 (PDT) Received: from localhost ([::1]:44844 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ofg64-00060d-VM for importer@patchew.org; Tue, 04 Oct 2022 07:28:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1offz5-0005h5-Gj for qemu-devel@nongnu.org; Tue, 04 Oct 2022 07:21:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:48713) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1offz1-0007fh-4e for qemu-devel@nongnu.org; Tue, 04 Oct 2022 07:21:10 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-507-Yar-san9McO5r0cGVnUgjQ-1; Tue, 04 Oct 2022 07:21:05 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E22E085A59D; Tue, 4 Oct 2022 11:21:04 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A1A40112132D; Tue, 4 Oct 2022 11:21:04 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 9E08B1800916; Tue, 4 Oct 2022 13:21:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664882466; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=926SWnSLMccgBjkjxqbW8eiulrqp6UsBpHGdDxmGoIQ=; b=FpS8jQe077APzR+KKOg+67mZMfuL92nZZnfpHtTESNY9qDyKSZf/NXkfLDFDHw/C8d6T9Y kYPOWcydrZA6SLtPXMsRrl9zqQIidmdXF3W4nhHlVMlFpPw/ivVhV6s0f8JTNcWpe6UxT7 18CQQ2yvO7FxV9UQYwoEfenhZBPKqKA= X-MC-Unique: Yar-san9McO5r0cGVnUgjQ-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Marcel Apfelbaum , "Michael S. Tsirkin" , David Hildenbrand , Eric Auger , peter.maydell@linaro.org, Gerd Hoffmann Subject: [PATCH v3 4/5] pci-ids: drop list of modern virtio devices Date: Tue, 4 Oct 2022 13:20:59 +0200 Message-Id: <20221004112100.301935-5-kraxel@redhat.com> In-Reply-To: <20221004112100.301935-1-kraxel@redhat.com> References: <20221004112100.301935-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1664882908154100001 Content-Type: text/plain; charset="utf-8" Drop the list of modern virtio devices and explain how they are calculated instead. Signed-off-by: Gerd Hoffmann Reviewed-by: Eric Auger --- docs/specs/pci-ids.txt | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/docs/specs/pci-ids.txt b/docs/specs/pci-ids.txt index dd6859d039d0..e463c4cb3a22 100644 --- a/docs/specs/pci-ids.txt +++ b/docs/specs/pci-ids.txt @@ -22,16 +22,14 @@ maintained as part of the virtio specification. 1af4:1004 SCSI host bus adapter device (legacy) 1af4:1005 entropy generator device (legacy) 1af4:1009 9p filesystem device (legacy) +1af4:1012 vsock device (bug compatibility) =20 -1af4:1041 network device (modern) -1af4:1042 block device (modern) -1af4:1043 console device (modern) -1af4:1044 entropy generator device (modern) -1af4:1045 balloon device (modern) -1af4:1048 SCSI host bus adapter device (modern) -1af4:1049 9p filesystem device (modern) -1af4:1050 virtio gpu device (modern) -1af4:1052 virtio input device (modern) +1af4:1040 Start of ID range for modern virtio devices. The PCI device + to ID is calculated from the virtio device ID by adding the +1af4:10ef 0x1040 offset. The virtio IDs are defined in the virtio + specification. The Linux kernel has a header file with + defines for all virtio IDs (linux/virtio_ids.h), qemu has a + copy in include/standard-headers/. =20 1af4:10f0 Available for experimental usage without registration. Must get to official ID when the code leaves the test lab (i.e. when seeking --=20 2.37.3 From nobody Thu May 9 03:51:30 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1664882782; cv=none; d=zohomail.com; s=zohoarc; b=fGBfAbm2aUlJDohQNMA2OwIb8g8oiU8Vcj7BXVxzLlo6vjm9zBcOzTDiDygNNuxE9zEWNjQwHi3MrBGaG8336fl0guFuJ1AYLVsV4snbNE6VZ1y+RzAsoyiAt3jFL+y+fUNZsj+WhAqjV1+1EsophrVYbEGi7H0B3GxN81YF18Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664882782; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ux3BFS/ij3u3J+WHsgeSxlIHDXTCI461l9BAmxt5/m4=; b=A0YRay4G9qDualFTfyyMeMfL8LBBKL/aixRputM0nSCZ4M9K6lOHB8qc8TnK9qKOQE2XvUAmz4BjQhx7Y+9bpHYDnvfIrlXEZg1N21YNXFX2jK2+q+nc6cKgV9FWZdt+WJcKGfv4/2VCVRMIEnJveFgjyGVW8O3LPWBAw9IjqCc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1664882782078426.6165225007036; Tue, 4 Oct 2022 04:26:22 -0700 (PDT) Received: from localhost ([::1]:47694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ofg44-0003Ek-IE for importer@patchew.org; Tue, 04 Oct 2022 07:26:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46374) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1offz5-0005hE-LM for qemu-devel@nongnu.org; Tue, 04 Oct 2022 07:21:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44770) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1offz2-0007fu-TR for qemu-devel@nongnu.org; Tue, 04 Oct 2022 07:21:10 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-196-R4FfkURLPJOoWSe7FxeImA-1; Tue, 04 Oct 2022 07:21:05 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EF9B529AB40D; Tue, 4 Oct 2022 11:21:04 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AF5121121339; Tue, 4 Oct 2022 11:21:04 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id ACEBD180091D; Tue, 4 Oct 2022 13:21:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664882468; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ux3BFS/ij3u3J+WHsgeSxlIHDXTCI461l9BAmxt5/m4=; b=U0iRukPzwjVUUk21vWgMVSijunKvvita9iPS2iELjfkBAax+ZURob76Pf3nVaD6WZn4LmV /lyHT4a8F9NFGEnGb0CnOD+aLACE4sjn6lVhmPzjHGI+6x5SMmrsyM2giTdNqizh5UR/5/ rWZCO9rbl59jfimKL4ZxERu/RD8IqZ4= X-MC-Unique: R4FfkURLPJOoWSe7FxeImA-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Marcel Apfelbaum , "Michael S. Tsirkin" , David Hildenbrand , Eric Auger , peter.maydell@linaro.org, Gerd Hoffmann Subject: [PATCH v3 5/5] pci-ids: document modern virtio-pci ids in pci.h too Date: Tue, 4 Oct 2022 13:21:00 +0200 Message-Id: <20221004112100.301935-6-kraxel@redhat.com> In-Reply-To: <20221004112100.301935-1-kraxel@redhat.com> References: <20221004112100.301935-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1664882782561100001 Content-Type: text/plain; charset="utf-8" While being at it add a #define for the magic 0x1040 number. Signed-off-by: Gerd Hoffmann --- include/hw/pci/pci.h | 10 ++++++++++ hw/virtio/virtio-pci.c | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index 42c83cb5ed00..d1ac308574f1 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h @@ -76,6 +76,7 @@ extern bool pci_available; #define PCI_SUBVENDOR_ID_REDHAT_QUMRANET 0x1af4 #define PCI_SUBDEVICE_ID_QEMU 0x1100 =20 +/* legacy virtio-pci devices */ #define PCI_DEVICE_ID_VIRTIO_NET 0x1000 #define PCI_DEVICE_ID_VIRTIO_BLOCK 0x1001 #define PCI_DEVICE_ID_VIRTIO_BALLOON 0x1002 @@ -85,6 +86,15 @@ extern bool pci_available; #define PCI_DEVICE_ID_VIRTIO_9P 0x1009 #define PCI_DEVICE_ID_VIRTIO_VSOCK 0x1012 =20 +/* + * modern virtio-pci devices get their id assigned automatically, + * there is no need to add #defines here. It gets calculated as + * + * PCI_DEVICE_ID =3D PCI_DEVICE_ID_VIRTIO_10_BASE + + * virtio_bus_get_vdev_id(bus) + */ +#define PCI_DEVICE_ID_VIRTIO_10_BASE 0x1040 + #define PCI_VENDOR_ID_REDHAT 0x1b36 #define PCI_DEVICE_ID_REDHAT_BRIDGE 0x0001 #define PCI_DEVICE_ID_REDHAT_SERIAL 0x0002 diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index a50c5a57d7e5..e7d80242b73f 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c @@ -1688,7 +1688,7 @@ static void virtio_pci_device_plugged(DeviceState *d,= Error **errp) pci_set_word(config + PCI_VENDOR_ID, PCI_VENDOR_ID_REDHAT_QUMRANET); pci_set_word(config + PCI_DEVICE_ID, - 0x1040 + virtio_bus_get_vdev_id(bus)); + PCI_DEVICE_ID_VIRTIO_10_BASE + virtio_bus_get_vdev_id= (bus)); pci_config_set_revision(config, 1); } config[PCI_INTERRUPT_PIN] =3D 1; --=20 2.37.3