From nobody Sun May 19 00:17:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=google.com ARC-Seal: i=1; a=rsa-sha256; t=1664819324; cv=none; d=zohomail.com; s=zohoarc; b=hdq+xQL8tP6T6/ZiieJjpwg2msxUMDHvTOYBXMSqiV4Y41Oev0HzvirDMrfKhKAfrmyJlnmO/fXhMXP9YazqTv00f8rQdqhhghUe5xKmhTLm+MtElWOV8VSvZiAzNUqCpk3cR3gujrP/ulMdA9/Dr70PIKADluKjZ60eEFkvQ7k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664819324; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=sxJXfZ008cDPK0oNi+eJPi7CzUgpg2BylU6cUpmEcCk=; b=iGfpRmwTh1e2muN7M7VHOozwY2CQu9j1aCG2iqCfs6oaTJrRmPmLiuSfdZVW8eJJEBMv+NjyKYGnslf5i5QQ/lxKtkaKa3j8RAecxgwFGLgh5stoWgPlGcyRouj2m2VsEZUbMY9Yl/vxfpGC3I41mkB6BAN0LTfIwxW+aPS+4dw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1664819324305427.6980728681999; Mon, 3 Oct 2022 10:48:44 -0700 (PDT) Received: from localhost ([::1]:52470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ofPYX-00047e-QW for importer@patchew.org; Mon, 03 Oct 2022 13:48:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38572) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <3CB47YwcKClEEx6CDAxz77z4x.v759x5D-wxEx4676z6D.7Az@flex--venture.bounces.google.com>) id 1ofPOW-0000Ea-TM for qemu-devel@nongnu.org; Mon, 03 Oct 2022 13:38:21 -0400 Received: from mail-yb1-xb4a.google.com ([2607:f8b0:4864:20::b4a]:33706) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <3CB47YwcKClEEx6CDAxz77z4x.v759x5D-wxEx4676z6D.7Az@flex--venture.bounces.google.com>) id 1ofPOU-0003Sz-RH for qemu-devel@nongnu.org; Mon, 03 Oct 2022 13:38:20 -0400 Received: by mail-yb1-xb4a.google.com with SMTP id e8-20020a5b0cc8000000b006bca0fa3ab6so10829587ybr.0 for ; Mon, 03 Oct 2022 10:38:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date; bh=sxJXfZ008cDPK0oNi+eJPi7CzUgpg2BylU6cUpmEcCk=; b=W1lfgmCX6wFAMMmHKdZX9gS8g90mvFSmZ4Z4HFp5heQZJzuKnaPC68xZZROFqPFGFa /j2YeSexGq3uoUqSeBAyMH+P0+8+Mdf0rg/7bFDXtGcwRDgyjYp8LO6Yi2BrklZ/BGbr WNwC9tMhcCxZHQyLbiWHuMlCNoIa9OYfw8BiaitCx3ZRfA59hWN8XtaQG0jE0YWJ1gWe PxSST4fn1mu6kH/q/bakRi4rv25DChwOZGexXplBQ3XEPNm1TQmB3+D/mmdp2NKpwHYj E5ODV+M/q1XhPb8IxOI6FHBn7kjRD4/65CW4uIcV0NB0Optv4utWMXHpyu5HnMLoSqBy QQUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date; bh=sxJXfZ008cDPK0oNi+eJPi7CzUgpg2BylU6cUpmEcCk=; b=JLhc+EoGOstFooIzlTm+0VINYiR/G9J4nZrCWrftfG4wzO1eZr24zTxNeyOTzaA9rG Yigg0FmFB/P0Uo3bzViRh4tLQPR3vn4aKc7fRytxqEHv8UBXL/XwOnonGOPitks6GFp7 pL4axGwrx6a0UlNJwuz82ee1pQ56eaRX2Do7nItJ4MrIqbGUvQTZNV/WGUnI0Dt5aGT+ zj7TdDFSUoAmN746ewmEhhpF7HyL/d2BDrv78bzIG/rVCPsyRPA1keJZ2ls7MnHjzuXY uRb9+vq1dCUHIQHVnYecFchyBhbIprP+m2dJQaqYOZP+cRJ2iuXwmgBHAPLx+j37NbYM JJIw== X-Gm-Message-State: ACrzQf3opeYVGcEuw+EzTczIH4ABmyEAMqzxRT+wOXgwr7hO5iwL/OUA HuOPaIRQ3yiuZlaqkiaWqXitFFiEuOLk X-Google-Smtp-Source: AMsMyM5fZEKxh0O+CNc22n4RkFXFmcIWI54ZrJAQRcsPTmXzA8T9jgkTpZsiHqLTNqon48I4E4tNLuMUvYw4 X-Received: from venture.svl.corp.google.com ([2620:15c:2a3:201:39ac:b4b:8b32:a988]) (user=venture job=sendgmr) by 2002:a25:b812:0:b0:6af:662c:9fa with SMTP id v18-20020a25b812000000b006af662c09famr20069572ybj.224.1664818696120; Mon, 03 Oct 2022 10:38:16 -0700 (PDT) Date: Mon, 3 Oct 2022 10:38:10 -0700 Mime-Version: 1.0 X-Mailer: git-send-email 2.38.0.rc1.362.ged0d419d3c-goog Message-ID: <20221003173810.1933849-1-venture@google.com> Subject: [PATCH v2] hw/net: npcm7xx_emc: set MAC in register space From: Patrick Venture To: hskinnemoen@google.com, kfting@nuvoton.com, peter.maydell@linaro.org Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, jasowang@redhat.com, Patrick Venture , Hao Wu Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::b4a; envelope-from=3CB47YwcKClEEx6CDAxz77z4x.v759x5D-wxEx4676z6D.7Az@flex--venture.bounces.google.com; helo=mail-yb1-xb4a.google.com X-Spam_score_int: -95 X-Spam_score: -9.6 X-Spam_bar: --------- X-Spam_report: (-9.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @google.com) X-ZM-MESSAGEID: 1664819325690100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The MAC address set from Qemu wasn't being saved into the register space. Reviewed-by: Hao Wu Signed-off-by: Patrick Venture Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- v2: only set the registers from qemu on reset once registers set, only read and write to them --- hw/net/npcm7xx_emc.c | 30 +++++++++++++++++++++++------- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a/hw/net/npcm7xx_emc.c b/hw/net/npcm7xx_emc.c index 7c86bb52e5..a33f8c7b23 100644 --- a/hw/net/npcm7xx_emc.c +++ b/hw/net/npcm7xx_emc.c @@ -112,6 +112,16 @@ static void emc_reset(NPCM7xxEMCState *emc) =20 emc->tx_active =3D false; emc->rx_active =3D false; + + /* Set the MAC address in the register space. */ + uint32_t value =3D (emc->conf.macaddr.a[0] << 24) | + (emc->conf.macaddr.a[1] << 16) | + (emc->conf.macaddr.a[2] << 8) | + emc->conf.macaddr.a[3]; + emc->regs[REG_CAMM_BASE] =3D value; + + value =3D (emc->conf.macaddr.a[4] << 24) | (emc->conf.macaddr.a[5] << = 16); + emc->regs[REG_CAML_BASE] =3D value; } =20 static void npcm7xx_emc_reset(DeviceState *dev) @@ -432,13 +442,25 @@ static bool emc_receive_filter1(NPCM7xxEMCState *emc,= const uint8_t *buf, } case ETH_PKT_UCAST: { bool matches; + uint32_t value; + struct MACAddr mac; if (emc->regs[REG_CAMCMR] & REG_CAMCMR_AUP) { return true; } + + value =3D emc->regs[REG_CAMM_BASE]; + mac.a[0] =3D value >> 24; + mac.a[1] =3D value >> 16; + mac.a[2] =3D value >> 8; + mac.a[3] =3D value >> 0; + value =3D emc->regs[REG_CAML_BASE]; + mac.a[4] =3D value >> 24; + mac.a[5] =3D value >> 16; + matches =3D ((emc->regs[REG_CAMCMR] & REG_CAMCMR_ECMP) && /* We only support one CAM register, CAM0. */ (emc->regs[REG_CAMEN] & (1 << 0)) && - memcmp(buf, emc->conf.macaddr.a, ETH_ALEN) =3D=3D 0); + memcmp(buf, mac.a, ETH_ALEN) =3D=3D 0); if (emc->regs[REG_CAMCMR] & REG_CAMCMR_CCAM) { *fail_reason =3D "MACADDR matched, comparison complemented"; return !matches; @@ -661,15 +683,9 @@ static void npcm7xx_emc_write(void *opaque, hwaddr off= set, break; case REG_CAMM_BASE + 0: emc->regs[reg] =3D value; - emc->conf.macaddr.a[0] =3D value >> 24; - emc->conf.macaddr.a[1] =3D value >> 16; - emc->conf.macaddr.a[2] =3D value >> 8; - emc->conf.macaddr.a[3] =3D value >> 0; break; case REG_CAML_BASE + 0: emc->regs[reg] =3D value; - emc->conf.macaddr.a[4] =3D value >> 24; - emc->conf.macaddr.a[5] =3D value >> 16; break; case REG_MCMDR: { uint32_t prev; --=20 2.38.0.rc1.362.ged0d419d3c-goog