From nobody Mon Apr 29 14:40:33 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1664547176; cv=none; d=zohomail.com; s=zohoarc; b=BN5e+R0CrXnK0WUPgA2UhCaNYrYc6I0DBFjnrL4r1meiOqDUQKZxk6keNTGRGzi5P3QQdhVDO5PehquLOzwlOFcJtjxDXHyKFiKUqV62yl8BcKc/YjOoqxeZA85Ljakj1K91DYTomX4ztaGsB0uNt6mDn3yZ4wEVS5juqJKRJ5Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664547176; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=esBp8RRii32GJjVQMVvs3H15PQQMZiZubnOSFtTvB/o=; b=OHPLqJqTR1N/r0JJkPcez/5UZmXLewDO3v0xd4pvLLmKBq4//xj7wEgcFVdD7AU1nQOBMJxttEjZg7HbM8aa+f1L25ehCz/ltM0za8bZt9yG26Ebfflz1gkDkn8VmXmKXK3GBSp2HhSfMOIc7hwaaM4DG9SAWlbJotW2EBH/Lio= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1664547176543424.9697932204383; Fri, 30 Sep 2022 07:12:56 -0700 (PDT) Received: from localhost ([::1]:32952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oeGl5-0006dT-D4 for importer@patchew.org; Fri, 30 Sep 2022 10:12:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50918) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oeGVv-000278-Aj for qemu-devel@nongnu.org; Fri, 30 Sep 2022 09:57:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:27927) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oeGVr-00022l-TL for qemu-devel@nongnu.org; Fri, 30 Sep 2022 09:57:13 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-171-b5cDJdlAOB2pePlkptXDrQ-1; Fri, 30 Sep 2022 09:57:07 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E585F100F7F2; Fri, 30 Sep 2022 13:57:06 +0000 (UTC) Received: from localhost (unknown [10.39.208.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id B2CA939D6A; Fri, 30 Sep 2022 13:57:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664546230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=esBp8RRii32GJjVQMVvs3H15PQQMZiZubnOSFtTvB/o=; b=g2YxEoqBOfNnbmLf5hVlwXmU86xjsbEoda9ZPmcsHsK85S3pslHtv/CLI+/ojYyGCkHE10 rCNZVCQqbKKRSp4PeBhHRH+AK0XGqHGvvBmLg1sAkzLUx4xKPNgA+m4FWUK5No/SoQFJ3P ih2EweZ9J4fEeaDWPonLhqAszD34TEc= X-MC-Unique: b5cDJdlAOB2pePlkptXDrQ-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: bin.meng@windriver.com, richard.henderson@linaro.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Stefan Weil Subject: [PATCH v2] win32: set threads name Date: Fri, 30 Sep 2022 17:57:01 +0400 Message-Id: <20220930135701.1681390-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -8 X-Spam_score: -0.9 X-Spam_bar: / X-Spam_report: (-0.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URI_TRY_3LD=1.982 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1664547177474100001 From: Marc-Andr=C3=A9 Lureau As described in: https://learn.microsoft.com/en-us/visualstudio/debugger/how-to-set-a-thread= -name-in-native-code?view=3Dvs-2022 SetThreadDescription() is available since Windows 10, version 1607 and in some versions only by "Run Time Dynamic Linking". Its declaration is not yet in mingw, so we lookup the function the same way glib does. Tested with Visual Studio Community 2022 debugger. Signed-off-by: Marc-Andr=C3=A9 Lureau --- util/qemu-thread-win32.c | 56 ++++++++++++++++++++++++++++++++++++++-- 1 file changed, 54 insertions(+), 2 deletions(-) diff --git a/util/qemu-thread-win32.c b/util/qemu-thread-win32.c index a2d5a6e825..e2d681fe7d 100644 --- a/util/qemu-thread-win32.c +++ b/util/qemu-thread-win32.c @@ -19,12 +19,40 @@ =20 static bool name_threads; =20 +typedef HRESULT (WINAPI *pSetThreadDescription) (HANDLE hThread, + PCWSTR lpThreadDescriptio= n); +static pSetThreadDescription SetThreadDescriptionFunc =3D NULL; +static HMODULE kernel32_module =3D NULL; + +static bool +load_set_thread_description(void) +{ + static gsize _init_once =3D 0; + + if (g_once_init_enter(&_init_once)) { + kernel32_module =3D LoadLibraryW(L"kernel32.dll"); + if (kernel32_module) { + SetThreadDescriptionFunc =3D + (pSetThreadDescription)GetProcAddress(kernel32_module, + "SetThreadDescription"= ); + if (!SetThreadDescriptionFunc) { + FreeLibrary(kernel32_module); + } + } + g_once_init_leave(&_init_once, 1); + } + + return !!SetThreadDescriptionFunc; +} + void qemu_thread_naming(bool enable) { - /* But note we don't actually name them on Windows yet */ name_threads =3D enable; =20 - fprintf(stderr, "qemu: thread naming not supported on this host\n"); + if (enable && !load_set_thread_description()) { + fprintf(stderr, "qemu: thread naming not supported on this host\n"= ); + name_threads =3D false; + } } =20 static void error_exit(int err, const char *msg) @@ -400,6 +428,26 @@ void *qemu_thread_join(QemuThread *thread) return ret; } =20 +static bool +set_thread_description(HANDLE h, const char *name) +{ + HRESULT hr; + g_autofree wchar_t *namew =3D NULL; + + if (!load_set_thread_description() || !name) { + return false; + } + + namew =3D g_utf8_to_utf16(name, -1, NULL, NULL, NULL); + if (!namew) { + return false; + } + + hr =3D SetThreadDescriptionFunc(h, namew); + + return SUCCEEDED(hr); +} + void qemu_thread_create(QemuThread *thread, const char *name, void *(*start_routine)(void *), void *arg, int mode) @@ -423,7 +471,11 @@ void qemu_thread_create(QemuThread *thread, const char= *name, if (!hThread) { error_exit(GetLastError(), __func__); } + if (name_threads && !set_thread_description(hThread, name)) { + fprintf(stderr, "Failed to set thread description: %s\n", name); + } CloseHandle(hThread); + thread->data =3D data; } =20 --=20 2.37.3