From nobody Mon Feb 9 11:06:22 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1664356839; cv=none; d=zohomail.com; s=zohoarc; b=MvqX4ODnWLNAncApvvauwfi6tp67VzurVROWYMqTOiqn8H6gEY3Th387vFADN1Qj+97sN9oywipsyDvrz30+H5M8J+QLHDkl4MxGhVYAobU+hP9tyELnolmxexGch+H4sTiI3UthyjMM+U28ndymYibs0SsjF2X4VC7p70cqHyQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664356839; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ZoEDCSw4xYTrv72BG6q3jqBdnLXfwig/ukmMFjh8lXg=; b=UZ/IP+VeDFdQDsX9UUgTty3m3vjhRBVn97xucxRjOrF27E0Qz1mrszoIkSxIpznm1geXiNsD+HT1Qu67R4o/Veyjbvu2utr+E52XYSGQnuY3KGOS6z+9qreo/sJScSH9NnwIpa1o6Tpkqr+oSHKHWGrck2ZK/YUDcpz6SSTjJjU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16643568393731008.9571288763397; Wed, 28 Sep 2022 02:20:39 -0700 (PDT) Received: from localhost ([::1]:38866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odTF7-0002q2-FO for importer@patchew.org; Wed, 28 Sep 2022 05:20:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50838) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odRLU-0000wo-5A for qemu-devel@nongnu.org; Wed, 28 Sep 2022 03:19:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:23108) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odRLS-0008SD-HG for qemu-devel@nongnu.org; Wed, 28 Sep 2022 03:19:03 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-646-pxV-hzn5N1WkSc6iKvnDpw-1; Wed, 28 Sep 2022 03:18:56 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7C489101CC67; Wed, 28 Sep 2022 07:18:56 +0000 (UTC) Received: from thuth.com (unknown [10.39.193.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5C1AE40C83BB; Wed, 28 Sep 2022 07:18:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664349541; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZoEDCSw4xYTrv72BG6q3jqBdnLXfwig/ukmMFjh8lXg=; b=fzlziSgKDZRBczROlOjAvp8CcacG9kv8yIxEJp2pMAGzEt7uzf5jAKPkDEUhBzp4ykGhB6 HV0c5WmAvt98UPhMWHsUQzOz2p//oshywWOVzU52jLQ+TnymXIyAqsGZNn0xE3gvRVEh4A Hd0Rc/OhH+SAAvFdJTka8XJRujg9sTo= X-MC-Unique: pxV-hzn5N1WkSc6iKvnDpw-1 From: Thomas Huth To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Bin Meng , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PULL 05/37] tests/qtest: cxl-test: Avoid using hardcoded /tmp Date: Wed, 28 Sep 2022 09:18:11 +0200 Message-Id: <20220928071843.1468323-6-thuth@redhat.com> In-Reply-To: <20220928071843.1468323-1-thuth@redhat.com> References: <20220928071843.1468323-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1664356840849100001 From: Bin Meng This case was written to use hardcoded /tmp directory for temporary files. Update to use g_dir_make_tmp() for a portable implementation. Signed-off-by: Bin Meng Reviewed-by: Marc-Andr=C3=A9 Lureau Message-Id: <20220925113032.1949844-9-bmeng.cn@gmail.com> Signed-off-by: Thomas Huth --- tests/qtest/cxl-test.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/tests/qtest/cxl-test.c b/tests/qtest/cxl-test.c index 2e14da7dee..cbe0fb549b 100644 --- a/tests/qtest/cxl-test.c +++ b/tests/qtest/cxl-test.c @@ -93,10 +93,9 @@ static void cxl_2root_port(void) static void cxl_t3d(void) { g_autoptr(GString) cmdline =3D g_string_new(NULL); - char template[] =3D "/tmp/cxl-test-XXXXXX"; - const char *tmpfs; + g_autofree const char *tmpfs =3D NULL; =20 - tmpfs =3D g_mkdtemp(template); + tmpfs =3D g_dir_make_tmp("cxl-test-XXXXXX", NULL); =20 g_string_printf(cmdline, QEMU_PXB_CMD QEMU_RP QEMU_T3D, tmpfs, tmpfs); =20 @@ -107,10 +106,9 @@ static void cxl_t3d(void) static void cxl_1pxb_2rp_2t3d(void) { g_autoptr(GString) cmdline =3D g_string_new(NULL); - char template[] =3D "/tmp/cxl-test-XXXXXX"; - const char *tmpfs; + g_autofree const char *tmpfs =3D NULL; =20 - tmpfs =3D g_mkdtemp(template); + tmpfs =3D g_dir_make_tmp("cxl-test-XXXXXX", NULL); =20 g_string_printf(cmdline, QEMU_PXB_CMD QEMU_2RP QEMU_2T3D, tmpfs, tmpfs, tmpfs, tmpfs); @@ -122,10 +120,9 @@ static void cxl_1pxb_2rp_2t3d(void) static void cxl_2pxb_4rp_4t3d(void) { g_autoptr(GString) cmdline =3D g_string_new(NULL); - char template[] =3D "/tmp/cxl-test-XXXXXX"; - const char *tmpfs; + g_autofree const char *tmpfs =3D NULL; =20 - tmpfs =3D g_mkdtemp(template); + tmpfs =3D g_dir_make_tmp("cxl-test-XXXXXX", NULL); =20 g_string_printf(cmdline, QEMU_2PXB_CMD QEMU_4RP QEMU_4T3D, tmpfs, tmpfs, tmpfs, tmpfs, tmpfs, tmpfs, --=20 2.31.1