From nobody Mon Feb 9 09:34:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1664353479; cv=none; d=zohomail.com; s=zohoarc; b=S0C7rh2CtlWrUchJ1aRJ5huHXtXxcf/Tc6fzioedSxWY+OZn2qJIDpuuQeH78m9ivfuwgtvxwZN62Te0K473kQEAZ5Cha7A/15r1JjR2sbr6+DInu57/wcuqlNMV79qHBKSTH8UA83C5VKVyX2L5FNYU4Cvj9PIoeq0qQjPG2vs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664353479; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=KzE561aL0CLDS1WEU8W/QraRdzWpPvLgwlDfs/9CCGI=; b=DtFLC1qoyGLPzEGdW53SDkqelHpCTjiKc7U888IX9HxGIjKyTG9woT7pb2Bj/yAs2ppGaxypv9zryinl12PlKnHoasURJP5k7YGJBJHUxyVfOXBA82nDNmpLqqo1VXzq7+1mqonyA0XduKdzx2h2jY43xwVqp4MW+0CPSmpftBw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1664353479797809.3841264763249; Wed, 28 Sep 2022 01:24:39 -0700 (PDT) Received: from localhost ([::1]:46198 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odSMw-00050Z-F5 for importer@patchew.org; Wed, 28 Sep 2022 04:24:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38376) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odRLx-00015R-6g for qemu-devel@nongnu.org; Wed, 28 Sep 2022 03:19:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:51535) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odRLv-0008Vz-IG for qemu-devel@nongnu.org; Wed, 28 Sep 2022 03:19:32 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-438-58mFwwBGO0m4AeCS-ZjjLw-1; Wed, 28 Sep 2022 03:19:27 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C7D6F811E81; Wed, 28 Sep 2022 07:19:26 +0000 (UTC) Received: from thuth.com (unknown [10.39.193.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5F96240C83BB; Wed, 28 Sep 2022 07:19:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664349571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KzE561aL0CLDS1WEU8W/QraRdzWpPvLgwlDfs/9CCGI=; b=dViwxZqUJ/WRDLdDFkPdT9rpmWbkmsdXZ7wkCjhCHKqlc/i3WkzHAPNzGcffMNKwbjLlRH vo6sHDFJT6HGPrIOm4XO70udtAyuU98D/Uc2BP/EuQYpYJ/bhYu2I6+1mOSnTC2T5xGyPK HSNRX0PmVCRKlC5K0uJWJzc2/4wfJ6A= X-MC-Unique: 58mFwwBGO0m4AeCS-ZjjLw-1 From: Thomas Huth To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Bin Meng , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PULL 22/37] tests/qtest: {ahci, ide}-test: Use relative path for temporary files for win32 Date: Wed, 28 Sep 2022 09:18:28 +0200 Message-Id: <20220928071843.1468323-23-thuth@redhat.com> In-Reply-To: <20220928071843.1468323-1-thuth@redhat.com> References: <20220928071843.1468323-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1664353481931100003 From: Bin Meng These test cases uses "blkdebug:path/to/config:path/to/image" for testing. On Windows, absolute file paths contain the delimiter ':' which causes the blkdebug filename parser fail to parse filenames. Signed-off-by: Bin Meng Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Thomas Huth Message-Id: <20220925113032.1949844-38-bmeng.cn@gmail.com> Signed-off-by: Thomas Huth --- tests/qtest/ahci-test.c | 21 ++++++++++++++++++--- tests/qtest/ide-test.c | 20 ++++++++++++++++++-- 2 files changed, 36 insertions(+), 5 deletions(-) diff --git a/tests/qtest/ahci-test.c b/tests/qtest/ahci-test.c index 1d5929d8c3..66652fed04 100644 --- a/tests/qtest/ahci-test.c +++ b/tests/qtest/ahci-test.c @@ -1833,7 +1833,7 @@ static void create_ahci_io_test(enum IOMode type, enu= m AddrMode addr, =20 int main(int argc, char **argv) { - const char *arch; + const char *arch, *base; int ret; int fd; int c; @@ -1871,8 +1871,22 @@ int main(int argc, char **argv) return 0; } =20 + /* + * "base" stores the starting point where we create temporary files. + * + * On Windows, this is set to the relative path of current working + * directory, because the absolute path causes the blkdebug filename + * parser fail to parse "blkdebug:path/to/config:path/to/image". + */ +#ifndef _WIN32 + base =3D g_get_tmp_dir(); +#else + base =3D "."; +#endif + /* Create a temporary image */ - fd =3D g_file_open_tmp("qtest.XXXXXX", &tmp_path, NULL); + tmp_path =3D g_strdup_printf("%s/qtest.XXXXXX", base); + fd =3D g_mkstemp(tmp_path); g_assert(fd >=3D 0); if (have_qemu_img()) { imgfmt =3D "qcow2"; @@ -1889,7 +1903,8 @@ int main(int argc, char **argv) close(fd); =20 /* Create temporary blkdebug instructions */ - fd =3D g_file_open_tmp("qtest-blkdebug.XXXXXX", &debug_path, NULL); + debug_path =3D g_strdup_printf("%s/qtest-blkdebug.XXXXXX", base); + fd =3D g_mkstemp(debug_path); g_assert(fd >=3D 0); close(fd); =20 diff --git a/tests/qtest/ide-test.c b/tests/qtest/ide-test.c index 25302be6dc..5e3e28aea2 100644 --- a/tests/qtest/ide-test.c +++ b/tests/qtest/ide-test.c @@ -1011,16 +1011,32 @@ static void test_cdrom_dma(void) =20 int main(int argc, char **argv) { + const char *base; int fd; int ret; =20 + /* + * "base" stores the starting point where we create temporary files. + * + * On Windows, this is set to the relative path of current working + * directory, because the absolute path causes the blkdebug filename + * parser fail to parse "blkdebug:path/to/config:path/to/image". + */ +#ifndef _WIN32 + base =3D g_get_tmp_dir(); +#else + base =3D "."; +#endif + /* Create temporary blkdebug instructions */ - fd =3D g_file_open_tmp("qtest-blkdebug.XXXXXX", &debug_path, NULL); + debug_path =3D g_strdup_printf("%s/qtest-blkdebug.XXXXXX", base); + fd =3D g_mkstemp(debug_path); g_assert(fd >=3D 0); close(fd); =20 /* Create a temporary raw image */ - fd =3D g_file_open_tmp("qtest.XXXXXX", &tmp_path, NULL); + tmp_path =3D g_strdup_printf("%s/qtest.XXXXXX", base); + fd =3D g_mkstemp(tmp_path); g_assert(fd >=3D 0); ret =3D ftruncate(fd, TEST_IMAGE_SIZE); g_assert(ret =3D=3D 0); --=20 2.31.1