From nobody Mon Feb 9 09:34:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1664354524; cv=none; d=zohomail.com; s=zohoarc; b=ViHYFXqqy7oN8SE3H9xAjLICnxhJQWfZYhASU6GTDdobJWWzSCm6/X3vUwgSW03b50qewZDN8JXDnTe/K4khWGIt0P1DbN/N6l1WqZoKuObZYAK4n/4JanQtmZZyDs6ho5WcgD78YsHNv9OQ+hbVwlS/gE7GQQXvXNgSYhRq+gg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664354524; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=d7S+a/NPPz5Pdw3vVRItqYkq+YsyiaI0EzdUXzDOmMg=; b=XkYsnQGX686bq9MA5KtfyErNVco0brf+3Paz3U1k4ZIvLL+rjxsy0Guq6TZu1huDCsEo8/YWKIZS0C50m2czleXt0BByg3SJ1FuGEQYzHApo2s4xImBxj2Kb9iylIlbTWb/SoBQ9ujWzq8RItVz49j4S5teZzqEauOpbntetp70= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1664354524019132.44362000878527; Wed, 28 Sep 2022 01:42:04 -0700 (PDT) Received: from localhost ([::1]:41214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odSdm-0008HL-RF for importer@patchew.org; Wed, 28 Sep 2022 04:42:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38026) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odRLh-0000yM-OA for qemu-devel@nongnu.org; Wed, 28 Sep 2022 03:19:22 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:29207) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odRLX-0008Sq-43 for qemu-devel@nongnu.org; Wed, 28 Sep 2022 03:19:09 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-587-yFTQ52xrNlW8B2Zr7Tv2ag-1; Wed, 28 Sep 2022 03:19:03 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E2123811E67; Wed, 28 Sep 2022 07:19:02 +0000 (UTC) Received: from thuth.com (unknown [10.39.193.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id C916340C83BB; Wed, 28 Sep 2022 07:19:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664349546; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d7S+a/NPPz5Pdw3vVRItqYkq+YsyiaI0EzdUXzDOmMg=; b=TXECj1a777byUxBv9iU8Dm++ksY5bS2vhxAqRc8c0bJM7UGm32gVw2ex3DG2OgcwGgEYE4 Vc2WBVWe9jZiQs2Ez/Ss1DCIbYHmP4YyzOLc7m9acdYnZ2LDWGK+YPq6PriOAF1uOqC+aK 4KEXO9s8qGS2T4FE1Ok054EFYsjNK8k= X-MC-Unique: yFTQ52xrNlW8B2Zr7Tv2ag-1 From: Thomas Huth To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Bin Meng , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PULL 09/37] tests/qtest: ide-test: Avoid using hardcoded /tmp Date: Wed, 28 Sep 2022 09:18:15 +0200 Message-Id: <20220928071843.1468323-10-thuth@redhat.com> In-Reply-To: <20220928071843.1468323-1-thuth@redhat.com> References: <20220928071843.1468323-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1664354525707100001 From: Bin Meng This case was written to use hardcoded /tmp directory for temporary files. Update to use g_file_open_tmp() for a portable implementation. Signed-off-by: Bin Meng Reviewed-by: Marc-Andr=C3=A9 Lureau Message-Id: <20220925113032.1949844-14-bmeng.cn@gmail.com> Signed-off-by: Thomas Huth --- tests/qtest/ide-test.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/qtest/ide-test.c b/tests/qtest/ide-test.c index 5bcb75a7e5..25302be6dc 100644 --- a/tests/qtest/ide-test.c +++ b/tests/qtest/ide-test.c @@ -121,8 +121,8 @@ enum { static QPCIBus *pcibus =3D NULL; static QGuestAllocator guest_malloc; =20 -static char tmp_path[] =3D "/tmp/qtest.XXXXXX"; -static char debug_path[] =3D "/tmp/qtest-blkdebug.XXXXXX"; +static char *tmp_path; +static char *debug_path; =20 static QTestState *ide_test_start(const char *cmdline_fmt, ...) { @@ -1015,12 +1015,12 @@ int main(int argc, char **argv) int ret; =20 /* Create temporary blkdebug instructions */ - fd =3D mkstemp(debug_path); + fd =3D g_file_open_tmp("qtest-blkdebug.XXXXXX", &debug_path, NULL); g_assert(fd >=3D 0); close(fd); =20 /* Create a temporary raw image */ - fd =3D mkstemp(tmp_path); + fd =3D g_file_open_tmp("qtest.XXXXXX", &tmp_path, NULL); g_assert(fd >=3D 0); ret =3D ftruncate(fd, TEST_IMAGE_SIZE); g_assert(ret =3D=3D 0); @@ -1049,7 +1049,9 @@ int main(int argc, char **argv) =20 /* Cleanup */ unlink(tmp_path); + g_free(tmp_path); unlink(debug_path); + g_free(debug_path); =20 return ret; } --=20 2.31.1