From nobody Tue Feb 10 03:38:17 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1664291676; cv=none; d=zohomail.com; s=zohoarc; b=AcSTBVlA1IqLVV3F904HaMbJAyUD9Rh7B3og3W0G+jdJWbz6ILCnvgbD/dvcNUBsTaigTBetJ3ixRL0LM9XvHjUPq7/GAZwbol07W6WhBV5bAoT4y6N57+fPL/2BuOAUrHuvJKCC8Rr2A9NnO5B84P+7TVgUxeEa/Y4pGLCy6Jc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664291676; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=YmGTfY44v68oWEDWIgGzIBfmabjki9ALqeTNQFkqiu4=; b=Wq6NJA9ZjF9OYHFBfrm3pDzzYRVjvp/StB6d4wuiI1SPHUdj/4oSnhVYvYan1mx1PvGdq11LcXtbf249NX29fU2+hpHMuLEmlpzL/MHZnqTNUh2NujeNJgnkj9u3SMhsbp4vIzDtUCZGEmzp7Kx7+VDuq2oXcoHhCV1XX3FR0tY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1664291676366262.49063301486194; Tue, 27 Sep 2022 08:14:36 -0700 (PDT) Received: from localhost ([::1]:59386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odCI7-0005zT-8b for importer@patchew.org; Tue, 27 Sep 2022 11:14:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odAnH-0001A7-Kj for qemu-devel@nongnu.org; Tue, 27 Sep 2022 09:38:39 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:55090) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1odAnG-00088l-0g for qemu-devel@nongnu.org; Tue, 27 Sep 2022 09:38:39 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DCBC11FCF0; Tue, 27 Sep 2022 13:38:36 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 84515139BE; Tue, 27 Sep 2022 13:38:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id IHfRHtz8MmNsKgAAMHmgww (envelope-from ); Tue, 27 Sep 2022 13:38:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1664285916; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YmGTfY44v68oWEDWIgGzIBfmabjki9ALqeTNQFkqiu4=; b=URJ+0pyl6gIBtVZowAqk1n7p2JSElH7R9OdLWuIRV3PiQJIpUk5F7JIP9gIAPWGoCdRyNj mwhsC1CUQS2sX4c78Qfvs0zLxlC2IXVEN5jSXDgvl6vt2qL7E7TVkpa+xlWvFGRY3foq4v 0DCgdzRCWrJd8GR4CuBtm70rj083jpM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1664285916; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YmGTfY44v68oWEDWIgGzIBfmabjki9ALqeTNQFkqiu4=; b=XQu7nGYgkVqbbCrJ4TOwRT43F/MEXuAuE/9IH2mpcylMBszbjIO+mB6ia3I41wAvhgZ2YE I3Jc47dF4REs0RDA== From: Claudio Fontana To: Paolo Bonzini , Richard Henderson , Markus Armbruster , Kevin Wolf Cc: qemu-devel@nongnu.org, dinechin@redhat.com, Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Claudio Fontana Subject: [PATCH v7 4/5] dmg: warn when opening dmg images containing blocks of unknown type Date: Tue, 27 Sep 2022 15:38:24 +0200 Message-Id: <20220927133825.32631-5-cfontana@suse.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20220927133825.32631-1-cfontana@suse.de> References: <20220927133825.32631-1-cfontana@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.220.29; envelope-from=cfontana@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1664291677874100001 Content-Type: text/plain; charset="utf-8" From: Kevin Wolf Signed-off-by: Claudio Fontana --- block/dmg.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/block/dmg.c b/block/dmg.c index 837f18aa20..96f8c2d14f 100644 --- a/block/dmg.c +++ b/block/dmg.c @@ -254,6 +254,25 @@ static int dmg_read_mish_block(BDRVDMGState *s, DmgHea= derState *ds, for (i =3D s->n_chunks; i < s->n_chunks + chunk_count; i++) { s->types[i] =3D buff_read_uint32(buffer, offset); if (!dmg_is_known_block_type(s->types[i])) { + switch (s->types[i]) { + case UDBZ: + warn_report_once("dmg-bzip2 module is missing, accessing b= zip2 " + "compressed blocks will result in I/O err= ors"); + break; + case ULFO: + warn_report_once("dmg-lzfse module is missing, accessing l= zfse " + "compressed blocks will result in I/O err= ors"); + break; + case UDCM: + case UDLE: + /* Comments and last entry can be ignored without problems= */ + break; + default: + warn_report_once("Image contains chunks of unknown type %x= , " + "accessing them will result in I/O errors= ", + s->types[i]); + break; + } chunk_count--; i--; offset +=3D 40; --=20 2.26.2